Eduardo has posted comments on this change.
Change subject: getVolumeInfo() new implementation.
..
Patch Set 3:
(2 comments)
Commit Message
Line 5: CommitDate: 2013-09-16
Eduardo has posted comments on this change.
Change subject: Making getVSize and getVTrueSize SD methods.
..
Patch Set 4:
(3 comments)
Commit Message
Line 12:
Line 13:
Ayal Baron has posted comments on this change.
Change subject: Use the full prefix when removing file images.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19107
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Avoid redundant volume produces.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17991
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Rename *Volume.extend method to *Volume.enlarge
..
Patch Set 1: Code-Review-2
I see no point for this change (which is not explained in the commit message
Ayal Baron has posted comments on this change.
Change subject: Avoid hsm image deletions.
..
Patch Set 4: Code-Review-2
-2 for visibility since you keep on rebasing without addressing the comments
--
To view, visit
Ayal Baron has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6:
(1 comment)
File
Ayal Baron has posted comments on this change.
Change subject: hsm: deleteImage fails because of wrong dictionary use
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17383
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19296
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Introduce lvm short filters.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/17968
To unsubscribe, visit http://gerrit.ovirt.org/settings
Sergey Gotliv has posted comments on this change.
Change subject: Use the full prefix when removing file images.
..
Patch Set 1: Code-Review+1
(1 comment)
The patch is good, but descriptions should be changed?
Michal Skrivanek has posted comments on this change.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: deleteImage fails because of wrong dictionary use
..
hsm: deleteImage fails because of wrong dictionary use
also, get fake template params before
Federico Simoncelli has posted comments on this change.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain
metadata
..
Patch Set 1: Code-Review-1
(2 comments)
-1 for visibility
Nir Soffer has posted comments on this change.
Change subject: Fix parent volume rollback after failure to create snapshot
..
Patch Set 6: -Code-Review
(2 comments)
Reply to comments
Deepak C Shetty has posted comments on this change.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain
metadata
..
Patch Set 1:
(1 comment)
File
Mark Wu has posted comments on this change.
Change subject: Report bond speed as function of slaved nics speed and bond mode
..
Patch Set 1: Code-Review-1
(4 comments)
File
Saggi Mizrahi has posted comments on this change.
Change subject: multipath.getMPDevNamesIter() return /dev/mapper.
..
Patch Set 2:
One of Saggi's automated scripts discovered that you are changing a file he
deeply cares
Federico Simoncelli has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 2: Verified+1
Verified migrating the master from one SD to another.
--
To view, visit
Alon Bar-Lev has uploaded a new change for review.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
packaging: spec: own /etc/pki/vdsm/libvirt-spice
Change-Id: If939a60a916c1cc8c529d91e4bc379032048d42e
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4491/ :
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
vdsm: move balloon logic out of buildConfDevices
Encapsulates empty balloon creation logic outside of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move balloon logic out of buildConfDevices
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4492/ :
Saggi Mizrahi has posted comments on this change.
Change subject: constants: unify the BLANK_UUID definition
..
Patch Set 2: Code-Review-1
(1 comment)
I agree that code duplication is an issue but constants.py is not the
Saggi Mizrahi has posted comments on this change.
Change subject: Raise specific exception when local path not exist
..
Patch Set 3: Code-Review-1
(1 comment)
File
Saggi Mizrahi has posted comments on this change.
Change subject: Change mom policy related interface to support multi-policy
..
Patch Set 11:
I reviewed *only* the API change and I approve.
I have not looked at the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Report bond speed as function of slaved nics speed and bond mode
..
Patch Set 2:
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: Report bond speed as function of slaved nics speed and bond mode
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19297
To
Saggi Mizrahi has posted comments on this change.
Change subject: Make HSM service self containted
..
Patch Set 5: Code-Review-2
This is not the way to go.
We are trying to move away from the mismatch between where files are
Amador Pahim has posted comments on this change.
Change subject: Report bond speed as function of slaved nics speed and bond mode
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/19297
To unsubscribe,
Eduardo has posted comments on this change.
Change subject: Raise specific exception when local path not exist
..
Patch Set 3: Code-Review-1
(1 comment)
Please explain which issue are you trying to solve.
Raising specific
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4494/ :
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19318
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
Patch Set 2:
waiting for:
testStressTest
to verify...
--
To view, visit http://gerrit.ovirt.org/19318
To
Dan Kenigsberg has posted comments on this change.
Change subject: Change of ConfigWriter._createConfFile parameters
..
Patch Set 6: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/18331
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
Patch Set 2: Verified+1
this stress test never ends... had to kill it.
--
To view, visit
Arik Hadas has posted comments on this change.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line
Dan Kenigsberg has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 2:
danken: what if one storage domain has considerably different latency?
paraphrasing fsimonce's
Yeela Kaplan has posted comments on this change.
Change subject: More precise exception when multipath failed.
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17145
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: reduce the time VM is paused in snapshot with RAM creation
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Federico Simoncelli has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 3: Verified+1
Commit change only.
--
To view, visit http://gerrit.ovirt.org/19176
To
Dan Kenigsberg has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/19176
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: make misc.pgrep for general usage
..
Patch Set 3: Code-Review-1
(1 comment)
File vdsm/storage/misc.py
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: update lease parameters on masterMigrate
..
sp: update lease parameters on masterMigrate
Given the current API the lease parameters should be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: update lease parameters on masterMigrate
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4495/ : SUCCESS
Ayal Baron has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/14671
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Read pool metadata once in StoragePool.getInfo()
..
Patch Set 5: Code-Review+2
The subsequent patch addresses my comment so +2
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
Patch Set 2:
Yes, this is a delicate dangerous change.
--
To view, visit http://gerrit.ovirt.org/19318
To
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1:
Yaniv, supervdsmProxy should better protect itself from unexpected extra
arguments.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: packaging: spec: own /etc/pki/vdsm/libvirt-spice
..
packaging: spec: own /etc/pki/vdsm/libvirt-spice
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4496/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Log client address on SSL errors
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4499/ : FAILURE
Juan Hernandez has posted comments on this change.
Change subject: Log client address on SSL errors
..
Patch Set 3:
I verified that this works correctly, but the tests are failing in Jenkins, and
I don't understand why. I
Juan Hernandez has posted comments on this change.
Change subject: Log client address on SSL errors
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/19332
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: Log client address on SSL errors
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19332
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Log client address on SSL errors
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4497/ :
Ayal Baron has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 2:
(1 comment)
File vdsm/storage/lvm.py
Line 131: strippeds =
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
vdsm: move watchdog default params to WatchdogDevice
Watchdog device creation is currently for no
Ayal Baron has posted comments on this change.
Change subject: supervdsmServer was not passing kwargs to fuser
..
Patch Set 1:
+1 on what Dan said. unexpected extra arguments should throw an exception so
that such bugs would
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..
Patch Set 6: Verified+1
Since Ubuntu and Debian are among the most popular distributions, I think it's
good to
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
vdsm: refactor buildConfDevices and getConfDevices into single function
Removes
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: centralize device limit checking
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4501/ : SUCCESS
63 matches
Mail list logo
