Change in vdsm[master]: libvirt_configure: restart libvirt on ovirtnode

2013-10-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: libvirt_configure: restart libvirt on ovirtnode .. Patch Set 1: (1 comment) Commit Message Line 4: Commit:

Change in vdsm[master]: tests: Minor cleanup in monkeypatch module and tests

2013-10-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Minor cleanup in monkeypatch module and tests .. tests: Minor cleanup in monkeypatch module and tests Change-Id:

Change in vdsm[master]: tests: Minor cleanup in monkeypatch module and tests

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Minor cleanup in monkeypatch module and tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20202 To unsubscribe, visit

Change in vdsm[master]: libvirt_configure: restart libvirt on ovirtnode

2013-10-20 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: libvirt_configure: restart libvirt on ovirtnode .. Patch Set 2: Sorry, I'm not so familiar with vdsm-reg code. So you say we call vdsmd reconfigure as

Change in vdsm[master]: libvirt_configure: restart libvirt on ovirtnode

2013-10-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: libvirt_configure: restart libvirt on ovirtnode .. Patch Set 2: for bug#1019200 I need detailed analysis why libvirt is not configured. -- To view, visit

Change in vdsm[master]: it fixes a bug in the hook validation decorator, that left t...

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: it fixes a bug in the hook validation decorator, that left tests scripts installed into the system. Now they're properly removed right after the tests ..

Change in vdsm[master]: New getChildrenList implementation.

2013-10-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: New getChildrenList implementation. .. New getChildrenList implementation. This implementation returns children of any image on the SD. Avoids to

Change in vdsm[master]: New getChildrenList implementation.

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: New getChildrenList implementation. .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/15765 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: hsm: fix isoprefix KeyError for inactive domains

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hsm: fix isoprefix KeyError for inactive domains .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20300 To unsubscribe, visit

Change in vdsm[master]: run pre-start bfore start needed services

2013-10-20 Thread ybronhei
Yaniv Bronhaim has abandoned this change. Change subject: run pre-start bfore start needed services .. Abandoned should stay as with systemd and upstat mechanism -- To view, visit http://gerrit.ovirt.org/20275 To

Change in vdsm[master]: it fixes a bug in the hook validation decorator, that left t...

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: it fixes a bug in the hook validation decorator, that left tests scripts installed into the system. Now they're properly removed right after the tests ..

Change in vdsm[master]: iscsi: Iscsi rescan cleanup

2013-10-20 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: iscsi: Iscsi rescan cleanup .. Patch Set 12: please change bug-url to the correct vdsm bug -- To view, visit http://gerrit.ovirt.org/19256 To unsubscribe,

Change in vdsm[master]: prevent hook validation decorator from leaving scripts insta...

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: prevent hook validation decorator from leaving scripts installed .. Patch Set 3: Verified-1 Build Failed

Change in vdsm[master]: prevent hook validation decorator from leaving scripts insta...

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: prevent hook validation decorator from leaving scripts installed .. Patch Set 4: Verified-1 Build Failed

Change in vdsm[master]: Define ModuleConfigure interface and API for modules configu...

2013-10-20 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Define ModuleConfigure interface and API for modules configuration tool .. Define ModuleConfigure interface and API for modules configuration tool This patch

Change in vdsm[master]: Define ModuleConfigure interface and API for modules configu...

2013-10-20 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Define ModuleConfigure interface and API for modules configuration tool .. Patch Set 1: I want to merge it to http://gerrit.ovirt.org/#/c/20100/12 , If no

Change in vdsm[master]: minor changes in libvirt connection

2013-10-20 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: minor changes in libvirt connection .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19463 To unsubscribe, visit

Change in vdsm[master]: DRAFT: allow hooks to pass down dictionaries in json format

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: DRAFT: allow hooks to pass down dictionaries in json format .. Patch Set 1: Verified-1 Build Failed

Change in vdsm[master]: Define ModuleConfigure interface and API for modules configu...

2013-10-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Define ModuleConfigure interface and API for modules configuration tool .. Patch Set 1: (7 comments) File

Change in vdsm[master]: Define ModuleConfigure interface and API for modules configu...

2013-10-20 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Define ModuleConfigure interface and API for modules configuration tool .. Patch Set 1: (2 comments)

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 5: Rebase and use new MonkeyClass class decorator. -- To view, visit http://gerrit.ovirt.org/19856 To unsubscribe,

Change in vdsm[master]: Introducing configurator package in vdsm-tool

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 12: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5049/ :

Change in vdsm[master]: Introducing configurator package in vdsm-tool

2013-10-20 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 9: (1 comment) File

Change in vdsm[master]: Define ModuleConfigure interface and API for modules configu...

2013-10-20 Thread ybronhei
Yaniv Bronhaim has abandoned this change. Change subject: Define ModuleConfigure interface and API for modules configuration tool .. Abandoned merged to http://gerrit.ovirt.org/#/c/20335/2 -- To view, visit

Change in vdsm[master]: Introducing configurator package in vdsm-tool

2013-10-20 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 13: (1 comment) File

Change in vdsm[master]: Define ModuleConfigure interface and API for modules configu...

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Define ModuleConfigure interface and API for modules configuration tool .. Patch Set 1: Build Failed

Change in vdsm[master]: minor changes in libvirt connection

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: minor changes in libvirt connection .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5051/ : ABORTED

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5052/ : ABORTED

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 6: More generic Callable, faking exceptions. -- To view, visit http://gerrit.ovirt.org/19856 To unsubscribe, visit

Change in vdsm[master]: bugfix: UpdateVmDevice QoS

2013-10-20 Thread eedri
Eyal Edri has posted comments on this change. Change subject: bugfix: UpdateVmDevice QoS .. Patch Set 6: Code-Review+1 (1 comment) but keep in mind, this will fail on centos 6.4 of course.

Change in vdsm[master]: Introducing configurator package in vdsm-tool

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introducing configurator package in vdsm-tool .. Patch Set 13: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5053/ :

Change in vdsm[ovirt-3.3]: fix premature selinux dependency

2013-10-20 Thread eedri
Eyal Edri has posted comments on this change. Change subject: fix premature selinux dependency .. Patch Set 1: Verified-1 http://jenkins.ovirt.org/job/vdsm_install_rpm_sanity_gerrit/label=centos64/201/consoleFull centos 6.4

Change in vdsm[master]: Define ModuleConfigure interface and API for modules configu...

2013-10-20 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Define ModuleConfigure interface and API for modules configuration tool .. Patch Set 1: (2 comments) File

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5054/ : ABORTED

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.ovirt.org/19856 To unsubscribe, visit

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 2: Verified-1 Build Failed

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed .. Patch Set 5: Code-Review-1 (1 comment) oops, I failed to notice this little issue.

Change in vdsm[master]: Packaging: Fix vdsm.prerm of Ubuntu packaging scripts

2013-10-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Packaging: Fix vdsm.prerm of Ubuntu packaging scripts .. Packaging: Fix vdsm.prerm of Ubuntu packaging scripts On Ubuntu, qemu-sanlock.conf is not

Change in vdsm[master]: Packaging: Fix vdsm.prerm of Ubuntu packaging scripts

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Packaging: Fix vdsm.prerm of Ubuntu packaging scripts .. Patch Set 2: Verified+1 skipping verification here. -- To view, visit http://gerrit.ovirt.org/20169

Change in vdsm[master]: BZ#844656 Release the _syncroot lock during _findDomain

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#844656 Release the _syncroot lock during _findDomain .. Patch Set 7: Code-Review-1 Indeed, after a year, a rebase is welcome. -- To view, visit

Change in vdsm[master]: minor changes in libvirt connection

2013-10-20 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: minor changes in libvirt connection .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19463 To unsubscribe, visit

Change in vdsm[master]: minor changes in libvirt connection

2013-10-20 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: minor changes in libvirt connection .. minor changes in libvirt connection change logging levels and use functools.wraps Change-Id:

Change in vdsm[master]: tests: prevent hook validation decorator from leaving script...

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: prevent hook validation decorator from leaving scripts installed .. Patch Set 5: Verified-1 Build Failed

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-20 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: iscsiadm: Add debug level option .. iscsiadm: Add debug level option VDSM uses iscdiadm to perform iSCSI operations which are often complicated to debug. This

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 7: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5057/ :

Change in vdsm[master]: tests: Add miniaml issciadm tests

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add miniaml issciadm tests .. Patch Set 8: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5058/ : ABORTED

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-20 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsiadm: Add debug level option .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5059/ : ABORTED

Change in vdsm[master]: libvirt_configure: restart libvirt on ovirtnode

2013-10-20 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: libvirt_configure: restart libvirt on ovirtnode .. Patch Set 2: Code-Review-1 investigating based on the comments. -- To view, visit