Ayal Baron has posted comments on this change.
Change subject: lvm: Invalidate lvm cache after extend
..
Patch Set 3: Code-Review-1
(2 comments)
File vdsm/storage/lvm.py
Dan Kenigsberg has posted comments on this change.
Change subject: Improve error when multipath can't access a pv
..
Patch Set 4: Code-Review+2
Actually, moving to set logic would have improved code quality and readability.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Improve error when multipath can't access a pv
..
Improve error when multipath can't access a pv
InvalidPhysDev gave a cryptic error message - Invalid
Antoni Segura Puimedon has posted comments on this change.
Change subject: Added missing python modules to the configure.ac checks
..
Patch Set 1:
(1 comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Ubuntu: make hard coded group names configurable in
configurator.py
..
Ubuntu: make hard coded group names configurable in configurator.py
In the
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Ubuntu: Sync with vdsm.spec.in
..
Ubuntu: Sync with vdsm.spec.in
Recently we split zombiereaper and made some changes in libvirt
configuring. This
Allon Mureinik has posted comments on this change.
Change subject: lvm: Invalidate lvm cache after extend
..
Patch Set 3:
(1 comment)
Commit Message
Line 6:
Line 7: lvm:
Allon Mureinik has posted comments on this change.
Change subject: lvm: deactivate unused lvs during bootstrap
..
Patch Set 4:
(4 comments)
File vdsm/storage/lvm.py
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling.ImagePathStatus: drop unused code, and only it
..
sampling.ImagePathStatus: drop unused code, and only it
The ImagePathStatus is never
Dan Kenigsberg has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code, and only it
..
Patch Set 3: Verified+1 Code-Review+2
Copying score: code has not changed since Nir's review, and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code, and only it
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4671/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: Added missing python modules to the configure.ac checks
..
Patch Set 1: Code-Review+1
Thanks.
--
To view, visit http://gerrit.ovirt.org/21317
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Added missing python modules to the configure.ac checks
..
Patch Set 1:
btw, I ran ./autogen.sh --system; ./configure with that patch after removing
Mark Wu has posted comments on this change.
Change subject: netconf: Improve unified persistence's rollback in memory.
..
Patch Set 6:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: lvm: deactivate unused lvs during bootstrap
..
Patch Set 4:
(4 comments)
File vdsm/storage/lvm.py
Line 330:
Ayal Baron has posted comments on this change.
Change subject: lvm: Ensure active LVs are refreshed before use.
..
Patch Set 5: -Code-Review
After discussing with Nir, I reread Eduardo's comment and saw that I missed the
part
Antoni Segura Puimedon has posted comments on this change.
Change subject: Added missing python modules to the configure.ac checks
..
Patch Set 1:
@Yaniv: That's odd, after doing a new checkout of the repo in my Arch Linux
Mark Wu has posted comments on this change.
Change subject: Add iproute2 configurator
..
Patch Set 19:
It can pass all the tests except followings:
testAddVlanedBridgeless
Nir Soffer has posted comments on this change.
Change subject: lvm: Invalidate lvm cache after extend
..
Patch Set 3:
(1 comment)
Commit Message
Line 6:
Line 7: lvm:
Yaniv Bronhaim has posted comments on this change.
Change subject: Added missing python modules to the configure.ac checks
..
Patch Set 1: Verified+1
It looks fine. tried it on another env
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Added missing python modules to the configure.ac checks
..
Patch Set 1: -Code-Review
Although, just to understand it completely, why doesn't it enough to
Dan Kenigsberg has posted comments on this change.
Change subject: Added missing python modules to the configure.ac checks
..
Patch Set 1:
It's important for non-rpm-based distros.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added missing python modules to the configure.ac checks
..
Added missing python modules to the configure.ac checks
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 5:
(1 comment)
It should not be that hard to check this in two branches: engine-3.1 and
Dan Kenigsberg has uploaded a new change for review.
Change subject: sampling: take storageDomains directly from storage subsys
..
sampling: take storageDomains directly from storage subsys
HostStatsThread does not poll
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: take storageDomains directly from storage subsys
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 6:
Build Successful
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 6:
Thanks for the reviews everyone and my apologies for the time taken to respond.
Placing
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 6:
(3 comments)
This looks like the right direction.
I would happier if the changes are
Nir Soffer has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
Final version:
- Removed nonessential stuff such as timing
- Inline into lvm.bootstrap() since deactivation
Nir Soffer has abandoned this change.
Change subject: fcp: Deactivate vdsm logical volumes
..
Abandoned
Replaced by http://gerrit.ovirt.org/#/c/21291/
--
To view, visit http://gerrit.ovirt.org/20720
To unsubscribe, visit
On Sun, Nov 17, 2013 at 03:53:38PM +, Jenkins ci oVirt Server wrote:
Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/
Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/812/
Build Number: 812
Build Status: Failure
Triggered By: Started by an SCM change
Dan Kenigsberg has abandoned this change.
Change subject: Add deathSignal options to better popen
..
Abandoned
merged out of vdsm's tree.
--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: take storageDomains directly from storage subsys
..
Patch Set 1:
(2 comments)
File vdsm/API.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: take storageDomains directly from storage subsys
..
Patch Set 2:
Build Successful
Darshan N has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 5:
(2 comments)
Commit Message
Line 9: This
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4678/ :
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(1 comment)
Nice. if I understand the logic correctly you have my +1. Although, didn't you
want to run
Bala.FA has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 6: Code-Review+1
Please verify
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit
40 matches
Mail list logo