Change in vdsm[master]: Teardown only VDSM images when power-off VM

2013-12-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: Teardown only VDSM images when power-off VM .. Patch Set 2: (1 comment) File vdsm/vm.py Line 2537:

Change in vdsm[master]: Teardown only VDSM images when power-off VM

2013-12-04 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: Teardown only VDSM images when power-off VM .. Patch Set 2: (1 comment) File vdsm/vm.py Line 2537:

Change in vdsm[master]: Teardown only VDSM images when power-off VM

2013-12-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: Teardown only VDSM images when power-off VM .. Patch Set 2: (1 comment) File vdsm/vm.py Line 2537:

Change in vdsm[master]: Avoid going into 'Paused' status during long during migrations

2013-12-04 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: Avoid going into 'Paused' status during long during migrations .. Patch Set 1: (1 comment) File

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: QoS: make report only when present and say so in the schema .. QoS: make report only when present and say so in the schema Libvirt XML format

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 1: Verified-1 Build Failed

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-12-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 3: (1 comment) Commit Message

Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable

2013-12-04 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 1: Code-Review+1 @Liron - not a bad idea. -- To view, visit http://gerrit.ovirt.org/21879 To

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 2: Verified-1 Build Failed

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5894/ :

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 3: Verified+1 Passed the tests. Verified also to create a bridged network with

Change in vdsm[ovirt-3.3]: Remove verbosity from restorecon hack for /var/log/core.

2013-12-04 Thread mtayer
Hello Yaniv Bronhaim, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/22021 to review the following change. Change subject: Remove verbosity from restorecon hack for /var/log/core.

Change in vdsm[ovirt-3.3]: Remove verbosity from restorecon hack for /var/log/core.

2013-12-04 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Remove verbosity from restorecon hack for /var/log/core. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22021 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: Remove verbosity from restorecon hack for /var/log/core.

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove verbosity from restorecon hack for /var/log/core. .. Patch Set 1: Build Successful

Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.

2013-12-04 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Avoid calling restorecon on a nonexistent dir. .. Patch Set 1: (1 comment) File vdsm.spec.in Line 644: fi

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread amuller
Assaf Muller has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 3: If an admin used the CLI to configure QoS with only average - Caps would return a

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 3: If an admin used the CLI to configure QoS with only average - Caps would

Change in vdsm[master]: QoS: make report only when present and say so in the schema

2013-12-04 Thread amuller
Assaf Muller has posted comments on this change. Change subject: QoS: make report only when present and say so in the schema .. Patch Set 3: Code-Review+1 (1 comment) Please add qosInbound and qosOutbound to the

Change in vdsm[master]: vm: Fix exception when shutdown() called on vm in 'Down' state

2013-12-04 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state .. Patch Set 1: Code-Review+1 (1 comment) note this patch is going to be obsoleted by

Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable

2013-12-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 2: Address Liron comment. -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable

2013-12-04 Thread laravot
Liron Ar has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21879 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Rename confusing lastCheck variable

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Rename confusing lastCheck variable .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5895/ : SUCCESS

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-12-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 4: Refine commit message and add reference to the original bug. -- To view, visit

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5896/ :

Change in vdsm[master]: domainMonitor: Separate change detection from lastCheck value

2013-12-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: domainMonitor: Separate change detection from lastCheck value .. Patch Set 4: Note: no code change. -- To view, visit http://gerrit.ovirt.org/21878 To

Change in vdsm[master]: vm: janitorial: replace file() with open()

2013-12-04 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: janitorial: replace file() with open() .. vm: janitorial: replace file() with open() As per docs, open() is preferred to file():

Change in vdsm[master]: vm: janitorial: replace file() with open()

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: janitorial: replace file() with open() .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5897/ : SUCCESS

Change in vdsm[master]: vm: janitorial: replace file() with open()

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: vm: janitorial: replace file() with open() .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22034 To unsubscribe, visit

Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

2013-12-04 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: utils: janitorial: refactor utils.readMemInfo .. utils: janitorial: refactor utils.readMemInfo minor cleanup in readMemInfo: - split the actual parsing

Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: janitorial: refactor utils.readMemInfo .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5898/ : SUCCESS

Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: utils: janitorial: refactor utils.readMemInfo .. Patch Set 1: Code-Review-1 (2 comments) Some minor nits.

Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

2013-12-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: janitorial: refactor utils.readMemInfo .. Patch Set 1: (1 comment) File tests/utilsTests.py Line

Change in vdsm[master]: vm: janitorial: replace file() with open()

2013-12-04 Thread amuller
Assaf Muller has posted comments on this change. Change subject: vm: janitorial: replace file() with open() .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22034 To unsubscribe, visit

Change in vdsm[master]: vm: janitorial: replace file() with open()

2013-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: janitorial: replace file() with open() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22034 To unsubscribe, visit

Change in vdsm[master]: sp: Improve logging when pool is destroyed

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: Improve logging when pool is destroyed .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5899/ : SUCCESS

Change in vdsm[master]: Avoid calling restorecon on a nonexistent dir.

2013-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Avoid calling restorecon on a nonexistent dir. .. Patch Set 1: (1 comment) File vdsm.spec.in Line 644: fi

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 37: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit

Change in vdsm[master]: asyncproc: make read synchronous

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: asyncproc: make read synchronous .. Patch Set 2: Verified+1 verified doing: from vdsm import utils p = utils.execCmd(['ip', '-d', '-o',

Change in vdsm[master]: link monitor: Add optional asynchronous operation

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: link monitor: Add optional asynchronous operation .. Patch Set 5: Verified+1 Verified in ipython: In [1]: from vdsm import ipwrapper In [2]:

Change in vdsm[master]: link monitor: Add optional asynchronous operation

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: link monitor: Add optional asynchronous operation .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5900/ :

Change in vdsm[master]: link monitor: Add optional asynchronous operation

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: link monitor: Add optional asynchronous operation .. Patch Set 6: Verified+1 Verified sync and async operation. -- To view, visit

Change in vdsm[master]: link monitor: Add optional asynchronous operation

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: link monitor: Add optional asynchronous operation .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5901/ :

Change in vdsm[master]: Teardown only VDSM images when power-off VM

2013-12-04 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: Teardown only VDSM images when power-off VM .. Patch Set 2: (1 comment) File vdsm/vm.py Line 2537:

Change in vdsm[master]: netconf: Make vdsm-restore-net-config use _inRollback

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Make vdsm-restore-net-config use _inRollback .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5902/ :

Change in vdsm[master]: Teardown only VDSM images when power-off VM

2013-12-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: Teardown only VDSM images when power-off VM .. Patch Set 2: (1 comment) File vdsm/vm.py Line 2537:

Change in vdsm[master]: netinfo: Introduce linkPool

2013-12-04 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: netinfo: Introduce linkPool .. netinfo: Introduce linkPool linkPool is a dictionary that always contains the device links present in the system as

Change in vdsm[master]: sp: Fix stopping domain monitors

2013-12-04 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: sp: Fix stopping domain monitors .. sp: Fix stopping domain monitors Commit 2671777c69 fixed stopping of domain monitors by stopping monitors from

Change in vdsm[ovirt-3.3]: sp: Improve logging when pool is destroyed

2013-12-04 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: sp: Improve logging when pool is destroyed .. Abandoned Replaced by http://gerrit.ovirt.org/22058 -- To view, visit http://gerrit.ovirt.org/21933 To unsubscribe, visit

Change in vdsm[master]: sp: Improve logging when pool is destroyed

2013-12-04 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: sp: Improve logging when pool is destroyed .. Abandoned Replaced by http://gerrit.ovirt.org/22058 -- To view, visit http://gerrit.ovirt.org/21932 To unsubscribe, visit

Change in vdsm[master]: sp: Fix stopping domain monitors

2013-12-04 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: sp: Fix stopping domain monitors .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22058 To unsubscribe, visit

Change in vdsm[master]: sp: Fix stopping domain monitors

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: Fix stopping domain monitors .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5904/ : SUCCESS

Change in vdsm[master]: netconf: privatize inRollback

2013-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: privatize inRollback .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/21868 To unsubscribe, visit

Change in vdsm[master]: netconf: privatize inRollback

2013-12-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: privatize inRollback .. Patch Set 5: job/vdsm_network_functional_tests is enough of a verfication for this. -- To view, visit

Change in vdsm[master]: netconf: privatize inRollback

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: privatize inRollback .. Patch Set 6: Rebased as requested on top of master. -- To view, visit http://gerrit.ovirt.org/21868 To unsubscribe,

Change in vdsm[ovirt-3.3]: deployUtil: expect integer vlan id from new netinfo

2013-12-04 Thread apahim
Amador Pahim has posted comments on this change. Change subject: deployUtil: expect integer vlan id from new netinfo .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21982 To unsubscribe, visit

Change in vdsm[master]: vdsm hooks: Add missing snapshot=no attribute to disk el...

2013-12-04 Thread apahim
Amador Pahim has posted comments on this change. Change subject: vdsm hooks: Add missing snapshot=no attribute to disk ellements. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21913 To unsubscribe,

Change in vdsm[ovirt-3.3]: deployUtil: expect integer vlan id from new netinfo

2013-12-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: deployUtil: expect integer vlan id from new netinfo .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21982 To unsubscribe,

Change in vdsm[master]: linkmonitor: fix reported device name of vlans and macvlans

2013-12-04 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: linkmonitor: fix reported device name of vlans and macvlans .. linkmonitor: fix reported device name of vlans and macvlans Previously, vlans and

Change in vdsm[master]: mkimage: do not create world-readable image

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: mkimage: do not create world-readable image .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5909/ : SUCCESS

Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

2013-12-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: janitorial: refactor utils.readMemInfo .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5910/ : SUCCESS

Change in vdsm[master]: utils: janitorial: refactor utils.readMemInfo

2013-12-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: utils: janitorial: refactor utils.readMemInfo .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22041 To unsubscribe, visit