Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Michal Skrivanek has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Michal Skrivanek has posted comments on this change.
Change subject: Avoid going into 'Paused' status during long during migrations
..
Patch Set 1:
(1 comment)
File
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: QoS: make report only when present and say so in the schema
..
QoS: make report only when present and say so in the schema
Libvirt XML format
oVirt Jenkins CI Server has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 1: Verified-1
Build Failed
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
Commit Message
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 1: Code-Review+1
@Liron - not a bad idea.
--
To view, visit http://gerrit.ovirt.org/21879
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 2: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5894/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3: Verified+1
Passed the tests. Verified also to create a bridged network with
Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22021
to review the following change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
mooli tayer has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22021
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
..
Patch Set 1:
Build Successful
mooli tayer has posted comments on this change.
Change subject: Avoid calling restorecon on a nonexistent dir.
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Line 644: fi
Assaf Muller has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3:
If an admin used the CLI to configure QoS with only average - Caps would return
a
Antoni Segura Puimedon has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3:
If an admin used the CLI to configure QoS with only average - Caps would
Assaf Muller has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3: Code-Review+1
(1 comment)
Please add qosInbound and qosOutbound to the
Michal Skrivanek has posted comments on this change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
Patch Set 1: Code-Review+1
(1 comment)
note this patch is going to be obsoleted by
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 2:
Address Liron comment.
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5895/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Refine commit message and add reference to the original bug.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5896/ :
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Note: no code change.
--
To view, visit http://gerrit.ovirt.org/21878
To
Francesco Romani has uploaded a new change for review.
Change subject: vm: janitorial: replace file() with open()
..
vm: janitorial: replace file() with open()
As per docs, open() is preferred to file():
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: janitorial: replace file() with open()
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5897/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: vm: janitorial: replace file() with open()
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22034
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
utils: janitorial: refactor utils.readMemInfo
minor cleanup in readMemInfo:
- split the actual parsing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5898/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 1: Code-Review-1
(2 comments)
Some minor nits.
Francesco Romani has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 1:
(1 comment)
File tests/utilsTests.py
Line
Assaf Muller has posted comments on this change.
Change subject: vm: janitorial: replace file() with open()
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22034
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: janitorial: replace file() with open()
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22034
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: Improve logging when pool is destroyed
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5899/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Avoid calling restorecon on a nonexistent dir.
..
Patch Set 1:
(1 comment)
File vdsm.spec.in
Line 644: fi
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: asyncproc: make read synchronous
..
Patch Set 2: Verified+1
verified doing:
from vdsm import utils
p = utils.execCmd(['ip', '-d', '-o',
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 5: Verified+1
Verified in ipython:
In [1]: from vdsm import ipwrapper
In [2]:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5900/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 6: Verified+1
Verified sync and async operation.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5901/ :
Federico Simoncelli has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: Make vdsm-restore-net-config use _inRollback
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5902/ :
Sergey Gotliv has posted comments on this change.
Change subject: Teardown only VDSM images when power-off VM
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2537:
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netinfo: Introduce linkPool
..
netinfo: Introduce linkPool
linkPool is a dictionary that always contains the device links
present in the system as
Nir Soffer has uploaded a new change for review.
Change subject: sp: Fix stopping domain monitors
..
sp: Fix stopping domain monitors
Commit 2671777c69 fixed stopping of domain monitors by stopping monitors from
Nir Soffer has abandoned this change.
Change subject: sp: Improve logging when pool is destroyed
..
Abandoned
Replaced by http://gerrit.ovirt.org/22058
--
To view, visit http://gerrit.ovirt.org/21933
To unsubscribe, visit
Nir Soffer has abandoned this change.
Change subject: sp: Improve logging when pool is destroyed
..
Abandoned
Replaced by http://gerrit.ovirt.org/22058
--
To view, visit http://gerrit.ovirt.org/21932
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5904/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: privatize inRollback
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/21868
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: privatize inRollback
..
Patch Set 5:
job/vdsm_network_functional_tests is enough of a verfication for this.
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: privatize inRollback
..
Patch Set 6:
Rebased as requested on top of master.
--
To view, visit http://gerrit.ovirt.org/21868
To unsubscribe,
Amador Pahim has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21982
To unsubscribe, visit
Amador Pahim has posted comments on this change.
Change subject: vdsm hooks: Add missing snapshot=no attribute to disk
ellements.
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21913
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21982
To unsubscribe,
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
linkmonitor: fix reported device name of vlans and macvlans
Previously, vlans and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5909/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5910/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: utils: janitorial: refactor utils.readMemInfo
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22041
To unsubscribe, visit
61 matches
Mail list logo