Ayal Baron has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4: Code-Review-1
marking -1 just so that my comment on the previous patchset will be seen.
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Liron, this is important fix - your -1 block this change for no good reason
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21937
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: Fix exception when shutdown() called on vm in 'Down' state
..
vm: Fix exception when shutdown() called on vm in 'Down' state
Attempting to call
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Let's wait for other opinions with it.
The -1 isn't for blocking the change, but to
Nir Soffer has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Verified+1
Verified in the CI - run 10 jobs (like the one from the bug), 9 completed
successfully, one had
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: Make vdsm-restore-net-config use _inRollback
..
Patch Set 4: Verified+1
copying score.
--
To view, visit http://gerrit.ovirt.org/21977
To
Assaf Muller has posted comments on this change.
Change subject: netconf: Make vdsm-restore-net-config use _inRollback
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21977
To unsubscribe, visit
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
just to clarify - my -1 is just so a maintainer will see my comment in
Assaf Muller has posted comments on this change.
Change subject: netconf: privatize inRollback
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21868
To unsubscribe, visit
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: link monitor: Reuse Link parsing
..
link monitor: Reuse Link parsing
'ip -d -o link show' and 'ip monitor link' lines share most of the
format. The
Aravinda VK has posted comments on this change.
Change subject: gluster: Add force option to Volume Create command
..
Patch Set 3:
GlusterFS changes is now available in release-3.4 branch
http://review.gluster.org/#/c/6355/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netconf: Make vdsm-restore-net-config use _inRollback
..
netconf: Make vdsm-restore-net-config use _inRollback
The setup networks operations performed
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: Make vdsm-restore-net-config use _inRollback
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21977
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 1:
Do you really want to use the _parse method of Link? I think that It's easier
to maintain the code when you
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Rename confusing lastCheck variable
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21879
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: deployUtil: expect integer vlan id from new netinfo
..
Patch Set 1: Verified+1 Code-Review+2
Verified by author Vladimir Tananko
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
A cleaner implementation addressing Liron comments.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5913/ :
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
(1 comment)
File
Francesco Romani has uploaded a new change for review.
Change subject: ksm: janitorial: with construct, file() to open()
..
ksm: janitorial: with construct, file() to open()
Summary: use open() and with wherever feasible.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ksm: janitorial: with construct, file() to open()
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5914/ : SUCCESS
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+1
(1 comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Improve logging
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21936
To unsubscribe, visit
Federico Simoncelli has submitted this change and it was merged.
Change subject: domainMonitor: Improve logging
..
domainMonitor: Improve logging
We have logs in domain monitor thread, and we can see when a monitor
starts or
Federico Simoncelli has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
@Nir, why aren't we using the mocking libraries suggested in the python
documentation:
Federico Simoncelli has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+1
(1 comment)
Code is fine but the commit message should be improved.
Nir Soffer has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
I'll check exiting libraries when I have time.
--
To view, visit http://gerrit.ovirt.org/21155
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1:
(1 comment)
Commit Message
Line 12: delaying stopping of
Assaf Muller has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22061
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [wip] jsonrpc: Vdsm changes
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5915/ : SUCCESS
Saggi Mizrahi has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ip monitor: replace pairwise with grouper
..
ip monitor: replace pairwise with grouper
pairwise takes an iterator or elements '123456789' and
Adam Litke has posted comments on this change.
Change subject: [wip] jsonrpc: Vdsm changes
..
Patch Set 8: Code-Review-1
(2 comments)
File vdsm_api/vdsmapi-schema.json
Line
Assaf Muller has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22092
To unsubscribe, visit
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 4:
(3 comments)
Fixed packaging issues.
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 5: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5917/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Introduce linkPool
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5903/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconf: privatize inRollback
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5905/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: privatize inRollback
..
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21868
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netconf: privatize inRollback
..
netconf: privatize inRollback
inRollback is not part of the external setupNetworks api. Thus, it
is wise to be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 1: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1:
(1 comment)
Commit Message
Line 22: jobs, where there is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 2: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: link monitor: Add optional asynchronous operation
..
Patch Set 6:
yet another reason to minimize the number of pinger() tests:
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 3: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5918/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Handling topology for ppc64
..
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5919/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 1: Code-Review-1
gosh, how have we missed that. I think it's important enough to add a grouper
unit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5920/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 4: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 6: Code-Review-1
(3 comments)
Do not misunderstand me - I'd really like to take ppc64 support in,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: link monitor: Reuse Link parsing
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5912/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ip monitor: replace pairwise with grouper
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5916/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5906/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
I find it hard to digest the VmPowerDown class. To me it seems that it could be
replaced by a
Vitor de Lima has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 6:
(2 comments)
File build-aux/config.sub
Line
Dan Kenigsberg has posted comments on this change.
Change subject: netconfpersistence: add diffing method to Config
..
Patch Set 12: Code-Review-1
(1 comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: netconf: provide a default rollback for configurators
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21739
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm hooks: Add missing snapshot=no attribute to disk
ellements.
..
Patch Set 2: Code-Review+1
I'd love to see Federico's ack on this, as my understanding of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5921/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 6:
(2 comments)
File build-aux/config.sub
Line
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 7: Code-Review-1
(1 comment)
File configure.ac
Nir Soffer has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1:
(1 comment)
Commit Message
Line 22: jobs, where there is no
Nir Soffer has posted comments on this change.
Change subject: asyncproc: make read synchronous
..
Patch Set 2:
(2 comments)
Nice - but how errors are handled?
Commit
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: Remove Obsoletes: python-cpopen
..
vdsm.spec: Remove Obsoletes: python-cpopen
python-cpopen spec obsoletes vdsm-python-cpopen, so
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: Remove Obsoletes: python-cpopen
..
Patch Set 1: Verified-1
Build Failed
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: specfile: Add psmisc as build required dep
..
specfile: Add psmisc as build required dep
Running a new F20 minimal install I installed all build reqs
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Remove Obsoletes: python-cpopen
..
Patch Set 2:
Jenkins error is not related to this patch.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: Remove Obsoletes: python-cpopen
..
Patch Set 2: Verified-1
Build Failed
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: Remove Obsoletes: python-cpopen
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22113
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3:
(2 comments)
-1, mostly for visibility.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 1: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: QoS: make report only when present and say so in the schema
..
Patch Set 3: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/22018
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
Federico Simoncelli has uploaded a new change for review.
Change subject: securable: refactor the scurable implementation
..
securable: refactor the scurable implementation
Change-Id: Id5a8be7536748481746795e27701fbecc7c3318c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5924/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 2:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 2: Verified-1
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 3: Verified+1
Builds fine in F20.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sp: Fix stopping domain monitors
..
Patch Set 1:
(1 comment)
Commit Message
Line 22: jobs, where there is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 3: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge This hook
support binding specified mac address to custom/other bridge than the currently
defined bridge in ovirt. This hook is also capable of binding a mac address to
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ipwrapper: Introduce the linkPool
..
ipwrapper: Introduce the linkPool
The linkPool is a Link object pool that is kept updated with the
events from ip
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: Introduce the linkPool
..
Patch Set 1:
@Dan any idea about the execCmd proc object not having a working daemonic
operation?
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: specfile: Add dosfstools and psmisc as build required dep
..
Patch Set 2:
(1 comment)
File vdsm.spec.in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: Introduce the linkPool
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5926/ : SUCCESS
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 7: Code-Review-1
(1 comment)
File
96 matches
Mail list logo
