Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review+1 Nif - Please verify. You can do this by moving ovirtmgmt to static, manually

Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)

2013-12-26 Thread rgolan
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: the libvirt xml is changed now to allow adding more cpus this means we have a topology element and a

Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6393/ :

Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)

2013-12-26 Thread rgolan
Roy Golan has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 7: Verified+1 Verified * the vm is up and running with 2 cpus * can call setVcpus Not verified * the

Change in vdsm[master]: Add --force option to upgrades

2013-12-26 Thread amuller
Assaf Muller has uploaded a new change for review. Change subject: Add --force option to upgrades .. Add --force option to upgrades The --force option will ignore the existance of upgrade files in /var/lib/vdsm/upgrade/ Each

Change in vdsm[master]: Add --force option to upgrades

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add --force option to upgrades .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6394/ : SUCCESS

Change in vdsm[master]: Add --force option to upgrades

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Add --force option to upgrades .. Patch Set 1: Verified+1 Verification: VDSM's invocation of the upgrades doesn't use --force Using --force properly ignores the

Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22742 To unsubscribe, visit

Change in vdsm[master]: Added network directory

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Added network directory .. Patch Set 2: Verified+1 Passes all unit and functional tests. -- To view, visit http://gerrit.ovirt.org/22694 To unsubscribe, visit

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: (1 comment) File vdsm/sourceRouteThread.py Line

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 3: (1 comment) File vdsm/sourceRouteThread.py

Change in vdsm[master]: sp: split metadata transaction in createMaster

2013-12-26 Thread abaron
Ayal Baron has posted comments on this change. Change subject: sp: split metadata transaction in createMaster .. Patch Set 2: (1 comment) File vdsm/storage/sd.py Line 771:

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 1: (1 comment) File vdsm/supervdsmServer

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Code-Review+1 why do you have 3 patchsets for the same change? good catch. must be

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 4: Since the module does not care any more about starting multiple threads, the global _thread is not

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-26 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 1: Code-Review-2 until we'll have a bug -- To view, visit http://gerrit.ovirt.org/22563 To

Change in vdsm[master]: supervdsmServer: Run sourceRouteThread in a thread

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer: Run sourceRouteThread in a thread .. Patch Set 3: Multiple patches are a Good Thing. I am not sure this is a bug per se. It's not the

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/22723 To unsubscribe, visit

Change in vdsm[master]: sourceRouteThread: Encapsulate inotify thread

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sourceRouteThread: Encapsulate inotify thread .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6395/ : SUCCESS

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 2: Add bug url, no code change. -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: fileSD: Fix image deletion on gluster domain

2013-12-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: fileSD: Fix image deletion on gluster domain .. Patch Set 2: Verified+1 Code was not changed. -- To view, visit http://gerrit.ovirt.org/22563 To unsubscribe,

Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan

2013-12-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Check all devices visibility after multipath rescan .. hsm: Check all devices visibility after multipath rescan After invoking multipath rescan,

Change in vdsm[master]: hsm: Do not hide errors when checking device visibility

2013-12-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Do not hide errors when checking device visibility .. hsm: Do not hide errors when checking device visibility When checking devices visibility,

Change in vdsm[master]: Revert clientIF: rescan devices on failed hotplugDisk

2013-12-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert clientIF: rescan devices on failed hotplugDisk .. Revert clientIF: rescan devices on failed hotplugDisk Commit

Change in vdsm[master]: setupNetworks: support networks with no underlying NIC

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: support networks with no underlying NIC .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22595 To unsubscribe, visit

Change in vdsm[master]: setupNetworks: support networks with no underlying NIC

2013-12-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: setupNetworks: support networks with no underlying NIC .. setupNetworks: support networks with no underlying NIC The old addNetwork API supported the

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread amuller
Assaf Muller has uploaded a new change for review. Change subject: Improved macspoof hook README following user request .. Improved macspoof hook README following user request Change-Id:

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6396/ :

Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 8: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6398/ :

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 2: (1 comment) File

Change in vdsm[master]: Unified net persistence upgrade: Change 'bridged' from str t...

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Unified net persistence upgrade: Change 'bridged' from str to bool .. Patch Set 1: Taking Toni's word on this one. -- To view, visit

Change in vdsm[master]: Unified net persistence upgrade: Change 'bridged' from str t...

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Unified net persistence upgrade: Change 'bridged' from str to bool .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22721 To

Change in vdsm[master]: Unified net persistence upgrade: Change 'bridged' from str t...

2013-12-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Unified net persistence upgrade: Change 'bridged' from str to bool .. Unified net persistence upgrade: Change 'bridged' from str to bool 'bridged' is

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6399/ :

Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)

2013-12-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: set the # of vcpus for a VM (hot plug/unplug) .. Patch Set 9: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6400/ :

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Improved macspoof hook README following user request .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22760 To unsubscribe, visit

Change in vdsm[master]: Improved macspoof hook README following user request

2013-12-26 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Improved macspoof hook README following user request .. Improved macspoof hook README following user request Change-Id:

Change in vdsm[master]: Add --force option to upgrades

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add --force option to upgrades .. Patch Set 1: Code-Review-1 What is it good for? When should it be used? Please explain in the commit message. -- To view,

Change in vdsm[master]: [1/2] getVdsCaps returns client iface for *current* connection

2013-12-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: [1/2] getVdsCaps returns client iface for *current* connection .. Patch Set 2: Code-Review-1 (3 comments) This is an important bug fix. Would you make it more