oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6408/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 3: Verified+1
verified against running VM.
changes since last patchset:
* log the errorCode only if the
Francesco Romani has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 3: Code-Review+1
Adding Saggi to review json api part, and allon to see if not requires any
engine's
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6409/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 1: Code-Review+1
This is good change as is. Feel free to improve it further.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 4: Verified+1
fixed typo in the commit message
--
To view, visit http://gerrit.ovirt.org/22631
To
Francesco Romani has abandoned this change.
Change subject: vm: janitorial: factorize key deletion in Vm.conf
..
Abandoned
http://gerrit.ovirt.org/#/c/22783/ is a much better approach
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6410/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 2:
Changes since last PatchSet:
* followed Dan's advice and made 'recover' and factored it
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6411/ :
Nir Soffer has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 1:
(5 comments)
Commit Message
Line 3:
Nir Soffer has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 2:
I'm now wondering if it would be good to split the recover code path from
createVm and
Francesco Romani has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 1:
(4 comments)
Commit Message
Line 3:
Francesco Romani has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 2:
I agree, the split-recover-path change is definitely better in a different
patch.
--
To
Maor Lipchuk has uploaded a new change for review.
Change subject: vdsm: Log unhandled exception for API fence node.
..
vdsm: Log unhandled exception for API fence node.
Adding a traceback log when openning a new thread in the
Maor Lipchuk has uploaded a new change for review.
Change subject: vdsm: Log unhandled exception for clientIF
..
vdsm: Log unhandled exception for clientIF
Adding a traceback log for unhandled exceptions,
when openning a new
Maor Lipchuk has uploaded a new change for review.
Change subject: vdsm: Add log to sourceRouteThread
..
vdsm: Add log to sourceRouteThread
Adding a log for sourceRouteThread so the log
will also contain the module name.
Maor Lipchuk has uploaded a new change for review.
Change subject: vdsm: Log unhandled exception for libvirt connection
..
vdsm: Log unhandled exception for libvirt connection
Adding a traceback log for unhandled exceptions
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for libvirt connection
..
Patch Set 1: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6413/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for API fence node.
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6414/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Add log to sourceRouteThread
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6415/ :
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: fileSD: Fix image deletion on gluster domain
..
fileSD: Fix image deletion on gluster domain
getImagePath() does not work for glusterSD. The problem
Yaniv Bronhaim has posted comments on this change.
Change subject: fileSD: Fix image deletion on gluster domain
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/22563
To unsubscribe, visit
Hello Saggi Mizrahi, Antoni Segura Puimedon, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22815
to review the following change.
Change subject: sampling: make HostStatsThread a daemon thread
Yaniv Bronhaim has posted comments on this change.
Change subject: sampling: make HostStatsThread a daemon thread
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22815
To unsubscribe, visit
Nir Soffer has abandoned this change.
Change subject: Checking pep8 on jenkins
..
Abandoned
jenkins fixed now
--
To view, visit http://gerrit.ovirt.org/22724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 5:
(1 comment)
cpopen 1.2.3-5 is now available . please verify
Dan Kenigsberg has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 8:
(1 comment)
File vdsm/storage/sp.py
Line 154:
Nir Soffer has posted comments on this change.
Change subject: vdsm: Add log to sourceRouteThread
..
Patch Set 1: Code-Review-1
(2 comments)
File vdsm/sourceRouteThread.py
Maor Lipchuk has posted comments on this change.
Change subject: vdsm: Add log to sourceRouteThread
..
Patch Set 1:
(1 comment)
File vdsm/sourceRouteThread.py
Line 12:
Francesco Romani has uploaded a new change for review.
Change subject: tests: do not check permissions on dos filesystem
..
tests: do not check permissions on dos filesystem
commit 0b147dc2e247e787ad760ba30a8b8815eb65daca
Francesco Romani has posted comments on this change.
Change subject: tests: do not check permissions on dos filesystem
..
Patch Set 1: Verified+1
verified:
* make check (as root) pass
* make rpm (as root) ends succesfully
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: do not check permissions on dos filesystem
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6416/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6417/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 9: Verified+1
Verified starting the spm (triggering getSpmStatus and setSpmStatus).
--
To view,
Federico Simoncelli has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 4: Verified+1
Verified creating a new pool.
--
To view, visit http://gerrit.ovirt.org/22418
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6418/ : SUCCESS
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: improve pool creation error handling
..
sp: improve pool creation error handling
Change-Id: I0cce08e368dec09c081609d0663d7990ab10
Signed-off-by:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: improve pool creation error handling
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6419/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: encapsulate spm status in StoragePool
..
sp: encapsulate spm status in StoragePool
The scope of this patch is to group the spm status values and
Dan Kenigsberg has posted comments on this change.
Change subject: sp: encapsulate spm status in StoragePool
..
Patch Set 9: Code-Review+2
Same as the version acked by Ayal, with pool.setMetaParams() inlined.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configNetwork: Fix bridgeless broken network deletion
..
Patch Set 5: Verified-1
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 2: Code-Review+2
Make sure to verify this patch with the create, recover, and dehibernation
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 4:
(1 comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 4:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Add log to sourceRouteThread
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6420/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for API fence node.
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6422/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6421/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for libvirt connection
..
Patch Set 2: Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: allow hooks to pass down dictionaries in json format
..
Patch Set 5: Verified-1
Build Failed
Federico Simoncelli has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 1:
(6 comments)
File vdsm/storage/sp.py
Line 879:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
..
Patch Set 3: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6426/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Add log to sourceRouteThread
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6425/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for libvirt connection
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6428/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for API fence node.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6427/ :
Federico Simoncelli has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 2: Verified+1
Verified migrating the master several times.
--
To view, visit http://gerrit.ovirt.org/22419
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6429/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: make HostStatsThread a daemon thread
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22815
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: mkimage: do not create world-readable image
..
Patch Set 5:
(1 comment)
File debian/control
Line 92:
Yaniv Bronhaim has posted comments on this change.
Change subject: Sometimes the FD number can be reused in the child process
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/9591
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: remove a dangling _saveReconnectInformation
..
sp: remove a dangling _saveReconnectInformation
A reordering of patches left a dangling
Dan Kenigsberg has posted comments on this change.
Change subject: sp: remove a dangling _saveReconnectInformation
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22823
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6431/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for libvirt connection
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6433/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Log unhandled exception for API fence node.
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6432/ :
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
..
Patch Set 4:
(2 comments)
Commit Message
Line 3: AuthorDate:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sp: remove a dangling _saveReconnectInformation
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6434/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for clientIF
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22812
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Add log to sourceRouteThread
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6430/ : SUCCESS
Nir Soffer has abandoned this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Abandoned
Not needed after libvirt eventloop fix was merged. Cleaning up imports in
remoteFileHandler should be
Nir Soffer has posted comments on this change.
Change subject: hsm: Rescan multipath before loading lvm cache
..
Patch Set 2:
Waiting until http://gerrit.ovirt.org/21530 is finished.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: sp: remove a dangling _saveReconnectInformation
..
Patch Set 1: Verified+1
Verified running masterMigrate
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: remove a dangling _saveReconnectInformation
..
sp: remove a dangling _saveReconnectInformation
A reordering of patches left a dangling
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer: Cleaner way to wait for signals
..
Patch Set 2: Code-Review+1
should be rebased above http://gerrit.ovirt.org/#/c/22718/ to test it
--
To
Yaniv Bronhaim has posted comments on this change.
Change subject: sourceRouteThread: Encapsulate inotify thread
..
Patch Set 4: Code-Review+1
I prefer that one. abandon http://gerrit.ovirt.org/#/c/22718/ and just be sure
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: remove master info from getStorageDomainInfo
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6435/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: sourceRouteThread: Encapsulate inotify thread
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/22723
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: supervdsmServer: Cleaner way to wait for signals
..
Patch Set 2:
after rebasing it over http://gerrit.ovirt.org/#/c/22723/ I'll verify this part
too
--
To
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: sampling: make HostStatsThread a daemon thread
..
sampling: make HostStatsThread a daemon thread
It can cause VDSM to hang when being improperly shut
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: janitorial: introduce a recovering attribute.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22783
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: configNetwork: Fix bridgeless broken network deletion
..
Patch Set 5: Code-Review+1
not sure
Yaniv Bronhaim has posted comments on this change.
Change subject: Add --force option to upgrades
..
Patch Set 1:
(3 comments)
File lib/vdsm/tool/upgrade.py
Line 117:
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 9:
it fails (FAIL: testCpuXML (vmTests.TestVm)). except that it looks quite
complete to me
--
To
Mike Kolesnik has posted comments on this change.
Change subject: hooks: Extract function for command execution
..
Patch Set 1:
(3 comments)
File
Mike Kolesnik has posted comments on this change.
Change subject: hooks: Security groups support for OVS
..
Patch Set 1:
(7 comments)
In reply to Itamar: the feature page is at
Ayal Baron has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
..
Patch Set 4:
(1 comment)
File vdsm/storage/sp.py
Line 695:
Ayal Baron has posted comments on this change.
Change subject: sp: improve masterMigrate safety
..
Patch Set 2:
(2 comments)
File vdsm/storage/sp.py
Line 768:
Ayal Baron has posted comments on this change.
Change subject: hsm: remove master info from getStorageDomainInfo
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22824
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Add log to sourceRouteThread
..
Patch Set 4:
(1 comment)
File vdsm/sourceRouteThread.py
Line 9:
Line
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for libvirt connection
..
Patch Set 4: Code-Review+1
Nice
--
To view, visit http://gerrit.ovirt.org/22811
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for API fence node.
..
Patch Set 4: Code-Review+1
Nice - I would never guess that this function is running in a thread.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for API fence node.
..
Patch Set 4: -Code-Review
(1 comment)
We can remove unneeded try except block in the wrapped function.
Nir Soffer has posted comments on this change.
Change subject: vdsm: Log unhandled exception for API fence node.
..
Patch Set 4:
(1 comment)
Commit Message
Line 3:
Itamar Heim has posted comments on this change.
Change subject: hooks: Security groups support for OVS
..
Patch Set 1:
mike - please include bug or feature page links in the commit message. the
review comments are way less
96 matches
Mail list logo
