Change in vdsm[master]: execCmd: no need to pass the default sudo=False value

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: execCmd: no need to pass the default sudo=False value .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24145 To unsubscribe,

Change in vdsm[master]: hsm: encapsulate devPath in appropriateDevice

2014-02-12 Thread derez
Daniel Erez has posted comments on this change. Change subject: hsm: encapsulate devPath in appropriateDevice .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24406 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: hsm: encapsulate devPath in appropriateDevice

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: encapsulate devPath in appropriateDevice .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7223/ : SUCCESS h

Change in vdsm[master]: hsm.py: volUUID is not member of HSM class

2014-02-12 Thread derez
Daniel Erez has posted comments on this change. Change subject: hsm.py: volUUID is not member of HSM class .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24313 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: vm: added missing GUID slot in Drive class

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: added missing GUID slot in Drive class .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7222/ : SUCCESS http

Change in vdsm[master]: hsm: encapsulate devPath in appropriateDevice

2014-02-12 Thread derez
Daniel Erez has posted comments on this change. Change subject: hsm: encapsulate devPath in appropriateDevice .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24406/1/vdsm/clientIF.py File vdsm/clientIF.py: Line 270:

Change in vdsm[master]: vm: added missing GUID slot in Drive class

2014-02-12 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: vm: added missing GUID slot in Drive class .. vm: added missing GUID slot in Drive class Following commit I6e8dadabdd02d3b44606f215c4bc7b7e306a591a, added missing

Change in vdsm[master]: vm: added missing GUID slot in Drive class

2014-02-12 Thread derez
Daniel Erez has posted comments on this change. Change subject: vm: added missing GUID slot in Drive class .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24418 To unsubscribe, visit http://gerrit.ovirt.or

Change in vdsm[master]: pylint: fix format string

2014-02-12 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: pylint: fix format string .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24412 To unsubscribe, visit http://gerrit.ovirt.org/s

Change in vdsm[master]: pylint: fix format string

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: pylint: fix format string .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7221/ : SUCCESS http://jenkins.ovirt.

Change in vdsm[master]: make check: add a pylint check

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: make check: add a pylint check .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7220/ : SUCCESS http://je

Change in vdsm[master]: pylint: fix format string

2014-02-12 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: pylint: fix format string .. pylint: fix format string Change-Id: I36ce9cdb63c49c0058af1f357badd13b1ae6be2b Signed-off-by: Dan Kenigsberg --- M vdsm/clientIF.

Change in vdsm[master]: make check: add a pylint check

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: make check: add a pylint check .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7219/ : SUCCESS http://je

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 3: Code-Review+1 Nicer than what I have envisaged. Please get Saggi to review it, though. -- To view, v

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7112/ : SUCCESS http

Change in vdsm[master]: hsm: encapsulate devPath in appropriateDevice

2014-02-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hsm: encapsulate devPath in appropriateDevice .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24406/1/vdsm/clientIF.py File vdsm/clientIF.py: Line 270:

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 3: Clean up commit message. -- To view, visit http://gerrit.ovirt.org/24309 To unsubscribe, visit http://ge

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7217/ : SUCCESS http:

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 2: This patch remove most of the places that import threadLocal.vars, and use a new threadlocal_task decorat

Change in vdsm[ovirt-3.4]: API: return additional Hosted Engine information from vdsStats

2014-02-12 Thread alitke
Adam Litke has posted comments on this change. Change subject: API: return additional Hosted Engine information from vdsStats .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24090 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: API: setHaMaintenanceMode command

2014-02-12 Thread alitke
Adam Litke has posted comments on this change. Change subject: API: setHaMaintenanceMode command .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24091 To unsubscribe, visit http://gerrit.ovirt.org/setti

Change in vdsm[master]: [WIP] destroy storage pool using command type 1

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] destroy storage pool using command type 1 .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6326/ : SUCCESS

Change in vdsm[ovirt-3.3]: vm iface statistics: never report negative rates

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm iface statistics: never report negative rates .. Patch Set 2: New bug cloned. -- To view, visit http://gerrit.ovirt.org/24322 To unsubscribe, visit http://

Change in vdsm[ovirt-3.3]: vm iface statistics: never report negative rates

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm iface statistics: never report negative rates .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24322 To unsubscribe, visit http://gerrit

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Enable config of VM serial number .. vdsm: Enable config of VM serial number Added support for passing explicit serial number as a part of vmPara

Change in vdsm[ovirt-3.4]: API: setHaMaintenanceMode command

2014-02-12 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: API: setHaMaintenanceMode command .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24091 To unsubscribe, visit http://gerrit

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24309/1/vdsm/storage/threadPool.py File vdsm/storage/threadPo

Change in vdsm[ovirt-3.4]: API: return additional Hosted Engine information from vdsStats

2014-02-12 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: API: return additional Hosted Engine information from vdsStats .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24090 To unsubscribe, visit h

Change in vdsm[ovirt-3.4]: API: setHaMaintenanceMode command

2014-02-12 Thread gpadgett
Greg Padgett has posted comments on this change. Change subject: API: setHaMaintenanceMode command .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24091 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: hsm: encapsulate devPath in appropriateDevice

2014-02-12 Thread derez
Daniel Erez has posted comments on this change. Change subject: hsm: encapsulate devPath in appropriateDevice .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24406 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: hsm: encapsulate devPath in appropriateDevice

2014-02-12 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: hsm: encapsulate devPath in appropriateDevice .. hsm: encapsulate devPath in appropriateDevice As a continuation of Ie0d4d805ca333990ea1f612eb03a87f4a505f4a8, app

Change in vdsm[ovirt-3.4]: API: return additional Hosted Engine information from vdsStats

2014-02-12 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: API: return additional Hosted Engine information from vdsStats .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24090 To unsubscribe, vis

Change in vdsm[ovirt-3.4]: API: setHaMaintenanceMode command

2014-02-12 Thread gpadgett
Greg Padgett has restored this change. Change subject: API: setHaMaintenanceMode command .. Restored Change merged to master, needs review for 3.4 -- To view, visit http://gerrit.ovirt.org/24091 To unsubscribe, visit http://g

Change in vdsm[ovirt-3.4]: API: return additional Hosted Engine information from vdsStats

2014-02-12 Thread gpadgett
Greg Padgett has restored this change. Change subject: API: return additional Hosted Engine information from vdsStats .. Restored Change merged to master, needs review for 3.4 -- To view, visit http://gerrit.ovirt.org/24090 T

Change in vdsm[master]: [WIP] Create storage pool using command type 1

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Create storage pool using command type 1 .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_ger

Change in vdsm[master]: [WIP] destroy storage pool using command type 1

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] destroy storage pool using command type 1 .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6326/

Change in vdsm[master]: [WIP] Towards a more (block) secure HSM.

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Towards a more (block) secure HSM. .. Patch Set 7: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el

Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] lvm: Add an option to replace locking type 4 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6323/ : FAILUR

Change in vdsm[master]: [WIP] Create storage domain using command type 1

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6324/ : SUCC

Change in vdsm[master]: [WIP] destroy storage pool using command type 1

2014-02-12 Thread ykaplan
Yeela Kaplan has uploaded a new change for review. Change subject: [WIP] destroy storage pool using command type 1 .. [WIP] destroy storage pool using command type 1 Change-Id: I67cda9abd0bbc01d7d0642d5d3327f8687d7f728 Signed-of

Change in vdsm[ovirt-3.4]: hsm: Fix missing MAX_DOMAINS constant

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: hsm: Fix missing MAX_DOMAINS constant .. Patch Set 1: verification is what required here now -- To view, visit http://gerrit.ovirt.org/24264 To unsubscribe, v

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerr

Change in vdsm[ovirt-3.4]: hsm: Fix missing MAX_DOMAINS constant

2014-02-12 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: hsm: Fix missing MAX_DOMAINS constant .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24264 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: spec: require libvirt 0.10.2-29.el6_5.4

2014-02-12 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: spec: require libvirt 0.10.2-29.el6_5.4 .. Patch Set 1: Code-Review-1 Waiting for the package to be available. -- To view, visit http://gerrit.ovirt.org/

Change in vdsm[master]: spec: require libvirt 0.10.2-29.el6_5.4

2014-02-12 Thread Federico Simoncelli
Federico Simoncelli has uploaded a new change for review. Change subject: spec: require libvirt 0.10.2-29.el6_5.4 .. spec: require libvirt 0.10.2-29.el6_5.4 A libvirt race condition caused the volume watermark to be reported as

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 5: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6321/ : SUC

Change in vdsm[master]: make check: add a pylint check

2014-02-12 Thread lbednar
Lukas Bednar has posted comments on this change. Change subject: make check: add a pylint check .. Patch Set 1: +1 I am surprised that it had quick response time. I wish you patience to get pylint_blacklist empty. thanks. --

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24309/1/vdsm/storage/threadPool.py File vdsm/storage/threadPool.p

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6320/ : FAILUR

Change in vdsm[master]: Validate conf in configure only if not forcing overriding

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Validate conf in configure only if not forcing overriding .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24132 To unsubscribe, visit h

Change in vdsm[master]: threadLocal: Cleanup thread local storage

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/24309/1//COMMIT_MSG Commit Message: Line 6: Line 7: thread

Change in vdsm[master]: Validate conf in configure only if not forcing overriding

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Validate conf in configure only if not forcing overriding .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/631

Change in vdsm[master]: introducing capabillity to stream data to image

2014-02-12 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: introducing capabillity to stream data to image .. Patch Set 9: (6 comments) http://gerrit.ovirt.org/#/c/23281/9//COMMIT_MSG Commit Message: Line 3: Auth

Change in vdsm[master]: Use same constants for configuring and check configure of sa...

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr

Change in vdsm[master]: Use same constants for configuring and check configure of sa...

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/24011 To unsubscribe, v

Change in vdsm[master]: make check: add a pylint check

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: make check: add a pylint check .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6317/ : SUCCESS http:/

Change in vdsm[master]: make check: add a pylint check

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: make check: add a pylint check .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24382/1//COMMIT_MSG Commit Message: Line 13: check gradually. Please a

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 3: Oh, and if you have a URL for the feature or the bug, please include it in the commit message. -- To

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 3: Code-Review-1 Please update VmDefinition in vdsm_api/vdsmapi-schema.json -- To view, visit http://gerr

Change in vdsm[master]: make check: add a pylint check

2014-02-12 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: make check: add a pylint check .. make check: add a pylint check pylint reports of plenty errors in our code, some of them are only style issues in our code or

Change in vdsm[master]: vm: set self._dom to None after destroying vm

2014-02-12 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: vm: set self._dom to None after destroying vm .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23014 To unsubscribe, visit http://gerr

Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/

Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

2014-02-12 Thread mpoledni
Martin Polednik has posted comments on this change. Change subject: tests: validate cdrom path sent to/received from vdsm .. Patch Set 4: Verified+1 Addresed Francesco's comments. -- To view, visit http://gerrit.ovirt.org/221

Change in vdsm[master]: vdsm: add support for TPM device passthrough

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for TPM device passthrough .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6315/ : SUCCESS

Change in vdsm[master]: vdsm: add support for TPM device passthrough

2014-02-12 Thread mpoledni
Martin Polednik has posted comments on this change. Change subject: vdsm: add support for TPM device passthrough .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/20649 To unsubscribe, visit http://gerrit.ov

Change in vdsm[ovirt-3.3]: vm iface statistics: never report negative rates

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vm iface statistics: never report negative rates .. Patch Set 1: Code-Review-1 the bz is targeted to 3.4. open 3.3 bug -- To view, visit http://gerrit.ovirt.o

Change in vdsm[ovirt-3.3]: vm iface statistics: never report negative rates

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: vm iface statistics: never report negative rates .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24322 To unsubscribe, visit http://ger

Change in vdsm[master]: Use same constants for configuring and check configure of sa...

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerr

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/3

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Removing vdsm-python-cpopen rpm creation from vdsm In vdsm 4.13.2 we replaced the dependency of p

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Patch Set 1: better to wait for Debian verification ? -- To view, visit http://gerrit.ovirt.org/24360 To

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 3: Code-Review+1 Good! Thanks for the explanation in the commit msg. -- To view, visit http://ger

Change in vdsm[master]: vm: set self._dom to None after destroying vm

2014-02-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: set self._dom to None after destroying vm .. Patch Set 3: I'm in for this. -- To view, visit http://gerrit.ovirt.org/23014 To unsubscribe, visit http://

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 3: Verified+1 updated commit message -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit

Change in vdsm[master]: introducing capabillity to stream data to image

2014-02-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: introducing capabillity to stream data to image .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/23281/9/vdsm/storage/imageSharing.py File vdsm/storage/imag

Change in vdsm[master]: hsm.py: volUUID is not member of HSM class

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hsm.py: volUUID is not member of HSM class .. Patch Set 2: Code-Review+2 checking python module: cpopen... no configure: error: failed to find required module c

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24360 To unsubscribe, visit http://g

Change in vdsm[master]: hsm.py: volUUID is not member of HSM class

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm.py: volUUID is not member of HSM class .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6313/ : SUC

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24360 To unsubscribe, visit http://ge

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 2: The goal of this feature is to give user better control over the resulting serial number of the VM. At th

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/3

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24360 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Patch Set 1: Verified+1 verified on rhel. need to check with debian that i didn't break anything -- To v

Change in vdsm[ovirt-3.3]: Removing vdsm-python-cpopen rpm creation from vdsm

2014-02-12 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Removing vdsm-python-cpopen rpm creation from vdsm .. Removing vdsm-python-cpopen rpm creation from vdsm In vdsm 4.13.2 we replaced the dependency of python-cp

Change in vdsm[master]: introducing capabillity to stream data to image

2014-02-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: introducing capabillity to stream data to image .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/23281/9//COMMIT_MSG Commit Message: Line 40: -- Mandatory

Change in vdsm[master]: execCmd: no need to pass the default sudo=False value

2014-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: execCmd: no need to pass the default sudo=False value .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24145 To unsubscribe, visit http:

Change in vdsm[ovirt-3.4]: vm: discover volume path from xml definition

2014-02-12 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: discover volume path from xml definition .. vm: discover volume path from xml definition In a previous commit (c072945 One shot prepare) we involun

Change in vdsm[ovirt-3.3]: vm: discover volume path from xml definition

2014-02-12 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: discover volume path from xml definition .. vm: discover volume path from xml definition In a previous commit (c072945 One shot prepare) we involun

Change in vdsm[master]: vdsm: add support for TPM device passthrough

2014-02-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vdsm: add support for TPM device passthrough .. Patch Set 3: Code-Review-1 (2 comments) -1 for the trailing spaces http://gerrit.ovirt.org/#/c/20649/3/vdsm/

Change in vdsm[master]: caps: Collect numa information

2014-02-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: caps: Collect numa information .. Patch Set 5: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/23703/5//COMMIT_MSG Commit Message: Line 15: The items

Change in vdsm[master]: hsm.py: volUUID is not member of HSM class

2014-02-12 Thread lbednar
Lukas Bednar has posted comments on this change. Change subject: hsm.py: volUUID is not member of HSM class .. Patch Set 1: I noticed this issue besides of [1]. I tried to run pylint on hsm.py module. and it showed up. I belie

Change in vdsm[master]: introducing capabillity to stream data to image

2014-02-12 Thread laravot
Liron Ar has posted comments on this change. Change subject: introducing capabillity to stream data to image .. Patch Set 9: (5 comments) http://gerrit.ovirt.org/#/c/23281/9//COMMIT_MSG Commit Message: Line 30: today for requ