oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6896/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 5: Verified+1
Patch set 5: force the type to string for consistency.
Verification:
* added unit
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 3:
Patch set 3: added and used a new error code
--
To view, visit http://gerrit.ovirt.org/25803
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6897/ :
Francesco Romani has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 6: Verified+1
patch set 6: wrong c'n'p in spec file, no code changes, re-ticked verified flag.
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6898/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 2:
First things first: I really like this idea.
But I strongly agree with Nir here: for the sake of ease
Vinzenz Feenstra has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/25803/3/vdsm/API.py
File vdsm/API.py:
Line 361:
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Verified+1
Re-verified manually:
* creation being tested during (still in progress) benchmarks
*
Francesco Romani has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 9: Verified+1
re-run same as for my previous comment tests on NFS storage, ticking verified.
--
To
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10: Verified+1
re-run same as for my previous comment tests on NFS storage, ticking verified.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6899/ :
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 4:
Patch set 4: actually discard partial stats as advertised
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/4/vdsm/vm.py
File vdsm/vm.py:
Line 2815:
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 2: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/25908/2/configure.ac
File configure.ac:
Dan Kenigsberg has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 2: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/25908/2/vdsm/API.py
File vdsm/API.py:
Line 1: #
Dan Kenigsberg has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21790
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Convert vm status strings to constants
..
Convert vm status strings to constants
This patch replaces all vmstatuses to constants.
Additionally added
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/419/ :
Dan Kenigsberg has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10:
(1 comment)
Thanks!
http://gerrit.ovirt.org/#/c/21792/10/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 35:
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10: Code-Review-1
(7 comments)
Some minor changes.
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in
Vinzenz Feenstra has uploaded a new change for review.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
virt: Rename vmChannels.py to vmchannels.py
Change-Id: Ic2cc66040035baa68ab5d29c483027cab97398c1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6900/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6901/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10:
(6 comments)
http://gerrit.ovirt.org/#/c/21792/10/vdsm.spec.in
File vdsm.spec.in:
Line 933:
Francesco Romani has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/25860
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6902/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6904/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6903/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 5: Verified+1
verification:
* runned a few migration manually without problems
since this
Nir Soffer has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 8: Code-Review+1
This block importing pickle is little ugly, and repeating it everywhere
increasing the ugliness.
How
Francesco Romani has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 8: -Verified
I like your proposal so much that I'm going to implement it and move this patch
on top of it.
--
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 12: Code-Review+1
Thanks Vinzenz!
--
To view, visit http://gerrit.ovirt.org/21792
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 12: Code-Review+1 Verified+1
the last changes seem to me small enough to not need to another round of
testing,
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 2:
I prefer to fix guestIF-guestagent, too, in one blow. Or have another followup.
--
To view, visit
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Rename guestIF{,Tests}.py to guestagent{,Tests}.py
Change-Id:
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26192
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 12: Code-Review+2
I think it's safe enough, too.
--
To view, visit http://gerrit.ovirt.org/21792
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6:
(2 comments)
Code should be simplified and errors must be handled.
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25877/6/tests/samplingTests.py
File tests/samplingTests.py:
Nir Soffer has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6: Code-Review-1
Not ready
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: py3: introduce a compatibility helper
..
py3: introduce a compatibility helper
introduce a module to host all the compatibility
code we need to support
Francesco Romani has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/25860/9/vdsm/storage/remoteFileHandler.py
File
Nir Soffer has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26196
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6906/ :
Nir Soffer has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/25860/9/vdsm/storage/remoteFileHandler.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6905/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26195
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6907/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26192
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: iscsi.py: cleanup - remove temp variable
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25710
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21792
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6910/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 1:
make rpm runs smoothly on F20, will try on RHEL before to tick as verified.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6908/ : SUCCESS
Dan Kenigsberg has abandoned this change.
Change subject: fencing: stop using a deprecated command
..
Abandoned
No urgency here, let's avoid the backporting headache.
--
To view, visit http://gerrit.ovirt.org/26075
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26196
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26196
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6909/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6911/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-reg: collect vdsm-config.log
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24862
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-reg: collect vdsm-config.log
..
vdsm-reg: collect vdsm-config.log
vdsm-config's log file was dumped in the catch-all /var/log directory.
Placing
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 13: Verified+1
re-verified using functional tests
http://paste.fedoraproject.org/89516/
some glitches
Antoni Segura Puimedon has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: oop: remove unused properties
..
Patch Set 1:
Could you put this patch on a topic branch so that the following patches are
tied together with this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6912/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6914/ :
Dan Kenigsberg has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Vinzenz Feenstra has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 622
Vinzenz Feenstra has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/25982/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 590:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6913/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Rename guestIF{,Tests}.py to guestagent{,Tests}.py
..
Patch Set 2:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6919/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26192
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/4/vdsm/vm.py
File vdsm/vm.py:
Line 2815:
Dan Kenigsberg has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2: Code-Review-1
Allon, Liron: if Vdsm holds the SPM, but is non-responsive, when is it fenced?
This patch adds
Dan Kenigsberg has submitted this change and it was merged.
Change subject: py3: introduce a compatibility helper
..
py3: introduce a compatibility helper
introduce a module to host all the compatibility
code we need to
Francesco Romani has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 2:
rebased and added fix for old pyflake
--
To view, visit http://gerrit.ovirt.org/26196
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: performance: switch to cPickle
..
performance: switch to cPickle
profiling of the creation code path shows
that the impact of pickle is not
Francesco Romani has posted comments on this change.
Change subject: tests: make virtTests run on RHEL/CentOS
..
Patch Set 1: Verified+1
verified running the tests.
--
To view, visit http://gerrit.ovirt.org/26198
To
Dan Kenigsberg has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25860
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 8: Code-Review-1
(2 comments)
some more small comments
Francesco Romani has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 3: Verified+1
verified using functional tests on F19.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6925/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: tests: make virtTests run on RHEL/CentOS
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26198/1/tests/functional/virtTests.py
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 7: Code-Review-1
(2 comments)
Minor comments
Antoni Segura Puimedon has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25860
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/25977/8/vdsm/virt/migration.py
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: make virtTests run on RHEL/CentOS
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6923/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25975/6/vdsm/virt/migration.py
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26111/2/init/sysvinit/vdsmd.init.in
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25908/2/vdsm/network/Makefile.am
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Rename vmChannels.py to vmchannels.py
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/432/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/434/ :
Dan Kenigsberg has posted comments on this change.
Change subject: py3: introduce a compatibility helper
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26196
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: make virtTests run on RHEL/CentOS
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6924/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25975/6/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/25976/7/vdsm/virt/migration.py
File
1 - 100 of 148 matches
Mail list logo
