Sergey Gotliv has posted comments on this change.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
Patch Set 5:
ping...
--
To view, visit http://gerrit.ovirt.org/25706
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix fix fix getDomUuidFromVolumePath()
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6943/ : SUCCESS
Eli Mesika has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3:
I don't think that a change from 2 to 10 sec will do a change since we are
computing the host load in soft
Dan Kenigsberg has posted comments on this change.
Change subject: nettests: use a constant dict NOCHK
..
Patch Set 2: Verified+1
Ran the complete functional test.
--
To view, visit http://gerrit.ovirt.org/26223
To
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: stop leaving leftover bridges when removing bonded
networks
..
Patch Set 2: Verified+1
Ran the complete functional test.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: nettests: use a constant dict NOCHK
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1183/ : FAILURE
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: iscsi: Specify tpgt to impose creation of a new style node
record
..
iscsi: Specify tpgt to impose creation of a new style node record
There are 2
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Change cpopen import
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26204/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 32:
Nir Soffer has posted comments on this change.
Change subject: utils: Change cpopen import
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26204/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 32: from
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix fix fix getDomUuidFromVolumePath()
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6943/ : SUCCESS
Vinzenz Feenstra has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: guest: Add support for guest cpu topology
..
Patch Set 15: Code-Review-1
(2 comments)
Making Federico's question more visible, and adding my own questions.
Federico Simoncelli has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 3:
(5 comments)
The libvirtCfg rename to libvirt worries me a little. Hopefully we won't get
Federico Simoncelli has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 3: Code-Review-1
--
To view, visit http://gerrit.ovirt.org/25908
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 21: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25263
To unsubscribe, visit
Martin Peřina has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3:
10 seconds is fine for for SSH Soft Fencing, because once vdsm restart command
was successfully executed,
Nir Soffer has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3:
Does engine timeout starts after vdsm restart command finished? Because if it
does, it means that this happens
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: stop leaving leftover bridges when removing bonded
networks
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26224
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: nettests: use a constant dict NOCHK
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26223
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 3:
(5 comments)
http://gerrit.ovirt.org/#/c/25908/3/vdsm/network/api.py
File vdsm/network/api.py:
Martin Peřina has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3:
Does engine timeout starts after vdsm restart command finished? Because if it
does, it means that this
Nir Soffer has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3:
Ok, then in this case increasing the timeout to 30-60 seconds will cause issues
with old engines.
--
To view,
Eli Mesika has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3:
Just reminding again that we want to prevent to enlarge recovery time for HA
VMs , so , 10 sec is OK 30 or bigger
Dan Kenigsberg has uploaded a new change for review.
Change subject: pep8: make pep8-1.5 happy with E241
..
pep8: make pep8-1.5 happy with E241
Change-Id: Ieaa71ec0adc2fdeff4f5530220d0f55c619bd726
Signed-off-by: Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3: Code-Review+2
Ok, if Engine is satisfied with extra 8 seconds for vdsm restart, I'm fine with
it too.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: nettests: use a constant dict NOCHK
..
Patch Set 2: Code-Review+2
Harmless test-only change
--
To view, visit http://gerrit.ovirt.org/26223
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: nettests: use a constant dict NOCHK
..
nettests: use a constant dict NOCHK
The options {'connectivityCheck': False} are very common, lets make it
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: stop leaving leftover bridges when removing bonded
networks
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26224
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ifcfg: stop leaving leftover bridges when removing bonded
networks
..
ifcfg: stop leaving leftover bridges when removing bonded networks
When having
Antoni Segura Puimedon has abandoned this change.
Change subject: vnic QoS: Fix specParams to XML definition conversion
..
Abandoned
Wrong branch
--
To view, visit http://gerrit.ovirt.org/26253
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26254
to review the following change.
Change subject: vnic QoS: Fix specParams to XML definition conversion
..
vnic QoS: Fix
mooli tayer has uploaded a new change for review.
Change subject: vds-tool: keep env on sysV service
..
vds-tool: keep env on sysV service
Update env when SYSTEMCTL_SKIP_REDIRECT is set instead of dropping
it.
Change-Id:
mooli tayer has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E265
..
Patch Set 1:
(3 comments)
http://gerrit.ovirt.org/#/c/26248/1/vdsm/gluster/exception.py
File vdsm/gluster/exception.py:
mooli tayer has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E241
..
Patch Set 1: -Verified Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26249
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E241
..
Patch Set 1:
So E265 (space before block comment) is included in pep8 1.5 and
E241 is not. is there going to be another
Kiril Nesenko has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 5:
Dan,
it make no sense for me to run .autogen.sh --system. Why do I need to run it as
a user with --system ?
Francesco Romani has uploaded a new change for review.
Change subject: WIP tests: add VM startup tests
..
WIP tests: add VM startup tests
Add more tests addressing the VM startup and XML processing.
Those tests will be used
Dima Kuznetsov has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E241
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26249
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4:
Please describe how you verified this patch (For example what operation you
performed, on which
Nir Soffer has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4:
For example verification description, see http://gerrit.ovirt.org/25706 or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6946/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E265
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6944/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vds-tool: keep env on sysV service
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6947/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E241
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6945/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP tests: add VM startup tests
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6948/ :
Xavi Francisco has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4: -Verified
--
To view, visit http://gerrit.ovirt.org/26121
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 4: Verified-1
Passed all network functional tests on f19 jenkins on the small change since
the
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: Introduce the network package
..
Patch Set 4: Verified+1
Meant to +1 but I botched it before :P
--
To view, visit
Francesco Romani has uploaded a new change for review.
Change subject: virt: migration: rename migration threads
..
virt: migration: rename migration threads
drop the now redundant 'Migration' prefix.
No functional or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6950/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6949/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6951/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: rename migration threads
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6954/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/25970/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: vds-tool: keep env on sysV service
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26255
To unsubscribe, visit
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Do not allow empty bridge names
..
Do not allow empty bridge names
It was possible to create empty bridge names that ended up in
libvirt networks
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Do not allow empty bridge names
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6955/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Do not allow empty bridge names
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26263
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6956/ :
Nir Soffer has posted comments on this change.
Change subject: virt: migration: rename migration threads
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26260
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6957/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6958/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6959/ :
Federico Simoncelli has uploaded a new change for review.
Change subject: volumeTests: add BlockDomainMetadataSlotTest
..
volumeTests: add BlockDomainMetadataSlotTest
A new test has been added to check the metadata slot
Federico Simoncelli has uploaded a new change for review.
Change subject: blockSD: rename mapMetaOffset to getVolumeMetadataSlot
..
blockSD: rename mapMetaOffset to getVolumeMetadataSlot
The name of the BlockStorageDomain
oVirt Jenkins CI Server has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
..
Patch Set 2:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: rename mapMetaOffset to getVolumeMetadataSlot
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6961/
Nir Soffer has posted comments on this change.
Change subject: Add logging to rules operations in supervdsmServer
..
Patch Set 4:
Thanks
--
To view, visit http://gerrit.ovirt.org/26121
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/25982/6/tests/vmTests.py
File tests/vmTests.py:
Line 809:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add logging to rules operations in supervdsmServer
..
Add logging to rules operations in supervdsmServer
Previously when udev rules were created and
Dan Kenigsberg has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 3: Code-Review-1
manual rebase needed
--
To view, visit http://gerrit.ovirt.org/26111
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/26112/3/vdsm/vdsm
File vdsm/vdsm:
Line 48:
Line
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/26112/3/vdsm/vdsm
File vdsm/vdsm:
Line 48:
Line 49: def
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 4:
Rebase on dependent patch.
--
To view, visit http://gerrit.ovirt.org/26112
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 6:
Rebase on dependent patch.
--
To view, visit http://gerrit.ovirt.org/26113
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6963/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6964/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6965/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 5:
We do not support or test non-system installations of Vdsm. But it does not
mean that we want to exclude them.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: init: Normalize shutdown timeout
..
init: Normalize shutdown timeout
On sysvinit, vdsm was killed 2 seconds after receiving a SIGTERM.
Currently
Dan Kenigsberg has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26111
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/26112/3/vdsm/vdsm
File vdsm/vdsm:
Line 48:
Line 49: def
Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: Clean up shutdown process
..
clientIF: Clean up shutdown process
clientIF.serve used to check if shutdown process has started once every
3
Dan Kenigsberg has submitted this change and it was merged.
Change subject: VmStatsThread: make _getNicStats testable
..
VmStatsThread: make _getNicStats testable
With this test, the shame of change Ie356d5f96c73b6 should not
Dan Kenigsberg has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25982
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vds-tool: keep env on sysV service
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6966/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E265
..
Patch Set 1: Verified+1
(1 comment)
Verified to contain no syntactical changes using
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E241
..
Patch Set 1: Verified+1
Verified to contain no syntactical changes using
https://github.com/edwardbadboy/pydiff
--
To
Dima Kuznetsov has posted comments on this change.
Change subject: pep8: make pep8-1.5 happy with E265
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26248
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vnic QoS: Fix specParams to XML definition conversion
..
Patch Set 1: Code-Review+2
Could you enable functional tests on this branch?
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: blockSD: rename mapMetaOffset to getVolumeMetadataSlot
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26265
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: autogen.sh: deprecate --system
..
Patch Set 5: Code-Review-1
Kiril, when you are creating the tar.gz or building the rpm you can run
./autogen.sh without
92 matches
Mail list logo
