Nir Soffer has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 6: Code-Review-1
(3 comments)
Hiding errors for no reason.
Francesco Romani has posted comments on this change.
Change subject: logs: improve VDSM logs human-readability
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in
File vdsm/logger.conf.in:
Nir Soffer has posted comments on this change.
Change subject: logs: improve VDSM logs human-readability
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in
File vdsm/logger.conf.in:
Line 66:
Nir Soffer has posted comments on this change.
Change subject: vdsm: adding docstring to MultiProtocolAcceptor and
ConnectedTcpServer
..
Patch Set 7: Code-Review-1
(1 comment)
Suggested more useful docstring.
Francesco Romani has uploaded a new change for review.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
vm: hyperv: make hw clock friendlier to windows
This patch sets the local time as windows reportedly
Francesco Romani has uploaded a new change for review.
Change subject: vm: hyperv: hyperv enlightenment optimizations
..
vm: hyperv: hyperv enlightenment optimizations
This patch the hyperv enlightenment optimizations.
The
Michal Skrivanek has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 716:
Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 6: Verified+1
Due to troublesome hyperv enlightenment support, I split the original patch in
a more
Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 1: Verified+1
Verified on RHEL6.5 by forcing the support to ON, then running a VM and
Francesco Romani has posted comments on this change.
Change subject: virt: migration: cleanup the migration mode
..
Patch Set 2: Verified+1
Verified on a patched VDSM by booting a VM and doing a hibernation/wakeup cycle.
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9656/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9655/ :
Francesco Romani has posted comments on this change.
Change subject: virt: replace status string with constant
..
Patch Set 2: Verified+1
Verified by doing hibernation/wakeup
--
To view, visit http://gerrit.ovirt.org/29110
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: hyperv enlightenment optimizations
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9657/ :
Michal Skrivanek has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 705:
Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 705:
Maor Lipchuk has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 6:
(3 comments)
http://gerrit.ovirt.org/#/c/29042/6/vdsm/storage/hsm.py
File
Michal Skrivanek has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29233/1/vdsm/virt/vm.py
File
Michal Skrivanek has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 705:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9658/ :
Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29233/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27619/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 705:
Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 8: Verified+1
removed arch check and utility method.
Copied score because I think the verification is
Francesco Romani has posted comments on this change.
Change subject: vm: hyperv: hyperv enlightenment optimizations
..
Patch Set 2:
rebased, dropped the helper method and the arch check
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: hyperv enlightenment optimizations
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9660/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9659/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9661/ :
Nir Soffer has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/29042/6/vdsm/storage/hsm.py
File
Michal Skrivanek has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 2: Code-Review+1
sorry, was confused
--
To view, visit http://gerrit.ovirt.org/29233
To
Maor Lipchuk has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/29042/6/vdsm/storage/hsm.py
File
Federico Simoncelli has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 6: Code-Review-1
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 7:
Build Failed
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27619
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29233
To unsubscribe, visit
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ifcfg: make conf file creation use device objects
..
ifcfg: make conf file creation use device objects
Up until not the configuration file creation
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: hyperv: hyperv enlightenment optimizations
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29234
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: make conf file creation use device objects
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
Michal Skrivanek has posted comments on this change.
Change subject: logs: improve VDSM logs human-readability
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in
File vdsm/logger.conf.in:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: make conf file creation use device objects
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9664/ :
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ifcfg: make conf file creation use device objects
..
ifcfg: make conf file creation use device objects
Up until not the configuration file creation
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ifcfg: make default route network be started by sysV
..
ifcfg: make default route network be started by sysV
With the change to unified persistence,
Nir Soffer has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/29042/6/vdsm/storage/hsm.py
File
Nir Soffer has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 7: Code-Review-1
See the comments for version 6:
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/29042/6/vdsm/storage/hsm.py
File
Nir Soffer has posted comments on this change.
Change subject: ifcfg: make default route network be started by sysV
..
Patch Set 1:
(1 comment)
Nice, needs little name cleanup.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9665/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9652/ :
Francesco Romani has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 2:
(1 comment)
My only concern is the name of the new module, not sure it is good enough. And
it is my
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(3 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 484:
Martin Polednik has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 2:
i myself find the name quite ok - kinda intuitive and autocomplete friendly
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 2:
still not using distutils as libvirt returns the version in format friendly for
simple = relation
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 15: Code-Review-1 Verified-1
Build Failed
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: isolate VmDevice xml generation method
..
vdsm: isolate VmDevice xml generation method
VmDevice class uses helper function 'createXmlElem' to ease
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9669/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9652/ :
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: initial split of vm devices
..
vdsm: initial split of vm devices
initial boostrapping of VmDevice and GeneralDevice from devices.py
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 16: Code-Review-1 Verified-1
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
(2 comments)
Nice, needs little cleanup.
http://gerrit.ovirt.org/#/c/17694/18/vdsm/virt/vm.py
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: Add args to remove_saslpasswd
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29201
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9670/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 17: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 8:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: isolate VmDevice xml generation method
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9671/ :
Francesco Romani has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 2:
(2 comments)
a few more notes (... to self :) )
http://gerrit.ovirt.org/#/c/26855/2/tests/vmTests.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: initial split of vm devices
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9672/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: vdsm: isolate VmDevice xml generation method
..
Patch Set 1: Code-Review+1
Here the distinction between devices and xml/domain start to blur.
In the future
Francesco Romani has posted comments on this change.
Change subject: vdsm: initial split of vm devices
..
Patch Set 1: Code-Review+1
(2 comments)
Things like class ControllerDevice(devices.VmDevice) are clumsy to read, but
I
oVirt Jenkins CI Server has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 8:
Build Successful
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move controller device to devices.py
..
vdsm: move controller device to devices.py
No real code changes
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
(2 comments)
I'm fine with the domain_descriptor.py;
but just a wild idea, maybe merge into
Nir Soffer has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 8: Code-Review-1
(3 comments)
Please *read* the comment for patch 6, explaining hot it can
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move video device to devices.py
..
vdsm: move video device to devices.py
No real code changes
Change-Id: I40ba700e6223490251af86189196f189ae4bad39
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move sound device to devices.py
..
vdsm: move sound device to devices.py
No real code changes
Change-Id: I42b8ae3475373d39c7d6375ccbc23a85437e19d0
Francesco Romani has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 2:
(1 comment)
Codewise your solution is fine; however, a bit nit about the naming.
Any possible
Martin Polednik has posted comments on this change.
Change subject: vdsm: initial split of vm devices
..
Patch Set 1:
I'd consider moving whole DeviceMapping and *_DEVICES to devices.py in future,
the meantime split will
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 18:
@return value
No, not any more, I just updated it
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move controller device to devices.py
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9674/ :
Dan Kenigsberg has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 8: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29213/8/vdsm.spec.in
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move video device to devices.py
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9675/ : SUCCESS
David Caro has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/29213/8/vdsm.spec.in
File vdsm.spec.in:
Line 97:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move controller device to devices.py
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9676/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: move sound device to devices.py
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9677/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: janitorial: move isVdsmImage into utils
..
janitorial: move isVdsmImage into utils
this patch moves vdsm/virt/vm.isVdsmImage into utils without code
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 19: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: janitorial: move isVdsmImage into utils
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1532/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9679/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: detach: Support force detach on orphaned Storage Domains.
..
Patch Set 9:
Build Successful
Federico Simoncelli has posted comments on this change.
Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/28264/1/vdsm/storage/hsm.py
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 18: Code-Review+2
yes, it's an unrelated
ImportError: No module named pyflakes
issue.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: detach: Support force detach on Storage Domains with old pools.
..
Patch Set 10:
Build Successful
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
vdsm-upgrade: adds wrapper to ovirt-node-upgrade
Currently ovirt-node provides ovirt-node-upgrade
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29279
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29279
to review the following change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
vdsm-upgrade: adds
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 19:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1533/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: hyperv: initial windows hyperv support
..
vm: hyperv: initial windows hyperv support
This patch adds explicit support for hyperv optimizations.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
Patch Set 2: Code-Review+2
raising score
--
To view, visit http://gerrit.ovirt.org/29233
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: hyperv: make hw clock friendlier to windows
..
vm: hyperv: make hw clock friendlier to windows
This patch sets the local time as windows
Dan Kenigsberg has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 8: Code-Review+2
Convinced.
--
To view, visit http://gerrit.ovirt.org/27619
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: detach: Support force detach on Storage Domains with old pools.
..
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/29042/10/vdsm/storage/hsm.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: hyperv: initial windows hyperv support
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1534/ :
1 - 100 of 203 matches
Mail list logo