Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: test: fixing cif getinstance issue
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29188
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: test: fixing cif getinstance issue
..
test: fixing cif getinstance issue
During running jsonrpc test cif.getInstance fails due to missing logger.
We
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: fixing cif getinstance issue
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1539/ : SUCCESS
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Moving conf init things together
..
Moving conf init things together
Change-Id: I41ac420cd0da5a3118ce5b3c4c3643b292ec2e86
Signed-off-by: Vinzenz Feenstra
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Query interface for all VM fields
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Moving conf init things together
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9707/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Moving conf init things together
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9708/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Query interface for all VM fields
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9709/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28838/2/vdsm/caps.py
File vdsm/caps.py:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: detach: Support force detach on Storage Domains with old pools.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29303
To unsubscribe,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: detach: Support force detach on Storage Domains with old pools.
..
detach: Support force detach on Storage Domains with old pools.
Force detach of
Yaniv Bronhaim has posted comments on this change.
Change subject: detach: Support force detach on Storage Domains with old pools.
..
Patch Set 2:
next time please add link to the patch on master
Martin Sivák has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 6:
(4 comments)
I can't persist the data when I change them, because
Martin Sivák has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added support for reporting the timezone and os info
..
Patch Set 3:
Build Failed
Francesco Romani has abandoned this change.
Change subject: WIP virt: use (c)ElementTree to process XML
..
Abandoned
Severely out of date. Will reboot once the xmldom and the domain_descriptor
patches are in.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9712/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9711/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9713/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9714/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: rename helper function
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9715/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9716/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: simplify the remote port handling
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9717/
Michal Skrivanek has posted comments on this change.
Change subject: Added support for reporting the timezone and os info
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/28940/3//COMMIT_MSG
Commit Message:
Line 6:
Vinzenz Feenstra has posted comments on this change.
Change subject: Added support for reporting the timezone and os info
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/28940/3//COMMIT_MSG
Commit Message:
Line 6:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added support for reporting the timezone and os info
..
Patch Set 4:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmcli: Add a contrib command line client alternative
..
Patch Set 1: Code-Review+2
I'd prefer something that parses the schema, but we can take it in, and
Nir Soffer has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
Dan Kenigsberg has posted comments on this change.
Change subject: net: remove last dependency on ifcfg persistence
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28530
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 6:
(4 comments)
not sure the design is actually correct if these
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: make default route network be started by sysV
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/29312/1//COMMIT_MSG
Commit Message:
Line 7:
Antoni Segura Puimedon has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 1: Code-Review-1
(6 comments)
Thanks for the change. Some string suggestions.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: verifyingTransport testing
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9719/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: adding docstring to MultiProtocolAcceptor and
ConnectedTcpServer
..
Patch Set 8:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9721/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: make default route network be started by sysV
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29312
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: adding docstring to MultiProtocolAcceptor and
ConnectedTcpServer
..
vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: adding docstring to MultiProtocolAcceptor and
ConnectedTcpServer
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28806
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: adding docstring to MultiProtocolAcceptor and
ConnectedTcpServer
..
Patch Set 9:
Build Successful
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: vdsm-store-net-config: make use of oVirt node bindings
..
vdsm-store-net-config: make use of oVirt node bindings
Up until now, vdsm-store-net-config
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-store-net-config: make use of oVirt node bindings
..
Patch Set 1:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: vdsm: verifyingTransport testing
..
Patch Set 6:
(4 comments)
http://gerrit.ovirt.org/#/c/28858/6/tests/sslTests.py
File tests/sslTests.py:
Line 64: def
Nir Soffer has posted comments on this change.
Change subject: vdsm: verifyingTransport testing
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/28858/6/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: drop redundant hasattr()
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9724/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: set status before to invoke suspend
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9723/ : SUCCESS
Adam Litke has posted comments on this change.
Change subject: Live Merge: Add liveMerge capability to vdsCaps
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/28998
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Live Merge: improve log messages
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: Live Merge: fix race between libvirt event and vm stats
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29309
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Live Merge: support active layer commit
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/28598
To unsubscribe, visit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
Greg Padgett has posted comments on this change.
Change subject: Live Merge: support active layer commit
..
Patch Set 5: Verified+1 Code-Review+1
Not too familiar with this code, but looks reasonable to me, and it works :)
--
Greg Padgett has posted comments on this change.
Change subject: Live Merge: fix race between libvirt event and vm stats
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29309
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: cleanup the migration mode
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9725/ :
Greg Padgett has posted comments on this change.
Change subject: Live Merge: improve log messages
..
Patch Set 1: Verified+1 Code-Review+1
My only reservation here is the job id first appears only at debug level, so if
an
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: replace status string with constant
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9726/ : SUCCESS
Greg Padgett has posted comments on this change.
Change subject: Live Merge: Add liveMerge capability to vdsCaps
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28998
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: verifyingTransport testing
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9728/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: Live Merge: support active layer commit
..
Patch Set 5: Code-Review-1
(5 comments)
Since we are waiting on libvirt, let's try to make this code nicer. -1
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Add liveMerge capability to vdsCaps
..
Patch Set 2: Code-Review+1
Looks good. Please consider to rebase http://gerrit.ovirt.org/#/c/28598/5 on
oVirt Jenkins CI Server has posted comments on this change.
Change subject: janitorial: move Vm._reportError into utils
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9727/ :
Adam Litke has uploaded a new change for review.
Change subject: Live Merge: Explicitly save block job info
..
Live Merge: Explicitly save block job info
When we removed _blockJobs from the VM.status() it had the unfortunate
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9729/ : SUCCESS
Adam Litke has posted comments on this change.
Change subject: Live Merge: Explicitly save block job info
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/29358
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Live Merge: improve log messages
..
Patch Set 1: Code-Review+1
(1 comment)
seems a nice improvement.
http://gerrit.ovirt.org/#/c/29310/1/vdsm/virt/vm.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Live Merge: Explicitly save block job info
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9730/ :
Francesco Romani has posted comments on this change.
Change subject: janitorial: move Vm._reportError into utils
..
Patch Set 3: Verified+1
fixed 'self' (not needed anymore). Verified the error path using vdsClient and
the
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
..
Patch Set 8:
Instead of passing address couldn't we just use
socket.getsockname()
To get the address\port associated with
Francesco Romani has posted comments on this change.
Change subject: sampling: allow window=1 in AdvancedStatsFunction
..
Patch Set 8: Verified+1
verified with the unit tests; being a new API, can't break anything.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: allow window=1 in AdvancedStatsFunction
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9731/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: add an helper method to get Vm policy
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9732/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move VmStatsThread away from vm.py
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9733/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add direct import of advancedstats helpers
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9734/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: verifyingTransport testing
..
Patch Set 7: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28858/7/tests/sslTests.py
File tests/sslTests.py:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: extend image over jsonrpc
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9735/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 23: Verified+1
Verified on a patched VDSM doing a few migrations back and forth.
--
To
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 22:
verified on a patched VDSM doing a few migraiton back and forth.
Tested: 25976, 25977,
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 22: Verified+1
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 23:
Tested: 25976, 25977, 25978, 26279
--
To view, visit http://gerrit.ovirt.org/25977
To
Francesco Romani has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 25:
Verified doing a few migration back and forth.
Tested-With: 25976, 25977, 25978, 26279
--
Francesco Romani has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 25: Verified+1
--
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/26279
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 14:
Verified by doing a few migrations back and forth
Tested-With: 25976, 25977, 25978, 26279
Francesco Romani has posted comments on this change.
Change subject: virt: migration: simplify the remote port handling
..
Patch Set 3: Verified+1
Verified by doing some migrations.
Note that the default configuration was not
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9737/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 25:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9736/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9739/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: rename helper function
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9738/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: simplify the remote port handling
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9740/
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 22: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/25976/22/vdsm/virt/migration.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Extract the DOM to Drive name, alias and path logic to reusable
method
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29059
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Extract the DOM to Drive name, alias and path logic to reusable
method
..
Extract the DOM to Drive name, alias and path logic to reusable method
Dan Kenigsberg has posted comments on this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28713
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extract the DOM to Drive name, alias and path logic to reusable
method
..
Patch Set 3:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: vm: extract a method to wait for migration
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28509/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Nir Soffer has posted comments on this change.
Change subject: vdsm: verifyingTransport testing
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/28858/7/tests/sslTests.py
File tests/sslTests.py:
Line 28: import
Dan Kenigsberg has posted comments on this change.
Change subject: vm: janitorial: detect if dom is running
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28510
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: janitorial: detect if dom is running
..
vm: janitorial: detect if dom is running
this patch extracts a little helper method
to detect if the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: janitorial: detect if dom is running
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1542/ :
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File
1 - 100 of 107 matches
Mail list logo
