Yeela Kaplan has posted comments on this change.
Change subject: spec: Remove non-existing requirement
..
Patch Set 1:
Please stop with the propaganda against ioprocess and abandon this unnecessary
patch.
There are no
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
..
Patch Set 2:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: mounts: Optimize mount loop device resolution
..
Patch Set 6: Code-Review-1
(9 comments)
Can be simplified and made more robust.
I already did profiling on
Dan Kenigsberg has submitted this change and it was merged.
Change subject: domainMonitor: Fix unsafe iteration
..
domainMonitor: Fix unsafe iteration
Using dict.iteritems() is safe only if nobody else can modify the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Fix unsafe iteration
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1555/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 3:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 3:
Please reply the comments on patchset 2:
Martin Sivák has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/29504/2//COMMIT_MSG
Commit
Nir Soffer has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29504
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 8:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9896/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 4:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
Michal Skrivanek has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 5:
(1 comment)
a question inside
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9899/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Patch Set 12:
Build Failed
Liron Aravot has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/28465
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 11:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9902/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9903/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 9:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9905/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 5:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 12: Code-Review-1
(3 comments)
Current check will hide bad objects in
Antoni Segura Puimedon has posted comments on this change.
Change subject: eliminate sampling.BaseSample
..
Patch Set 2: Code-Review+1
Much clearer now. Thanks!
--
To view, visit http://gerrit.ovirt.org/29471
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/28712/12//COMMIT_MSG
Michal Skrivanek has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 5: Code-Review-1
for visibility. please change to regular warn or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9907/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9908/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: HostStats: stop storing list of host ifids and speeds
..
Patch Set 2: Code-Review+1
(1 comment)
Antoni Segura Puimedon has posted comments on this change.
Change subject: introduce connectivity log
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29472
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Patch Set 13:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 12:
Build Failed
Federico Simoncelli has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28465
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 9:
Let's get this merged soon.
--
To view, visit http://gerrit.ovirt.org/28465
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: move reconfigure logic from %postun to %post
..
Patch Set 1:
saw another problem here:
Installing : 1:libguestfs-tools-c-1.20.11-2.el6.x86_64
Martin Sivák has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/28712/8/vdsm/virt/vm.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9911/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9912/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: threadpool: add a thread pool with watchdog
..
Patch Set 8:
(5 comments)
Added the missing answer. Will amend the docs do describe how this code is
Martin Sivák has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 12:
(4 comments)
http://gerrit.ovirt.org/#/c/28712/12//COMMIT_MSG
Michal Skrivanek has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29504
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9913/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 10:
Build Successful
Michal Skrivanek has posted comments on this change.
Change subject: threadpool: add a thread pool with watchdog
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/29191/8/lib/threadpool/worker.py
File
Michal Skrivanek has posted comments on this change.
Change subject: threadpool: add a thread pool with watchdog
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/29191/8/lib/threadpool/worker.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9915/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 6:
Build Failed
Michal Skrivanek has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 13: Code-Review+1
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9917/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9918/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: threadpool: docs: add design notes
..
Patch Set 4:
(5 comments)
Thanks for your comments. Will expand these docs.
Nir Soffer has posted comments on this change.
Change subject: threadpool: add a thread pool with watchdog
..
Patch Set 8:
(3 comments)
http://gerrit.ovirt.org/#/c/29191/8/lib/threadpool/worker.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Patch Set 14:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 13:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9921/ :
Michal Skrivanek has posted comments on this change.
Change subject: threadpool: add a thread pool with watchdog
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/29191/8/lib/threadpool/worker.py
File
Nir Soffer has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28712
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9922/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9923/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9924/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 10: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29115/10/vdsm/rpc/BindingXMLRPC.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9925/ :
Nir Soffer has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/29498/6/vdsm/rpc/vdsmapi-schema.json
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: GET requests - use Range header
..
core: GET requests - use Range header
This patch replaces the use of the custom Size header with use of http
Dan Kenigsberg has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 10: Verified+1 Code-Review+2
Simple rebase, copying score.
--
To view, visit http://gerrit.ovirt.org/28465
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1556/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: threadpool: add a thread pool with watchdog
..
Patch Set 8:
(3 comments)
http://gerrit.ovirt.org/#/c/29191/8/lib/threadpool/worker.py
File
Martin Sivák has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/29498/6/vdsm/rpc/vdsmapi-schema.json
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 11:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9927/ :
Francesco Romani has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 11: Code-Review+1
Thanks, I agree with Nir (comments in patch v11) and this looks nicer
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 7:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 7:
Build Successful
Dan Kenigsberg has submitted this change and it was merged.
Change subject: domainMonitor: Fix unsafe iteration of domain monitor status
..
domainMonitor: Fix unsafe iteration of domain monitor status
When we generate repoStat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Fix unsafe iteration of domain monitor status
..
Patch Set 2:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the API definition for cpu tune methods
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9931/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9930/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Patch Set 15:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9933/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9935/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 14:
Build Failed
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: upgrade: fix seal persistence for oVirt node
..
upgrade: fix seal persistence for oVirt node
The oVirt node filesystem is not persistent by default.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: fix seal persistence for oVirt node
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9936/ :
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29546
to review the following change.
Change subject: ipwrapper: do not report devices that disappear
..
ipwrapper: do not
Nir Soffer has posted comments on this change.
Change subject: threadpool: docs: add design notes
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29190/4/lib/threadpool/README.rst
File lib/threadpool/README.rst:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: eliminate sampling.BaseSample
..
Patch Set 2: Verified+1 Code-Review+2
Verified with entire topic branch
--
To view, visit http://gerrit.ovirt.org/29471
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: HostStats: recalculate total line rate every time
..
HostStats: recalculate total line rate every time
This should have been done when we started
Dan Kenigsberg has posted comments on this change.
Change subject: HostStats: recalculate total line rate every time
..
Patch Set 1: Verified+1 Code-Review+2
Verified with entire topic branch
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: eliminate sampling.BaseSample
..
eliminate sampling.BaseSample
For quite some time, BaseSample is not a common base class of anything.
It serves no
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 2: Code-Review-1
(2 comments)
The module name could be jut xml since inside it would have Domain
Dan Kenigsberg has posted comments on this change.
Change subject: HostStats: stop storing list of host ifids and speeds
..
Patch Set 2: Verified+1 Code-Review+2
(1 comment)
verified with the entire topic branch
Dan Kenigsberg has submitted this change and it was merged.
Change subject: HostStats: stop storing list of host ifids and speeds
..
HostStats: stop storing list of host ifids and speeds
Current code keeps an almost-up-to-date
Dan Kenigsberg has posted comments on this change.
Change subject: introduce connectivity log
..
Patch Set 2: Code-Review+2
connectivity.log file is created, with no noticeable effects to vdsm behavior.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: introduce connectivity log
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/29472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: introduce connectivity log
..
introduce connectivity log
Users have been requesting to have access to a simple log file that
tracks host connectivity.
Martin Sivák has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/29115/10/vdsm/rpc/BindingXMLRPC.py
File
Francesco Romani has posted comments on this change.
Change subject: threadpool: docs: add design notes
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29190/4/lib/threadpool/README.rst
File lib/threadpool/README.rst:
Francesco Romani has posted comments on this change.
Change subject: threadpool: docs: add design notes
..
Patch Set 4:
patch set 5: added specific notes for VDSM.
--
To view, visit http://gerrit.ovirt.org/29190
To
Francesco Romani has posted comments on this change.
Change subject: threadpool: add a thread pool with watchdog
..
Patch Set 8:
patch set 9: rebased due to changes in parent patch.
--
To view, visit
1 - 100 of 183 matches
Mail list logo
