Francesco Romani has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 24: Code-Review+1
good enough for me.
--
To view, visit http://gerrit.ovirt.org/28715
To
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 23:
Inline comments in patchset 22
--
To view, visit http://gerrit.ovirt.org/28714
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 21: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28896
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29652
To unsubscribe, visit
On Wed, Jul 09, 2014 at 08:54:32PM +0100, Jenkins ci oVirt Server wrote:
Project:
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/
Build:
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/1597/
Build Number: 1597
Build Status: Failure
Darshan N has restored this change.
Change subject: gluster: geo replication status and status detail
..
Restored
--
To view, visit http://gerrit.ovirt.org/18414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: net: skip network restoration if its physical devs are missing
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29313
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: skip network restoration if its physical devs are missing
..
net: skip network restoration if its physical devs are missing
When performing
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: replace minidom.Element for memory snapshots
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10122/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move __hacked_writexml in the vmxml module
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10123/ :
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/25976/22/vdsm/virt/migration.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net: skip network restoration if its physical devs are missing
..
Patch Set 5:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move _DomXML into the xml module
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10124/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: xml: add function to iterate over devices
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10125/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: use vmxml.Element in snapshot method
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10126/ : SUCCESS
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29832
to review the following change.
Change subject: net: skip network restoration if its physical devs are missing
..
net:
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 23: Verified+1
copied verification score
--
To view, visit http://gerrit.ovirt.org/25976
To
Francesco Romani has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 15: Verified+1
score lost to not-trivial rebase. Copied.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: use vmxml.Element in setLinkAndNetwork
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10128/ :
On 07/10, Dan Kenigsberg wrote:
On Wed, Jul 09, 2014 at 08:54:32PM +0100, Jenkins ci oVirt Server wrote:
Project:
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/
Build:
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/1597/
Build
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 26:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10129/ :
On 07/10, Antoni Segura Puimedon wrote:
- Original Message -
From: Dan Kenigsberg dan...@redhat.com
To: dc...@redhat.com, ee...@redhat.com
Cc: vdsm-patches@lists.fedorahosted.org
Sent: Thursday, July 10, 2014 8:59:03 AM
Subject: Re: [oVirt Jenkins]
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 24:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: replace magic number
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10131/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: introduce a XML processing module
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10127/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10132/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: rename helper function
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10133/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: decouple monitoring from thread
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10134/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: simplify the remote port handling
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10135/
Antoni Segura Puimedon has posted comments on this change.
Change subject: upgrade: fix seal persistence for oVirt node
..
Patch Set 1: Verified+1
The involved code is the same as master (that was just verified). It is safe to
Michal Skrivanek has posted comments on this change.
Change subject: vm: detect migration completed on recovery
..
Patch Set 10: Code-Review-1
- the bug is pending on being public
- minor change in isDomainRunning
--
To
Martin Sivák has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 24: Verified+1
Still passes all my tests.
--
To view, visit http://gerrit.ovirt.org/28715
To
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 23: Verified+1
It still passes my tests, but I wonder if there is a better way to update the
vdsm caches here.
--
To view,
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 21: Verified+1
Still passes all my test scenarios and unit tests.
--
To view, visit http://gerrit.ovirt.org/28896
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: detect migration completed on recovery
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10136/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: misc: remove readfile function.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29758
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: misc: remove readfile function.
..
Patch Set 1: Verified-1
(1 comment)
http://gerrit.ovirt.org/#/c/29758/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: misc: remove readfile function.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29758/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 200:
Nir Soffer has uploaded a new change for review.
Change subject: mailbox: Log traceback after fatal failures in mailbox monitors
..
mailbox: Log traceback after fatal failures in mailbox monitors
Mailbox monitor threads were
Nir Soffer has uploaded a new change for review.
Change subject: mailbox: Remove fatal, uneeded, and racy check
..
mailbox: Remove fatal, uneeded, and racy check
After errors in _checkForMail, the error handling code check if
Nir Soffer has uploaded a new change for review.
Change subject: mailbox: Fix unsafe locking
..
mailbox: Fix unsafe locking
In setMaxHostID, both _inLock and _outLock are acquired and released in
an unsafe way, not ensuring
Nir Soffer has posted comments on this change.
Change subject: mailbox: Remove fatal, uneeded, and racy check
..
Patch Set 2:
Add bug url
--
To view, visit http://gerrit.ovirt.org/29854
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: mailbox: Log traceback after fatal failures in mailbox monitors
..
Patch Set 2:
Add related bug url.
--
To view, visit http://gerrit.ovirt.org/29853
To
Nir Soffer has posted comments on this change.
Change subject: mailbox: Fix unsafe locking
..
Patch Set 2:
Add related bug url.
--
To view, visit http://gerrit.ovirt.org/29855
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mailbox: Log traceback after fatal failures in mailbox monitors
..
Patch Set 1:
Build Successful
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 24: Verified+1
Additional lines covered by tests, the rest did not change.
--
To view, visit http://gerrit.ovirt.org/28714
To
Martin Sivák has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/28714/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3824:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mailbox: Remove fatal, uneeded, and racy check
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10139/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: Fix indentation violation
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10137/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mailbox: Fix unsafe locking
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10140/ : SUCCESS
Allon Mureinik has posted comments on this change.
Change subject: mailbox: Remove fatal, uneeded, and racy check
..
Patch Set 2: Code-Review+1
Using with instead of try-finally in checkForMail seems more elegant, but
that
On Thu, Jul 10, 2014 at 09:38:14AM +0200, David Caro wrote:
On 07/10, Dan Kenigsberg wrote:
On Wed, Jul 09, 2014 at 08:54:32PM +0100, Jenkins ci oVirt Server wrote:
Project:
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=centos7/
Build:
Oved Ourfali has posted comments on this change.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29861
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 24: Code-Review+1
(1 comment)
good enough for me.
http://gerrit.ovirt.org/#/c/28714/24/vdsm/virt/vm.py
File
Allon Mureinik has posted comments on this change.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29861
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: pep8: Fix indentation violation
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29826
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mailbox: Remove fatal, uneeded, and racy check
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10141/
Hello Nir Soffer, Antoni Segura Puimedon, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29875
to review the following change.
Change subject: misc: Cleaner readspeed
..
misc:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mailbox: Fix unsafe locking
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10142/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: vdsm: check attribute not object type
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29874
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mailbox: Log traceback after fatal failures in mailbox monitors
..
Patch Set 2:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 18:
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8: Fix indentation violation
..
pep8: Fix indentation violation
Change-Id: I030a2635e4d0923eb5127dd74bc60c98954a8d49
Signed-off-by: Nir Soffer
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: Fix indentation violation
..
Patch Set 2: Code-Review+2
It's quite odd that I did not see this last night.
--
To view, visit
Dan Kenigsberg has abandoned this change.
Change subject: pep8: continuation line indentation is not a multiple of four
..
Abandoned
Thanks a lot, and sorry for the noise.
This has already been merged with
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 14:
Build Successful
Dima Kuznetsov has posted comments on this change.
Change subject: upgrade: fix seal persistence for oVirt node
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29822
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
..
vdsm: Missing hostId parameter on reconstructMaster verb
Json schema was not consistent
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
..
Patch Set 1: Code-Review+2
raising score
--
To view, visit http://gerrit.ovirt.org/29861
To
Dan Kenigsberg has posted comments on this change.
Change subject: mailbox: Log traceback after fatal failures in mailbox monitors
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29853
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10146/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: check attribute not object type
..
vdsm: check attribute not object type
Checking existance attribute is more flexible than checking object
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: check attribute not object type
..
Patch Set 1: Code-Review+2
Yep, that's more Pythonic.
--
To view, visit http://gerrit.ovirt.org/29874
To
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Removal of management_ip info in getCaps
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29869
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 5: Code-Review+2
If Nir can live with a superfluous list creation, I suppose that so can I...
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: Fix indentation violation
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5588/ :
SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: Accept all stomp commands
..
jsonrpc: Accept all stomp commands
Protocol detector needs to accept all stomp commands. The connection can
be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: check attribute not object type
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5589/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5590/ :
SUCCESS
Allon Mureinik has posted comments on this change.
Change subject: mailbox: Fix unsafe locking
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29855
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: mailbox: Log traceback after fatal failures in mailbox monitors
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29853
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29881
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: test: fixing cif getinstance issue
..
Patch Set 1: Code-Review-1
Please abandon and re-post with the correct Change-Id of
Dan Kenigsberg has posted comments on this change.
Change subject: mailbox: Fix unsafe locking
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29855
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: misc: Cleaner readspeed
..
Patch Set 1:
Looks ok, but why do we need to backport it?
--
To view, visit http://gerrit.ovirt.org/29875
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10147/ : ABORTED
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Query interface for all VM fields
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10149/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: misc: Cleaner readspeed
..
Patch Set 1:
because we want to backport http://gerrit.ovirt.org/#/c/29758
--
To view, visit http://gerrit.ovirt.org/29875
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Query interface for all VM fields
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10150/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: continuation line indentation is not a multiple of four
..
Patch Set 1:
Build Successful
Francesco Romani has posted comments on this change.
Change subject: schedule: Introduce scheduling libary
..
Patch Set 4:
(4 comments)
This could be an useful building block, but I have a couple of initial
concerns, one
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Missing hostId parameter on reconstructMaster verb
..
Patch Set 2:
Build Successful
On Thu, Jul 10, 2014 at 11:51:15AM +0100, Jenkins ci oVirt Server wrote:
Project:
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=fedora19/
Build:
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/label=fedora19/1606/
Build Number: 1606
Build Status: Failure
Nir Soffer has posted comments on this change.
Change subject: schedule: Introduce scheduling libary
..
Patch Set 4:
(4 comments)
Francesco, see my response in the inline comment.
Francesco Romani has posted comments on this change.
Change subject: schedule: Introduce scheduling libary
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/29607/4/lib/vdsm/schedule.py
File lib/vdsm/schedule.py:
Line
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: upgrade: fix seal persistence for oVirt node
..
upgrade: fix seal persistence for oVirt node
The oVirt node filesystem is not persistent by default.
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: extend image over jsonrpc
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29857
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm: extend image over jsonrpc
..
vdsm: extend image over jsonrpc
Schema file was not consistend with API.py. All the verbs should use
the same
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm: Removal of management_ip info in getCaps
..
vdsm: Removal of management_ip info in getCaps
'management_ip' property containing ip of vdsm
was
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: fix seal persistence for oVirt node
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/21/ : SUCCESS
1 - 100 of 145 matches
Mail list logo
