Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 6:
(4 comments)
http://gerrit.ovirt.org/#/c/31700/6/vdsm/rpc/vdsmapi-schema.json
File
Francesco Romani has uploaded a new change for review.
Change subject: test: fix typos and repair vmTests
..
test: fix typos and repair vmTests
A couple of errors sneaked into master after commit 2ec1f8e7cb8c
likely because
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 11:
Build Failed
Allon Mureinik has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32964/1/vdsm/rpc/Bridge.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 7: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 12:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11548/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11549/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 13:
Build Failed
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32964
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11552/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11551/ : SUCCESS
Eli Mesika has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 3: -Verified
(1 comment)
http://gerrit.ovirt.org/#/c/32695/3/vdsm/API.py
File vdsm/API.py:
Line 1253:
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 2:
test failures doesn't seem relevant.
--
To view, visit http://gerrit.ovirt.org/32964
To
Allon Mureinik has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32964
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tests: Use more clear name
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: tests: Use more clear name
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32726
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Use more clear name
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32726
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32928/1/vdsm.spec.in
File vdsm.spec.in:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Use more clear name
..
tests: Use more clear name
false_mock is misterious name, specially when used as false_mock=False.
Reading the code
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Use more clear name
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1855/ : SUCCESS
Allon Mureinik has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images
..
Patch Set 2:
Nir, can you verify?
--
To view, visit http://gerrit.ovirt.org/32836
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 2:
Build Failed
Martin Polednik has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 8: Code-Review-1
(5 comments)
-1 for visibility, other than the minor things it seems to be OK (+
Martin Peřina has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/32695/3/vdsm/API.py
File vdsm/API.py:
Line 1253:
Dan Kenigsberg has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32965
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/32695/3/vdsm/API.py
File vdsm/API.py:
Line 1253:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11554/ : FAILURE
Martin Peřina has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 8: Code-Review-1
(3 comments)
minor nit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphdev: fix device hooks post migration
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27933
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: graphdev: fix device hooks post migration
..
vm: graphdev: fix device hooks post migration
the _deviceXML attribute was not regenerated on
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: graphdev: fix device hooks post migration
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1856/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31697
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: vm: add unit tests for setBalloonTarget
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29390
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: vm: add unit tests for setBalloonTarget
..
tests: vm: add unit tests for setBalloonTarget
Change-Id: I97d4667204560a372d10ab3ed0aa69b3407e671a
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: declass warning for unsupported pause code
..
vm: declass warning for unsupported pause code
When VDSM starts, it resyncs the VM state with
Dan Kenigsberg has posted comments on this change.
Change subject: vm: declass warning for unsupported pause code
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32154
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: vm: add unit tests for setBalloonTarget
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1857/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: declass warning for unsupported pause code
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1858/ :
Nir Soffer has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py
File tests/vmTests.py:
Line 1311:
Nir Soffer has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py
File tests/vmTests.py:
Line 1342:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: introduce hostdev module
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/355/ :
SUCCESS
Francesco Romani has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py
File tests/vmTests.py:
Line 1311:
Dan Kenigsberg has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32928/2/vdsm/virt/libvirt-hook.sh
Dan Kenigsberg has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 3: Code-Review-1
oops, another rebase is required
--
To view, visit http://gerrit.ovirt.org/31697
To
Saggi Mizrahi has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32964
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
jsonrpc: wrong usage of optional arguments in ctor
When ctor arguments are marked as optional in
Oved Ourfali has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32980
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1: Verified+1
ticking Verified because
- with this patch all the tests pass again
- 'make rpm' completes
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1859/ :
Francesco Romani has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 9: Code-Review+1
good for me. Not enterely sure about the versioning, but I believe this is
minor. Let's go
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: introduce hostdev module
..
Patch Set 8: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/32313/8/vdsm/hostdev.py
File vdsm/hostdev.py:
Line 69:
Martin Polednik has posted comments on this change.
Change subject: vdsm: introduce hostdev module
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/32313/8/vdsm/hostdev.py
File vdsm/hostdev.py:
Line 69:
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/32980/1/vdsm/rpc/Bridge.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: sslerror during accept should be logged on warning
..
Patch Set 1:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: sslerror during accept should be logged on warning
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32985/1/vdsm/protocoldetector.py
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
jsonrpc: wrong usage of optional arguments in ctor
When ctor arguments are marked as optional in
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: wrong usage of optional arguments in ctor
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32980
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/32965/1/tests/vmTests.py
File tests/vmTests.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: sslerror during accept should be logged on warning
..
Patch Set 2:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: sslerror during accept should be logged on warning
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32985
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32965
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: test: fix typos and repair vmTests
..
test: fix typos and repair vmTests
A couple of errors sneaked into master after commit 2ec1f8e7cb8c
likely
Dan Kenigsberg has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32965
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: test: fix typos and repair vmTests
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1860/ : SUCCESS
Yoav Kleinberger has uploaded a new change for review.
Change subject: tests: added NFS support to functional tests
..
tests: added NFS support to functional tests
In this patch, I introduce a new NFS storage context for the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: added NFS support to functional tests
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 3:
Build Failed
mooli tayer has uploaded a new change for review.
Change subject: vdsm-tool: always define log_outputs in libvirt's conf.
..
vdsm-tool: always define log_outputs in libvirt's conf.
According to [1] libvirt will use for logging:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: always define log_outputs in libvirt's conf.
..
Patch Set 1:
Build Successful
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: always define log_outputs in libvirt's conf.
..
Patch Set 1: Code-Review+1
(1 comment)
Verified on fedora 19 and an el7 where
mooli tayer has posted comments on this change.
Change subject: vdsm-tool: always define log_outputs in libvirt's conf.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/32991/1//COMMIT_MSG
Commit Message:
Line 17: [1]
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: always define log_outputs in libvirt's conf.
..
Patch Set 2:
Build Successful
Martin Sivák has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32928/2/vdsm/virt/libvirt-hook.sh
File
Francesco Romani has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 3:
I succesfully did migration with this hook[1]
- two centos 7 hosts using
Francesco Romani has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 4: Verified+1
the rebase wasn't automated but still pretty simple, thus copied score
--
To view,
Francesco Romani has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 4:
forgot to add: re-did make rpm make check and passed OK.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: always log when guest CPU state changes
..
vm: always log when guest CPU state changes
In order to improve debuggability of VDSM,
add a log when
Dan Kenigsberg has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31697
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: always log when guest CPU state changes
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1861/ :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: always define log_outputs in libvirt's conf.
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32991/2//COMMIT_MSG
Commit
Dan Kenigsberg has posted comments on this change.
Change subject: Add a libvirt migration hook to filter out min_guarantee element
..
Patch Set 3: Code-Review-1
(2 comments)
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: sslerror during accept should be logged on warning
..
Patch Set 2: Code-Review-1
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: sslerror during accept should be logged on warning
..
Patch Set 2: -Code-Review
Seems that the review was too quick :-)
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Create qcow2 compat 0.10 images
..
Patch Set 2: Verified+1
Verified on mixed cluster with rhel7 and rhel6.5 hosts:
- create vm on rhel7
- verify that
Oved Ourfali has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit
88 matches
Mail list logo