Martin Peřina has posted comments on this change.
Change subject: fence: Fix description and JSONRPC marshalling for fenceNode API
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/33156
To unsubscribe,
Hello Piotr Kliczewski, Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33156
to review the following change.
Change subject: fence: Fix description and JSONRPC marshalling for fenceNode API
Oved Ourfali has posted comments on this change.
Change subject: fence: Fix description and JSONRPC marshalling for fenceNode API
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33156
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Cleanup logging
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32505
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: storage.monitor: Streamline names
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32507
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: storage.monitor: Use lowercase module name
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32506
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: fileSD: Move private constant near the only call site
..
Patch Set 1: Code-Review-1
Every time you use a (private) constant you would have to check if it
Yaniv Bronhaim has posted comments on this change.
Change subject: fence: Fix description and JSONRPC marshalling for fenceNode API
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33156
To unsubscribe,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: fence: Fix description and JSONRPC marshalling for fenceNode API
..
fence: Fix description and JSONRPC marshalling for fenceNode API
1) Fixes
Nir Soffer has posted comments on this change.
Change subject: fileSD: Move private constant near the only call site
..
Patch Set 1:
When we add the second use, we can move the constant up - for now this is the
best location.
Hello Nir Soffer, Saggi Mizrahi, mooli tayer, Dima Kuznetsov, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33163
to review the following change.
Change subject: oop: Use Storage.oop logger
Yeela Kaplan has posted comments on this change.
Change subject: oop: Use Storage.oop logger
..
Patch Set 1: Verified+1
Same as upstream.
build is ok.
--
To view, visit http://gerrit.ovirt.org/33163
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fence: Fix description and JSONRPC marshalling for fenceNode API
..
Patch Set 2:
Build Failed
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: [WIP] change qosOutbound for a nested 'hostQoS':{'out':
bandwidth_params}
..
[WIP] change qosOutbound for a nested 'hostQoS':{'out': bandwidth_params}
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] change qosOutbound for a nested 'hostQoS':{'out':
bandwidth_params}
..
Patch Set 1:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] change qosOutbound for a nested 'hostQoS':{'out':
bandwidth_params}
..
Patch Set 2:
Build Successful
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Conflict with firewalld and NetworkManager and use iptables
..
Conflict with firewalld and NetworkManager and use iptables
As shown in the bug, we do
Yaniv Bronhaim has posted comments on this change.
Change subject: oop: Use Storage.oop logger
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33163
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: oop: Use Storage.oop logger
..
oop: Use Storage.oop logger
Use storage logger to avoid oop logs in /var/log/messages.
Storage logger is configured to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 14:
Build Failed
Liron Aravot has uploaded a new change for review.
Change subject: vm: return diskMapping on status()
..
vm: return diskMapping on status()
status() is used by API.Global.getVMList and should return also the disk
mapping
Liron Aravot has uploaded a new change for review.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
vm, guestagent: return hash should include also the disk mapping
Change-Id:
Martin Sivák has abandoned this change.
Change subject: Extract the DOM to Drive name, alias and path logic to reusable
method
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30066
To
Martin Sivák has abandoned this change.
Change subject: tests: make api check support falsey values
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30067
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Fix the API definition for cpu tune methods
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30068
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Improve the _validateIoTuneParams so the params are passed as
argument
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30069
To
Martin Sivák has abandoned this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30175
To
Martin Sivák has abandoned this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30070
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: janitorial: move isVdsmImage into utils
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30099
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: vm: fix getVmPolicy return type.
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30072
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Refactor XMLElement to virt.utils
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30071
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30074
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Change method names in vmtune.py to the PEP8 style
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30078
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Add API.VM.setIoTune
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30076
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Sivák has abandoned this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30075
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Remove noisy log message from CPU metadata collector
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30079
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Support ioTune values 2^31 in getStats over xml-rpc
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30233
To unsubscribe, visit
Martin Sivák has abandoned this change.
Change subject: Add API.VM.getIoTunePolicy
..
Abandoned
Won't make it into 3.5.
--
To view, visit http://gerrit.ovirt.org/30077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Tal Nisan has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 3:
Rerun-Hooks: run
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: Use Storage.oop logger
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/170/ : SUCCESS
Tal Nisan has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11597/ : SUCCESS
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/31701
To unsubscribe,
Lior Vernia has posted comments on this change.
Change subject: [WIP] change qosOutbound for a nested 'hostQoS':{'out':
bandwidth_params}
..
Patch Set 2: Code-Review+1
Ack, will implement serialization/deserialization
Liron Aravot has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/33197
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/33198
To unsubscribe,
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 9:
(4 comments)
http://gerrit.ovirt.org/#/c/30909/9//COMMIT_MSG
Commit Message:
Line 11:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 10:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Revert 'Create default multipath.conf during install'
..
Patch Set 9:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Add logs to rotateFiles
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11600/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Use ovirt node for persist and unpersist files
..
Patch Set 4:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11602/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: change qosOutbound for a nested 'hostQoS':{'out':
bandwidth_params}
..
Patch Set 3:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 5: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/32695/5/vdsm/API.py
File vdsm/API.py:
Line 1234:
Federico Simoncelli has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 14: Code-Review+2
Same as patch set 13.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 10: Code-Review+2
Same as patch set 9.
--
To view, visit http://gerrit.ovirt.org/31700
To unsubscribe,
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm: return diskMapping on status()
..
vm: return diskMapping on status()
status() is used by API.Global.getVMList and should return also the disk
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
vm, guestagent: return hash should include also the disk mapping
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1878/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
Patch Set 15:
Build Failed
Eli Mesika has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/32695/5/vdsm/API.py
File vdsm/API.py:
Line 1234:
Eli Mesika has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11604/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 6: Code-Review-1
We are way past feature freeze. 3.5.0 is very much delayed already. We should
not take this
Ondřej Svoboda has uploaded a new change for review.
Change subject: utils: Move namedTemporaryDir here from testlib
..
utils: Move namedTemporaryDir here from testlib
To be used in subsequent work.
Change-Id:
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: Stop NetworkManager from ifup'ing our reference bond
..
netinfo: Stop NetworkManager from ifup'ing our reference bond
This is hopefully only a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Error out if we failed to change a bond's mode
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Move namedTemporaryDir here from testlib
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11606/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Stop NetworkManager from ifup'ing our reference bond
..
Patch Set 1:
Build Failed
Martin Peřina has posted comments on this change.
Change subject: vdsm: making PM 'on' and 'off' sync
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit
73 matches
Mail list logo
