Francesco Romani has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 2: Code-Review+1
(1 comment)
Nice! Added a minor comment for a possible improvement.
Francesco Romani has posted comments on this change.
Change subject: qemuimg: Memoize _supports_qcow2_compat
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34711
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/34710/2//COMMIT_MSG
Commit
Francesco Romani has posted comments on this change.
Change subject: vm: sync device update during creation of a vm
..
Patch Set 2:
We have quite some things mixed here.
Most likely (but not 100% sure) this hasn't happened
Darshan N has uploaded a new change for review.
Change subject: gluster: volume snapshot config set and get verbs.
..
gluster: volume snapshot config set and get verbs.
This patch adds two new verbs to get and set the
Liron Aravot has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34636
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13328/ : FAILURE
Michal Skrivanek has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47.
..
Patch Set 6:
@eedri: the package is already in released 6.6.z.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot config set and get verbs.
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13329/ :
Martin Polednik has posted comments on this change.
Change subject: virt: move vm.GraphicsDevice - vmdevices.Graphics
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34557/1/vdsm/virt/vmdevices.py
File
Martin Polednik has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 1: Code-Review+1
After quick look and running the tests seems to be running, hopefully nothing
Dan Kenigsberg has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 2: Code-Review+2
Right - 4.16.z did not really have this feature until now.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: fix guest disk mapping versioning
..
schema: fix guest disk mapping versioning
The guest disk mapping report feature is being merged to the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47.
..
Patch Set 6:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 8: Code-Review-1
please add links to the patches in master branch
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4156/ : FAILURE
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm: return diskMapping on status()
..
vm: return diskMapping on status()
status() is used by API.Global.getVMList and should return also the disk
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vm, guestagent: return hash should include also the disk mapping
..
vm, guestagent: return hash should include also the disk mapping
Change-Id:
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 10: Code-Review+2
next time remember the links. i added them for you
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 16:
(7 comments)
http://gerrit.ovirt.org/#/c/33309/16/tests/v2vTests.py
File tests/v2vTests.py:
Line 82:
Shahar Havivi has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 14: Verified-1
do not review
--
To view, visit http://gerrit.ovirt.org/34294
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: return diskMapping on status()
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/70/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: External hypervisor VMs integration
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13331/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Convert VM from external source to Data Domain
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13332/ :
Martin Polednik has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25820
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: fix guest disk mapping versioning
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/148/
Saggi Mizrahi has posted comments on this change.
Change subject: storageServer: remove dead code from getSessionInfo
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34537
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: libnl: drop libnl-1 dependency
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34677
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: libnl: make link cache optional for link_info and addr_info
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/32949/5//COMMIT_MSG
Commit Message:
Line
Francesco Romani has abandoned this change.
Change subject: vm: reorder device normalization
..
Abandoned
wrong approach
--
To view, visit http://gerrit.ovirt.org/34664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has abandoned this change.
Change subject: vm: split storage part from device normalization
..
Abandoned
wrong approach
--
To view, visit http://gerrit.ovirt.org/34666
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: WIP: vm: rationalize device setup
..
Abandoned
wrong approach
--
To view, visit http://gerrit.ovirt.org/34667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has abandoned this change.
Change subject: vm: rename buildConfDevices
..
Abandoned
wrong approach
--
To view, visit http://gerrit.ovirt.org/34665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Francesco Romani has uploaded a new change for review.
Change subject: vm: split slow disk access from normalization
..
vm: split slow disk access from normalization
split utp potentially slow disk access from fast
disk
Francesco Romani has uploaded a new change for review.
Change subject: vm: move device setup into __init__
..
vm: move device setup into __init__
Device hierarchy should never change except fot hotplug/hotunplug.
Besides
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: split slow disk access from normalization
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13334/ : FAILURE
Yeela Kaplan has posted comments on this change.
Change subject: utils: change persistFile to persist
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34073
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/31583
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: utils: Use ovirt node for persist files
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/33468
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: utils: add unpersist for symmetry
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34074
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: Use utils.persist instead of importing ovirt-node Config
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34075
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: misc: use utils.persist/unpersist instead of execcmd
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34076
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: utils: change persistFile to persist
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34073/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-10-12
Yeela Kaplan has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 7:
Verified by:
Installing an ovirt-node vm from iso.
transferred changed files in patches to the node.
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31583
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Move functionality from storage.misc
..
utils: Move functionality from storage.misc
move persistFile into utils
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo:nicSpeed(): fix nicSpeed condition
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13312/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13315/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13325/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Move functionality from storage.misc
..
Patch Set 8:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 5:
Build Failed
Saggi Mizrahi has posted comments on this change.
Change subject: oop: Use a single instance of IOProcess per SD
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31501
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: tests: add unit tests for IOProcess per SD
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: tests: add unit tests for IOProcess per SD
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34578
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 2: Code-Review-1
(1 comment)
Please add: doc/infra/cache.rst
And make the content:
Cache
Dan Kenigsberg has submitted this change and it was merged.
Change subject: oop: Use a single instance of IOProcess per SD
..
oop: Use a single instance of IOProcess per SD
Next step after switching from RFH to IOPROC is to
Dan Kenigsberg has posted comments on this change.
Change subject: ioprocess: Have tests check ioprocess and not RFH
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34083
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ioprocess: Have tests check ioprocess and not RFH
..
ioprocess: Have tests check ioprocess and not RFH
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: add unit tests for IOProcess per SD
..
tests: add unit tests for IOProcess per SD
Change-Id: I904a33e45ad935856517b70f6bd3e6e5d56ca187
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 6:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 7: Code-Review-1
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: Use a single instance of IOProcess per SD
..
Patch Set 10:
Build Failed
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 7:
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ioprocess: Have tests check ioprocess and not RFH
..
Patch Set 4:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 2:
I'll add documentation and improve the docstrings in next version.
Thanks for the quick review!
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: add unit tests for IOProcess per SD
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/152/
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 7: Verified+1
Tested on an EL6 host with the default (ifcfg)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hba: Parallel hba scanning
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13338/ : FAILURE
Yeela Kaplan has uploaded a new change for review.
Change subject: oop: fix tests
..
oop: fix tests
Change-Id: I9dfd7d2815d70566fc3a95760058e45e9dcfeab3
Signed-off-by: Yeela Kaplan ykap...@redhat.com
---
M
Yeela Kaplan has posted comments on this change.
Change subject: oop: fix tests
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Saggi Mizrahi has posted comments on this change.
Change subject: oop: fix tests
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit http://gerrit.ovirt.org/34765
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13340/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: fix tests
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13341/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: fix tests
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13342/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13343/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: split slow disk access from normalization
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13344/ :
Hello Douglas Schilling Landgraf, David Caro, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34766
to review the following change.
Change subject: Adding the possibility to skip checks on rpmbuild
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13339/ : ABORTED
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/34571/7/vdsm.spec.in
File
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 7:
(2 comments)
A note on predefined custom properties.
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 10: Verified+1
No functional change, but now the hook does not depend on
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34571
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
hooks: Add a hook to configure IPv6 networking through custom properties
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add a hook to configure IPv6 networking through custom
properties
..
Patch Set 11:
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: oop: fix tests
..
oop: fix tests
Change-Id: I9dfd7d2815d70566fc3a95760058e45e9dcfeab3
Signed-off-by: Yeela Kaplan ykap...@redhat.com
Reviewed-on:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: oop: fix tests
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/154/ :
FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Displays active slave for the bond in getVdsCaps
networkTests: test to check if active slave exists
..
Patch Set 2: Code-Review-1 Verified-1
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34768
to review the following change.
Change subject: caps: Report online logical CPUs
..
caps: Report online
Vitor de Lima has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34768
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storageServer: remove dead code from getSessionInfo
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13349/
Dan Kenigsberg has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34766
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13350/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: Memoize _supports_qcow2_compat
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13351/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13352/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Mark netowrk test as broken
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13353/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 3: Verified+1
Version 3 changes:
- Add documentation to doc/cache.rst - should move to infra/cache.rst
Nir Soffer has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 4: Verified+1
Version 4 refine cache module documentation so it looks better in sphinx output.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13354/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13356/ :
1 - 100 of 109 matches
Mail list logo