Change in vdsm[ovirt-3.5]: virt: Fix limit when calculating next volume size

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38088 To unsubscribe, visit http://

Change in vdsm[ovirt-3.5]: virt: Check if a drive is chuhked before extending

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38087 To unsubscribe, visit http:/

Change in vdsm[ovirt-3.5]: virt: Add Drive.chunked property

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38086 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: InterfaceSampleTests are failing with IOError .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16034/ : To av

Change in vdsm[master]: gluster: add createBrick verb

2015-02-23 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 22: (2 comments) http://gerrit.ovirt.org/#/c/35498/22/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Lin

Change in vdsm[master]: api: pass parameters to IpConfig as positional

2015-02-23 Thread osvoboda
Ondřej Svoboda has abandoned this change. Change subject: api: pass parameters to IpConfig as positional .. Abandoned Superseded by a different approach. -- To view, visit http://gerrit.ovirt.org/37787 To unsubscribe, visit h

Change in vdsm[master]: models: move IpConfig's members to NetDevice

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: move IpConfig's members to NetDevice .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16033/ : SUCCESS http

Change in vdsm[master]: ifcfg: make _getIfaceConfValues pass ipv4, ipv6 to _createCo...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: make _getIfaceConfValues pass ipv4, ipv6 to _createConfFile .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit

Change in vdsm[master]: models: move dynamic IP configuration parameters to IPv4 and...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: move dynamic IP configuration parameters to IPv4 and IPv6 .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/

Change in vdsm[master]: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16030/ : SU

Change in vdsm[master]: models: move IpConfig's members to NetDevice

2015-02-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: models: move IpConfig's members to NetDevice .. models: move IpConfig's members to NetDevice Change-Id: I30ce76e1b9f32f1f35fe5927ed6b1215f911ff89 Signed-off-by

Change in vdsm[master]: ifcfg: make _getIfaceConfValues pass ipv4, ipv6 to _createCo...

2015-02-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: ifcfg: make _getIfaceConfValues pass ipv4, ipv6 to _createConfFile .. ifcfg: make _getIfaceConfValues pass ipv4, ipv6 to _createConfFile Change-Id: I519641cb7

Change in vdsm[master]: misc: Support zero-time in getReadDelay()

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/38082/1//COMMIT_MSG Commit Message: Line 6: Line 7: misc: Suppo

Change in vdsm[master]: misc: Support zero-time in getReadDelay()

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/38082/1//COMMIT_MSG Commit Message: Line 6: Line 7: misc: Suppo

Change in vdsm[master]: misc: Support zero-time in getReadDelay()

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/38082/1//COMMIT_MSG Commit Message: Line 6: L

Change in vdsm[master]: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16029/ : SU

Change in vdsm[master]: models: move dynamic IP configuration parameters to IPv4 and...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: move dynamic IP configuration parameters to IPv4 and IPv6 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/

Change in vdsm[master]: models: move dynamic IP configuration parameters to IPv4 and...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: move dynamic IP configuration parameters to IPv4 and IPv6 .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job

Change in vdsm[master]: tests: Use permutations for separating test failures

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Use permutations for separating test failures .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_mer

Change in vdsm[master]: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments

2015-02-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments .. ifcfg: use _to_ifcfg_bool to shorten yes/no assignments Change-Id: I1af641e5c2a8a5b80b3cd74e89e32459

Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_m

Change in vdsm[master]: network: order 'ipv4' before 'ipv6' and rename 'blocking' to...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: order 'ipv4' before 'ipv6' and rename 'blocking' to 'blockingdhcp' .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pe

Change in vdsm[master]: tests: Use permutations for separating test failures

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Use permutations for separating test failures .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/38031 To unsubscribe, visit http:/

Change in vdsm[master]: tests: Use permutations for separating test failures

2015-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Use permutations for separating test failures .. tests: Use permutations for separating test failures Change-Id: I7cacc89f9a8ddfef56b3c27234acb0

Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test .. Patch Set 3: Code-Review+2 /me is not sure that the new form is considerably more readable, but I'm t

Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

2015-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test .. tests: Enhance ReadSpeed.testReadSpeedRegExp unit test Test changed to be more readable. Cur

Change in vdsm[master]: models: remove IpConfig's namedtuple (NetDevice.ipConfig)

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: remove IpConfig's namedtuple (NetDevice.ipConfig) .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16025/ :

Change in vdsm[master]: iproute2, pyroute_two: use IpConfig directly (NetDevice.ipco...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2, pyroute_two: use IpConfig directly (NetDevice.ipconfig) .. Patch Set 9: -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_pe

Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test .. Patch Set 3: The previous comment belong to the next patch. -- To view, visit http://gerrit.ovirt.org/38

Change in vdsm[master]: models: move dynamic IP configuration parameters to IPv4 and...

2015-02-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: models: move dynamic IP configuration parameters to IPv4 and IPv6 .. models: move dynamic IP configuration parameters to IPv4 and IPv6 Change-Id: Ia7fa5c5580e

Change in vdsm[master]: network: order 'ipv4' before 'ipv6' and rename 'blocking' to...

2015-02-23 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: network: order 'ipv4' before 'ipv6' and rename 'blocking' to 'blockingdhcp' .. network: order 'ipv4' before 'ipv6' and rename 'blocking' to 'blockingdhcp' Cha

Change in vdsm[master]: tests: Use permutations for separating test failures

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Use permutations for separating test failures .. Patch Set 5: Code-Review+1 Tests pass, little too verbose since permutation use the argument value in the t

Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test .. Patch Set 3: Tests pass, little too verbose since permutation use the argument value in the test name, an

Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/38021 To unsubscribe, visit http://gerr

Change in vdsm[master]: tests: Use permutations for separating test failures

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Use permutations for separating test failures .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/38031 To unsubscribe, visit http://gerrit

Change in vdsm[master]: ifcfg: stop using IpConfig's namedtuple altogether

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: stop using IpConfig's namedtuple altogether .. Patch Set 7: -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16023/

Change in vdsm[master]: misc: Support zero-time in getReadDelay()

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38082 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[ovirt-3.5]: virt: Check if a drive is chuhked before extending

2015-02-23 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38087 To unsubscribe, visit http://g

Change in vdsm[ovirt-3.5]: virt: Add Drive.chunked property

2015-02-23 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38086 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: sdm: introduce the new createVolume command

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: introduce the new createVolume command .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/38097/1/vdsm/storage/sdm/__init__.py File vdsm/storage/sdm/__i

Change in vdsm[master]: ifcfg: use IpConfig in _createConfFile instead of its namedt...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: use IpConfig in _createConfFile instead of its namedtuple .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16

Change in vdsm[master]: ifcfg: use IpConfig in _createConfFile instead of its namedt...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: use IpConfig in _createConfFile instead of its namedtuple .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16

Change in vdsm[ovirt-3.5]: virt: Fix limit when calculating next volume size

2015-02-23 Thread alitke
Adam Litke has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38088 To unsubscribe, visit http://gerrit

Change in vdsm[ovirt-3.5]: virt: Check if a drive is chuhked before extending

2015-02-23 Thread alitke
Adam Litke has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38087 To unsubscribe, visit http://gerri

Change in vdsm[ovirt-3.5]: virt: Add Drive.chunked property

2015-02-23 Thread alitke
Adam Litke has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38086 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: sdm: Allow query of task information on SDM hosts

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: Allow query of task information on SDM hosts .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16018/ : SUCCESS

Change in vdsm[master]: create gc and delete

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: create gc and delete .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16020/ : SUCCESS http://jenkins.ovirt.org/job

Change in vdsm[master]: block: use the contextmanager for getVolumeMetadataSlot

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: block: use the contextmanager for getVolumeMetadataSlot .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16017/ : SU

Change in vdsm[master]: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _g...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _getIfaceConfValues .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_

Change in vdsm[master]: models: rename NetDevice.ip to ipconfig to be more descriptive

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: rename NetDevice.ip to ipconfig to be more descriptive .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/1601

Change in vdsm[ovirt-3.5]: virt: Fix limit when calculating next volume size

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 2: This is a partial fix for urgent bug. -- To view, visit http://gerrit.ovirt.org/38088 To unsubsc

Change in vdsm[ovirt-3.5]: virt: Check if a drive is chuhked before extending

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 1: This patch is required for the next patches, partially fixing urgent bug. -- To view, visit htt

Change in vdsm[ovirt-3.5]: virt: Add Drive.chunked property

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 1: This patch is required for the next patches, partially fixing urgent bug. -- To view, visit http://gerrit.ovirt.o

Change in vdsm[ovirt-3.5]: virt: Fix limit when calculating next volume size

2015-02-23 Thread nsoffer
Hello Adam Litke, Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/38088 to review the following change. Change subject: virt: Fix limit when calculating next volume size ...

Change in vdsm[ovirt-3.5]: virt: Check if a drive is chuhked before extending

2015-02-23 Thread nsoffer
Hello Dan Kenigsberg, Allon Mureinik, Francesco Romani, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/38087 to review the following change. Change subject: virt: Check if a drive is chuhked before extending ..

Change in vdsm[ovirt-3.5]: virt: Add Drive.chunked property

2015-02-23 Thread nsoffer
Hello Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/38086 to review the following change. Change subject: virt: Add Drive.chunked property .. virt: Add Drive.chun

Change in vdsm[master]: NetDevice: lookup IP attributes using __getattr__

2015-02-23 Thread osvoboda
Ondřej Svoboda has abandoned this change. Change subject: NetDevice: lookup IP attributes using __getattr__ .. Abandoned With IpConfig having shrunk to a simple container of IPv4 and IPv6 (for now static) IP configuration info

Change in vdsm[master]: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool ...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_ifcfg_bool .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master

Change in vdsm[master]: models: make IpConfig deal with blank configuration from Net...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: make IpConfig deal with blank configuration from NetDevice gracefully .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master

Change in vdsm[master]: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool ...

2015-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_ifcfg_bool .. ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_i

Change in vdsm[master]: models: make IpConfig deal with blank configuration from Net...

2015-02-23 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: models: make IpConfig deal with blank configuration from NetDevice gracefully .. models: make IpConfig deal with blank configuration from NetDevice gra

Change in vdsm[master]: _addNetwork: never try to set mtu=None to an existing bridge

2015-02-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: _addNetwork: never try to set mtu=None to an existing bridge .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37899 To unsubscribe, visit

Change in vdsm[master]: models: rename NetDevice.ip to ipconfig to be more descriptive

2015-02-23 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: models: rename NetDevice.ip to ipconfig to be more descriptive .. Patch Set 6: (1 comment) I'll revert the parentheses. http://gerrit.ovirt.org/#/c/37797/6/vd

Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

2015-02-23 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38021 To unsubscribe, visit http

Change in vdsm[master]: network: test: remove bond with removed enslaved nics

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: test: remove bond with removed enslaved nics .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16014/ : SUCC

Change in vdsm[master]: misc: Support zero-time in getReadDelay()

2015-02-23 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/38082/1//COMMIT_MSG Commit Message: Line 15: monitor to fail

Change in vdsm[master]: janitorial: add utility to overwrite error message

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: janitorial: add utility to overwrite error message .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/37912/1/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: misc: Support zero-time in getReadDelay()

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: Support zero-time in getReadDelay() .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16013/ : SUCCESS http://

Change in vdsm[master]: network: test: remove bond with removed enslaved nics

2015-02-23 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: network: test: remove bond with removed enslaved nics .. network: test: remove bond with removed enslaved nics Change-Id: I5d3edfa8dca55afdfcf09e219372958d7c6ba6

Change in vdsm[master]: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool ...

2015-02-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_ifcfg_bool .. Patch Set 5: Verified+1 Passed network's functional tests and unit tests OK --

Change in vdsm[master]: NetDevice: lookup IP attributes using __getattr__

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: NetDevice: lookup IP attributes using __getattr__ .. Patch Set 7: Code-Review-1 I do noyt see the benefit of implicit lookup for NetDevice items inside the IpC

Change in vdsm[master]: ifcfg: use IpConfig in _createConfFile instead of namedtuple

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: use IpConfig in _createConfFile instead of namedtuple .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16012/

Change in vdsm[master]: virt: Extract Vm.__extendDriveReplica method

2015-02-23 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Extract Vm.__extendDriveReplica method .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/38028/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1525:

Change in vdsm[master]: models: remove IpConfig's namedtuple (NetDevice.ipConfig)

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: models: remove IpConfig's namedtuple (NetDevice.ipConfig) .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37796 To unsubscribe, visit h

Change in vdsm[master]: ifcfg: stop using IpConfig's namedtuple altogether

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: stop using IpConfig's namedtuple altogether .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16004/ : SUCCESS

Change in vdsm[master]: ifcfg: stop using IpConfig's namedtuple altogether

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: stop using IpConfig's namedtuple altogether .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37795 To unsubscribe, visit http://g

Change in vdsm[master]: iproute2, pyroute_two: use IpConfig directly (NetDevice.ipco...

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: iproute2, pyroute_two: use IpConfig directly (NetDevice.ipconfig) .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36726 To unsubscribe

Change in vdsm[master]: WIP: packaging: updating for VDSM 4.17 on Debian jessie

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: packaging: updating for VDSM 4.17 on Debian jessie .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16011/ : SU

Change in vdsm[master]: misc: Support zero-time in getReadDelay()

2015-02-23 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: misc: Support zero-time in getReadDelay() .. misc: Support zero-time in getReadDelay() When system time goes backward during a read, dd returns zero time and Infinit

Change in vdsm[master]: ifcfg: use IpConfig in _createConfFile instead of namedtuple

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: use IpConfig in _createConfFile instead of namedtuple .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37794 To unsubscribe, visi

Change in vdsm[master]: WIP: packaging: updating for VDSM 4.17 on Debian jessie

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: packaging: updating for VDSM 4.17 on Debian jessie .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16010/ : SU

Change in vdsm[master]: debug: Integrate manhole debugging service

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: debug: Integrate manhole debugging service .. Patch Set 6: ping for other reviews - I think this is an useful addition -- To view, visit http://gerrit.ovirt

Change in vdsm[master]: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _g...

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _getIfaceConfValues .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37793 To

Change in vdsm[master]: models: rename NetDevice.ip to ipconfig to be more descriptive

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: models: rename NetDevice.ip to ipconfig to be more descriptive .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/37797/6/vdsm/network/models.py File vdsm

Change in vdsm[master]: models: rename NetDevice.ip to ipconfig to be more descriptive

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: models: rename NetDevice.ip to ipconfig to be more descriptive .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/37797/6/vdsm/network/api.p

Change in vdsm[ovirt-3.5]: network: api: allow removal of bond with no slaves

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: api: allow removal of bond with no slaves .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_network_functional_tests_gerrit

Change in vdsm[master]: virt: Introduce Vm._setVolumeSize helper

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Introduce Vm._setVolumeSize helper .. Patch Set 3: Code-Review+1 Happy to have learned something about IRS. -- To view, visit http://gerrit.ovirt.org/

Change in vdsm[master]: virt: Extract Vm.__extendDriveReplica method

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Extract Vm.__extendDriveReplica method .. Patch Set 1: Code-Review+1 (1 comment) nitpicking about names, but not worth delaying this patch. http://ger

Change in vdsm[master]: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool ...

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_ifcfg_bool .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/37792/5/v

Change in vdsm[master]: virt: Improve volume extension info readability

2015-02-23 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Improve volume extension info readability .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/38029 To unsubscribe, visit http://ge

Change in vdsm[ovirt-3.5]: network: api: allow removal of bond with no slaves

2015-02-23 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: network: api: allow removal of bond with no slaves .. Patch Set 1: Verified+1 Passed network's functional tests and unit tests with the same results as patch bef

Change in vdsm[ovirt-3.5]: network: api: allow removal of bond with no slaves

2015-02-23 Thread phoracek
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/38079 to review the following change. Change subject: network: api: allow removal of bond with no slaves .. network: api: allow

Change in vdsm[master]: models: make IpConfig deal with blank configuration from Net...

2015-02-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: models: make IpConfig deal with blank configuration from NetDevice gracefully .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36712 T

Change in vdsm[master]: virt: devices: move device creation in a submodule

2015-02-23 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: virt: devices: move device creation in a submodule .. virt: devices: move device creation in a submodule In the Vm class, the vm devices are arranged in a tr

Change in vdsm[master]: models: make IpConfig deal with blank configuration from Net...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: make IpConfig deal with blank configuration from NetDevice gracefully .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master

Change in vdsm[master]: ifcfg: stop using IpConfig's namedtuple altogether

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: stop using IpConfig's namedtuple altogether .. Patch Set 6: -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16004/

Change in vdsm[master]: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _g...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _getIfaceConfValues .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_

Change in vdsm[master]: NetDevice: lookup IP attributes using __getattr__

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: NetDevice: lookup IP attributes using __getattr__ .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16005/ : FAILURE

Change in vdsm[master]: models: rename NetDevice.ip to ipconfig to be more descriptive

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: rename NetDevice.ip to ipconfig to be more descriptive .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/1599

Change in vdsm[master]: iproute2, pyroute_two: use IpConfig directly (NetDevice.ipco...

2015-02-23 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2, pyroute_two: use IpConfig directly (NetDevice.ipconfig) .. Patch Set 8: -Verified Build Failed http://jenkins.ovirt.org/job/vdsm_master_pe

  1   2   >