Dima Kuznetsov has uploaded a new change for review.
Change subject: caps: Fix access to /sys/class/iommu
..
caps: Fix access to /sys/class/iommu
This patch fixes OSError during getVdsCapabilities introduced in
Dima Kuznetsov has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/37097/11/lib/yajsonrpc/stompReactor.py
File
Adam Litke has posted comments on this change.
Change subject: monitor: return whether the reported status is actual
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37952
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38587/2//COMMIT_MSG
Commit
Dima Kuznetsov has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/37057/11/lib/yajsonrpc/betterAsyncore.py
File
Nir Soffer has posted comments on this change.
Change subject: clusterLock: Make inquire retval consistent
..
Patch Set 1: Code-Review+1
I think we should raise something instead of returning expected output
(2-tuple) with
Ido Barkan has posted comments on this change.
Change subject: split network restoration from vdsmd.service
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/29441/9/init/systemd/vdsm-network.service.in
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Cache the result of numaUtils.getVcpuPids
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16505/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 8:
(18 comments)
https://gerrit.ovirt.org/#/c/37509/8/vdsm/v2v.py
File vdsm/v2v.py:
Line 37:
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 9: Code-Review-1
Please see my comments on version 8.
--
To view, visit
Dima Kuznetsov has posted comments on this change.
Change subject: asyncore: dynamic tick support
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37057
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/37055
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/721/ :
SUCCESS
Darshan N has posted comments on this change.
Change subject: gluster: Adds new verb to setup geo-rep mount broker.
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/38444/1/vdsm/gluster/api.py
File
Petr Horáček has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 2: -Verified
Requires functional test
--
To view, visit https://gerrit.ovirt.org/38587
To
Bala.FA has posted comments on this change.
Change subject: gluster: Adds new verbs to setup gluster geo-replication.
..
Patch Set 5: Code-Review-1
(2 comments)
If you see this patch is applicable for newer glusterfs, please
Martin Polednik has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1: Code-Review+1
Which OS (version) is affected?
--
To view, visit https://gerrit.ovirt.org/38641
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 11:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16567/ : SUCCESS
Dima Kuznetsov has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1: Verified+1
I encountered this on a CentOS 6 although it is probably more related to what
HW the kernel
Yeela Kaplan has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 4: Code-Review-1
(3 comments)
Darshan N has posted comments on this change.
Change subject: gluster: Adds new verbs to setup gluster geo-replication.
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/38228/5/vdsm/gluster/api.py
File
Dima Kuznetsov has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38397
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 11:
Build Successful
Martin Polednik has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1:
Even on hardware that doesn't have iommu the /sys/class/iommu should be present
since 7.1 and we target
Francesco Romani has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 10: -Code-Review
questions answered, removing score - will review again later
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: asyncore: Move AsyncoreEvent to betterAsyncore
..
Patch Set 11:
Build Failed
Martin Polednik has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1: Code-Review-1
-1 for question*
--
To view, visit https://gerrit.ovirt.org/38641
To unsubscribe, visit
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 24: Verified+1
--
To view, visit https://gerrit.ovirt.org/35498
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Remove JsonRpcClientPool
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16568/ : SUCCESS
Bala.FA has posted comments on this change.
Change subject: gluster: Adds new verbs to setup gluster geo-replication.
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38228/5/vdsm/gluster/api.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Adds new verb to setup geo-rep mount broker.
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16507/ :
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/35498/23/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:
Yeela Kaplan has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38641
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1:
As long as master is built for el6 (and we even have official nightlies) we
should not make such
Martin Polednik has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 1: Code-Review+1
I would welcome a comment explaining the issue and to remove it when el6 is
gone for us
Martin Polednik has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 12: Code-Review-1
(3 comments)
Minor comments
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: Adds new verbs to setup gluster geo-replication.
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16570/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in
_getIfaceConfValues
..
Patch Set 8:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 24:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/580/ :
SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/37509/9/vdsm/v2v.py
File vdsm/v2v.py:
Line 219:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: use IpConfig in _createConfFile instead of its namedtuple
..
Patch Set 10:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: stomp: Remove redundant code
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35939
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: janitorial: use the response module
..
Patch Set 5:
Thanks Francesco,
I will set the response in the next patch of convert vm as well
--
To view, visit
Martin Polednik has abandoned this change.
Change subject: vdsm: refactor all_devices using etree
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/32453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Martin Polednik has abandoned this change.
Change subject: vdsm: refactor all_channels using etree
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/32448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Allon Mureinik has uploaded a new change for review.
Change subject: image.py: reference exception as e when required
..
image.py: reference exception as e when required
Change-Id: Ic9bd5ef1b4656bf6fb15e9c897356e94a2a795b5
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix detection of device vmId
..
Patch Set 2: Verified+1
Unit tests (fixed) point to no issue, running VM manually correctly reports
vmId for device.
Francesco Romani has posted comments on this change.
Change subject: stomp: parsing buffer refactoring
..
Patch Set 1: Code-Review-1
(4 comments)
mostly questions, hence -1 for visibility, but quite some of them
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 5:
Build Failed
Ido Barkan has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 12:
(3 comments)
Petr Horáček has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 5: Verified+1
Solves problem in this reproduction
oVirt Jenkins CI Server has posted comments on this change.
Change subject: models: remove IpConfig's namedtuple (NetDevice.ipConfig)
..
Patch Set 8:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: iproute2, pyroute_two: use IpConfig directly
(NetDevice.ipconfig)
..
Patch Set 10:
Build Failed
Allon Mureinik has posted comments on this change.
Change subject: image.py: reference exception as e when required
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38669/1/vdsm/storage/image.py
File
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: Properly log and return an error if the threadFactory
fails
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/35936
To
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/35935/6//COMMIT_MSG
Commit Message:
Line 11:
Dan Kenigsberg has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/38587/6/tests/unifiedPersistenceTests.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: network: persistence: skip bonds owned and used by vdsm
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/38587/6/tests/unifiedPersistenceTests.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: janitorial: use the response module
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16575/ : SUCCESS
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/38675
to review the following change.
Change subject: storage: Add path cap. PV size to getDeviceList
..
storage: Add path cap.
Francesco Romani has uploaded a new change for review.
Change subject: vm: rename internal method for clarity
..
vm: rename internal method for clarity
_getVcpuLimit actually updates a field,
so rename it accordingly.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: order 'ipv4' before 'ipv6' and rename 'blocking' to
'blockingdhcp'
..
Patch Set 2:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: do not poll for scheduler parameters
..
Patch Set 4:
v3 was rebased.
v4 refactors and addresses Martin's comments.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: remove rom, file and bar settings from API
..
Patch Set 3:
Build Failed
Francesco Romani has uploaded a new change for review.
Change subject: API: honor onlyUUID only if short status is asked
..
API: honor onlyUUID only if short status is asked
this patch makes the 'onlyUUID' parameter take effect
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move NUMA collecting code to stats thread
..
Patch Set 3:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 6:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: rename internal method for clarity
..
Patch Set 1: Verified+1
trivial patch, verified with 'make check'
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Log the the duration time of the migration
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/736/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 9:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: display hostdev passthrough support in caps
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: add method to get all registered VMs
..
Patch Set 26:
Build Failed
Francesco Romani has abandoned this change.
Change subject: DONTMERGE: bench-only: fake MOM.
..
Abandoned
we just need to make MOM fast enough
--
To view, visit https://gerrit.ovirt.org/37083
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
..
Patch Set 13:
(1 comment)
mostly OK, I just like a bit more docs. Should be quick and easy to add.
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/38397
To unsubscribe,
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 5:
Verified on RHEL7 - Migration went through without problems excluding
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
virt: Do not count time spent on migrationCreate against timeout
Currently, the
Francesco Romani has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/37097/12/lib/yajsonrpc/betterAsyncore.py
File
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: add ability to get dictionary directly from
JsonRpcRequest
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/35254/7//COMMIT_MSG
Commit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Allow autobackup option in lvm module
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16573/ : SUCCESS
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: fix detection of device vmId
..
hostdev: fix detection of device vmId
Due to recent and previous name juggling, the device vmId is NOT
detected when
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 2:
version 2 improves the commit message and adds bug url, with no code changes.
--
To view,
Timothy Asir has posted comments on this change.
Change subject: lvm: Enhance changelv function to fix option repeated error
..
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/38195/6//COMMIT_MSG
Commit Message:
Line
Francesco Romani has posted comments on this change.
Change subject: lib: introduce the 'response' module
..
Patch Set 10:
only rebased on top of more tests to help with verification. No code changes.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: tests: add more tests for custom error responses
..
Patch Set 1:
no code changes, all test behave like before/expected, thus V+1
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 9:
rebased with no code changes
--
To view, visit https://gerrit.ovirt.org/38268
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: remove _reportError
..
Patch Set 10:
rebased with no code changes
--
To view, visit https://gerrit.ovirt.org/38269
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: lib: introduce the 'response' module
..
Patch Set 11:
rebased with no code changes
--
To view, visit https://gerrit.ovirt.org/37912
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 5: Code-Review+2
(1 comment)
Francesco Romani has posted comments on this change.
Change subject: lib: virt: add the response.success() helper
..
Patch Set 9:
rebased with no code changes
--
To view, visit https://gerrit.ovirt.org/38270
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 10:
rebased with no code changes
--
To view, visit https://gerrit.ovirt.org/38268
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: janitorial: use the response module
..
Patch Set 4:
rebased with no code changes
--
To view, visit https://gerrit.ovirt.org/38447
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: stop using IpConfig's namedtuple altogether
..
Patch Set 8:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Fix access to /sys/class/iommu
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16572/ : SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38397
To unsubscribe,
Shahar Havivi has posted comments on this change.
Change subject: v2v: janitorial: use the response module
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38447
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: tests: add more tests for custom error responses
..
tests: add more tests for custom error responses
An upcoming patchset wants to introduce and leverage
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Do not count time spent on migrationCreate against timeout
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38397/5/vdsm/virt/migration.py
File
1 - 100 of 118 matches
Mail list logo
