Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19:
(2 comments)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 3
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonr
Francesco Romani has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 5: Code-Review+1
It seems to me that you replaced a few comments -as Dan requested- in the code
Francesco Romani has posted comments on this change.
Change subject: migration: remove getVmStats before migration
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39202
To unsubscribe, visit https://ge
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: raise proper execption if mount point already used
..
Patch Set 2:
* Update tracker::#1209475::OK
* Check Bug-Url::OK
* Check Public Bug::#120947
automat...@ovirt.org has posted comments on this change.
Change subject: tests: lib: drop forward port from python 2.7
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/4087
Francesco Romani has posted comments on this change.
Change subject: vmstats: Fix cpu usage key names
..
Patch Set 2: Code-Review+1
thanks for the changes. Looks fine now.
--
To view, visit https://gerrit.ovirt.org/40845
To u
Francesco Romani has abandoned this change.
Change subject: tests: lib: drop forward port from python 2.7
..
Abandoned
obsoleted by https://gerrit.ovirt.org/#/c/40888
--
To view, visit https://gerrit.ovirt.org/40879
To unsubs
Francesco Romani has posted comments on this change.
Change subject: testlib: drop python-2.6-specific code
..
Patch Set 2:
probably also safe_repr can go.
--
To view, visit https://gerrit.ovirt.org/40888
To unsubscribe, visi
Ido Barkan has posted comments on this change.
Change subject: models, configurators: replace the internal 'async' flag with
blockingdhcp
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40456
To unsub
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: set default value for dataalignment and physicalextent
value
..
Patch Set 2:
* Update tracker::#1210296::OK
* Check Bug-Url::OK
* Check Public B
Ido Barkan has posted comments on this change.
Change subject: testlib: drop python-2.6-specific code
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/40888/2//COMMIT_MSG
Commit Message:
Line 5: CommitD
Nir Soffer has posted comments on this change.
Change subject: vmstats: Fix cpu usage key names
..
Patch Set 2:
Francesco, this version uses the fix you suggested. Can you review it again?
--
To view, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: vmstats: Fix cpu usage key names
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: sslutils: move createSSLContext from clientIF
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/36699/8/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Lin
Nir Soffer has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 5:
Dan, Francesco, I believe this version address your comments. Would you review
it again?
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: allow to get the nth-last sample
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40427
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: less verbose debug in _getInterfaceStats
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40424
To unsubscribe, visit https:/
automat...@ovirt.org has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 5:
* Update tracker::#1220039::OK
* Check Bug-Url::OK
* Check Public Bug::#1220039::OK, pub
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: hoststats: rationalize getInterfaceStats
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/40426
To unsubscribe, visit https:/
automat...@ovirt.org has posted comments on this change.
Change subject: testlib: drop python-2.6-specific code
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
automat...@ovirt.org has posted comments on this change.
Change subject: debug: Add virt-alignment-scan.debug tool
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: debug: Add virt-alignment-scan.debug tool
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
automat...@ovirt.org has posted comments on this change.
Change subject: debug: Add virt-alignment-scan.debug tool
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Nir Soffer has uploaded a new change for review.
Change subject: debug: Add virt-alignment-scan.debug tool
..
debug: Add virt-alignment-scan.debug tool
Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8
Signed-off-by: Nir Soff
Timothy Asir has uploaded a new change for review.
Change subject: gluster: raise proper execption if mount point already used
..
gluster: raise proper execption if mount point already used
Currently if an already used mount poi
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: raise proper execption if mount point already used
..
Patch Set 1:
* Update tracker::#1209475::OK
* Check Bug-Url::OK
* Check Public Bug::#120947
Timothy Asir has uploaded a new change for review.
Change subject: gluster: set default value for dataalignment and physicalextent
value
..
gluster: set default value for dataalignment and physicalextent value
Set default value
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: set default value for dataalignment and physicalextent
value
..
Patch Set 1:
* Update tracker::#1210296::OK
* Check Bug-Url::OK
* Check Public B
automat...@ovirt.org has posted comments on this change.
Change subject: testlib: drop python-2.6-specific code
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Dan Kenigsberg has uploaded a new change for review.
Change subject: testlib: drop python-2.6-specific code
..
testlib: drop python-2.6-specific code
Noe that we no longer support el6 and its python-2.6, we can drop these
backpo
Yaniv Bronhaim has posted comments on this change.
Change subject: migration: remove getVmStats before migration
..
Patch Set 9:
not related to the chain at all ..
--
To view, visit https://gerrit.ovirt.org/39202
To unsubscri
Yaniv Bronhaim has posted comments on this change.
Change subject: migration: remove getVmStats before migration
..
Patch Set 9: Code-Review+1
please don't depend on the rest of the patches. lets merge it separately
--
To vie
Yaniv Bronhaim has posted comments on this change.
Change subject: sslutils: move createSSLContext from clientIF
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/36699/8/lib/vdsm/sslutils.py
File lib/vdsm
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
spec: require qemu-*-ev on CentOS >= 7
Added a requirement for qemu-kvm-ev and qemu-img-ev on CentOS >= 7.
q
automat...@ovirt.org has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 5:
* Update tracker::#1221192::OK
* Update tracker::#1220333::OK
* Set MODIFIED::bug 1221192#1221
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: spec: updated qemu-* requirements on EL
..
spec: updated qemu-* requirements on EL
Updated the build version for qemu-kvm-ev,qemu-kvm-rev,qemu-img-ev a
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 4: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/40877
To unsubscribe, visit https:/
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: add an option to create a stomp client
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/38491/9/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 4
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReac
Freddy Rolland has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/40877
To unsubscribe, visit https://gerrit.ovirt.
Dan Kenigsberg has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 5: Continuous-Integration+1
testMethodReturnsNullAndServerReturnsTrue failure unrelated to this patch.
--
automat...@ovirt.org has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 6:
* Update tracker::#1221192::OK
* Update tracker::#1220333::OK
* Set MODIFIED::bug 1221192#12211
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/s
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: add an option to create a stomp client
..
Patch Set 9: Code-Review-1
you have pep8 error here (vdsm/clientIF.py:462:5: E303 too many blank lines (2)
--
Allon Mureinik has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 4: Code-Review+1
The Jenkins failure is just redundant noise, as usual - this time, failing unit
tests whi
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 13:
(9 comments)
https://gerrit.ovirt.org/#/c/38819/13/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReacto
Petr Horáček has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/40882/1/tests/functional/networkTests.py
File tests/functional/networkT
automat...@ovirt.org has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 5:
* Update tracker::#1221192::OK
* Update tracker::#1220333::OK
* Check Bug-Url::OK
* Check Public Bu
Dan Kenigsberg has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40882/1/tests/functional/networkTests.py
File tests/fun
Petr Horáček has uploaded a new change for review.
Change subject: netlink: make relative imports PY3 compatible
..
netlink: make relative imports PY3 compatible
Change-Id: I43f01393790283eca5118e6e492eef1f7e6eb5c0
Signed-off-by
automat...@ovirt.org has posted comments on this change.
Change subject: netlink: make relative imports PY3 compatible
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: netinfoTests: Do not try to read bonding options
..
netinfoTests: Do not try to read bonding options
A user running the tests usually does not have sud
automat...@ovirt.org has posted comments on this change.
Change subject: netinfoTests: Do not try to read bonding options
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Darshan N has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/40141/5/vdsm/gluster/api.py
File vdsm/gluster/api.py
Dan Kenigsberg has posted comments on this change.
Change subject: netinfoTests: Do not try to read bonding options
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40881
To unsubscribe, visit https://gerr
Yaniv Bronhaim has posted comments on this change.
Change subject: netinfoTests: Do not try to read bonding options
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40881
To unsubscribe, visit https://g
automat...@ovirt.org has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/6/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/sto
Petr Horáček has uploaded a new change for review.
Change subject: network: allow custom bondOption
..
network: allow custom bondOption
Allow 'custom' in bond options. This value will be accepted by
Bond.validateOptions method b
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: verbs to enable/disable snapshot scheduling.
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Freddy Rolland has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/40876
To unsubscribe, visit https://gerrit.ovirt.o
Freddy Rolland has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/40876
To unsubscribe, visit https://gerrit.ovirt.o
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: outgoing connection to a broker
..
Patch Set 13: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/38819/13/lib/vdsm/config.py.in
File lib/vdsm/co
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 19:
(6 comments)
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 167:
Lin
Dan Kenigsberg has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 4: Code-Review+2
build failure is unrelated to this patch, and should be fixed by this backport
https://gerr
Hello Ondřej Svoboda,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40881
to review the following change.
Change subject: netinfoTests: Do not try to read bonding options
..
netinfoTests: Do not
automat...@ovirt.org has posted comments on this change.
Change subject: netinfoTests: Do not try to read bonding options
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least o
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: server side subscriptions
..
Patch Set 18:
(3 comments)
https://gerrit.ovirt.org/#/c/38451/18/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Lin
automat...@ovirt.org has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 4:
* Update tracker::#1221192::OK
* Update tracker::#1220333::OK
* Check Bug-Url::OK
* Check Public B
automat...@ovirt.org has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 4:
* Update tracker::#1221192::OK
* Update tracker::#1220333::OK
* Check Bug-Url::OK
* Check Public Bu
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: events
..
Patch Set 19: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/38069/19/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Li
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: client side subscription
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line
Francesco Romani has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwor
Francesco Romani has posted comments on this change.
Change subject: tests: lib: drop forward port from python 2.7
..
Patch Set 1: Verified+1
verified running 'make check' on F21 - Python 2.7.8
--
To view, visit https://gerri
Francesco Romani has uploaded a new change for review.
Change subject: tests: lib: drop forward port from python 2.7
..
tests: lib: drop forward port from python 2.7
Since we now depend on (distributions which ship) python 2.7,
automat...@ovirt.org has posted comments on this change.
Change subject: tests: lib: drop forward port from python 2.7
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: Revert "network: allow custom bondOption"
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert "network: allow custom bondOption"
..
Revert "network: allow custom bondOption"
This patch was based on misunderstanding of bond's 'areOptionsAp
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40876
To unsubscribe, visit https://gerrit.ovir
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 3: Code-Review+2
same as master.
--
To view, visit https://gerrit.ovirt.org/40877
To unsubscribe, visit h
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Add vdsClient secrets verbs
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Add option to clear other secrets
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Nir Soffer has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwordsTest
Nir Soffer has posted comments on this change.
Change subject: vmstats: Handle missing system_time and user_time
..
Patch Set 1:
Thanks Francesco, I will fix it as you suggest.
--
To view, visit https://gerrit.ovirt.org/40845
automat...@ovirt.org has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 3:
* Update tracker::#1221192::OK
* Update tracker::#1220333::OK
* Check Bug-Url::OK
* Check Public B
automat...@ovirt.org has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 3: -Verified
* Update tracker::#1221192::OK
* Update tracker::#1220333::OK
* Check Bug-Url::OK
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-ur
automat...@ovirt.org has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is require
automat...@ovirt.org has posted comments on this change.
Change subject: spec: updated qemu-* requirements on EL
..
Patch Set 1:
* Update tracker::#1199014::OK
* Update tracker::#1209034::OK
* Check Bug-Url::OK
* Check Public B
Hello Fred Rolland, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40877
to review the following change.
Change subject: spec: updated qemu-* requirements on EL
..
Hello Fred Rolland, Allon Mureinik, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40876
to review the following change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
s
automat...@ovirt.org has posted comments on this change.
Change subject: spec: require qemu-*-ev on CentOS >= 7
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url
Francesco Romani has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File tests/passwor
automat...@ovirt.org has posted comments on this change.
Change subject: spec: Update qemu requirement in EL7
..
Patch Set 1:
* Update tracker::#1199014::OK
--
To view, visit https://gerrit.ovirt.org/38408
To unsubscribe, vis
Allon Mureinik has abandoned this change.
Change subject: spec: Update qemu requirement in EL7
..
Abandoned
Already covered by Ifbd1fdd425f773776c5ce7596a0f339480a3296c
--
To view, visit https://gerrit.ovirt.org/38408
To unsu
Dan Kenigsberg has posted comments on this change.
Change subject: password: Prevent password logging and persisting
..
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/40707/4/tests/passwordsTests.py
File t
1 - 100 of 178 matches
Mail list logo
