Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 16:
(5 comments)
https://gerrit.ovirt.org/#/c/42908/16/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 39:
Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/42908/16/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 135:
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 8: Code-Review-1
(1 comment)
nit
https://gerrit.ovirt.org/#/c/33375/8/lib/vdsm/netlink/addr.py
Ido Barkan has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43423
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 11:
From Patchset 8:
Passed network functional tests with ifcfg and unified persistence without a
Ido Barkan has uploaded a new change for review.
Change subject: fix pep8
..
fix pep8
Change-Id: I4e0d9c4fc179825e9d14b4787e65b77dcfec59d7
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M tests/functional/networkTests.py
1
automat...@ovirt.org has posted comments on this change.
Change subject: fix pep8
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the stable
Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 17: Code-Review-1
Replace wakeup with other term so we can avoid using wake_up.
--
To view, visit
Ido Barkan has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/42908/16/lib/vdsm/rwlock.py
File lib/vdsm/rwlock.py:
Line 39:
Dan Kenigsberg has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 3: Code-Review-1
(1 comment)
Ido Barkan has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 148:
Dan Kenigsberg has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43891
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Dan Kenigsberg has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 1: Verified+1
gitpydiff is happy
--
To view, visit https://gerrit.ovirt.org/44021
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 3:
* Update tracker::#1234867::OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: bonding: validate options based on pre-dumped ones
..
Patch Set 3:
* Update tracker::#1234867::OK
* Check Bug-Url::OK
* Check Public
Dan Kenigsberg has posted comments on this change.
Change subject: Renaming policycoreutils-python dependency for fedora 23 and
above
..
Patch Set 2: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/44019
To
Ido Barkan has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 20:
can we just drop this patch and use the next one?
--
To view, visit https://gerrit.ovirt.org/42928
To
Nir Soffer has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 23:
We can squash this into the former patch. I'm keeping it separate in case Dan
prefer the simpler solution.
--
To
Nir Soffer has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 148:
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 2: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/44027/2/vdsm.spec.in
File vdsm.spec.in:
automat...@ovirt.org has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Roman Mohr has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/44028/1/tests/tcTests.py
File tests/tcTests.py:
Line 106:
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 3: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least
automat...@ovirt.org has posted comments on this change.
Change subject: Renaming policycoreutils-python dependency for fedora 23 and
above
..
Patch Set 2:
* Update tracker::#1246626::OK
* Check Bug-Url::OK
* Check Public
Ido Barkan has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/43995
To unsubscribe,
Petr Horáček has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 8: Verified+1
Passed network functional tests with ifcfg and unified persistence without a
Ido Barkan has posted comments on this change.
Change subject: net: fix
testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
..
Patch Set 3:
(1 comment)
Ido Barkan has abandoned this change.
Change subject: More logging for missing nics.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/41782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
automat...@ovirt.org has posted comments on this change.
Change subject: More logging for missing nics.
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/41782
To
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Petr Horáček has uploaded a new change for review.
Change subject: net: configurators: persist custom bond option
..
net: configurators: persist custom bond option
Until now, custom bond property was exposed only to
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least
Nir Soffer has posted comments on this change.
Change subject: tests: Add RWLock tests
..
Patch Set 13:
(4 comments)
https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 48:
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43859/1//COMMIT_MSG
Commit Message:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/43859/1//COMMIT_MSG
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Change state of the agent only after heartbeat processing
..
virt: Change state of the agent only after heartbeat processing
Until now we have
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Change state of the agent only after heartbeat processing
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Ido Barkan has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/33375/8/lib/vdsm/netlink/addr.py
File
Ido Barkan has posted comments on this change.
Change subject: netinfo: improve which ipv4 addr is reported.
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/33375
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: remove redundant rhev_build_config_opt global
..
remove redundant rhev_build_config_opt global
Change-Id: Id35d43e51de308f132de13f7ed1a6aa1b445f944
automat...@ovirt.org has posted comments on this change.
Change subject: remove redundant rhev_build_config_opt global
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44021
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: remove double whitespace after commas
..
remove double whitespace after commas
Change-Id: I9e88bd78afddf6a835600e45d127e2bdbe0a0d7f
Signed-off-by: Dan
Dan Kenigsberg has posted comments on this change.
Change subject: Renaming policycoreutils-python dependency for fedora 23 and
above
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44019/1//COMMIT_MSG
Commit
automat...@ovirt.org has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Ido Barkan has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 23: Code-Review+1
can we just squash this ti the former patch?
--
To view, visit https://gerrit.ovirt.org/42909
To
Dan Kenigsberg has uploaded a new change for review.
Change subject: remove double whitespace after commas
..
remove double whitespace after commas
Change-Id: I9e88bd78afddf6a835600e45d127e2bdbe0a0d7f
Signed-off-by: Dan
automat...@ovirt.org has posted comments on this change.
Change subject: remove double whitespace after commas
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Roman Mohr has uploaded a new change for review.
Change subject: tcTests: Fix problem of left over bridges
..
tcTests: Fix problem of left over bridges
For unknown reason the command which should shut down the bridge fails
to
automat...@ovirt.org has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Roman Mohr has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44028
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 20: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42928
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/43891/9/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Dan Kenigsberg has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/44028/1/tests/tcTests.py
File
Roman Mohr has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 1:
To reproduce the issue, just run
while true; do ../tests/run_tests_local.sh tcTests.py ;done
The number
Dan Kenigsberg has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44027
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove redundant rhev_build_config_opt global
..
Remove redundant rhev_build_config_opt global
By mistake this part of code was left after
automat...@ovirt.org has posted comments on this change.
Change subject: Remove redundant rhev_build_config_opt global
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: configurators: persist custom bond option
..
net: configurators: persist custom bond option
Until now, custom bond property was exposed only to
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Petr Horáček has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 3: Verified+1
Passed functional network tests with unified and ifcfg persistence without a
Omer Frenkel has posted comments on this change.
Change subject: vm: event: send status event on pause and resume
..
Patch Set 14: Verified+1
verified with latest engine using start on pause and then resume. events sent
and
Dan Kenigsberg has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 3: Code-Review-1
this is test-only, but it sounds real:
13:37:38 ERROR: testGetBondingOptions
Sandro Bonazzola has posted comments on this change.
Change subject: Removing prefix definition for qemu-kvm-ev
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43993
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: tests: Create storagetestlib module
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43547/4/tests/storagetestlib.py
File tests/storagetestlib.py:
Line
Fabian Deutsch has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/43254
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: vdsm-tool: remove register verb
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/43921
To unsubscribe, visit
Fabian Deutsch has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 1:
Please update the commit msg to poin tot the vdsm verb. And are you sure that
we don't need any of the vdsm-*
Adam Litke has uploaded a new change for review.
Change subject: storage: Rename _share to share_to_image
..
storage: Rename _share to share_to_image
When a new volume is created whose parent is a template volume, that
template
Adam Litke has uploaded a new change for review.
Change subject: sdc: Allow StorageDomainCache to cache StorageDomainManifest
objects
..
sdc: Allow StorageDomainCache to cache StorageDomainManifest objects
When HSM is
Adam Litke has uploaded a new change for review.
Change subject: storage: Refactor new volume metadata generation
..
storage: Refactor new volume metadata generation
To prepare for garbage-collectible volume metadata needed by
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: deleteImage and deps
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: storage: Rename getParent to getParentId
..
storage: Rename getParent to getParentId
The Volume and VolumeMetadata classes have functions to return the
parent
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Introduce class structure
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: VolumeMetadata: move prepare and teardown
..
VolumeMetadata: move prepare and teardown
Change-Id: Iba0954ace3b1da5ea9afc41aeb6ea69a729fe29c
Signed-off-by: Adam
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: storage: Factor apparentsize adjustment into a reusable function
..
storage: Factor apparentsize adjustment into a reusable function
When creating a new volume
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move extend and extendVolume
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move simple metadata getters and setters
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Adam Litke has uploaded a new change for review.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
StorageDomainManifest: Manifest objects produce VolumeMetadata objects
When we are
Adam Litke has uploaded a new change for review.
Change subject: ImageManifest: move getChain
..
ImageManifest: move getChain
The implementation of getChain instantiates storagedomain and volume
objects. This must be fixed.
Adam Litke has uploaded a new change for review.
Change subject: storage: Rename getParentVolume* to produceParent
..
storage: Rename getParentVolume* to produceParent
The Volume object provides getParentVolume and the
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: clusterLock: Acquire, release, and inquire volume leases
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: clusterlock: Add reference counting
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: VolumeMetadata: Move getImageVolumes
..
VolumeMetadata: Move getImageVolumes
Change-Id: I4e99008b0df26a0bd2f714ac060ceee437e0060e
Signed-off-by: Adam Litke
automat...@ovirt.org has posted comments on this change.
Change subject: StorageDomainManifest: move image and volume enumeration
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move the getParent API
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 2:
* Update tracker::#1231379::OK
* Check Bug-Url::OK
* Check Public Bug::#1231379::OK, public bug
* Check
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 2: Verified+1
make rpm didn't generate the vdsm-reg pkg.
--
To view, visit
1 - 100 of 180 matches
Mail list logo
