Dan Kenigsberg has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 1: Verified+1
* gitpydiff HEAD~ shows not semantic change
* pep8-1.4.6 is happy
* 1.5.6 is happy, too.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: make pep8-1.4.6 (el7) happy
..
make pep8-1.4.6 (el7) happy
Change-Id: Iee593cee60690c43f82f30900f5c992bfba49000
Signed-off-by: Dan Kenigsberg
Michal Skrivanek has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43414
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: API: use modern locking around VM.destroy
..
API: use modern locking around VM.destroy
cleanup a bit VM.destroy() without functional changes:
- log outside
Francesco Romani has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 16: Verified+1
Verification: installed Fedora on a freshly created VM, using patched VDSM.
automat...@ovirt.org has posted comments on this change.
Change subject: utils: remove legacy code for uuid
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: utils: remove legacy code for uuid
..
utils: remove legacy code for uuid
In 3.6 version we won't support old registration
schema. This patch
Yaniv Bronhaim has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44239
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py
File
Francesco Romani has posted comments on this change.
Change subject: call stop_event_loop upon exit
..
Patch Set 5: Code-Review+1
will verify ASAP
--
To view, visit https://gerrit.ovirt.org/26532
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: remove legacy code for uuid
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44241/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: call stop_event_loop upon exit
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: use the response module
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has uploaded a new change for review.
Change subject: pep8 again
..
pep8 again
Too bad that my pep8-correcting patch was written and verified before
commit 14e2c07 was merged.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: pep8 again
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44246
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: pep8 again
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the stable
Francesco Romani has posted comments on this change.
Change subject: call stop_event_loop upon exit
..
Patch Set 5: Verified+1
(1 comment)
VDSM still stops, the newly added function call seem to have negligible (near
zero)
Dan Kenigsberg has posted comments on this change.
Change subject: utils: remove legacy code for uuid
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44241
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pep8 again
..
pep8 again
Too bad that my pep8-correcting patch was written and verified before
commit 14e2c07 was merged.
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: pep8 again
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: fully convert to response module
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove _reportError
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for disk hotplug/hotunplug
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Dan Kenigsberg has posted comments on this change.
Change subject: pep8 again
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/44246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: pep8 again
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/44246
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: vm: event: simplify send_status_event
..
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43414
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: event: simplify send_status_event
..
vm: event: simplify send_status_event
Now that VDSM is fully in charge of sending
events to Engine, there is
Dan Kenigsberg has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44201
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: make pep8-1.4.6 (el7) happy
..
make pep8-1.4.6 (el7) happy
Change-Id: Iee593cee60690c43f82f30900f5c992bfba49000
Signed-off-by: Dan Kenigsberg
automat...@ovirt.org has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 1: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
Hello Ido Barkan,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44239
to review the following change.
Change subject: make pep8-1.4.6 (el7) happy
..
make pep8-1.4.6 (el7) happy
Change-Id:
Sandro Bonazzola has posted comments on this change.
Change subject: make pep8-1.4.6 (el7) happy
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44239
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: register: remove legacy code
..
register: remove legacy code
The legacy code should be dropped. The new registration
schema should only support Engine
Dan Kenigsberg has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44219
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: restore-net-config: set main thread name
..
Patch Set 2:
* Update tracker::#1203422::OK
* Set MODIFIED::bug 1203422#1203422IGNORE, not all
automat...@ovirt.org has posted comments on this change.
Change subject: net: ignore pass through ifcfg parameters for selective
restoration
..
Patch Set 2:
* Update tracker::#1203422::OK
* Set MODIFIED::bug
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: restore-net-config: set main thread name
..
restore-net-config: set main thread name
restore-net-config's log flow to supervdsm.log, and are a bit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net: ignore pass through ifcfg parameters for selective
restoration
..
net: ignore pass through ifcfg parameters for selective restoration
Ignore
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net: always persist owned ifcfg files on ovirt node
..
net: always persist owned ifcfg files on ovirt node
Now, after VDSM writes all ifcfg files with
automat...@ovirt.org has posted comments on this change.
Change subject: net: always persist owned ifcfg files on ovirt node
..
Patch Set 5:
* Update tracker::#1203422::OK
* Check TR::#1203422::OK
* Set MODIFIED::bug
Petr Horáček has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 4: Verified+1
Passed unit net*.py tests and funtional network tests without a regression.
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: hooks: introduce before/after_get_stats hook points
..
Patch Set 2:
the after_ hook below works as it should.
#!/usr/bin/python
import hooking
stats =
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove unused 'output' value in response
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: tests: add tests for disk hotplug/hotunplug
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: vm: remove _reportError
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: call stop_event_loop upon exit
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: caps: report capabilities on UNKNOWN OS
..
caps: report capabilities on UNKNOWN OS
The capabilities reporting (getCapabilities API) does
logic on libvirt
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: use the response module
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: caps: report capabilities on UNKNOWN OS
..
Patch Set 1: Verified+1
verification:
on RHEL 7.2 host, renamed /etc/redhat-release. This is sufficient to fool
Roman Mohr has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/44028/2/tests/tcTests.py
File tests/tcTests.py:
Line 105:
automat...@ovirt.org has posted comments on this change.
Change subject: network: allow custom bondOption
..
Patch Set 4:
* Update tracker::#1234867::OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: configurators: persist custom bond option
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: introduce before/after_get_stats hook points
..
Patch Set 2:
* Update tracker::#1234867::OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK,
Petr Horáček has posted comments on this change.
Change subject: hooks: introduce before/after_get_stats hook points
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43274/1/vdsm/API.py
File vdsm/API.py:
Line 1302:
Petr Horáček has posted comments on this change.
Change subject: hooks: introduce before/after_get_stats hook points
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/43274
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: network: wait for a bridge to appear before disabling IPv6 on it
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43583
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: caps: report capabilities on UNKNOWN OS
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: virt: fully convert to response module
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS
..
Patch Set 4: Verified+1
verified with 44232:
verification:
on RHEL 7.2 host, renamed /etc/redhat-release. This
Dan Kenigsberg has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 2: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/44220
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 1:
I prefer postively-named options, and find
--check-fqdn False
clearer than
--nocheck-fqdn
it might only
Dan Kenigsberg has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 3: Code-Review+2
vdsm-store-net-config is still much needed. Do not drop it.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 3: Continuous-Integration+1
merging per QE/PM approval.
--
To view, visit https://gerrit.ovirt.org/43254
To
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm-reg: remove the sub-project
..
Patch Set 4:
* Update tracker::#1231379::OK
* Set MODIFIED::bug 1231379#1231379IGNORE, not oVirt prod but Red
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-reg: remove the sub-project
..
vdsm-reg: remove the sub-project
As vdsm-reg is deprecated. At moment vdsm-tool has
register verb which executes
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: switch to response.error()
..
vm: switch to response.error()
response.error() offers a nicer and cleaner
way to report error responses instead of
Dan Kenigsberg has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 20: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38268
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: use node name and fqdn when needed
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: simplify check fqdn
..
Patch Set 2:
I prefer to have --nocheck-fqdn as the default is always True but if you prefer
this way, it's not a
automat...@ovirt.org has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Douglas Schilling Landgraf has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/44219
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix mount point issue for snapshot thin lv
..
Patch Set 1: Code-Review-1
This patch is not required since the blivet bug is already fixed. This patch
can
Dan Kenigsberg has posted comments on this change.
Change subject: caps: report capabilities on UNKNOWN OS
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44232
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: report capabilities on UNKNOWN OS
..
caps: report capabilities on UNKNOWN OS
The capabilities reporting (getCapabilities API) does
logic on
automat...@ovirt.org has posted comments on this change.
Change subject: caps: report capabilities on UNKNOWN OS
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/32459
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: let Engine start a VM on an UNKOWN OS
..
virt: let Engine start a VM on an UNKOWN OS
This superflouse validation was introduced as a bandage to
automat...@ovirt.org has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Francesco Romani has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43770/4/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 630:
automat...@ovirt.org has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/43770/4/vdsm/clientIF.py
File vdsm/clientIF.py:
Francesco Romani has posted comments on this change.
Change subject: vm: switch to response.error()
..
Patch Set 20: Verified+1
mechanical translation. response.error() is tested enough nowadays.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: tcTests: Fix problem of left over bridges
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/44028/2/tests/tcTests.py
File tests/tcTests.py:
Line 105:
Dan Kenigsberg has posted comments on this change.
Change subject: register: remove legacy code
..
Patch Set 3: Code-Review-1
(1 comment)
nit about log message and docstring.
note that I've fixed the commit message.
96 matches
Mail list logo
