Piotr Kliczewski has posted comments on this change.
Change subject: stomp: allow to mock monotonic_time method
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/43745/2/lib/yajsonrpc/stomp.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: storage: skip test_mkIsoFs on MountError 'failed to setup loop
device'
..
Patch Set 1:
Please improve the commit message.
"""this test fails quite often on
Dan Kenigsberg has submitted this change and it was merged.
Change subject: safelease: Fix wrong parameter name
..
safelease: Fix wrong parameter name
smpstop.sh expects a storage domain uuid, not a pool id. Updat the
Dan Kenigsberg has submitted this change and it was merged.
Change subject: safelease: Improve logging when releasing lock
..
safelease: Improve logging when releasing lock
We used to log that "Cluster lock was released
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: fix _emergencyNetworkCleanup
..
net: fix _emergencyNetworkCleanup
The code assumed that 'bridged' was always a part of the network
attributes. It
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix _emergencyNetworkCleanup
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: net: fix _emergencyNetworkCleanup
..
Patch Set 1: Verified+1
simple enough to skip verification
--
To view, visit https://gerrit.ovirt.org/45703
To
Ido Barkan has uploaded a new change for review.
Change subject: net: remove unneeded log
..
net: remove unneeded log
This log message is very common and doesn't say a lot. Reducing
verbosity here will do no harm and will clean
Michal Skrivanek has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
I hope you all realize we have a 3.6 RC build next week. We can't go back and
forth multiple
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: check whether the connection is still open before
processing
..
Patch Set 1:
Yaniv, can you be a bit more expressive why you do not like this
Piotr Kliczewski has posted comments on this change.
Change subject: integration: let client factory to construct xmlclient
..
Patch Set 1:
Integration tests are not run during the build so whenever I change something
in the
Ido Barkan has posted comments on this change.
Change subject: net: remove unneeded log
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46266
To unsubscribe, visit https://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: ignore empty frame
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42919/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Remove QEMU passthrough hack in ppc64
..
Patch Set 1: Code-Review+2
looks OK.
--
To view, visit https://gerrit.ovirt.org/46265
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: automation: add build_artifacts
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/46135/3/automation/check-patch.sh
File
Piotr Kliczewski has posted comments on this change.
Change subject: Move jobs.py to lib/vdsm
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46141
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: storage: skip test_mkIsoFs on MountError 'failed to setup loop
device'
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46244
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: safelease: Increase spmprotect timeouts
..
safelease: Increase spmprotect timeouts
When spmprotect.sh fail to renew the lease, it start a fencing
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Increase spmprotect timeouts
..
Patch Set 4:
* Update tracker::#1222564::OK
* Set MODIFIED::bug 1222564#1222564IGNORE, not oVirt prod
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Increase spmprotect timeouts
..
Patch Set 3:
* Update tracker::#1222564::OK
* Check Bug-Url::OK
* Check Public Bug::#1222564::OK, public bug
*
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Improve logging when releasing lock
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has posted comments on this change.
Change subject: safelease: Fix wrong parameter name
..
Patch Set 6:
indeed
releaseLockCommand = [freeLockUtil, self._sdUUID]
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Fix wrong parameter name
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Remove unhelpful debug code
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: safelease: Remove unhelpful debug code
..
safelease: Remove unhelpful debug code
Remove unhelpful debug function that logged an important message only
Yaniv Bronhaim has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
(3 comments)
added few replies - please do the change and work with a wrapper, it won't
require
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: change default protocol
..
Patch Set 1:
OK
--
To view, visit https://gerrit.ovirt.org/43457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/45738/15/tests/tasksetTests.py
File tests/tasksetTests.py:
Ido Barkan has posted comments on this change.
Change subject: automation: add build_artifacts
..
Patch Set 3:
/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/tests/nosetests.xml
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Remove QEMU passthrough hack in ppc64
..
Patch Set 1:
* Update tracker::#1122627::OK
* Check Bug-Url::OK
* Check Public Bug::#1122627::OK, public
Hello Vitor de Lima, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/46265
to review the following change.
Change subject: virt: Remove QEMU passthrough hack in ppc64
..
virt:
Martin Polednik has posted comments on this change.
Change subject: virt: Remove QEMU passthrough hack in ppc64
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46265
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: remove unneeded log
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: ignore empty frame
..
Patch Set 1:
(1 comment)
can you add a test so I'll understand how empty frame can appear?
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: change default protocol
..
Patch Set 1: Code-Review-1
you must explain more in the commit message - what happened before, why we used
different value and
Nir Soffer has posted comments on this change.
Change subject: storage: skip test_mkIsoFs on MountError 'failed to setup loop
device'
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/46244/1/tests/mkimageTests.py
Piotr Kliczewski has posted comments on this change.
Change subject: tests: ignore empty frame
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42919/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 355:
Ido Barkan has posted comments on this change.
Change subject: net: mark test_getVdsStats as broken
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46240
To unsubscribe, visit
Meni Yakove has posted comments on this change.
Change subject: netinfo:Report host DNSs in getVdsCaps
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/46233
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo:Report host DNSs in getVdsCaps
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
(10 comments)
https://gerrit.ovirt.org/#/c/45738/15/debian/control
File debian/control:
Line 16:
Nir Soffer has posted comments on this change.
Change subject: tests: Generalize sdm_indirection_tests
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/46259/1/tests/sdm_indirection_tests.py
File
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/45738/15/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 648
Piotr Kliczewski has posted comments on this change.
Change subject: Update v2v to use new jobs infrastructure
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45382
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: init: wait for ipv4 with monitoring
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46148/5/vdsm.spec.in
File vdsm.spec.in:
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: check whether the connection is still open before
processing
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/42920
To
Yaniv Bronhaim has posted comments on this change.
Change subject: integration: let client factory to construct xmlclient
..
Patch Set 1: Code-Review+1
did it work before?
--
To view, visit https://gerrit.ovirt.org/44426
To
Yaniv Bronhaim has posted comments on this change.
Change subject: integration: let client factory to construct xmlclient
..
Patch Set 1:
how do you run the integration test btw? any output?
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 15:
ok, let's try switching the order of taskset. Will do a quick check before to
upload a new
Ido Barkan has posted comments on this change.
Change subject: tests: let nose produce an xunit xml format.
..
Patch Set 2:
/home/jenkins/workspace/vdsm_master_check-patch-fc22-x86_64/vdsm/tests/nosetests.xml
--
To view,
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Michal Skrivanek has posted comments on this change.
Change subject: graphics: use global displayNetwork if no local specified
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/46224/3/vdsm/virt/vmdevices/graphics.py
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 16: Verified+1
v16:
- switch back to the wrapper path we found broken in v11 (see below)
- add tests
automat...@ovirt.org has posted comments on this change.
Change subject: ifcfg: make removeNic cope with a missing ifcfg file
..
Patch Set 3:
* Update tracker::#1256252::OK
* Check Bug-Url::OK
* Check Public Bug::#1256252::OK,
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/46280
to review the following change.
Change subject: ifcfg: only deal gracefully with ENOENT in removeNic
..
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: make removeNic cope with a missing ifcfg file
..
Patch Set 2:
(1 comment)
ENOENT is handled in a following patch.
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: make removeNic cope with a missing ifcfg file
..
Patch Set 3:
Again, CI failure is unrelated.
10:30:37 test_mkFloppyFs(None)
automat...@ovirt.org has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 17:
* Update tracker::#1247075::OK
* Check Bug-Url::OK
* Check Public Bug::#1247075::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: storage: skip test_mkIsoFs on MountError 'failed to setup loop
device'
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
Petr Horáček has posted comments on this change.
Change subject: storage: skip test_mkIsoFs on MountError 'failed to setup loop
device'
..
Patch Set 1:
Builded, installed, mkimageTests.py passed ok.
With:
raise
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 16:
(3 comments)
https://gerrit.ovirt.org/#/c/45738/16/lib/vdsm/constants.py.in
File
Ido Barkan has posted comments on this change.
Change subject: ifcfg: make removeNic cope with a missing ifcfg file
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45932
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 18:
* Update tracker::#1247075::OK
* Check Bug-Url::OK
* Check Public Bug::#1247075::OK, public
Petr Horáček has posted comments on this change.
Change subject: net: init: wait for ipv4 with monitoring
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/46148/5/vdsm.spec.in
File vdsm.spec.in:
Line 857:
automat...@ovirt.org has posted comments on this change.
Change subject: net: init: wait for ipv4 with monitoring
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 18: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Remove unneeded "features" configuration
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
automat...@ovirt.org has posted comments on this change.
Change subject: multipath: Replace specific device sections with all_devs
section
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: multipath: Replace specific device sections with all_devs
section
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/45735
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: multipath: Remove unneeded "features" configuration
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/45734
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 18:
(7 comments)
https://gerrit.ovirt.org/#/c/45738/18/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Ido Barkan has posted comments on this change.
Change subject: ifcfg: only determine and write HWADDR in removeNic if enabled
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46281
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: ifcfg: only deal gracefully with ENOENT in removeNic
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46280
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: vdscli: map invocation params to dictionary
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45429
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: netinfo:Report host DNSs in getVdsCaps
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46233/2/lib/vdsm/netinfo.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 19:
* Update tracker::#1247075::OK
* Check Bug-Url::OK
* Check Public Bug::#1247075::OK, public
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45738
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 19: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45738/19/vdsm/vdsm
File vdsm/vdsm:
Line
Meni Yakove has posted comments on this change.
Change subject: netinfo:Report host DNSs in getVdsCaps
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46233/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 581:
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo:Report host DNSs in getVdsCaps
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Barak Korren has posted comments on this change.
Change subject: core: moving InquireNotSupportedError to storage_exception.py
..
Patch Set 3:
I didn't find the re-triggered jobs so I re-triggered myself:
automat...@ovirt.org has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 20:
* Update tracker::#1247075::OK
* Check Bug-Url::OK
* Check Public Bug::#1247075::OK, public
Meni Yakove has posted comments on this change.
Change subject: netinfo:Report host DNSs in getVdsCaps
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/46233
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: graphics: use global displayNetwork if no local specified
..
Patch Set 4:
* Update tracker::#1261007::OK
* Check Bug-Url::OK
* Check Public
Petr Horáček has abandoned this change.
Change subject: Makefile: optionally disable PEP8 and Pyflakes
..
Abandoned
There is no need for this patch
--
To view, visit https://gerrit.ovirt.org/46044
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Makefile: optionally disable PEP8 and Pyflakes
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: automation: add build_artifacts
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cleanup: Remove unused pidfile option and argument parsing code
..
cleanup: Remove unused pidfile option and argument parsing code
Since we move to
automat...@ovirt.org has posted comments on this change.
Change subject: cleanup: Remove unused pidfile option and argument parsing code
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
Francesco Romani has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 18: Verified+1
only changes in tests since last verification. Jenkins likes them, hence V+1
again.
Petr Horáček has posted comments on this change.
Change subject: net: init: wait for ipv4 with monitoring
..
Patch Set 6: Verified+1
Module itself was tested: http://fpaste.org/268363/48720214/
It working OK inside VDSM as
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 3: Code-Review+1
makes sense. Please check also that the schema allows us to skip this
Francesco Romani has posted comments on this change.
Change subject: host stats: Add onlineCpus to vdsStats
..
Patch Set 2:
(2 comments)
Draft -> no score
I'm fine with the concept, but we should polish the Engine interface.
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 3:
please add one unit test or one functional test
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 18:
(8 comments)
Nice, few things can be improved.
https://gerrit.ovirt.org/#/c/45738/18/lib/vdsm/utils.py
Roman Mohr has posted comments on this change.
Change subject: host stats: Add onlineCpus to vdsStats
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46270
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: jsonrpc: check whether the connection is still open before
processing
..
Patch Set 1:
(1 comment)
sorry, missed my comment
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Add onlineCpus to vdsStats
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: check whether the connection is still open before
processing
..
Patch Set 1:
(1 comment)
Yaniv Bronhaim has posted comments on this change.
Change subject: scale: limit cpu usage using cpu-affinity
..
Patch Set 17:
I gave few comments in ps16, think you can avoid the constants part and some
wonders about the new
1 - 100 of 267 matches
Mail list logo
