automat...@ovirt.org has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4:
* #1131192::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1131192::OK, public bug
*
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 1:
(1 comment)
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 6:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/48308/5/vdsm/storage/storageServer.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: Remove usage of deathSignal
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Moving cpopen import to compat to allow working with python 3
..
Moving cpopen import to compat to allow working with python 3
Once python3-copen will be
Idan Shaby has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: executor based thread factory
..
jsonrpc: executor based thread factory
Creating new thread for every request is not efficient so we introduce
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2:
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK, public bug
*
Sandro Bonazzola has posted comments on this change.
Change subject: Added fc23 repos to the automation scripts
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/48180
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Added fc23 repos to the automation scripts
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: fix missing dep ethtool
..
automation: fix missing dep ethtool
Fix
http://jenkins.ovirt.org/job/vdsm_3.5_build-artifacts-el6-x86_64/1/console
by
automat...@ovirt.org has posted comments on this change.
Change subject: automation: fix missing dep ethtool
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url
automat...@ovirt.org has posted comments on this change.
Change subject: asyncore: remove misleading log entry
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has uploaded a new change for review.
Change subject: asyncore: remove misleading log entry
..
asyncore: remove misleading log entry
From time to time I can see misleading warning in the logs:
Petr Horáček has posted comments on this change.
Change subject: net: tests: support iperf3 for performance tests
..
Patch Set 23: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/46448/23/lib/vdsm/ipwrapper.py
File
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48308/6//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: Moving cpopen import to compat to allow working with python 3
..
Patch Set 1: Code-Review-1
(1 comment)
Nice, but we are not ready for this yet.
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 5:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Sandro Bonazzola has posted comments on this change.
Change subject: Added fc23 repos to the automation scripts
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/48180/3/automation/build-artifacts.repos.fc23
File
Sandro Bonazzola has posted comments on this change.
Change subject: automation: fix missing dep ethtool
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48379
To unsubscribe, visit
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48196
to review the following change.
Change subject: executor: introduce the executor library
..
executor:
Piotr Kliczewski has posted comments on this change.
Change subject: executor: Fix thread-unsafe call
..
Patch Set 2: Verified+1
Verified by performance team
--
To view, visit https://gerrit.ovirt.org/48197
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: executor: Fix thread-unsafe call
..
Patch Set 2: -Verified
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK, public
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Code-Review+1 -Verified
Idan, can you describe (in details) how you verified this patch?
--
To view,
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2: Verified+1
Verified by performance team.
--
To view, visit https://gerrit.ovirt.org/48198
To
Allon Mureinik has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/31162
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: executor: introduce the executor library
..
Patch Set 2: -Verified
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK,
Piotr Kliczewski has posted comments on this change.
Change subject: schedule: Introduce scheduling library
..
Patch Set 2: Verified+1
Verified be performance team.
--
To view, visit https://gerrit.ovirt.org/48195
To
Piotr Kliczewski has posted comments on this change.
Change subject: executor: introduce the executor library
..
Patch Set 2: Verified+1
Verified by performance team.
--
To view, visit https://gerrit.ovirt.org/48196
To
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48197
to review the following change.
Change subject: executor: Fix thread-unsafe call
..
executor: Fix
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Francesco Romani has abandoned this change.
Change subject: lib: executor: pack items in a Task tuple
..
Abandoned
no longer needed after the new direction took on 48191
--
To view, visit https://gerrit.ovirt.org/48192
To
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48195
to review the following change.
Change subject: schedule: Introduce scheduling library
..
schedule:
automat...@ovirt.org has posted comments on this change.
Change subject: schedule: Introduce scheduling library
..
Patch Set 2: -Verified
* #1279950::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279950::OK,
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48308/5/vdsm/storage/storageServer.py
automat...@ovirt.org has posted comments on this change.
Change subject: Adding toolTests.py to python3 check modules
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: Moving cpopen import to compat to allow working with python 3
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
automat...@ovirt.org has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 1:
(1 comment)
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/48308/4/tests/storageServerTests.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: lib: executor: pack items in a Task tuple
..
Patch Set 5:
* #1250839::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/48192
To
Francesco Romani has posted comments on this change.
Change subject: executor: introduce the executor library
..
Patch Set 2: Code-Review+2
looks fine. New code, well covered by tests, very little chance to break
something :)
Francesco Romani has posted comments on this change.
Change subject: executor: Fix thread-unsafe call
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48197
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: schedule: Introduce scheduling library
..
Patch Set 2: Code-Review+2
looks fine. New code, well covered by tests, very little chance to break
something :)
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 2: Code-Review-1
(1 comment)
I'm fine with the concept, but I found an unexpected change. Could be
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 7:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/48308/6//COMMIT_MSG
Commit Message:
Line 9: There
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1: Verified+1
As promised.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 5: Code-Review+2
thanks for the updates!
--
To view, visit
Ondřej Svoboda has uploaded a new change for review.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
networkTests: ensure that the 'primary' bonding option is recognized
Change-Id:
automat...@ovirt.org has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN,
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: set OVS devices UP
..
hooks: ovs: set OVS devices UP
Set all attached and created devices explicitly UP.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48389
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
networkTests: ensure that the 'primary' bonding option is recognized
automat...@ovirt.org has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE,
Francesco Romani has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46934
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 9: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/46846/9//COMMIT_MSG
Commit
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 7: Code-Review-1
(1 comment)
Nice, just one space missing.
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48308/7/vdsm/storage/storageServer.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 6:
* #1277879::Update tracker: OK
* Set MODIFIED::bug
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 8:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Ala Hino has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/48308/8//COMMIT_MSG
Commit Message:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 9:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 8: Code-Review+1
Thanks Ala!
Waiting for Sahina review before approving.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: ova should support zip and extracted directory formats
..
v2v: ova should support zip and extracted directory formats
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 8: -Code-Review
(1 comment)
One more thing - the title needs update as well.
Nir Soffer has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 8: Code-Review+2 Verified+1
Removed unintended whitespace change.
--
To view, visit https://gerrit.ovirt.org/47863
To
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: FakeLVM add lvPath test
..
tests: FakeLVM add lvPath test
Test the lvPath function. Allow FakeLVM to be created without a
temporary directory
automat...@ovirt.org has posted comments on this change.
Change subject: tests: FakeLVM add lvPath test
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48399
to review the following change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 1: Verified-1
* #1184497::Update tracker: OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
* #1279740::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279740::OK, public bug
*
automat...@ovirt.org has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 11:
* #1264003::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Bala.FA has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43821/6/vdsm/gluster/exception.py
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6: Code-Review-1
Please follow approach as it is used in volumeSnapshotConfigSet.
--
Milan Zamazal has posted comments on this change.
Change subject: gitignore: Missing autogenerated files added
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48328
To unsubscribe, visit
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File
Roman Mohr has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/46269/9/tests/hoststatsTests.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Francesco Romani has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3: Code-Review+2
(1 comment)
please plan some tests for this patch. It is fine if
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 4:
* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK,
Shahar Havivi has posted comments on this change.
Change subject: v2v: ova should support zip and extracted directory formats
..
Patch Set 3:
sure
ova needs tests as well...
--
To view, visit https://gerrit.ovirt.org/48129
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 6:
(1 comment)
I changed the schema to follow the approach used in volumeSnapshotConfigSet.
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Francesco Romani has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 2: Code-Review+2
raising score after BZ was added
--
To view, visit https://gerrit.ovirt.org/48287
To
David Caro has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 9:
(2 comments)
https://gerrit.ovirt.org/#/c/48268/9/automation/lago-control.sh
File
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
@Oved, it seems that 3.6 was not added to the stable branch set, that should be
the reason why CI
Francesco Romani has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46270/7/vdsm/rpc/vdsmapi-schema.json
File
Francesco Romani has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 12: Code-Review+1
thanks for the updates! At first glance looks fine now, will have another
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscribe,
Ala Hino has posted comments on this change.
Change subject: gluster: Set mount path based on gluster volume info
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/48308/2/tests/storageServerTests.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4: Code-Review+2
raising score after BZ was added
--
To view, visit https://gerrit.ovirt.org/48293
To
1 - 100 of 202 matches
Mail list logo