automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: support iperf3 for performance tests
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: test tc upper limit using iperf
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46708
To unsubscribe, visit https://gerr
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://ge
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48449
To unsubscribe, vis
automat...@ovirt.org has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 1:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: check operation result for vm nic hotunplug
..
vm: check operation result for vm nic hotunplug
After detaching a device we need to verify that this device
Ido Barkan has posted comments on this change.
Change subject: net: tests: test tc upper limit using iperf
..
Patch Set 23: Verified+1
--
To view, visit https://gerrit.ovirt.org/46449
To unsubscribe, visit https://gerrit.ovirt
Ido Barkan has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48451
To unsubscribe
Ido Barkan has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48340
To unsubscribe
automat...@ovirt.org has posted comments on this change.
Change subject: spec: install bonding-defaults.json with 644 permissions, not
600
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no B
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: install bonding-defaults.json with 644 permissions, not
600
..
spec: install bonding-defaults.json with 644 permissions, not 600
This way make c
Ondřej Svoboda has posted comments on this change.
Change subject: net: tests: test network's iface
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48366/2/tests/functional/networkTests.py
File tests/fun
Ondřej Svoboda has posted comments on this change.
Change subject: net: tests: test tc upper limit using iperf
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46449
To unsubscribe, visit https://gerri
Ondřej Svoboda has posted comments on this change.
Change subject: net: tests: test tc upper limit using iperf
..
Patch Set 20:
(1 comment)
You're right.
https://gerrit.ovirt.org/#/c/46449/20/tests/tcTests.py
File tests/tcTes
Ondřej Svoboda has posted comments on this change.
Change subject: net: tests: support iperf3 for performance tests
..
Patch Set 23: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/46448/23/tests/nettestlib.py
File test
automat...@ovirt.org has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 2: -Verified
* #1262496::Update tracker: OK
* Check Bug-Url::OK
* Check
Ondřej Svoboda has posted comments on this change.
Change subject: bonding defaults: for validation, we need to be aware of all
options
..
Patch Set 1:
The CI hasn't picked this patch apparently, but I ran unit tests and funct
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1: Verified+1
Unit tests and functional tests passed with no regression, but
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
Here the spec file after configuring for fedora build:
# Build types
%global rhev_build no
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 5:
This version fixes the examples in the commit message.
--
To view, visit https://gerrit.ovirt.org/
automat...@ovirt.org has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 5: Verified+1
This version fixes with_hooks global, and remove unneeded quotes for
gluster_mgmt condit
automat...@ovirt.org has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/4/configure.ac
File configure.ac:
Line 53: ,
Li
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 4:
Fix the issues I commented about and some more. Seems to work now.
--
To view, visit https://gerri
automat...@ovirt.org has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Nir Soffer has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 6:
CI failure on fedora 23 is not related (missing package).
--
To view, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 6:
This version change the default with_gluster_mgmt to avoid breaking the fedora
build.
--
To view, v
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 3:
(6 comments)
https://gerrit.ovirt.org/#/c/48446/3/configure.ac
File configure.ac:
Line 77
Line 78
Javier Coscia has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovi
Amador Pahim has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
Roy, can we have vdsm log showing the entire flow?
--
To view, visit https://gerrit.ovirt.org/48217
To unsubs
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/3/configure.ac
File configure.ac:
Line 63: )],
Nir Soffer has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48133/2/vdsm/mkimage.py
File vdsm/mkimage.py:
Line 123:
Nir Soffer has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 3: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/48133/3/tests/cmdutilsTests.py
File tests/cmdutil
automat...@ovirt.org has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Amador Pahim has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 2: Code-Review-1
(1 comment)
Just a minor issue. The rest looks great.
Thank you.
https://gerrit.ovirt.
Nir Soffer has posted comments on this change.
Change subject: Remove unused sd setMetadata and rotateFiles
..
Patch Set 5:
Thanks for this cleanup!
Can you separate the removal of rotateFiles and setMetadata?
I want to check
automat...@ovirt.org has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Ramesh N has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48449
To unsubscribe, visit https://
automat...@ovirt.org has posted comments on this change.
Change subject: mkimage: lib: add and use umaskset helper
..
Patch Set 3:
* #1278414::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278414::OK, public bug
Amador Pahim has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 1: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/48450/1//COMMIT_MSG
Commit Message:
Line 9:
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/3/configure.ac
File configure.ac:
Line 63:
automat...@ovirt.org has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48452
to review the following change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
spec
Yeela Kaplan has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 1: Verified+1
Same as master.
--
To view, visit https://gerrit.ovirt.org/48452
To unsubscribe, vi
automat...@ovirt.org has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least
automat...@ovirt.org has posted comments on this change.
Change subject: Remove unused sd setMetadata and rotateFiles
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-U
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48451
to review the following change.
Change subject: networkTests: ensure that the 'primary' bonding option is
recognized
..
automat...@ovirt.org has posted comments on this change.
Change subject: Remove unused sd setMetadata and rotateFiles
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Javier Coscia has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: Remove unused sd setMetadata and rotateFiles
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Javier Coscia has uploaded a new change for review.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Hook: ide2sata: To switch IDE disks to SATA
Add the ability to use SATA/AHCI disks while creating them as IDE.
C
automat...@ovirt.org has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Hello Piotr Kliczewski, Bala.FA, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48449
to review the following change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
automat...@ovirt.org has posted comments on this change.
Change subject: build: Introduce --enable-gluster-mgmt option
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 11: Code-Review+1
question answered. We will fix my concern on a later patch.
Martin, please make jenkins happy w
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/46912/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 773:
Line
Martin Polednik has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/46912/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 773:
Line 7
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
gluster: Added VDSM verb to stop gluster related processes
Added a verb which stops the g
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url f
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 7: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/43821
To unsubscri
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Francesco Romani has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46897
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46897/4/vdsm/caps.py
File vdsm/caps.py:
Line 217: arch
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/46912/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 773:
Line
Martin Polednik has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/46912/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 773:
Line 7
Francesco Romani has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:
Li
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 11: Code-Review-1
(1 comment)
looks fine, but I have a question inside, hence -1 for visibility
https://gerrit.o
Martin Sivák has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
Yep that is what I would expect. When you instruct sanlock to force remove a
lockspace it kills the clients
Ondřej Svoboda has posted comments on this change.
Change subject: spec: install bonding-defaults.json with 644 permissions, not
600
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/46401
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
Sanlock sees qemu pid is using a path on one of its a resource(the sd) and when
it needs to remove the lockspac
Tomas Jelinek has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 6: Code-Review-1
there is a missing part of how to setup the initial downtime. The initial
should
Francesco Romani has submitted this change and it was merged.
Change subject: sampling: fix semaphore misusing
..
sampling: fix semaphore misusing
We should release the internal _sampling semaphore only
if we acquired it succes
automat...@ovirt.org has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 3:
* #1250839::Update tracker: OK
* Set MODIFIED::bug 1250839#1250839IGNORE, not oVirt prod but vdsm
Dan Kenigsberg has posted comments on this change.
Change subject: automation: auto add required build dependencies
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48408/4/automation/check-patch.packages
File automati
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: fix semaphore misusing
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48348
To unsubscribe, visit https://gerrit.ovirt.org/
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
First, we need a fix asap and the refcount patch doesn't look like its going to
be merged soon enough.
I'm not
Francesco Romani has submitted this change and it was merged.
Change subject: jsonrpc: executor based thread factory
..
jsonrpc: executor based thread factory
Creating new thread for every request is not efficient so we introdu
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/48293
To unsubscribe, visit https:
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 5:
* #1279740::Update tracker: OK
* Set MODIFIED::bug 1279740#1279740IGNORE, not oVirt prod bu
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: executor based thread factory
..
Patch Set 4:
run CI jobs manually
--
To view, visit https://gerrit.ovirt.org/48293
To unsubscribe, visit https://g
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48404/1//COMMIT_MSG
Commit Message:
Line 14: This chan
Milan Zamazal has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/48404/1/tests/vmTests.py
File tests/vmTests.py:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
automat...@ovirt.org has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 3:
* #1279740::Update tracker: OK
* Set MODIFIED::bug 1279740#1279740IGNORE, not oVirt prod but vdsm
Francesco Romani has submitted this change and it was merged.
Change subject: scheduler: use single instance
..
scheduler: use single instance
We used to have one instance of a scheduler used for periodic
operations. With this
Francesco Romani has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 2:
run CI jobs manually (again...)
--
To view, visit https://gerrit.ovirt.org/48287
To unsubscribe, visit https:
Francesco Romani has posted comments on this change.
Change subject: scheduler: use single instance
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/48287
To unsubscribe, visit https://gerrit
Nir Soffer has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1: Code-Review-1
(1 comment)
Needs further investigation.
https://gerrit.ovirt.org/#/c/48217/1//COMMIT_MSG
Commi
Francesco Romani has posted comments on this change.
Change subject: automation: auto add required build dependencies
..
Patch Set 4: Code-Review+1
Looks OK
--
To view, visit https://gerrit.ovirt.org/48408
To unsubscribe, vis
Martin Sivák has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48217/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: When attachin
automat...@ovirt.org has posted comments on this change.
Change subject: faqemu: refactor and update
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
1 - 100 of 158 matches
Mail list logo
