Change in vdsm[master]: stomp: message tracking do not clean properly

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: stomp: message tracking do not clean properly .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: stomp: improve message id handling during response send

2015-11-25 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: stomp: improve message id handling during response send .. stomp: improve message id handling during response send Signed-off-by: pkliczewski

Change in vdsm[master]: stomp: improve message id handling during response send

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: stomp: improve message id handling during response send .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: code coverage: change approach how to enable it

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: VolumeMetadata: Metadata read utils

2015-11-25 Thread alitke
Adam Litke has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/blockVolume.py File

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 10: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: renaming device unplug related function

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: renaming device unplug related function .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: VolumeMetadata: volume share utilities

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: volume share utilities .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48473/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2691:

Change in vdsm[master]: tests: Adding coverage check for unit tests

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.6]: image: copy - set VM metadata images format to RAW

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: image: copy - set VM metadata images format to RAW .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49144 To unsubscribe, visit

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 4: (10 comments) https://gerrit.ovirt.org/#/c/48880/4/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: VolumeMetadata: move newMetadata

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newMetadata .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: VolumeMetadata: Move getParentVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getParentVolume .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getImageVolumes .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: code coverage: change approach how to enable it

2015-11-25 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 1: Code-Review-1 (1 comment) change looks ok please fix the spelling

Change in vdsm[master]: VolumeMetadata: move refreshVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move refreshVolume .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: hsm.py: Deprecate getVGList

2015-11-25 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: hsm.py: Deprecate getVGList .. hsm.py: Deprecate getVGList oVirt Engine commit 4312bfd removed all the usages of getVGList from the engine's code. Since

Change in vdsm[master]: hsm.py: Deprecate getVGList

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hsm.py: Deprecate getVGList .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: VolumeMetadata: Move simple metadata getters and setters

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move simple metadata getters and setters .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: VolumeMetadata: move refreshVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move refreshVolume .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Metadata read utils

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move the getParent API

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move the getParent API .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getImageVolumes .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: metadata write utils

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: metadata write utils .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: VolumeMetadata: move newMetadata

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newMetadata .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move isLeaf, setLeaf and dependencies

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: VolumeMetadata: Move recheckIfLeaf into *Metadata class

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: volume share utilities

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: volume share utilities .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: VolumeMetadata: Move getParentVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getParentVolume .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-25 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: Code-Review-1 (11 comments) I can't get rid of feeling that the implementation is too complicated for the

Change in vdsm[master]: build: Cleanup conditionals in the build system

2015-11-25 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: build: Cleanup conditionals in the build system .. Patch Set 18: (3 comments) https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in File vdsm.spec.in: Line 46

Change in vdsm[master]: code coverage: change approach how to enable it

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 2: (2 comments) Thanks Petr! Looks good, please see the comments.

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

2015-11-25 Thread alitke
Adam Litke has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/41998/17/vdsm/storage/blockVolume.py File

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newVolumeLease .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: StorageDomain: Add get_manifest

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: StorageDomain: Add get_manifest .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: devices: drop support for ancient Engines

2015-11-25 Thread smelamud
Shmuel Leib Melamud has posted comments on this change. Change subject: vm: devices: drop support for ancient Engines .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49173 To unsubscribe, visit

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-25 Thread mbetak
Martin Betak has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: I'm going to have to agree with Milan. We need to ask ourselves, what we are getting in exchange for all this

Change in vdsm[master]: hsm.py: Deprecate getVGList

2015-11-25 Thread alitke
Adam Litke has posted comments on this change. Change subject: hsm.py: Deprecate getVGList .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48998 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: Remove reporting of bond custom options from RunningConfig

2015-11-25 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: Remove reporting of bond custom options from RunningConfig .. Patch Set 2: Code-Review+1 Well done! -- To view, visit https://gerrit.ovirt.org/49081 To

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 6: Nice work! See the comments. -- To view, visit https://gerrit.ovirt.org/48880 To unsubscribe, visit

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 8: Code-Review+1 (2 comments) Very nice, waiting for Francesco approval.

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 12: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line 1279:

Change in vdsm[master]: startup: Change system default encoding to utf8

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Please review latest change. -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe,

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: Sahina, your ack is welcome. -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: > Uploaded patch set 9. Fixed identation -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 10: Code-Review-1 This should be squashed with https://gerrit.ovirt.org/49038 -- To view, visit

Change in vdsm[master]: tests: Adding coverage check for unit tests

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 4: It does not seem that ANY test has been running: 16:18:11 Complete! 16:18:11 + coverage html

Change in vdsm[master]: vm: renaming device unplug related function

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: renaming device unplug related function .. Patch Set 5: Code-Review-1 This rename belongs to https://gerrit.ovirt.org/48473 -- To view, visit

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newVolumeLease .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh File

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: (1 comment) Nice, see the comment about breaking long lines.

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1260: Line

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 5: Code-Review+1 (1 comment) Looks good, one minor comment.

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Fred, can you test this? -- To view, visit https://gerrit.ovirt.org/49009 To unsubscribe, visit

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49009 To unsubscribe, visit

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1260: Line

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 3: Code-Review+1 Nice! Waiting for Francesco and Ido. -- To view, visit https://gerrit.ovirt.org/49104 To

Change in vdsm[master]: mkimage: check image attributes after creation

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 5: Code-Review+1 (1 comment) Looks good, one minor comment.

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: Code-Review+2 Thanks Ala! -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: Piotr, please approve the infra change. -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

2015-11-25 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46692 To unsubscribe,

Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple

2015-11-25 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: Code-Review+1 okay -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit

Change in vdsm[master]: hooks: ovs: skip non-vNic device's XML

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: skip non-vNic device's XML .. Patch Set 2: Code-Review-1 (1 comment)

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-25 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh File

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

2015-11-25 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: hooks: hostusb: make sudoers rule more specific .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48963 To unsubscribe, visit

Change in vdsm[master]: net: split netinfo module

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (8 comments) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line 1261:

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 11: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line

Change in vdsm[master]: init: configure multipath on upgrade from ovirt-3.3 and 3.4

2015-11-25 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48106 To unsubscribe,

Change in vdsm[master]: spec: Require newer multipath version

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer multipath version .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/49113/3//COMMIT_MSG Commit Message: Line 7: spec: Require newer

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 10: Code-Review+1 Waiting for Francesco approval. -- To view, visit https://gerrit.ovirt.org/48473

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

2015-11-25 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit

Change in vdsm[master]: net: remove editNetwork old API

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48910 To unsubscribe, visit

Change in vdsm[master]: VolumeMetadata: Metadata read utils

2015-11-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41846 To unsubscribe, visit

Change in vdsm[master]: net: remove delNetwork old API

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove delNetwork old API .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48911 To unsubscribe, visit

  1   2   3   >