gerrit-hooks has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: improve message id handling during response send
..
stomp: improve message id handling during response send
Signed-off-by: pkliczewski
gerrit-hooks has posted comments on this change.
Change subject: stomp: improve message id handling during response send
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: Metadata read utils
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/blockVolume.py
File
gerrit-hooks has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 10:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: vm: renaming device unplug related function
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/48473/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2691:
gerrit-hooks has posted comments on this change.
Change subject: tests: Adding coverage check for unit tests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: image: copy - set VM metadata images format to RAW
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49144
To unsubscribe, visit
Marcin Mirecki has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 4:
(10 comments)
https://gerrit.ovirt.org/#/c/48880/4/tests/vmTests.py
File tests/vmTests.py:
Line
Marcin Mirecki has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 1: Code-Review-1
(1 comment)
change looks ok please fix the spelling
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has submitted this change and it was merged.
Change subject: hsm.py: Deprecate getVGList
..
hsm.py: Deprecate getVGList
oVirt Engine commit 4312bfd removed all the usages of getVGList from the
engine's code.
Since
gerrit-hooks has posted comments on this change.
Change subject: hsm.py: Deprecate getVGList
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move simple metadata getters and setters
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Metadata read utils
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move the getParent API
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: metadata write utils
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Milan Zamazal has posted comments on this change.
Change subject: virt: introduce "Async" helper
..
Patch Set 2: Code-Review-1
(11 comments)
I can't get rid of feeling that the implementation is too complicated for the
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 18:
(3 comments)
https://gerrit.ovirt.org/#/c/48446/18/vdsm.spec.in
File vdsm.spec.in:
Line 46
Nir Soffer has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 2:
(2 comments)
Thanks Petr!
Looks good, please see the comments.
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/41998/17/vdsm/storage/blockVolume.py
File
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain: Add get_manifest
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Shmuel Leib Melamud has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Betak has posted comments on this change.
Change subject: virt: introduce "Async" helper
..
Patch Set 2:
I'm going to have to agree with Milan. We need to ask ourselves, what we are
getting in exchange for all this
Adam Litke has posted comments on this change.
Change subject: hsm.py: Deprecate getVGList
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ondřej Svoboda has posted comments on this change.
Change subject: net: Remove reporting of bond custom options from RunningConfig
..
Patch Set 2: Code-Review+1
Well done!
--
To view, visit https://gerrit.ovirt.org/49081
To
Nir Soffer has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 6:
Nice work!
See the comments.
--
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Make BIOS messages available on vmconsole
..
Patch Set 8: Code-Review+1
(2 comments)
Very nice, waiting for Francesco approval.
Marcin Mirecki has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 12:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:
Line 1279:
Nir Soffer has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 5:
Please review latest change.
--
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 8:
Sahina, your ack is welcome.
--
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 9:
> Uploaded patch set 9.
Fixed identation
--
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 10: Code-Review-1
This should be squashed with https://gerrit.ovirt.org/49038
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Adding coverage check for unit tests
..
Patch Set 4:
It does not seem that ANY test has been running:
16:18:11 Complete!
16:18:11 + coverage html
Nir Soffer has posted comments on this change.
Change subject: vm: renaming device unplug related function
..
Patch Set 5: Code-Review-1
This rename belongs to https://gerrit.ovirt.org/48473
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: build: contrib script to build for rhev with the required flags
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh
File
Nir Soffer has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 7:
(1 comment)
Nice, see the comment about breaking long lines.
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1260:
Line
Nir Soffer has posted comments on this change.
Change subject: mkimage: setup right permissions before mkisofs
..
Patch Set 5: Code-Review+1
(1 comment)
Looks good, one minor comment.
Nir Soffer has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 1:
Fred, can you test this?
--
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: spec: Require newer qemu version for el7
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49009
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1260:
Line
gerrit-hooks has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: adding compatibility for ovirt-engine 4.0 support
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in
File
Nir Soffer has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 3: Code-Review+1
Nice! Waiting for Francesco and Ido.
--
To view, visit https://gerrit.ovirt.org/49104
To
Nir Soffer has posted comments on this change.
Change subject: mkimage: check image attributes after creation
..
Patch Set 5: Code-Review+1
(1 comment)
Looks good, one minor comment.
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 8: Code-Review+2
Thanks Ala!
--
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 8:
Piotr, please approve the infra change.
--
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46692
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: pass ip configuration as a namedtuple
..
Patch Set 1: Code-Review+1
okay
--
To view, visit https://gerrit.ovirt.org/48830
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: skip non-vNic device's XML
..
Patch Set 2: Code-Review-1
(1 comment)
Fabian Deutsch has posted comments on this change.
Change subject: build: contrib script to build for rhev with the required flags
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh
File
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: hostusb: make sudoers rule more specific
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48963
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 5:
(8 comments)
https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:
Line 1261:
gerrit-hooks has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 11:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Marcin Mirecki has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 5:
(4 comments)
https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py
File tests/vmTests.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48106
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: spec: Require newer multipath version
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/49113/3//COMMIT_MSG
Commit Message:
Line 7: spec: Require newer
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 10: Code-Review+1
Waiting for Francesco approval.
--
To view, visit https://gerrit.ovirt.org/48473
gerrit-hooks has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Oved Ourfali has posted comments on this change.
Change subject: adding compatibility for ovirt-engine 4.0 support
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in
File
Sahina Bose has posted comments on this change.
Change subject: gluster: Remove duplicate servers
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: remove editNetwork old API
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48910
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Metadata read utils
..
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: remove delNetwork old API
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48911
To unsubscribe, visit
1 - 100 of 224 matches
Mail list logo