Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 2: ping -- To view, visit https://gerrit.ovirt.org/48356 To unsubscribe, visit

Change in vdsm[master]: stomp: improve message id handling during response send

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: improve message id handling during response send .. Patch Set 2: Verified+1 Fixed comment and rebased. Copying verification flag. -- To view, visit

Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: config: Resolve crash when IPv6 disabled in kernel .. Patch Set 4: Code-Review-1 (1 comment) minor comment, please have this patch ready quickly.

Change in vdsm[master]: build: Align Fedora and EL qemu requirements

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: build: Align Fedora and EL qemu requirements .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: netinfo: replace an annoying (and misleading) log message

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: netinfo: replace an annoying (and misleading) log message .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: tests: JsonRpcServer tests suite

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: JsonRpcServer tests suite .. Patch Set 4: ping -- To view, visit https://gerrit.ovirt.org/43581 To unsubscribe, visit

Change in vdsm[master]: Show debug message before action

2015-12-08 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: Show debug message before action .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49368 To unsubscribe, visit

Change in vdsm[master]: Show debug message before action

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Show debug message before action .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: stomp: improve message id handling during response send

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: stomp: improve message id handling during response send .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: stomp: message tracking do not clean properly

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: stomp: message tracking do not clean properly .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: config: Resolve crash when IPv6 disabled in kernel .. Patch Set 4: * #1277204::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1277204::OK, public

Change in vdsm[master]: configurators: make disable_ipv6 permanent by using sysctl.d...

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: configurators: make disable_ipv6 permanent by using sysctl.d configs .. Patch Set 5: * #1219363::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: Add vmfex-dev hook to default RPMs for install

2015-12-08 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50024 To unsubscribe, visit

Change in vdsm[master]: spec: Align RHEL and CentOS qemu* requiments

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Align RHEL and CentOS qemu* requiments .. Patch Set 4: * #1248400::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1248400::OK, public bug *

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

2015-12-08 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/49097/11/lib/vdsm/netinfo/dhcp.py File

Change in vdsm[master]: build: Align Fedora and EL qemu requirements

2015-12-08 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: build: Align Fedora and EL qemu requirements .. build: Align Fedora and EL qemu requirements Bump the Fedora requirement to 2.3.0 to better align Fedora and

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Send all the pending messages in handle_write .. Patch Set 2: Code-Review+2 On the other hand we may use all the reactor cycles to work with single

Change in vdsm[master]: startup: Change system default encoding to utf8

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe, visit

Change in vdsm[master]: netinfo: assess DHCP on devices from cmdlines of dhclients

2015-12-08 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/49097/11/lib/vdsm/netinfo/dhcp.py File

Change in vdsm[master]: stomp: make sure that subscriptions use uniqe id

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that subscriptions use uniqe id .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/46656/3/lib/yajsonrpc/stompreactor.py File

Change in vdsm[master]: Show debug message before action

2015-12-08 Thread sshnaidm
Sagi Shnaidman has posted comments on this change. Change subject: Show debug message before action .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/49368 To unsubscribe, visit

Change in vdsm[master]: spec: Align RHEL and CentOS qemu* requiments

2015-12-08 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: Align RHEL and CentOS qemu* requiments .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/49974/3/vdsm.spec.in File vdsm.spec.in: Line 237 Line

Change in vdsm[master]: build: Align Fedora and EL qemu requirements

2015-12-08 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: build: Align Fedora and EL qemu requirements .. Patch Set 1: Verified+1 Verification: 1. Make sure the system does not have qemu-kvm installed 2. make rpm with

Change in vdsm[master]: config: Resolve crash when IPv6 disabled in kernel

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: config: Resolve crash when IPv6 disabled in kernel .. Patch Set 3: * #1277204::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1277204::OK, public

Change in vdsm[master]: virt: vm: Update time on VM after resume

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 6: Code-Review+1 Continuous-Integration+1 unrelated failure -- To view, visit

Change in vdsm[master]: jsonrpcvdscli: make sure not to ignore response queue

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: make sure not to ignore response queue .. Patch Set 1: ping -- To view, visit https://gerrit.ovirt.org/48609 To unsubscribe, visit

Change in vdsm[master]: Adding python3 run for nosetests

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 28: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: gluster: fix brick devices are created with incorrect data a...

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: fix brick devices are created with incorrect data alignment .. Patch Set 3: * #1270792::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

2015-12-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 2: Code-Review-1 (1 comment)

Change in vdsm[master]: net: consolidate bondings.py naming

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: consolidate bondings.py naming .. net: consolidate bondings.py naming This is only a partial change. More cleanup needs to be done soon after

Change in vdsm[master]: net: publicise misc._visible_devs

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: publicise misc._visible_devs .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: net: publicise misc._visible_devs

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: publicise misc._visible_devs .. net: publicise misc._visible_devs It is used in many netinfo submodules Change-Id:

Change in vdsm[master]: net: consolidate bondings.py naming

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: consolidate bondings.py naming .. Patch Set 9: Code-Review+2 Verified+1 copying score -- To view, visit https://gerrit.ovirt.org/49626 To unsubscribe,

Change in vdsm[master]: fix for generated code

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fix for generated code .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: fix for generated code

2015-12-08 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: fix for generated code .. fix for generated code Change-Id: Ic5f06b071fcc2fda63920507f0ed8be8ff899fc0 Signed-off-by: Yaniv Bronhaim ---

Change in vdsm[master]: network: tests: rename config to running_config

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: network: tests: rename config to running_config .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50004 To unsubscribe, visit

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Send all the pending messages in handle_write .. Patch Set 2: I thought about my comment and as a result I gave second one. Let's have it in. -- To

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: init: wait for ipv4 with monitoring .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

2015-12-08 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: init: wait for ipv4 with monitoring .. Patch Set 11: rebased -- To view, visit https://gerrit.ovirt.org/46148 To unsubscribe, visit

Change in vdsm[master]: net: consolidate bridges.py names

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: consolidate bridges.py names .. net: consolidate bridges.py names Functions names became relative to the module Change-Id:

Change in vdsm[master]: net: canonify netinfo.vlans.py names

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: canonify netinfo.vlans.py names .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49954 To unsubscribe, visit

Change in vdsm[master]: net: consolidate bridges.py names

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: consolidate bridges.py names .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49628 To unsubscribe, visit

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: init: wait for ipv4 with monitoring .. Patch Set 12: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/46148/12/init/wait_for_ipv4s File

Change in vdsm[master]: storage: Introduction to transfer.py

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Introduction to transfer.py .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/49952/1/Makefile.am File Makefile.am: Line 94:

Change in vdsm[master]: hooks: ovs: tests TODO draft

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: tests TODO draft .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: consolidate bondings.py naming

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: consolidate bondings.py naming .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: net: consolidate bridges.py names

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: consolidate bridges.py names .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: net: remove network residues.

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: remove network residues. .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: fix for generated code

2015-12-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: fix for generated code .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50086 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

2015-12-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: stomp: Send all the pending messages in handle_write .. Patch Set 2: Piotr, based on your comment, I'm not sure if you want this patch or not. -- To view, visit

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

2015-12-08 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: init: wait for ipv4 with monitoring .. Patch Set 11: @Ondra: now im using constants from ifcfg module -- To view, visit https://gerrit.ovirt.org/46148 To

Change in vdsm[master]: net: init: wait for ipv4 with monitoring

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: init: wait for ipv4 with monitoring .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: remove network residues.

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove network residues. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49975 To unsubscribe, visit

Change in vdsm[master]: net: remove network residues.

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: remove network residues. .. net: remove network residues. Those files were forgotten in the branch after the network package was moved under

Change in vdsm[master]: netinfo: replace an annoying (and misleading) log message

2015-12-08 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: replace an annoying (and misleading) log message .. Patch Set 7: Verified+1 Needless tracebacks are gone and instead, we have nice, one-line

Change in vdsm[master]: virt: Add support for vgamem attribute

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 1: * #1275539::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1275539::OK, public bug * Check

Change in vdsm[master]: contrib: Simple jsonrpc client

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48356/2/tests/functional/utils.py

Change in vdsm[master]: network: tests: rename config to running_config

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: tests: rename config to running_config .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: fix for generated code

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fix for generated code .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/50086 To unsubscribe, visit

Change in vdsm[master]: fix for generated code

2015-12-08 Thread ybronhei
Yaniv Bronhaim has abandoned this change. Change subject: fix for generated code .. Abandoned -- To view, visit https://gerrit.ovirt.org/50086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType:

Change in vdsm[master]: contrib: Simple jsonrpc client

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 6: Here is my proposal how we could have command line client which uses jsonrpc. The code was verified and I

Change in vdsm[master]: contrib: Simple jsonrpc client

2015-12-08 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/35181/5/contrib/jsonrpc File contrib/jsonrpc: Line 84: DESTINATION

Change in vdsm[master]: Adding python3 run for nosetests

2015-12-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 28: Verified+1 -- To view, visit https://gerrit.ovirt.org/48051 To unsubscribe, visit

Change in vdsm[master]: vdsm.spec typo in package description

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec typo in package description .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49661 To unsubscribe, visit

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vdsm.spec typo in package description

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm.spec typo in package description .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: vdsm.spec typo in package description

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm.spec typo in package description .. vdsm.spec typo in package description Change-Id: I0d93bfda23cda70948af9d96b7f76198543d1953 Signed-off-by: Ido

Change in vdsm[master]: jsonrpcvdscli: improve functional network tests duration time

2015-12-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpcvdscli: improve functional network tests duration time .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/48356/2/tests/functional/utils.py File

Change in vdsm[master]: Adding python3 run for nosetests

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Adding python3 run for nosetests .. Adding python3 run for nosetests This patch adds list of nosetests modules that makecheck will try to run with

Change in vdsm[master]: Adding python3 run for nosetests

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 28: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48051 To unsubscribe, visit

Change in vdsm[master]: Adding python3 run for nosetests

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 29: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/49952/1/Makefile.am File Makefile.am: Line 94:

Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

2015-12-08 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR .. pyflakes: drop a too-clever SKIP_PYFLAKES_ERR Commit 6177a169fc84576 attempted to ignore a false pyflakes

Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: network: tests: rename config to running_config

2015-12-08 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: network: tests: rename config to running_config .. Patch Set 2: Verified+1 Passed network functional tests without a regression. -- To view, visit

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

2015-12-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: _read_ovf_from_tar_ova use tarfile package .. Patch Set 1: (3 comments) Neat! https://gerrit.ovirt.org/#/c/50106/1//COMMIT_MSG Commit Message: Line 5:

Change in vdsm[master]: hooks: ovs: use network lib instead of hardcoded path hack

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: use network lib instead of hardcoded path hack .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: tests: Safer fake objects for indirection tests

2015-12-08 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Safer fake objects for indirection tests .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50029 To unsubscribe, visit

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

2015-12-08 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: v2v: _read_ovf_from_tar_ova use tarfile package .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/50106/1//COMMIT_MSG Commit Message: Line 5:

Change in vdsm[master]: tests: Safer fake objects for indirection tests

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Safer fake objects for indirection tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-08 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 2: Verified+1 Passed ovs tests without a regression. test_drop_initial_bond_slaves_ip_config is

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: _read_ovf_from_tar_ova use tarfile package .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

2015-12-08 Thread shavivi
Shahar Havivi has uploaded a new change for review. Change subject: v2v: _read_ovf_from_tar_ova use tarfile package .. v2v: _read_ovf_from_tar_ova use tarfile package using build-in package instead of execCmd. Change-Id:

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

2015-12-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: stomp: Send all the pending messages in handle_write .. Patch Set 2: Yaniv, can review? -- To view, visit https://gerrit.ovirt.org/4 To unsubscribe, visit

Change in vdsm[master]: v2v: Use tarfile instead of running tar process

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: Use tarfile instead of running tar process .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Safer fake objects for indirection tests

2015-12-08 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Safer fake objects for indirection tests .. tests: Safer fake objects for indirection tests When testing that old code is redirecting calls to new

Change in vdsm[master]: hooks: ovs: drop initial bonds' slaves IP config

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: avoid running pep8 and pyflakes on py.in files

2015-12-08 Thread automation
gerrit-hooks has posted comments on this change. Change subject: avoid running pep8 and pyflakes on py.in files .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: avoid running pep8 and pyflakes on py.in files

2015-12-08 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: avoid running pep8 and pyflakes on py.in files .. avoid running pep8 and pyflakes on py.in files Change-Id: I76d5e555455d1b4acc568a42b864e220c79ab6fa

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-08 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: run ovs _configure only if there are changes to do .. Patch Set 1: Verified+1 Passed ovs tests without a regression. -- To view, visit

Change in vdsm[master]: v2v: _read_ovf_from_tar_ova use tarfile package

2015-12-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: _read_ovf_from_tar_ova use tarfile package .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50106/1/vdsm/v2v.py File vdsm/v2v.py: Line 915 Line 916

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: Send all the pending messages in handle_write .. stomp: Send all the pending messages in handle_write We used to send one pending message in

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-12-08 Thread derez
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 22: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41999 To unsubscribe, visit

Change in vdsm[master]: spec: Remove the lib64 vdsm python directory

2015-12-08 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: spec: Remove the lib64 vdsm python directory .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50115 To unsubscribe, visit

Change in vdsm[master]: v2v: Use tarfile instead of running tar process

2015-12-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: v2v: Use tarfile instead of running tar process .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/50106/2/vdsm/v2v.py File vdsm/v2v.py: Line 916:

Change in vdsm[master]: network: tests: rename config to running_config

2015-12-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: tests: rename config to running_config .. network: tests: rename config to running_config Let's be more explicit and call 'config' (=

  1   2   >