Nir Soffer has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 22:
(3 comments)
https://gerrit.ovirt.org/#/c/48672/22/vdsm/v2v.py
File vdsm/v2v.py:
Line 636:
Line 637: def
Nir Soffer has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 9: Code-Review-1
(8 comments)
Generally look good
https://gerrit.ovirt.org/#/c/49951/9/vdsm/v2v.py
Edward Haas has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51041/1/lib/vdsm/network/api.py
File
Ido Barkan has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51041
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: remove business logic out of CachingNetInfo
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/5
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: add test testSuccessfulImportOVA
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Edward Haas has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51041
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 5:
* #1270220::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270220::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: set netconf/* owner to 'vdsm'
..
net: set netconf/* owner to 'vdsm'
On ovirt-node netconf/* has umask of 660 with root
as owner. Accessing the
gerrit-hooks has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 3:
* #1293617::Update tracker: OK
* Set MODIFIED::bug 1293617#1293617IGNORE, not oVirt classification but
Nir Soffer has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48477/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1539
Liron Aravot has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/48477/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Ido Barkan has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51041/1/lib/vdsm/network/api.py
File
Edward Haas has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/51041
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has uploaded a new change for review.
Change subject: net api: Normalize 'remove' for networks to boolean
..
net api: Normalize 'remove' for networks to boolean
Normalize 'remove' value to a boolean at the api entry
Nir Soffer has submitted this change and it was merged.
Change subject: fileSD: use fileVolume constants for file extensions
..
fileSD: use fileVolume constants for file extensions
This patch replaces the use of file extension
gerrit-hooks has posted comments on this change.
Change subject: fileSD: use fileVolume constants for file extensions
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Shahar Havivi has posted comments on this change.
Change subject: v2v: add test testSuccessfulImportOVA
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/50585
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/50584
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: fileSD: use fileVolume constants for file extensions
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51040
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yaniv Bronhaim has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50849
To unsubscribe,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
gluster: fix xfs filesystem is created with wrong inode size
Currently brick create
Yaniv Bronhaim has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50853
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
gluster: fix alignment issue for brick creation on JBOD
Chunk size and alignment value
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: gluster add mount options for gluster brick.
..
gluster add mount options for gluster brick.
Mount options "inode64,noatime" should be used to
mount
gerrit-hooks has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 3:
* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix alignment issue for brick creation on JBOD
..
Patch Set 3:
* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not
gerrit-hooks has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: gluster: create bricks without MBR partitions
..
Patch Set 3:
* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix xfs filesystem is created with wrong inode size
..
Patch Set 3:
* #1293537::Update tracker: OK
* Set MODIFIED::bug 1293537#1293537OK
--
To
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: gluster: create bricks without MBR partitions
..
gluster: create bricks without MBR partitions
During gluster brick creation, PVs should be
created
gerrit-hooks has posted comments on this change.
Change subject: net tests: Marking testFakeNics as broken
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: net tests: Marking testFakeNics as broken
..
net tests: Marking testFakeNics as broken
The test testFakeNics fails when hidden nics
appear in netinfo
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
gluster: ensure LV size is multiple of VG's PE value
Alignment value for JBOD is changed to
gerrit-hooks has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 4:
* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt
Yaniv Bronhaim has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50854
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 3: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/50854
To unsubscribe,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: gluster: fix size conversion issues in brick create
..
gluster: fix size conversion issues in brick create
There is change in blivet API
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix size conversion issues in brick create
..
Patch Set 3:
* #1270792::Update tracker: OK
* Set MODIFIED::bug 1270792#1270792IGNORE, not oVirt
Yaniv Bronhaim has posted comments on this change.
Change subject: gluster add mount options for gluster brick.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50852
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: net tests: Marking testFakeNics as broken
..
Patch Set 3: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/50580
To
gerrit-hooks has posted comments on this change.
Change subject: gluster: ensure LV size is multiple of VG's PE value
..
Patch Set 3:
* #1270792::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270792::OK, public
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3:
* #1271771::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1271771::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: JSONRPC: make Image.prepare to return info.
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/51054/3/lib/api/vdsmapi-schema.json
File
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/27334
To unsubscribe, visit
Jenkins CI has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 2
--
To
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3:
Verification scenario which was tested:
1. Add a host with two storage domains - iscsi domain A and file
Dan Kenigsberg has uploaded a new change for review.
Change subject: netinfo: survive even when a expected iface is not connected to
bridge
..
netinfo: survive even when a expected iface is not connected to bridge
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/27334/3/vdsm/storage/sp.py
File
gerrit-hooks has posted comments on this change.
Change subject: netinfo: survive even when a expected iface is not connected to
bridge
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Dan Kenigsberg has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 2: Continuous-Integration+1
Unrelated indeed.
15:39:05 FAIL: test_discarded_workers
Dan Kenigsberg has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51060
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48477
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 7:
* #1270220::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270220::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: v2v: add test testSuccessfulImportOVA
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50585
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49636
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/48672/21/vdsm/v2v.py
File vdsm/v2v.py:
Line 667: params = {}
Shahar Havivi has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 21:
(3 comments)
https://gerrit.ovirt.org/#/c/48672/21/vdsm/v2v.py
File vdsm/v2v.py:
Line 667: params =
Dan Kenigsberg has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51041
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net api: Normalize 'remove' for networks to boolean
..
net api: Normalize 'remove' for networks to boolean
Normalize 'remove' value to a boolean at
gerrit-hooks has posted comments on this change.
Change subject: net api: Normalize 'remove' for networks to boolean
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/50584/4/tests/v2vTests.py
File tests/v2vTests.py:
Line 207:
gerrit-hooks has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Shahar Havivi has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/49951/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 400:
gerrit-hooks has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Shahar Havivi has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/50584
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 1:
* #1293617::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1293617::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/50596/6/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Dan Kenigsberg has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51053
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: JsonRPC: make Image.prepare to return info.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: JsonRPC: make Image.prepare to return info.
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/51054/2//COMMIT_MSG
Commit Message:
Line 12:
Line 13:
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor testSuccessfulImport test
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50584
To unsubscribe, visit
Amit Aviram has posted comments on this change.
Change subject: JsonRPC: make Image.prepare to return info.
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/51054/2//COMMIT_MSG
Commit Message:
Line 12:
Line 13:
Dan Kenigsberg has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50299
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/51053
to review the following change.
Change subject: net: set netconf/* owner to 'vdsm'
..
net: set netconf/* owner to 'vdsm'
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Add dependencies for generated .py files
..
build: Add dependencies for generated .py files
In the past we checked .py.in files with pep8 and
Amit Aviram has uploaded a new change for review.
Change subject: Image: prepare to return info
..
Image: prepare to return info
...
Change-Id: Icc03568b35c14e1f5c7239c8c3df8f74acf3ec51
Signed-off-by: Amit Aviram
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 8:
* #1269175::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269175::OK, public bug
* Check
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: set netconf/* owner to 'vdsm'
..
net: set netconf/* owner to 'vdsm'
On ovirt-node netconf/* has umask of 660 with root
as owner. Accessing the
gerrit-hooks has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 2:
* #1293617::Update tracker: OK
* Set MODIFIED::bug 1293617#1293617IGNORE, not oVirt classification but
Petr Horáček has posted comments on this change.
Change subject: net: remove business logic out of CachingNetInfo
..
Patch Set 7: Code-Review+1
good job, i'm looking forward to use it in ovs hook
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: Image: prepare to return info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Edward Haas has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51053
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 7:
* #1269175::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269175::OK, public bug
* Check
Edward Haas has uploaded a new change for review.
Change subject: net: set netconf/* owner to 'vdsm'
..
net: set netconf/* owner to 'vdsm'
On ovirt-node netconf/* has umask of 660 with root
as owner. Accessing the folders and
gerrit-hooks has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 1:
* #1294075::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1294075::OK, public bug
* Check
Nir Soffer has restored this change.
Change subject: sp: update domain links on state change
..
Restored
We still need this, it is better then the current long-term no-solution in
master.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: JSONRPC: make Image.prepare to return info.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 6:
* #1270220::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1270220::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 2:
* #1294075::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1294075::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 2:
CI failures do not seem to be related to this patch.
--
To view, visit https://gerrit.ovirt.org/51060
To
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 2:
* #1091030::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1091030::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/51060
To unsubscribe, visit
98 matches
Mail list logo
