Adam Litke has posted comments on this change.
Change subject: jobs: Take lock once when deleting a job
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51215
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: jobs: Add Job.__repr__ for easier debugging
..
Patch Set 3: Code-Review+1
Not +2 because I am unsure if we need the ProgressingJob class.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: tests: Set status when creating a job
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51269
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 23: Verified+1
Using unit tests
--
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 23: Verified+1
Using unit tests
--
To view, visit https://gerrit.ovirt.org/42004
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 24: Verified+1
Using unit tests
--
To view, visit https://gerrit.ovirt.org/42002
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: jobs: Replace validation method with a property
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51216
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: startup: Change system default encoding to utf8
..
startup: Change system default encoding to utf8
In Python 2, the system default encoding is
Dan Kenigsberg has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5: Code-Review+2
Let us unbreak master first.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: build: update libvirt dependency for fedora
..
Patch Set 1:
* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: keep README on wiki
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: keep README on wiki
..
hooks: ovs: keep README on wiki
Keeping OVS README on wiki would give the hook more visibility and
it will be
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: keep README on wiki
..
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/51294
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: keep README on wiki
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: keep README on wiki
..
hooks: ovs: keep README on wiki
Keeping OVS README on wiki would give the hook more visibility and
easier editation.
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/51295
to review the following change.
Change subject: build: update libvirt dependency for fedora
..
build: update libvirt
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit
Idan Shaby has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: keep README on wiki
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 3:
* #1291207::Update tracker: OK
* Set MODIFIED::bug 1291207#1291207OK
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: net: drop isolatedCommand handling
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51281
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: fileSD: Do not try to remove non-existent lease file
..
fileSD: Do not try to remove non-existent lease file
The volume.lease file exists only if a
Francesco Romani has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2: Code-Review+1
looks fine to not-storage-expert-me. I'd like another ACK from one storage
Freddy Rolland has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51132
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..
Patch Set 2:
* #1287862::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287862::OK,
Maor Lipchuk has posted comments on this change.
Change subject: ceph: Support OVF_STORE upload for ceph.
..
Patch Set 2:
draft
--
To view, visit https://gerrit.ovirt.org/43296
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 2:
* #1281940::Update tracker: OK
* Set MODIFIED::bug 1281940#1281940OK
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51273
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: drop isolatedCommand handling
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has uploaded a new change for review.
Change subject: net: drop isolatedCommand handling
..
net: drop isolatedCommand handling
Since addNetwork and delNetwork API was dropped, we don't need
isolatedCommand handling
Fabian Deutsch has posted comments on this change.
Change subject: register: handle non uuid machines
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47385/2/lib/vdsm/tool/register.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51187
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: tests: Test default Job.progress implementation
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: jobs: Add Job.__repr__ for easier debugging
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Set status when creating a job
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: tests: Test default Job.progress implementation
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: jobs: Take lock once when deleting a job
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jobs: Replace validation method with a property
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 13: Verified+1
Used the unit tests.
--
To view, visit https://gerrit.ovirt.org/44043
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: sslTests.py: Fix typos
..
sslTests.py: Fix typos
Change-Id: I3f37d7de5e07061a93d7025db8e2ef792ccaa461
Signed-off-by: Allon Mureinik
gerrit-hooks has posted comments on this change.
Change subject: sslTests.py: Fix typos
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: sslTests.py: Fix typos
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: rwlock_test: Make pep8 happy again
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sigutils: Fix typo "the the" -> "the"
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: dump_volume_chains.py: Spelling in comment
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: sigutils: Fix typo "the the" -> "the"
..
sigutils: Fix typo "the the" -> "the"
Change-Id: If37c6e3e542368355f2349998f94445f1c4a7c5a
Signed-off-by: Allon
Nir Soffer has posted comments on this change.
Change subject: dump_volume_chains.py: Spelling in comment
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: dump_volume_chains.py: Spelling in comment
..
dump_volume_chains.py: Spelling in comment
Change-Id: I10c973bb642dcc00c7b8762546992902edab0acc
Nir Soffer has posted comments on this change.
Change subject: sigutils: Fix typo "the the" -> "the"
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: verify.py: Fix typo "attribets" -> "attributes"
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: tests: Test default Job.progress implementation
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Test default Job.progress implementation
..
tests: Test default Job.progress implementation
Test jobs.Job.progress, and add ProgressingJob class
Nir Soffer has submitted this change and it was merged.
Change subject: verify.py: Fix typo "attribets" -> "attributes"
..
verify.py: Fix typo "attribets" -> "attributes"
Change-Id: Ibfbaf713f21da763a5ac8edd826320aae979bed7
Nir Soffer has posted comments on this change.
Change subject: verify.py: Fix typo "attribets" -> "attributes"
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51312
To
Allon Mureinik has posted comments on this change.
Change subject: rwlock_test: Make pep8 happy again
..
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: jobs: Add Job.__repr__ for easier debugging
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51217
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sigutils: Fix typo "the the" -> "the"
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51304
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: rwlock_test: Make pep8 happy again
..
Patch Set 1:
Unbreaking master
--
To view, visit https://gerrit.ovirt.org/51346
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: rwlock_test: Make pep8 happy again
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: rwlock_test: Make pep8 happy again
..
rwlock_test: Make pep8 happy again
Fixing typo (shold -> should) increased the line length to 80
characters, making
gerrit-hooks has posted comments on this change.
Change subject: tests: Set status when creating a job
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Set status when creating a job
..
tests: Set status when creating a job
Instead of setting job private instance variables, set the status when
gerrit-hooks has posted comments on this change.
Change subject: rwlock_test: Make pep8 happy again
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51309
To
gerrit-hooks has posted comments on this change.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
rwlock_test.py: Fix typo "shold" -> "should"
Change-Id: I6dff56805732b0675c980a92910a281978050f36
Nir Soffer has posted comments on this change.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51310
To
gerrit-hooks has posted comments on this change.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
momTests.py: Fix typo "paramters" -> "parameters"
Change-Id:
Yaniv Bronhaim has posted comments on this change.
Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..
Patch Set 2:
btw, I promised to nir that we'll continue the work on vdsm-arch and remove
this
Allon Mureinik has posted comments on this change.
Change subject: schema: Fix Typos
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51302
To unsubscribe, visit https://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: try to configure sebool after upgrade
..
Patch Set 1:
what to say ? maybe better to run sebool configurations as well :\ not sure
about it
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: net: Enable VDSM to listen on IPv6 addresses
..
Patch Set 1:
Verified by running the unit tests and functional tests.
The unit tests include an IPv6 connection
Allon Mureinik has posted comments on this change.
Change subject: vdsClient: Fix typo parmeter->parameter
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51300
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: nfs-check.py: apostrophe
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: sslTests.py: Fix typos
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: sslTests.py: Fix typos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Tal Nisan has posted comments on this change.
Change subject: verify.py: Fix typo "attribets" -> "attributes"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51312
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit
Martin Sivák has posted comments on this change.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: build: update libvirt dependency for fedora
..
Patch Set 3:
* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
*
Allon Mureinik has posted comments on this change.
Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51308
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: momTests.py: Fix typo "paramters" -> "parameters"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51309
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: utils.py: Fix typo "placeholer" -> "placeholder"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51307
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51308
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51310
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: dump_volume_chains.py: Spelling in comment
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51306
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: build: update libvirt dependency for fedora
..
Patch Set 4:
* #1253756::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1253756::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: fileSD: improve error handling in deleteImage
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51299
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: zombiereaper: Fix typo "happend" -> "happened"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: verify.py: Fix typo "attribets" -> "attributes"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: dump_volume_chains.py: Spelling in comment
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: betterAsyncore.py: Fix typo "enought"->"enough"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sslTests.py: Fix typos
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: utils.py: Fix typo "placeholer" -> "placeholder"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: compat.py: Fixed typo "libary"->"library"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Allon Mureinik has uploaded a new change for review.
Change subject: rwlock_test.py: Fix typo "shold" -> "should"
..
rwlock_test.py: Fix typo "shold" -> "should"
Change-Id: I6dff56805732b0675c980a92910a281978050f36
1 - 100 of 210 matches
Mail list logo