Change in vdsm[ovirt-3.6]: build: Centos device-mapper-multipath requirement

Francesco Romani has posted comments on this change. Change subject: build: Centos device-mapper-multipath requirement .. Patch Set 1: Code-Review+2 fine for me. Waiting for one succesfull jenkins run -- To view, visit

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Francesco Romani has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 3: Code-Review+2 thanks for the updates! -- To view, visit https://gerrit.ovirt.org/51508 To

Change in vdsm[ovirt-3.6.1]: code coverage: change approach how to enable it

Francesco Romani has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 1: Code-Review+1 3.6.2 was tagged from the ovirt-3.6 branch. We usually tag from ovirt-3.6

Change in vdsm[master]: tests: Improve object filtering tests

Francesco Romani has posted comments on this change. Change subject: tests: Improve object filtering tests .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51038 To unsubscribe, visit

Change in vdsm[master]: tests: Fix typo elasped -> elapsed

Francesco Romani has posted comments on this change. Change subject: tests: Fix typo elasped -> elapsed .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51542 To unsubscribe, visit

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 9: Continuous-Integration+1 Jenkins failure not relevant. -- To view, visit

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 9: make check pass for me. -- To view, visit https://gerrit.ovirt.org/51421

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/51421/9//COMMIT_MSG Commit

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/51421/6/vdsm/virt/vm.py File

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 7: Code-Review-1 (1 comment)

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

gerrit-hooks has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: Introduce commands module to separate execCmd and AsyncProc ...

gerrit-hooks has posted comments on this change. Change subject: Introduce commands module to separate execCmd and AsyncProc from utils .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

gerrit-hooks has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Yaniv Bronhaim has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/51421/6/vdsm/virt/vm.py File

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

gerrit-hooks has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: Introduce commands module to separate execCmd and AsyncProc ...

Nir Soffer has posted comments on this change. Change subject: Introduce commands module to separate execCmd and AsyncProc from utils .. Patch Set 10: Code-Review+1 Looks good, needs approval from all subsystem maintainers.

Change in vdsm[master]: gluster: Add gluster exception tests

Nir Soffer has uploaded a new change for review. Change subject: gluster: Add gluster exception tests .. gluster: Add gluster exception tests GlusterException inherits from VdsmException, which we are going to change in the

Change in vdsm[master]: exception: Inherit from VdsmException

gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: gluster: Add gluster exception tests

Nir Soffer has posted comments on this change. Change subject: gluster: Add gluster exception tests .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51565 To unsubscribe, visit

Change in vdsm[master]: exception: Make VdsmException reusable

Nir Soffer has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 4: This version updates the copyright years on modified modules. -- To view, visit

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

Nir Soffer has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 5: Verified+1 This version rebase on master and update for recent changes in jobs tests. -- To view,

Change in vdsm[master]: exception: Inherit from VdsmException

gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: exception: Make VdsmException reusable

gerrit-hooks has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

Nir Soffer has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 8: This version updates the copyright year on modified modules. -- To view, visit

Change in vdsm[master]: exception: Inherit from VdsmException

Nir Soffer has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 7: Verified+1 This version move GeneralException.info() up to VdsmException, and update GlusterException to use

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Nir Soffer has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/51549/2/lib/vdsm/hooks.py

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

gerrit-hooks has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: exception: Make VdsmException reusable

gerrit-hooks has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: gluster: Add gluster exception tests

gerrit-hooks has posted comments on this change. Change subject: gluster: Add gluster exception tests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

Nir Soffer has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 5: Also update the copyright years on modified modules. -- To view, visit

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

gerrit-hooks has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 2: * #1295778::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Nir Soffer has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 2: Rebase without code change (exceptions topic was modified). -- To view, visit

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Nir Soffer has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51549/2/vdsm/rpc/Bridge.py File

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 9: Code-Review-1 (7 comments)

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/51421/9//COMMIT_MSG Commit

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Piotr Kliczewski has uploaded a new change for review. Change subject: hooks: make sure that hook error inherits from vdsm exception .. hooks: make sure that hook error inherits from vdsm exception We need to make sure to

Change in vdsm[master]: exception: Inherit from VdsmException

gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

gerrit-hooks has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 1: * #1295778::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: exception: Make VdsmException reusable

gerrit-hooks has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

gerrit-hooks has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

Piotr Kliczewski has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 4: No code changes, just rebase -- To view, visit https://gerrit.ovirt.org/48868 To

Change in vdsm[master]: exception: Inherit from VdsmException

Piotr Kliczewski has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 5: No code changes, just rebase -- To view, visit https://gerrit.ovirt.org/48869 To unsubscribe, visit

Change in vdsm[master]: exception: Make VdsmException reusable

Piotr Kliczewski has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 3: No code changes, just rebase -- To view, visit https://gerrit.ovirt.org/48875 To unsubscribe, visit

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 6: No code changes, just rebase -- To view, visit https://gerrit.ovirt.org/48871 To

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Piotr Kliczewski has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 1: Verified+1 (1 comment) Verified by running vdsm and raising HookError. The

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

gerrit-hooks has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Yaniv Bronhaim has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 3: totally too much imo. i'll live better without this patch -- To

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Piotr Kliczewski has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/51549/2/lib/vdsm/hooks.py File

Change in vdsm[master]: caps: use cpuarch module

Nir Soffer has posted comments on this change. Change subject: caps: use cpuarch module .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49991 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: nettestlib: add ppc64le TUNSETIFF value

Nir Soffer has posted comments on this change. Change subject: nettestlib: add ppc64le TUNSETIFF value .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46955 To unsubscribe, visit

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

Nir Soffer has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/49972/6/lib/vdsm/Makefile.am File

Change in vdsm[master]: cpuinfo: use is_ppc predicate when parsing cpu_map.xml

Nir Soffer has posted comments on this change. Change subject: cpuinfo: use is_ppc predicate when parsing cpu_map.xml .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51382/2/vdsm/caps.py File

Change in vdsm[master]: testlib: use arch from lib

Nir Soffer has posted comments on this change. Change subject: testlib: use arch from lib .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49973/4/tests/testlib.py File tests/testlib.py: Line 165: _ARCH_REAL

Change in vdsm[master]: testlib: use arch from lib

Nir Soffer has posted comments on this change. Change subject: testlib: use arch from lib .. Patch Set 5: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/49973/5/tests/testlib.py File tests/testlib.py: Line 1 Line 2

Change in vdsm[master]: exception: Make VdsmException reusable

Nir Soffer has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/48875 To unsubscribe, visit

Change in vdsm[master]: nettestlib: use cpuarch module

Nir Soffer has posted comments on this change. Change subject: nettestlib: use cpuarch module .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49992/4/tests/nettestlib.py File tests/nettestlib.py: Line 154: Line

Change in vdsm[master]: nettestlib: use cpuarch module

Nir Soffer has posted comments on this change. Change subject: nettestlib: use cpuarch module .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49992/4/tests/nettestlib.py File tests/nettestlib.py: Line 1 Update the

Change in vdsm[master]: vdsm: introduce cpuinfo module

Nir Soffer has posted comments on this change. Change subject: vdsm: introduce cpuinfo module .. Patch Set 20: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46912/20/lib/vdsm/cpuinfo.py File lib/vdsm/cpuinfo.py:

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Nir Soffer has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51549/2/vdsm/rpc/Bridge.py File

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

Piotr Kliczewski has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 5: Code-Review-1 (1 comment) The codes are part of the contract between the engine and vdsm.

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

gerrit-hooks has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: * #1226911::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1226911::OK,

Change in vdsm[master]: virt: Remove staticmethod usage from guest agent

gerrit-hooks has posted comments on this change. Change subject: virt: Remove staticmethod usage from guest agent .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/51521 To unsubscribe, visit

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 3: We should consider that copying guestInfo might contain quite a lot of data (e.g. Windows

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

gerrit-hooks has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: untested: notify Engine when host connectivity changes

Piotr Kliczewski has posted comments on this change. Change subject: untested: notify Engine when host connectivity changes .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py

Change in vdsm[master]: tests: Fix typo elasped -> elapsed

gerrit-hooks has posted comments on this change. Change subject: tests: Fix typo elasped -> elapsed .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: Fix typo elasped -> elapsed

Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix typo elasped -> elapsed .. Patch Set 2: Continuous-Integration+1 how come no test is run? (unrelated to patch) 23:18:28 ../tests/run_tests_local.sh

Change in vdsm[master]: tests: Fix typo elasped -> elapsed

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Fix typo elasped -> elapsed .. tests: Fix typo elasped -> elapsed Change-Id: I5f24b7e7862ddcc6542dd96969b4537f4464be7e Signed-off-by: Nir

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Francesco Romani has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 4: kudos for the effort! Unfortunately this is huge from every possible

Change in vdsm[master]: service: change vdsm KillMode to mixed

Piotr Kliczewski has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Dan Kenigsberg has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51521/1/vdsm/virt/vmchannels.py

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Francesco Romani has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 3: I am fine with shallow copy, it was one of the options I suggested in v1 :) Let's just keep

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51521/1/vdsm/virt/vmchannels.py File

Change in vdsm[master]: vm: use response module in the destroy path

Milan Zamazal has posted comments on this change. Change subject: vm: use response module in the destroy path .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51383 To unsubscribe, visit

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Francesco Romani has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 3: Code-Review+1 Vinzenz, good point. I forgot about this, my fault. Temporarily decreasing

Change in vdsm[master]: PoC: enforcement of contract for rpc

Piotr Kliczewski has posted comments on this change. Change subject: PoC: enforcement of contract for rpc .. Patch Set 2: (14 comments) https://gerrit.ovirt.org/#/c/50032/2//COMMIT_MSG Commit Message: Line 7: PoC:

Change in vdsm[master]: storage: Rename *VolumeMetadata to *VolumeManifest

Nir Soffer has submitted this change and it was merged. Change subject: storage: Rename *VolumeMetadata to *VolumeManifest .. storage: Rename *VolumeMetadata to *VolumeManifest When refactoring the storage classes

Change in vdsm[master]: storage: Rename *VolumeMetadata to *VolumeManifest

gerrit-hooks has posted comments on this change. Change subject: storage: Rename *VolumeMetadata to *VolumeManifest .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: Added Python 3 support for sslTests.py

Piotr Kliczewski has posted comments on this change. Change subject: Added Python 3 support for sslTests.py .. Patch Set 6: For which ssl implementation have you verified this patch? -- To view, visit

Change in vdsm[master]: storage: Rename *VolumeMetadata to *VolumeManifest

Nir Soffer has posted comments on this change. Change subject: storage: Rename *VolumeMetadata to *VolumeManifest .. Patch Set 1: Code-Review+2 Continuous-Integration+1 CI failure not relevant, verified locally with make

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Piotr Kliczewski has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/51421/4//COMMIT_MSG

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 4: (15 comments) Nice! but you move too much stuff for no reason. We need

Change in vdsm[master]: virt: Set cloexec flag on channel sockets

gerrit-hooks has posted comments on this change. Change subject: virt: Set cloexec flag on channel sockets .. Patch Set 18: * #1226911::Update tracker: OK * Set MODIFIED::bug 1226911#1226911IGNORE, not oVirt

Change in vdsm[master]: virt: Set cloexec flag on channel sockets

Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Set cloexec flag on channel sockets .. virt: Set cloexec flag on channel sockets To counter act potential leakage of open handles, this patch is

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: Jenkins once again fails on unrelated changes -- To view, visit

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Milan Zamazal has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 3: We discussed that with Vinzenz extensively and we decided making a shallow copy instead of a

Change in vdsm[master]: untested: notify Engine when host connectivity changes

Francesco Romani has posted comments on this change. Change subject: untested: notify Engine when host connectivity changes .. Patch Set 1: (1 comment) conceptually I'm fine with the idea, but it needs some polishing.

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/51521 To unsubscribe, visit

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

Nir Soffer has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 6: Code-Review-1 (29 comments) Nice! We need to remove some unneeded

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: (6 comments) https://gerrit.ovirt.org/#/c/51521/2/vdsm/virt/vmchannels.py File

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51521/3/vdsm/virt/vmchannels.py File

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51521/3/vdsm/virt/vmchannels.py File

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51521/3/vdsm/virt/vmchannels.py File

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 4: Code-Review+1 I would like a log when unregister_fd does not find the fd in epoll, but

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/51521/2/vdsm/virt/vmchannels.py File

Change in vdsm[master]: Introduce commands package to separate execCmd and AsyncProc...

gerrit-hooks has posted comments on this change. Change subject: Introduce commands package to separate execCmd and AsyncProc from utils .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

  1   2   >