Change in vdsm[master]: kill and report asyncProc if fails on first write to stdin

Yaniv Bronhaim has posted comments on this change. Change subject: kill and report asyncProc if fails on first write to stdin .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51763 To unsubscribe, visit

Change in vdsm[master]: virt: Don't expose GuestAgent.guestInfo directly

Francesco Romani has posted comments on this change. Change subject: virt: Don't expose GuestAgent.guestInfo directly .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51508/4/vdsm/virt/guestagent.py File

Change in vdsm[master]: nestedvt: set CPU host-passthrough mode when enabled

Martin Polednik has uploaded a new change for review. Change subject: nestedvt: set CPU host-passthrough mode when enabled .. nestedvt: set CPU host-passthrough mode when enabled Nested KVM requires the VMS/VMX flag to be

Change in vdsm[master]: virt: safer handling of migration parameters

gerrit-hooks has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 4: * #1296936::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1296936::OK, public bug *

Change in vdsm[master]: virt: safer handling of migration parameters

Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 4: v4 adds basic tests with no code changes. -- To view, visit https://gerrit.ovirt.org/51656 To

Change in vdsm[master]: untested: notify Engine when host connectivity changes

Piotr Kliczewski has posted comments on this change. Change subject: untested: notify Engine when host connectivity changes .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py File

Change in vdsm[master]: migration: use context manager for semaphore

Milan Zamazal has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51655 To unsubscribe, visit

Change in vdsm[master]: virt: safer handling of migration parameters

Vinzenz Feenstra has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51656 To unsubscribe, visit

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

gerrit-hooks has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: vm: safer handling of conf in restore

Martin Polednik has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51657 To unsubscribe, visit

Change in vdsm[master]: vm: safer handling of conf in restore

Francesco Romani has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/51657/6//COMMIT_MSG Commit Message: Line 12: mutation > ...

Change in vdsm[master]: nestedvt: set CPU host-passthrough mode when enabled

Francesco Romani has posted comments on this change. Change subject: nestedvt: set CPU host-passthrough mode when enabled .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51764 To unsubscribe, visit

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: Code-Review-1 (8 comments) I think the general approach is OK, let's just improve the "technical

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

gerrit-hooks has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: virt: safer handling of migration parameters

Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51656/3/vdsm/virt/migration.py File

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Shahar Havivi has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (1 comment) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 317:

Change in vdsm[master]: migration: use context manager for semaphore

Vinzenz Feenstra has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51655 To unsubscribe, visit

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

Jenkins CI has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 3: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited

Change in vdsm[master]: test: Do not force verbose test output

Edward Haas has uploaded a new change for review. Change subject: test: Do not force verbose test output .. test: Do not force verbose test output Let the user explicitly enable verbose. Tests, especially unit tests, are

Change in vdsm[master]: test: Do not force verbose test output

gerrit-hooks has posted comments on this change. Change subject: test: Do not force verbose test output .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

Maor Lipchuk has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/51766 To unsubscribe, visit

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Francesco Romani has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Milan, please verify -- To view, visit https://gerrit.ovirt.org/51648 To unsubscribe, visit

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Francesco Romani has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Code-Review+2 it was OK for me before, now it is even better. -- To view, visit

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

Francesco Romani has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49972 To unsubscribe, visit

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

Francesco Romani has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 9: restored my score -- To view, visit https://gerrit.ovirt.org/49972 To unsubscribe,

Change in vdsm[master]: vm: safer handling of conf in restore

Jenkins CI has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 4: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 3 -- To

Change in vdsm[master]: vm: safer handling of conf in restore

gerrit-hooks has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: safer handling of migration parameters

Milan Zamazal has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 3: Code-Review+1 (4 comments) Please fix the typos in the commit message and I've got a question for

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

gerrit-hooks has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 3: * #1291930::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1291930::OK,

Change in vdsm[master]: v2v: tests: refactor v2vTests

Francesco Romani has posted comments on this change. Change subject: v2v: tests: refactor v2vTests .. Patch Set 1: Code-Review+2 yes, better this way -- To view, visit https://gerrit.ovirt.org/51703 To unsubscribe, visit

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

Piotr Kliczewski has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48868 To unsubscribe, visit

Change in vdsm[master]: vm: safer removal of the recovery file

Francesco Romani has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (3 comments) thanks for pointing out more english mistakes :)

Change in vdsm[master]: v2v: tests: new testing class: MockVirConnectTests

Shahar Havivi has posted comments on this change. Change subject: v2v: tests: new testing class: MockVirConnectTests .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/51704/2/tests/v2vTests.py File tests/v2vTests.py:

Change in vdsm[master]: migration: use context manager for semaphore

Martin Polednik has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51655 To unsubscribe, visit

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Francesco Romani has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: Code-Review-1 (2 comments) few tests are missing. Codewise looks good.

Change in vdsm[master]: register: Leave the logging to the vdsm-tool

gerrit-hooks has posted comments on this change. Change subject: register: Leave the logging to the vdsm-tool .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46978 To

Change in vdsm[master]: register: Leave the logging to the vdsm-tool

Fabian Deutsch has abandoned this change. Change subject: register: Leave the logging to the vdsm-tool .. Abandoned Let's keep the rgeistration log in a different place. -- To view, visit https://gerrit.ovirt.org/46978 To

Change in vdsm[master]: register: Leave the logging to the vdsm-tool

Fabian Deutsch has posted comments on this change. Change subject: register: Leave the logging to the vdsm-tool .. Patch Set 2: Okay, fine for me to drop this patch. -- To view, visit https://gerrit.ovirt.org/46978 To

Change in vdsm[master]: nestedvt: set CPU host-passthrough mode when enabled

gerrit-hooks has posted comments on this change. Change subject: nestedvt: set CPU host-passthrough mode when enabled .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: nestedvt: set CPU host-passthrough mode when enabled

Martin Polednik has posted comments on this change. Change subject: nestedvt: set CPU host-passthrough mode when enabled .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51764 To unsubscribe, visit

Change in vdsm[master]: vm: safer handling of conf in restore

gerrit-hooks has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: safer handling of migration parameters

Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/51656/3//COMMIT_MSG Commit Message: Line 9: need >

Change in vdsm[master]: virt: safer handling of migration parameters

gerrit-hooks has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 5: * #1296936::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1296936::OK, public bug *

Change in vdsm[master]: vm: safer handling of conf in restore

Milan Zamazal has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/51657/6//COMMIT_MSG Commit Message: Line 12:

Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support .. Patch Set 32: (1 comment) https://gerrit.ovirt.org/#/c/48672/32/tests/v2vTests.py File tests/v2vTests.py: Line 317:

Change in vdsm[master]: vm: safer handling of conf in restore

gerrit-hooks has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 3: * #1296936::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1296936::OK, public bug * Check

Change in vdsm[master]: migration: use context manager for semaphore

gerrit-hooks has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 3: * #1296936::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1296936::OK, public bug *

Change in vdsm[master]: virt: safer handling of migration parameters

gerrit-hooks has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 3: * #1296936::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1296936::OK, public bug *

Change in vdsm[master]: virt: safer handling of migration parameters

Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 5: v5 addresses comments from Milan added in v3. -- To view, visit https://gerrit.ovirt.org/51656

Change in vdsm[master]: vm: safer handling of conf in restore

gerrit-hooks has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

Maor Lipchuk has uploaded a new change for review. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. lun: Serial attr should not passed to libvirt for lun disks. Following the change which was

Change in vdsm[master]: virt: safer handling of migration parameters

Martin Polednik has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 5: Code-Review+1 Liking the change between #4 and #5, I'll trust you on it's safety. :) -- To

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

gerrit-hooks has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: vm: safer handling of conf in restore

gerrit-hooks has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: safer handling of migration parameters

Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 5: Verified+1 re-verified migrating VMs back and forth a few times with no issues. -- To view,

Change in vdsm[master]: test: Do not force verbose test output

Edward Haas has posted comments on this change. Change subject: test: Do not force verbose test output .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51772 To unsubscribe, visit

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

Dan Kenigsberg has submitted this change and it was merged. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. caps/lib: move CPU architecture details to lib/cpuarch CPU architecture details include

Change in vdsm[master]: tests: improve vmstats.disks coverage

Francesco Romani has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 4: Verified+1 trying again to make jenkins happy. No code changes. -- To view, visit

Change in vdsm[master]: virt: Add new guest agent API function for lifecycle-events

Vinzenz Feenstra has uploaded a new change for review. Change subject: virt: Add new guest agent API function for lifecycle-events .. virt: Add new guest agent API function for lifecycle-events This patch introduces a new API

Change in vdsm[master]: virt: Add support for the after migration event (GuestAgent)

Vinzenz Feenstra has uploaded a new change for review. Change subject: virt: Add support for the after migration event (GuestAgent) .. virt: Add support for the after migration event (GuestAgent) This reports the fininalization

Change in vdsm[master]: virt: Add the before migration event (GuestAgent)

Vinzenz Feenstra has uploaded a new change for review. Change subject: virt: Add the before migration event (GuestAgent) .. virt: Add the before migration event (GuestAgent) This event allows the guest operating system to

Change in vdsm[master]: vm: make _deleteVm() more robust

gerrit-hooks has posted comments on this change. Change subject: vm: make _deleteVm() more robust .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: migration: set timeout to 10 mins

Oved Ourfali has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51786 To unsubscribe, visit

Change in vdsm[master]: virt: Don't create on non-x86 architectures

Milan Zamazal has posted comments on this change. Change subject: virt: Don't create on non-x86 architectures .. Patch Set 3: Verified+1 Verified is still there for x86. Martin's ppc verification should be still valid as

Change in vdsm[master]: migration: set timeout to 10 mins

Michal Skrivanek has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51786/2/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py:

Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages

Allon Mureinik has posted comments on this change. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. Patch Set 9: ping? -- To view, visit https://gerrit.ovirt.org/36764 To unsubscribe, visit

Change in vdsm[master]: caps: use cpuarch module

gerrit-hooks has posted comments on this change. Change subject: caps: use cpuarch module .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: caps: use cpuarch module

Dan Kenigsberg has posted comments on this change. Change subject: caps: use cpuarch module .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49991 To unsubscribe, visit

Change in vdsm[master]: caps: use cpuarch module

Dan Kenigsberg has submitted this change and it was merged. Change subject: caps: use cpuarch module .. caps: use cpuarch module With the cpuarch module, some of the code in caps can be rewritten to use cpuarch directly.

Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

gerrit-hooks has posted comments on this change. Change subject: caps/lib: move CPU architecture details to lib/cpuarch .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. --

Change in vdsm[master]: vm: safer removal of the recovery file

Francesco Romani has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51387/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 827:

Change in vdsm[master]: vm: safer removal of the recovery file

Martin Polednik has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51387/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 827:

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

Piotr Kliczewski has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 4: Verified+1 Moved HookError from hooks to exception module. Verified locally by

Change in vdsm[master]: hooks: make sure that hook error inherits from vdsm exception

gerrit-hooks has posted comments on this change. Change subject: hooks: make sure that hook error inherits from vdsm exception .. Patch Set 4: * #1295778::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: exception: Inherit from VdsmException

gerrit-hooks has posted comments on this change. Change subject: exception: Inherit from VdsmException .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

gerrit-hooks has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: set timeout to 10 mins

Piotr Kliczewski has uploaded a new change for review. Change subject: migration: set timeout to 10 mins .. migration: set timeout to 10 mins On heavily loaded environments createMigration call can take a lot of time so we want

Change in vdsm[master]: migration: set timeout to 10 mins

Francesco Romani has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: (2 comments) looks good, a couple of questions and suggestions inside

Change in vdsm[master]: split to commandsTests.py - only execCmd tests

Yaniv Bronhaim has posted comments on this change. Change subject: split to commandsTests.py - only execCmd tests .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit

Change in vdsm[master]: migration: set timeout to 10 mins

Jenkins CI has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view,

Change in vdsm[master]: vm: safer removal of the recovery file

Francesco Romani has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (5 comments) https://gerrit.ovirt.org/#/c/51387/3//COMMIT_MSG Commit Message: Line 9: an > ... a ...

Change in vdsm[master]: py3 test improving

gerrit-hooks has posted comments on this change. Change subject: py3 test improving .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: virt: move getVDSMDomains in recovery.py

gerrit-hooks has posted comments on this change. Change subject: virt: move getVDSMDomains in recovery.py .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: move recovery load into VmState

gerrit-hooks has posted comments on this change. Change subject: virt: move recovery load into VmState .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: move channels constants into vmchannels.py

gerrit-hooks has posted comments on this change. Change subject: virt: move channels constants into vmchannels.py .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Delete unrelated files from patch

gerrit-hooks has posted comments on this change. Change subject: Delete unrelated files from patch .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51387/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 827:

Change in vdsm[master]: py3 test improving

gerrit-hooks has posted comments on this change. Change subject: py3 test improving .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: vm: safer removal of the recovery file

Milan Zamazal has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51387/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 827:

Change in vdsm[master]: virt: move getVDSMDomains in recovery.py

gerrit-hooks has posted comments on this change. Change subject: virt: move getVDSMDomains in recovery.py .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: extract cleanupRecoveryFile() helper

gerrit-hooks has posted comments on this change. Change subject: vm: extract cleanupRecoveryFile() helper .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: move channels constants into vmchannels.py

gerrit-hooks has posted comments on this change. Change subject: virt: move channels constants into vmchannels.py .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: move handling of recovery file in a class

gerrit-hooks has posted comments on this change. Change subject: virt: move handling of recovery file in a class .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: safer removal of the recovery file

gerrit-hooks has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 4: * #1253043::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1253043::OK, public bug * Check

Change in vdsm[master]: vm: make deleteVm private

gerrit-hooks has posted comments on this change. Change subject: vm: make deleteVm private .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: virt: move recovery load into VmState

gerrit-hooks has posted comments on this change. Change subject: virt: move recovery load into VmState .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: Remove staticmethod usage from guest agent

gerrit-hooks has posted comments on this change. Change subject: virt: Remove staticmethod usage from guest agent .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: Correct epoll unregistration usage in vmchannels

gerrit-hooks has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 10: * #1226911::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1226911::OK,

Change in vdsm[master]: migration: use context manager for semaphore

Michal Skrivanek has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51655 To unsubscribe, visit

  1   2   >