Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: We need also the previous patch, ensuring that fds are closed on execv. This is probably the

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51841 To unsubscribe, visit https:/

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Nir Soffer has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51840 To unsubscribe, visit https:/

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: waiting for more reviews. -- To view, visit https://gerrit.ovirt.org/51840 To unsubsc

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

Francesco Romani has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 2: Code-Review+1 very nice catch! -- To view, visit https://gerrit.ovirt.org/51868 To unsubscribe,

Change in vdsm[master]: utils: add weakmethod helper

Vinzenz Feenstra has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51865/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 905: func =

Change in vdsm[master]: utils: add weakmethod helper

Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (9 comments) https://gerrit.ovirt.org/#/c/51865/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 905: func = meth

Change in vdsm[master]: utils: add weakmethod helper

Vinzenz Feenstra has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py File tests/utilsTests.py: Line 1057: Line

Change in vdsm[master]: utils: add weakmethod helper

Vinzenz Feenstra has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/51865/4/tests/utilsTests.py File tests

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Vinzenz Feenstra has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit https://ge

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Nir Soffer has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 7: Code-Review+1 Waiting for other reviews -- To view, visit https://gerrit.ovirt.org/51630 To unsubscr

Change in vdsm[master]: sp: update domain links on state change

Adam Litke has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 7: Code-Review+1 Looks good to me but I'd prefer Nir to +2 it. -- To view, visit https://gerrit.ovirt.org/513

Change in vdsm[master]: Added Python 3 support for sslTests.py

gerrit-hooks has posted comments on this change. Change subject: Added Python 3 support for sslTests.py .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: kill and report asyncProc if fails on first write to stdin

Nir Soffer has posted comments on this change. Change subject: kill and report asyncProc if fails on first write to stdin .. Patch Set 2: Code-Review-1 (2 comments) On second look there are some issues. https://gerrit.ovirt.o

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

Nir Soffer has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/51868 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: kill and report asyncProc if fails on first write to stdin

Nir Soffer has posted comments on this change. Change subject: kill and report asyncProc if fails on first write to stdin .. Patch Set 2: Code-Review+1 (2 comments) Code looks fine, but commit message needs more love. https:/

Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

Nir Soffer has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 2: Code-Review+1 (1 comment) Minor issue with the import, otherwise looks good. https://gerrit.ovi

Change in vdsm[master]: tests: Stress test the loop leak fix

Nir Soffer has abandoned this change. Change subject: tests: Stress test the loop leak fix .. Abandoned Not needed now -- To view, visit https://gerrit.ovirt.org/51748 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: tests: Stress test the loop leak fix

gerrit-hooks has posted comments on this change. Change subject: tests: Stress test the loop leak fix .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/51748 To unsubscribe,

Change in vdsm[master]: sp: update domain links on state change

Nir Soffer has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 7: Code-Review+1 (2 comments) Looks good, the commit message needs minor cleanup. Waiting for Adam and Liron

Change in vdsm[master]: health: Introduce Vdsm health monitoring

gerrit-hooks has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

gerrit-hooks has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 2: * #1269424::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269424::OK, public bug * Che

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

Nir Soffer has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 1: Verified+1 Verified using the tests and with sanity flow. -- To view, visit https://gerrit.ovirt.org/

Change in vdsm[master]: health: Introduce Vdsm health monitoring

Nir Soffer has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 2: Verified+1 Works now, used to find RWLock leak. -- To view, visit https://gerrit.ovirt.org/51708 To unsub

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

gerrit-hooks has posted comments on this change. Change subject: misc: Fix RWLock leak due to reference cycle .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: misc: Fix RWLock leak due to reference cycle

Nir Soffer has uploaded a new change for review. Change subject: misc: Fix RWLock leak due to reference cycle .. misc: Fix RWLock leak due to reference cycle RWLock shared and exclusive context managers had a reference cycle; th

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: sure, I just prepared everything already - Thanks already -- To view, visit https://g

Change in vdsm[master]: health: Introduce Vdsm health monitoring

gerrit-hooks has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Jenkins CI has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 7: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 6 -

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 7: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Pu

Change in vdsm[ovirt-3.6]: lun: Serial attr should not passed to libvirt for lun disks.

Francesco Romani has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: Code-Review+1 looks fine, but the bz is scheduled for ovirt 3.6.5 (!!!), do we ne

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: will merge after 3.6 patch is merged to respect the proper flow, and to let automation

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 4: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN, n

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 6: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Pu

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 5: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Pu

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Francesco Romani has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 4: Michal, sure thing, let me amend my commit message to read something like This patch uses util

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: jenkins CI score is indeed bogus - removing, will retry later. -- To view, visit http

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: Code-Review+2 code is indeed identical to master (did actual diff), and this patch is

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 4: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Pu

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 3: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN, n

Change in vdsm[ovirt-3.6]: lun: Serial attr should not passed to libvirt for lun disks.

Nir Soffer has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51848 To unsubscribe, visit h

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Michal Skrivanek has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 3: Code-Review+1 this is a backporting material - we don't want to change behavior of killing vdsm

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/51866 To uns

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 2: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN, n

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Francesco Romani has abandoned this change. Change subject: lib: use weakmethod to break reference cycles .. Abandoned wrong change-id, should have been https://gerrit.ovirt.org/51630 -- To view, visit https://gerrit.ovirt.or

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 3: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Pu

Change in vdsm[master]: sp: update domain links on state change

Idan Shaby has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/51393/6/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 144: L

Change in vdsm[master]: sp: update domain links on state change

gerrit-hooks has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 7: * #1271771::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1271771::OK, public bug * Check Pr

Change in vdsm[ovirt-3.6]: lun: Serial attr should not passed to libvirt for lun disks.

Maor Lipchuk has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51848 To unsubscribe, visit ht

Change in vdsm[master]: utils: add weakmethod helper

Francesco Romani has uploaded a new change for review. Change subject: utils: add weakmethod helper .. utils: add weakmethod helper TODO: write proper commit message. Change-Id: I9f26aa314e26142122e9f594275406cf7fbade98 Bug-Url

Change in vdsm[master]: utils: add weakmethod helper

gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url

Change in vdsm[master]: lib: use weakmethod to break reference cycles

Francesco Romani has uploaded a new change for review. Change subject: lib: use weakmethod to break reference cycles .. lib: use weakmethod to break reference cycles TODO: write proper commit message Change-Id: I6906d4ea6a3fd59

Change in vdsm[master]: lib: use weakmethod to break reference cycles

gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

gerrit-hooks has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Petr Horáček has uploaded a new change for review. Change subject: hooks: ovs: enable auto-attach mapping .. hooks: ovs: enable auto-attach mapping Add Auto-Attach mapping support to OVS hook. I-SID could be defined in engine wi

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: Verified+1 Verified on 3.5 branch migrated vms back and forth, started and stopped vms

Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

Piotr Kliczewski has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51850/1/vdsm/supervdsmServer File vdsm/supervdsmS

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/51407/8/lib/vdsm/commands.py F

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: Verified on 3.6 branch migrated vms back and forth, started and stopped vms and restar

Change in vdsm[ovirt-3.6]: virt: Correct epoll unregistration usage in vmchannels

Vinzenz Feenstra has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/51840 To unsubscribe, visit http

Change in vdsm[master]: health: Introduce Vdsm health monitoring

Nir Soffer has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51708/1/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 4

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

gerrit-hooks has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 2: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 7: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * C

Change in vdsm[master]: virt: stats: make compute_latency more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 7: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Ch

Change in vdsm[master]: virt: stats: make disk_rate more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 10: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check P

Change in vdsm[master]: tests: improve vmstats.disks coverage

gerrit-hooks has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 6: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check Prod

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

Francesco Romani has uploaded a new change for review. Change subject: tests: extend coverage for vmstats.disks() .. tests: extend coverage for vmstats.disks() This patch adds tests to cover the existing behaviour of vmstats.dis

Change in vdsm[ovirt-3.5]: virt: Correct epoll unregistration usage in vmchannels

Francesco Romani has posted comments on this change. Change subject: virt: Correct epoll unregistration usage in vmchannels .. Patch Set 2: Code-Review+1 IIRC this code hasn't changed that much, and the patch looks good. Please

Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

Nir Soffer has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51850/1/vdsm/supervdsmServer File vdsm/supervdsmServer:

Change in vdsm[master]: kill and report asyncProc if fails on first write to stdin

Piotr Kliczewski has posted comments on this change. Change subject: kill and report asyncProc if fails on first write to stdin .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/51763/2/lib/vdsm/commands.py File lib/vds

Change in vdsm[master]: tests: improve vmstats.disks coverage

Francesco Romani has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 4: split this patch in two: https://gerrit.ovirt.org/51854 just add tests for existing code, which doesn't

Change in vdsm[master]: virt: stats: make compute_latency more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make compute_latency more robust .. Patch Set 6: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Ch

Change in vdsm[master]: tests: extend coverage for vmstats.disks()

gerrit-hooks has posted comments on this change. Change subject: tests: extend coverage for vmstats.disks() .. Patch Set 1: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check

Change in vdsm[master]: split to commandsTests.py - only execCmd tests

Piotr Kliczewski has posted comments on this change. Change subject: split to commandsTests.py - only execCmd tests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51762 To unsubscribe, visit https://g

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 6: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * C

Change in vdsm[master]: virt: stats: make disk_rate more robust

gerrit-hooks has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 9: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check Pr

Change in vdsm[master]: tests: improve vmstats.disks coverage

gerrit-hooks has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 5: * #1281337::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281337::OK, public bug * Check Prod

Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

Piotr Kliczewski has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: We see this issue only in Brno production system on one host. I applied the fix there to m

Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

Piotr Kliczewski has uploaded a new change for review. Change subject: supervdsm: failed validateAccess leaves pipes open .. supervdsm: failed validateAccess leaves pipes open Whenever we run validateAccess and it fails with "Pe

Change in vdsm[master]: supervdsm: failed validateAccess leaves pipes open

gerrit-hooks has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: tests: improve vmstats.disks coverage

Francesco Romani has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 4: -Verified -- To view, visit https://gerrit.ovirt.org/50598 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: migration: set timeout to 10 mins

Michal Skrivanek has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51786 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: tests: improve vmstats.disks coverage

Francesco Romani has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 4: (1 comment) good point, so the correct approach is: add tests, make sure they fail, mark them @brokent

Change in vdsm[ovirt-3.6]: lun: Serial attr should not passed to libvirt for lun disks.

gerrit-hooks has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: * #1291930::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1291930::OK,

Change in vdsm[ovirt-3.6]: lun: Serial attr should not passed to libvirt for lun disks.

Hello Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/51848 to review the following change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. lun: Serial a

Change in vdsm[master]: health: Introduce Vdsm health monitoring

Oved Ourfali has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 1: Code-Review+1 (1 comment) Wait for Piotr/Yaniv to review, of course. https://gerrit.ovirt.org/#/c/51708

Change in vdsm[master]: native ovs

gerrit-hooks has posted comments on this change. Change subject: native ovs .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a vali

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

Nir Soffer has submitted this change and it was merged. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. lun: Serial attr should not passed to libvirt for lun disks. Following the change which was

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

gerrit-hooks has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 5: * #1291930::Update tracker: OK * Set MODIFIED::bug 1291930#1291930IGNORE, not

Change in vdsm[master]: lun: Serial attr should not passed to libvirt for lun disks.

Nir Soffer has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51766 To unsubscribe, visit h

Change in vdsm[master]: test: Configurable verbose test output

Edward Haas has posted comments on this change. Change subject: test: Configurable verbose test output .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/51772 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: test: Configurable verbose test output

Edward Haas has posted comments on this change. Change subject: test: Configurable verbose test output .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51772/1//COMMIT_MSG Commit Message: Line 8: Line 9: Let the user

Change in vdsm[master]: test: Configurable verbose test output

gerrit-hooks has posted comments on this change. Change subject: test: Configurable verbose test output .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: tests: improve vmstats.disks coverage

Milan Zamazal has posted comments on this change. Change subject: tests: improve vmstats.disks coverage .. Patch Set 4: (1 comment) I think the tests checking for missing stats are intended to report that corresponding KeyErr

Change in vdsm[master]: storage: Introduction to imagetickets.py

gerrit-hooks has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: storage: Introduction to imagetickets.py

Amit Aviram has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 8: (18 comments) https://gerrit.ovirt.org/#/c/50014/8/client/vdsClient.py File client/vdsClient.py: Line 16

Change in vdsm[master]: vm: delete recovery file only after destroy()

Milan Zamazal has posted comments on this change. Change subject: vm: delete recovery file only after destroy() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51799/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3892:

Change in vdsm[master]: storage: Introduction to imagetickets.py

gerrit-hooks has posted comments on this change. Change subject: storage: Introduction to imagetickets.py .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: supervdsm: use cpuarch

Milan Zamazal has posted comments on this change. Change subject: supervdsm: use cpuarch .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51433 To unsubscribe, visit https://gerrit.ovirt.org/settings G

  1   2   >