Nir Soffer has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 14: Code-Review-1
Duplicate url sneaked into the commit message
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11:
Francesco, can you chec why jenkins is unhappy?
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11:
Nir, sure thing.
Looks like my test caught the ResourceRef leak you fixed:
00:17:03.041
Francesco Romani has posted comments on this change.
Change subject: migration: use context manager for semaphore
..
Patch Set 2: Continuous-Integration+1
run CI tests manually + test on RHEL 6.7 environment, seems OK.
--
To
Francesco Romani has posted comments on this change.
Change subject: migration: use context manager for semaphore
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52341
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: safer handling of migration parameters
..
Patch Set 3:
* #1298190::Update tracker: OK
* Set MODIFIED::bug 1298190#1298190IGNORE, not oVirt
Francesco Romani has submitted this change and it was merged.
Change subject: virt: safer handling of migration parameters
..
virt: safer handling of migration parameters
The Migration Source code path needs to store
gerrit-hooks has posted comments on this change.
Change subject: migration: use context manager for semaphore
..
Patch Set 3:
* #1298190::Update tracker: OK
* Set MODIFIED::bug 1298190#1298190IGNORE, not oVirt
Dan Kenigsberg has posted comments on this change.
Change subject: net: Enable VDSM to perform migration over IPv6
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/51933/2/vdsm/virt/migration.py
File
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit
Oved Ourfali has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 4:
Can we merge that?
--
To view, visit https://gerrit.ovirt.org/51786
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: guest-agent: desktopLock exception on EBADF should be ignored
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Francesco Romani has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 14:
fixed duplicate URL
--
To view, visit https://gerrit.ovirt.org/51630
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: virt: safer handling of migration parameters
..
Patch Set 2:
merge?
--
To view, visit https://gerrit.ovirt.org/52342
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: migration: use context manager for semaphore
..
migration: use context manager for semaphore
The migration source code path needs to take the
gerrit-hooks has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 15:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check
Michal Skrivanek has posted comments on this change.
Change subject: vm: safer handling of conf in restore
..
Patch Set 2:
merge?
--
To view, visit https://gerrit.ovirt.org/52343
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: migration: use context manager for semaphore
..
Patch Set 2:
merge?
--
To view, visit https://gerrit.ovirt.org/52341
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: vm: safer handling of conf in restore
..
vm: safer handling of conf in restore
In the restore state (aka dehibernation) path, there
are a few places
Francesco Romani has posted comments on this change.
Change subject: virt: safer handling of migration parameters
..
Patch Set 2: Code-Review+2 Continuous-Integration+1
run tests locally + run basic sanity tests on RHEL 6.7
gerrit-hooks has posted comments on this change.
Change subject: vm: safer handling of conf in restore
..
Patch Set 3:
* #1298190::Update tracker: OK
* Set MODIFIED::bug 1298190#1298190IGNORE, not oVirt classification
Francesco Romani has posted comments on this change.
Change subject: vm: safer handling of conf in restore
..
Patch Set 2: Code-Review+2 Continuous-Integration+1
run tests locally: some tests fail, but unrelated (bonds)
run on
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: introduction of yaml schema format
..
schema: introduction of yaml schema format
The vdsm-api file contains potential format of new schema. There
gerrit-hooks has posted comments on this change.
Change subject: schema: introduction of yaml schema format
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: tests: lib: add tests for utils.weakmethod
..
Patch Set 1:
(6 comments)
https://gerrit.ovirt.org/#/c/52408/1/tests/utilsTests.py
File tests/utilsTests.py:
Line
Martin Polednik has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/51865/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 908:
Line
Nir Soffer has posted comments on this change.
Change subject: Introducing context manager to terminate async processes on
internal fail
..
Patch Set 14: Code-Review+1
Waiting for Piotr and Dan reviews
--
To view, visit
Marcin Mirecki has abandoned this change.
Change subject: vm: nic hotunplug, perform libvirt operation before modyfing
vdsm nic objects
..
Abandoned
This was an alternative solution to:
https://gerrit.ovirt.org/#/c/51187/
gerrit-hooks has posted comments on this change.
Change subject: vm: nic hotunplug, perform libvirt operation before modyfing
vdsm nic objects
..
Patch Set 1:
* #1134256::Update tracker: OK
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 5:
* #1295778::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1295778::OK,
Piotr Kliczewski has uploaded a new change for review.
Change subject: hooks: moving hook error to exception module
..
hooks: moving hook error to exception module
Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056
gerrit-hooks has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: simplify bridge tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: simplify bridge tests
..
tests: simplify bridge tests
Change-Id: I02f9fb60898b49f63915ac6a26b6e62d5e09a4d0
Signed-off-by: pkliczewski
Michal Skrivanek has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 7:
(8 comments)
https://gerrit.ovirt.org/#/c/35181/7/contrib/jsonrpc
File contrib/jsonrpc:
Line 25: methods and
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: safer removal of the recovery file
..
vm: safer removal of the recovery file
If a user shutdowns a VM from inside the guest, Vdsm leaves
a stale
Dan Kenigsberg has posted comments on this change.
Change subject: vm: delete recovery file only after destroy()
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51799
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: safer removal of the recovery file
..
Patch Set 6:
* #1253043::Update tracker: OK
* Set MODIFIED::bug 1253043#1253043IGNORE, not oVirt classification
Dan Kenigsberg has posted comments on this change.
Change subject: vm: safer removal of the recovery file
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51387
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py
File
Nir Soffer has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51630
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51630
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 6:
What I mean is that there is an effort to improve amount of data that we
collect about vdsm/engine
Vinzenz Feenstra has posted comments on this change.
Change subject: guest-agent: desktopLock exception on EBADF should be ignored
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/47404
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check Public Bug::WARN,
Francesco Romani has uploaded a new change for review.
Change subject: tests: lib: add tests for utils.weakmethod
..
tests: lib: add tests for utils.weakmethod
This patch adds tests for utils.weakmethod().
The tests were
gerrit-hooks has posted comments on this change.
Change subject: tests: lib: add tests for utils.weakmethod
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 16:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283999::ERROR, private bug
* Check
Nir Soffer has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12: Verified+1
stripped out the tests in 52408 because of unrelated failures/they are not
trivial to get right in
Martin Polednik has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: add weakmethod helper
..
utils: add weakmethod helper
The libvirtconnection module adds wrapping around virDomain
objects, to detect and react
gerrit-hooks has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 17:
* update_tracker: OK
* Set MODIFIED::bug 1283999#1283999IGNORE, not oVirt classification
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: use weakmethod to break reference cycles
..
lib: use weakmethod to break reference cycles
The libvirtconnection module replaces the methods
of
gerrit-hooks has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 13:
* update_tracker: OK
* Set MODIFIED::bug 1283999#1283999IGNORE, not oVirt classification but
--
To view,
Francesco Romani has posted comments on this change.
Change subject: virt: stats: make _disk_iops_bytes more robust
..
Patch Set 8: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/50594/8/vdsm/virt/vmstats.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt: stats: make disk_rate more robust
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/48493/11/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
gerrit-hooks has posted comments on this change.
Change subject: vm: use response module in the destroy path
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: vm: use response module in the destroy path
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51383
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: use response module in the destroy path
..
vm: use response module in the destroy path
use the facilities of the response module to
make the code
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: make deleteVm private
..
vm: make deleteVm private
The Vm.deleteVm() method is never used outside the Vm class,
so it should be _private.
gerrit-hooks has posted comments on this change.
Change subject: vm: make deleteVm private
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: make deleteVm private
..
Patch Set 4: Code-Review+2 Continuous-Integration+1
I bet the error had nothing to do with the patch.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: make _deleteVm() more robust
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/51385/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Edward Haas has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Edward Haas has posted comments on this change.
Change subject: net: Use VLAN ID as integer across VDSM
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/51802/3/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.py:
gerrit-hooks has posted comments on this change.
Change subject: net: Use VLAN ID as integer across VDSM
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move channels constants into vmchannels.py
..
Patch Set 5: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/51475/5/vdsm/virt/vmchannels.py
File
Edward Haas has posted comments on this change.
Change subject: net: Use VLAN ID as integer across VDSM
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/51802
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: move getVDSMDomains in recovery.py
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/51476/5/vdsm/virt/recovery.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move getVDSMDomains in recovery.py
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51476/5/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:
Francesco Romani has posted comments on this change.
Change subject: virt: move handling of recovery file in a class
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/recovery.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move handling of recovery file in a class
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/recovery.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: move recovery load into VmState
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/51389/6/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:
Allon Mureinik has posted comments on this change.
Change subject: lun: Serial attr should not passed to libvirt for lun disks.
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG
Yaniv Bronhaim has posted comments on this change.
Change subject: net: vdsClient fails to connect to an IPv6 addr
..
Patch Set 2: Code-Review+1
jenkins error is not related
--
To view, visit https://gerrit.ovirt.org/52367
gerrit-hooks has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Add readers contention rwlock test
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: lun: Serial attr should not passed to libvirt for lun disks.
..
Patch Set 1: Code-Review+1
Cannot be simpler, but we need to verify this on rhel 6 and 7.
--
To
Yaniv Bronhaim has posted comments on this change.
Change subject: lun: Serial attr should not passed to libvirt for lun disks.
..
Patch Set 1: Code-Review-1
you will have to have 3.5.z bug for that ..
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove unneeded assert
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 20:
This version updates the copyright years, no code change.
--
To view, visit https://gerrit.ovirt.org/43423
To
Nir Soffer has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 24: Verified+1
This version updates the copyright years and improve the commit message, no
code change.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: tests: simplify bridge tests
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52414
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: host: use cpuarch
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/51434/7//COMMIT_MSG
Commit Message:
Line 6:
Line 7: host: use cpuarch
Line 8:
Line
Nir Soffer has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51549
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: dsaversion: use cpuarch
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51719
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: lun: Serial attr should not passed to libvirt for lun disks.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG
Commit Message:
Line 7:
Nir Soffer has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 5: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/51549/5/tests/bridgeTests.py
File
Nir Soffer has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1: Code-Review+1
How old engines (e.g, 3.6) will handle the new error code?
previously we sent
Maor Lipchuk has posted comments on this change.
Change subject: lun: Serial attr should not passed to libvirt for lun disks.
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dsaversion: use cpuarch
..
dsaversion: use cpuarch
This patch replaces the previous platform lookup that used string
constants by more sophisticated
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm: use cpuarch
..
supervdsm: use cpuarch
This patch replaces the previous platform lookup that used string
constants by more sophisticated
Yaniv Bronhaim has posted comments on this change.
Change subject: net: Cleanup _create_socket from dead code
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52462
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: use cpuarch
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: dsaversion: use cpuarch
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
1 - 100 of 181 matches
Mail list logo