Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 14: Code-Review-1 Duplicate url sneaked into the commit message -- To view, visit

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 11: Francesco, can you chec why jenkins is unhappy? -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe,

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 11: Nir, sure thing. Looks like my test caught the ResourceRef leak you fixed: 00:17:03.041

Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 2: Continuous-Integration+1 run CI tests manually + test on RHEL 6.7 environment, seems OK. -- To

Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52341 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 3: * #1298190::Update tracker: OK * Set MODIFIED::bug 1298190#1298190IGNORE, not oVirt

Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters

2016-01-19 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: virt: safer handling of migration parameters .. virt: safer handling of migration parameters The Migration Source code path needs to store

Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 3: * #1298190::Update tracker: OK * Set MODIFIED::bug 1298190#1298190IGNORE, not oVirt

Change in vdsm[master]: net: Enable VDSM to perform migration over IPv6

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: Enable VDSM to perform migration over IPv6 .. Patch Set 2: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/51933/2/vdsm/virt/migration.py File

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit

Change in vdsm[master]: migration: set timeout to 10 mins

2016-01-19 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: migration: set timeout to 10 mins .. Patch Set 4: Can we merge that? -- To view, visit https://gerrit.ovirt.org/51786 To unsubscribe, visit

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 14: fixed duplicate URL -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters

2016-01-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 2: merge? -- To view, visit https://gerrit.ovirt.org/52342 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore

2016-01-19 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: migration: use context manager for semaphore .. migration: use context manager for semaphore The migration source code path needs to take the

Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 15: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check

Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore

2016-01-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 2: merge? -- To view, visit https://gerrit.ovirt.org/52343 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: migration: use context manager for semaphore

2016-01-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: migration: use context manager for semaphore .. Patch Set 2: merge? -- To view, visit https://gerrit.ovirt.org/52341 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore

2016-01-19 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: vm: safer handling of conf in restore .. vm: safer handling of conf in restore In the restore state (aka dehibernation) path, there are a few places

Change in vdsm[ovirt-3.5]: virt: safer handling of migration parameters

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: safer handling of migration parameters .. Patch Set 2: Code-Review+2 Continuous-Integration+1 run tests locally + run basic sanity tests on RHEL 6.7

Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 3: * #1298190::Update tracker: OK * Set MODIFIED::bug 1298190#1298190IGNORE, not oVirt classification

Change in vdsm[ovirt-3.5]: vm: safer handling of conf in restore

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: safer handling of conf in restore .. Patch Set 2: Code-Review+2 Continuous-Integration+1 run tests locally: some tests fail, but unrelated (bonds) run on

Change in vdsm[master]: schema: introduction of yaml schema format

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: schema: introduction of yaml schema format .. schema: introduction of yaml schema format The vdsm-api file contains potential format of new schema. There

Change in vdsm[master]: schema: introduction of yaml schema format

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: schema: introduction of yaml schema format .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: lib: add tests for utils.weakmethod

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: lib: add tests for utils.weakmethod .. Patch Set 1: (6 comments) https://gerrit.ovirt.org/#/c/52408/1/tests/utilsTests.py File tests/utilsTests.py: Line

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/51865/12/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 908: Line

Change in vdsm[master]: Introducing context manager to terminate async processes on ...

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail .. Patch Set 14: Code-Review+1 Waiting for Piotr and Dan reviews -- To view, visit

Change in vdsm[master]: vm: nic hotunplug, perform libvirt operation before modyfing...

2016-01-19 Thread mmirecki
Marcin Mirecki has abandoned this change. Change subject: vm: nic hotunplug, perform libvirt operation before modyfing vdsm nic objects .. Abandoned This was an alternative solution to: https://gerrit.ovirt.org/#/c/51187/

Change in vdsm[master]: vm: nic hotunplug, perform libvirt operation before modyfing...

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: nic hotunplug, perform libvirt operation before modyfing vdsm nic objects .. Patch Set 1: * #1134256::Update tracker: OK -- To view, visit

Change in vdsm[master]: hooks: make sure to handle vdsm exception in the bridge

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: make sure to handle vdsm exception in the bridge .. Patch Set 5: * #1295778::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1295778::OK,

Change in vdsm[master]: hooks: moving hook error to exception module

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: hooks: moving hook error to exception module .. hooks: moving hook error to exception module Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056

Change in vdsm[master]: hooks: moving hook error to exception module

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: moving hook error to exception module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: simplify bridge tests

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: simplify bridge tests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: simplify bridge tests

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: tests: simplify bridge tests .. tests: simplify bridge tests Change-Id: I02f9fb60898b49f63915ac6a26b6e62d5e09a4d0 Signed-off-by: pkliczewski

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit

Change in vdsm[master]: contrib: Simple jsonrpc client

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 7: (8 comments) https://gerrit.ovirt.org/#/c/35181/7/contrib/jsonrpc File contrib/jsonrpc: Line 25: methods and

Change in vdsm[master]: vm: safer removal of the recovery file

2016-01-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: safer removal of the recovery file .. vm: safer removal of the recovery file If a user shutdowns a VM from inside the guest, Vdsm leaves a stale

Change in vdsm[master]: vm: delete recovery file only after destroy()

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: delete recovery file only after destroy() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51799 To unsubscribe, visit

Change in vdsm[master]: vm: safer removal of the recovery file

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 6: * #1253043::Update tracker: OK * Set MODIFIED::bug 1253043#1253043IGNORE, not oVirt classification

Change in vdsm[master]: vm: safer removal of the recovery file

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: safer removal of the recovery file .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51387 To unsubscribe, visit

Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py File

Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit

Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit

Change in vdsm[master]: health: Introduce Vdsm health monitoring

2016-01-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: health: Introduce Vdsm health monitoring .. Patch Set 6: What I mean is that there is an effort to improve amount of data that we collect about vdsm/engine

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

2016-01-19 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/47404 To unsubscribe,

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 12: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check Public Bug::WARN,

Change in vdsm[master]: tests: lib: add tests for utils.weakmethod

2016-01-19 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: tests: lib: add tests for utils.weakmethod .. tests: lib: add tests for utils.weakmethod This patch adds tests for utils.weakmethod(). The tests were

Change in vdsm[master]: tests: lib: add tests for utils.weakmethod

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: lib: add tests for utils.weakmethod .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 16: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283999::ERROR, private bug * Check

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 12: Verified+1 stripped out the tests in 52408 because of unrelated failures/they are not trivial to get right in

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51865 To unsubscribe, visit

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: add weakmethod helper .. utils: add weakmethod helper The libvirtconnection module adds wrapping around virDomain objects, to detect and react

Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles .. Patch Set 17: * update_tracker: OK * Set MODIFIED::bug 1283999#1283999IGNORE, not oVirt classification

Change in vdsm[master]: lib: use weakmethod to break reference cycles

2016-01-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: lib: use weakmethod to break reference cycles .. lib: use weakmethod to break reference cycles The libvirtconnection module replaces the methods of

Change in vdsm[master]: utils: add weakmethod helper

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: add weakmethod helper .. Patch Set 13: * update_tracker: OK * Set MODIFIED::bug 1283999#1283999IGNORE, not oVirt classification but -- To view,

Change in vdsm[master]: virt: stats: make _disk_iops_bytes more robust

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: stats: make _disk_iops_bytes more robust .. Patch Set 8: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/50594/8/vdsm/virt/vmstats.py File

Change in vdsm[master]: virt: stats: make disk_rate more robust

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: stats: make disk_rate more robust .. Patch Set 11: (3 comments) https://gerrit.ovirt.org/#/c/48493/11/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py:

Change in vdsm[master]: vm: use response module in the destroy path

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: use response module in the destroy path .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: vm: use response module in the destroy path

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: use response module in the destroy path .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51383 To unsubscribe, visit

Change in vdsm[master]: vm: use response module in the destroy path

2016-01-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: use response module in the destroy path .. vm: use response module in the destroy path use the facilities of the response module to make the code

Change in vdsm[master]: vm: make deleteVm private

2016-01-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: make deleteVm private .. vm: make deleteVm private The Vm.deleteVm() method is never used outside the Vm class, so it should be _private.

Change in vdsm[master]: vm: make deleteVm private

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: make deleteVm private .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: vm: make deleteVm private

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: make deleteVm private .. Patch Set 4: Code-Review+2 Continuous-Integration+1 I bet the error had nothing to do with the patch. -- To view, visit

Change in vdsm[master]: vm: make _deleteVm() more robust

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: make _deleteVm() more robust .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51385/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line

Change in vdsm[master]: net: When IPv6 is not enabled, fallback to IPv4

2016-01-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py File vdsm/clientIF.py: Line

Change in vdsm[master]: net: Use VLAN ID as integer across VDSM

2016-01-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Use VLAN ID as integer across VDSM .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51802/3/lib/vdsm/kernelconfig.py File lib/vdsm/kernelconfig.py:

Change in vdsm[master]: net: Use VLAN ID as integer across VDSM

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Use VLAN ID as integer across VDSM .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: move channels constants into vmchannels.py

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: move channels constants into vmchannels.py .. Patch Set 5: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/51475/5/vdsm/virt/vmchannels.py File

Change in vdsm[master]: net: Use VLAN ID as integer across VDSM

2016-01-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Use VLAN ID as integer across VDSM .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/51802 To unsubscribe, visit

Change in vdsm[master]: virt: move getVDSMDomains in recovery.py

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: move getVDSMDomains in recovery.py .. Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/51476/5/vdsm/virt/recovery.py File

Change in vdsm[master]: virt: move getVDSMDomains in recovery.py

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: move getVDSMDomains in recovery.py .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/51476/5/vdsm/virt/recovery.py File vdsm/virt/recovery.py:

Change in vdsm[master]: virt: move handling of recovery file in a class

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: move handling of recovery file in a class .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/recovery.py File

Change in vdsm[master]: virt: move handling of recovery file in a class

2016-01-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: move handling of recovery file in a class .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/recovery.py File

Change in vdsm[master]: virt: move recovery load into VmState

2016-01-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: move recovery load into VmState .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/51389/6/vdsm/virt/recovery.py File vdsm/virt/recovery.py:

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

2016-01-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG

Change in vdsm[master]: net: vdsClient fails to connect to an IPv6 addr

2016-01-19 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: net: vdsClient fails to connect to an IPv6 addr .. Patch Set 2: Code-Review+1 jenkins error is not related -- To view, visit https://gerrit.ovirt.org/52367

Change in vdsm[master]: rwlock: Replace misc.RWLock

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Add readers contention rwlock test

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add readers contention rwlock test .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: Code-Review+1 Cannot be simpler, but we need to verify this on rhel 6 and 7. -- To

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

2016-01-19 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: Code-Review-1 you will have to have 3.5.z bug for that .. -- To view, visit

Change in vdsm[master]: rwlock: Add simpler RWLock

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Remove unneeded assert

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Remove unneeded assert .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: rwlock: Replace misc.RWLock

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 20: This version updates the copyright years, no code change. -- To view, visit https://gerrit.ovirt.org/43423 To

Change in vdsm[master]: rwlock: Add simpler RWLock

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 24: Verified+1 This version updates the copyright years and improve the commit message, no code change. -- To view,

Change in vdsm[master]: tests: simplify bridge tests

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: simplify bridge tests .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52414 To unsubscribe, visit

Change in vdsm[master]: host: use cpuarch

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: host: use cpuarch .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/51434/7//COMMIT_MSG Commit Message: Line 6: Line 7: host: use cpuarch Line 8: Line

Change in vdsm[master]: hooks: make sure to handle vdsm exception in the bridge

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hooks: make sure to handle vdsm exception in the bridge .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51549 To unsubscribe, visit

Change in vdsm[master]: dsaversion: use cpuarch

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: dsaversion: use cpuarch .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/51719 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG Commit Message: Line 7:

Change in vdsm[master]: hooks: make sure to handle vdsm exception in the bridge

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hooks: make sure to handle vdsm exception in the bridge .. Patch Set 5: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/51549/5/tests/bridgeTests.py File

Change in vdsm[master]: hooks: moving hook error to exception module

2016-01-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hooks: moving hook error to exception module .. Patch Set 1: Code-Review+1 How old engines (e.g, 3.6) will handle the new error code? previously we sent

Change in vdsm[ovirt-3.5]: lun: Serial attr should not passed to libvirt for lun disks.

2016-01-19 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: lun: Serial attr should not passed to libvirt for lun disks. .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/52463/1//COMMIT_MSG Commit Message: Line

Change in vdsm[master]: dsaversion: use cpuarch

2016-01-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: dsaversion: use cpuarch .. dsaversion: use cpuarch This patch replaces the previous platform lookup that used string constants by more sophisticated

Change in vdsm[master]: supervdsm: use cpuarch

2016-01-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: supervdsm: use cpuarch .. supervdsm: use cpuarch This patch replaces the previous platform lookup that used string constants by more sophisticated

Change in vdsm[master]: net: Cleanup _create_socket from dead code

2016-01-19 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: net: Cleanup _create_socket from dead code .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52462 To unsubscribe, visit

Change in vdsm[master]: supervdsm: use cpuarch

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: use cpuarch .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: dsaversion: use cpuarch

2016-01-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dsaversion: use cpuarch .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

  1   2   >