Javier Coscia has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 7:
Francesco and the rest of the team, sorry for the delay, I found an issue with
the hook while using
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 15: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/49505/15/vdsm/v2v.py
gerrit-hooks has posted comments on this change.
Change subject: migration added migrateChangeParams verb
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration added migrateChangeParams verb
..
migration added migrateChangeParams verb
Currently it contains only the bandwidth but it will be used also
Yaniv Bronhaim has posted comments on this change.
Change subject: [wip] Dynamic load of supervdsm_api funcs
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/52875/3/vdsm/supervdsmServer
File vdsm/supervdsmServer:
gerrit-hooks has posted comments on this change.
Change subject: [wip] Dynamic load of supervdsm_api funcs
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Barak Korren has posted comments on this change.
Change subject: CI automation: Trigger post merge tests
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52779
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: CI automation: Trigger post merge tests
..
Patch Set 3: Code-Review+1
until we'll use the functional tests script in check_merged
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 1: Verified+1
verified using the tests
--
To view, visit https://gerrit.ovirt.org/52894
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
net: When IPv6 is not enabled, fallback to IPv4
There are setups where IPv6 is disabled, causing a
Francesco Romani has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Code-Review+1
This is too deep in storage flow for me, so I trust the review of the storage
gerrit-hooks has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Francesco Romani has posted comments on this change.
Change subject: virt: migration: initialize SourceThread._destServer on __init__
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52897
To
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 15:
* #1303548::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: CI automation: Trigger post merge tests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: CI automation: Trigger post merge tests
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52779
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: CI automation: Trigger post merge tests
..
CI automation: Trigger post merge tests
Trigger tests execution after a merge.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/50596/10/lib/vdsm/network/configurators/iproute2.py
File
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
This change is little risky, touching untestable legacy code. The best way to
introduce it is to include
Francesco Romani has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 4: -Code-Review
It is too fragile to make this per-domain and not per-operation.
Handling
Francesco Romani has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Code-Review+2
Raising score as per chat with Tal and Nir. Will merge later today to give the
chance
Milan Zamazal has posted comments on this change.
Change subject: periodic: silence useless log
..
Patch Set 2: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/52895/2//COMMIT_MSG
Commit Message:
Line 17: operation
Francesco Romani has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
Sounds ok for me, but another ack froma storage-expert developer would be great.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: migration: initialize SourceThread._destServer on __init__
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52897
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/52894/2//COMMIT_MSG
Commit Message:
Line 9:
Edward Haas has posted comments on this change.
Change subject: [wip] Dynamic load of supervdsm_api funcs
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/52875/3/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
gerrit-hooks has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: periodic: silence useless log
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 4:
* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
*
Edward Haas has posted comments on this change.
Change subject: [wip] Dynamic load of supervdsm_api funcs
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/52875/3/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line
Edward Haas has posted comments on this change.
Change subject: [wip] Dynamic load of supervdsm_api funcs
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: XML helper for virt introduced
..
Patch Set 1:
(6 comments)
nice job, this seems a nice way forward.
https://gerrit.ovirt.org/#/c/52821/1//COMMIT_MSG
Francesco Romani has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
Francesco Romani has posted comments on this change.
Change subject: Use XML API in VM._getUnderlyingDeviceAddress
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52824
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
Francesco, I don't think Jenkins is set to run on this branch, can you please
test locally as you
Jenkins CI has posted comments on this change.
Change subject: createImageLinks: recreate if the link exists but it's broken
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value
gerrit-hooks has posted comments on this change.
Change subject: createImageLinks: recreate if the link exists but it'ss broken
..
Patch Set 1:
* #1300749::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: createImageLinks: recreate if the link exists but it's broken
..
Patch Set 2:
* #1300749::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Francesco Romani has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52894/2//COMMIT_MSG
Commit Message:
Line 9: dump
> ...
Simone Tiraboschi has uploaded a new change for review.
Change subject: createImageLinks: recreate if the link exists but it'ss broken
..
createImageLinks: recreate if the link exists but it'ss broken
Recreate the symlink if it
Milan Zamazal has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 4: Code-Review-1
(5 comments)
The intention seems to be fine to me, just some clarification and/or
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 3: Verified-1
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 3: Verified+1
vdsClient -s 0 getVdsStats now logs only hook execution.
--
To view, visit
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/52923
to review the following change.
Change subject: sp: update domain links on state change
..
sp: update
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
* #1271771::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1271771::OK, public bug
* Check
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52851
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 4:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: don't log every stats change
..
hooks: ovs: don't log every stats change
VDSM log is spammed with 'ovs_after_get_stats' and every hour the
gerrit-hooks has posted comments on this change.
Change subject: network: native Open vSwitch support
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 1:
* #1234867::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/52920
To unsubscribe, visit
Petr Horáček has abandoned this change.
Change subject: hooks: ovs: don't log every stats change
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/52920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 2: Verified+1
vdsClient -s 0 getVdsStats now logs only hook execution.
--
To view, visit
Petr Horáček has restored this change.
Change subject: hooks: ovs: don't log every stats change
..
Restored
--
To view, visit https://gerrit.ovirt.org/52920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Idan Shaby has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/52923
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 3:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52920
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/52361
To
Petr Horáček has abandoned this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/52361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 3: Verified+1
The test is not used now.
--
To view, visit https://gerrit.ovirt.org/52361
To
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: don't log every stats change
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: don't log every stats change
..
hooks: ovs: don't log every stats change
VDSM log is spammed with 'ovs_after_get_stats' and every hour the VDSM
log
Jenkins CI has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 3: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: don't log every stats change
..
hooks: ovs: don't log every stats change
VDSM log is spammed with 'ovs_after_get_stats' and every hour the
Francesco Romani has submitted this change and it was merged.
Change subject: sp: update domain links on state change
..
sp: update domain links on state change
In some situations (e.g. after a reconstructMaster command) the
Francesco Romani has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
merging, because all storage developers agreed to have this in.
Let me quickly remind that since we
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 2:
* #1271771::Update tracker: OK
* Set MODIFIED::bug 1271771#1271771OK
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: fix tests (waitForState and vdsProxy)
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Petr Horáček has restored this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Restored
--
To view, visit https://gerrit.ovirt.org/52361
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Code-Review+2
let's wait for Jenkins to run. Otherwise I'll check locally.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52923
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
File
Sandro Bonazzola has posted comments on this change.
Change subject: createImageLinks: recreate if the link exists but it's broken
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52937
To unsubscribe,
Shahar Havivi has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 15:
(4 comments)
https://gerrit.ovirt.org/#/c/49505/15/vdsm/v2v.py
File vdsm/v2v.py:
Francesco Romani has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
testing locally
--
To view, visit https://gerrit.ovirt.org/52923
To unsubscribe, visit
Martin Mucha has posted comments on this change.
Change subject: untested: notify Engine when host connectivity changes
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit
Tomas Jelinek has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/46940/11/vdsm/virt/migration.py
File
gerrit-hooks has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1: Continuous-Integration+1
patch is identical to one for branch ovirt-3.6. Tested locally on centos 7
Milan Zamazal has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
File
Tal Nisan has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 1:
Quite a thorough test Francesco, thanks! Ever considered changing your surname
to Jenkins? ;)
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: sp: update domain links on state change
..
Patch Set 2:
* #1271771::Update tracker: OK
* Set MODIFIED::bug 1271771#1271771OK
--
To view, visit
Francesco Romani has submitted this change and it was merged.
Change subject: sp: update domain links on state change
..
sp: update domain links on state change
In some situations (e.g. after a reconstructMaster command) the
Tomas Jelinek has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 11:
hmm, not sure how to split this up into patches which bring value by
themselves. What I can
gerrit-hooks has posted comments on this change.
Change subject: migration: Added support for setting the convergenceSchedule
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: Make DomainDescriptor use new XML API
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52822/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: Make
Milan Zamazal has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
File
Francesco Romani has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
Milan Zamazal has posted comments on this change.
Change subject: XML helper for virt introduced
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52821/1//COMMIT_MSG
Commit Message:
Line 14:
Line 15: The rough plan
Francesco Romani has posted comments on this change.
Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
Francesco Romani has posted comments on this change.
Change subject: XML helper for virt introduced
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52821/1/vdsm/virt/xmlutil.py
File vdsm/virt/xmlutil.py:
Line 22:
Francesco Romani has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/52884/4//COMMIT_MSG
Commit Message:
Line 9: r
>
Francesco Romani has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/52884/4/vdsm/virt/periodic.py
File
gerrit-hooks has posted comments on this change.
Change subject: periodic: ignore known-benign libvirt errors
..
Patch Set 5:
* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: periodic: silence useless log
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
98 matches
Mail list logo
