Change in vdsm[ovirt-3.6]: hooks: make sure to handle vdsm exception in the bridge

Francesco Romani has posted comments on this change. Change subject: hooks: make sure to handle vdsm exception in the bridge .. Patch Set 1: Code-Review+1 looks fine. Waiting for another ack, then could be merged. -- To

Change in vdsm[ovirt-3.6]: hooks: moving hook error to exception module

Francesco Romani has posted comments on this change. Change subject: hooks: moving hook error to exception module .. Patch Set 1: Code-Review+1 looks OK. Same comment as parent patch about unhappy hooks. Please find another

Change in vdsm[ovirt-3.6]: hooks: ovs: fix bonded network change problem

gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix bonded network change problem .. Patch Set 3: -Verified * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK,

Change in vdsm[master]: Dynamic load of supervdsm_api funcs

Edward Haas has posted comments on this change. Change subject: Dynamic load of supervdsm_api funcs .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52875 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix detection for ppc64le

Martin Polednik has posted comments on this change. Change subject: hostdev: fix detection for ppc64le .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50525/3/vdsm/caps.py File vdsm/caps.py: Line 517: Line 518:

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Petr Horáček has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 3: Verified+1 OVS tests passed without a regression. Manual testing of ovs_aa_map option was OK -- To

Change in vdsm[ovirt-3.6]: exception: Make VdsmException reusable

Francesco Romani has posted comments on this change. Change subject: exception: Make VdsmException reusable .. Patch Set 1: Code-Review+1 (1 comment) Looks OK. Please get another ack.

Change in vdsm[master]: hostdev: fix detection for ppc64le

Francesco Romani has posted comments on this change. Change subject: hostdev: fix detection for ppc64le .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50525/3/vdsm/caps.py File vdsm/caps.py: Line 517: Line 518:

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

Dan Kenigsberg has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/49505/16/vdsm/v2v.py File vdsm/v2v.py:

Change in vdsm[master]: hostdev: fix detection for ppc64le

Francesco Romani has posted comments on this change. Change subject: hostdev: fix detection for ppc64le .. Patch Set 3: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/50525/3/vdsm/caps.py File vdsm/caps.py: Line 517:

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

Shahar Havivi has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 17: Verified+1 -- To view, visit https://gerrit.ovirt.org/49505 To unsubscribe, visit

Change in vdsm[master]: net: drop isolatedCommand handling

Petr Horáček has posted comments on this change. Change subject: net: drop isolatedCommand handling .. Patch Set 2: It is easy to fix in _check_connectivity() but what abou main() function? Configurator is not available

Change in vdsm[master]: nestedvt: set CPU host-passthrough mode when enabled

Martin Polednik has abandoned this change. Change subject: nestedvt: set CPU host-passthrough mode when enabled .. Abandoned Seems that the hook is good enough for most of the cases as is. Needs more investigation on the part

Change in vdsm[master]: nestedvt: set CPU host-passthrough mode when enabled

gerrit-hooks has posted comments on this change. Change subject: nestedvt: set CPU host-passthrough mode when enabled .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

gerrit-hooks has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: Dynamic load of supervdsm_api funcs

gerrit-hooks has posted comments on this change. Change subject: Dynamic load of supervdsm_api funcs .. Patch Set 5: * #1182092::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182092::OK, public bug * Check

Change in vdsm[master]: adding dynamic_package_load util module for reuseability

gerrit-hooks has posted comments on this change. Change subject: adding dynamic_package_load util module for reuseability .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: adding dynamic_package_load util module for reuseability

Yaniv Bronhaim has uploaded a new change for review. Change subject: adding dynamic_package_load util module for reuseability .. adding dynamic_package_load util module for reuseability Change-Id:

Change in vdsm[master]: adding dynamic_package_load util module for reuseability

gerrit-hooks has posted comments on this change. Change subject: adding dynamic_package_load util module for reuseability .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: Dynamic load of supervdsm_api funcs

gerrit-hooks has posted comments on this change. Change subject: Dynamic load of supervdsm_api funcs .. Patch Set 6: * #1182092::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182092::OK, public bug * Check

Change in vdsm[master]: adding dynamic_package_load util module for reuseability

Edward Haas has posted comments on this change. Change subject: adding dynamic_package_load util module for reuseability .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/53016 To unsubscribe, visit

Change in vdsm[master]: setupNetworks: moving nics between bonds

Edward Haas has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit

Change in vdsm[master]: network: ovs configurator A

gerrit-hooks has posted comments on this change. Change subject: network: ovs configurator A .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vdsm: Remove unreachable code

gerrit-hooks has posted comments on this change. Change subject: vdsm: Remove unreachable code .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/52997 To unsubscribe, visit

Change in vdsm[master]: network: ovs configurator A

gerrit-hooks has posted comments on this change. Change subject: network: ovs configurator A .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: setupNetworks: moving nics between bonds

Francesco Romani has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

Francesco Romani has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49505 To unsubscribe,

Change in vdsm[master]: WIP: DONTMERGE: do not leave leftovers if migrationCreate fails

Francesco Romani has uploaded a new change for review. Change subject: WIP: DONTMERGE: do not leave leftovers if migrationCreate fails .. WIP: DONTMERGE: do not leave leftovers if migrationCreate fails DONTMERGE, Proof of

Change in vdsm[master]: WIP: DONTMERGE: better saveState

gerrit-hooks has posted comments on this change. Change subject: WIP: DONTMERGE: better saveState .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: WIP: DONTMERGE: better saveState

Francesco Romani has uploaded a new change for review. Change subject: WIP: DONTMERGE: better saveState .. WIP: DONTMERGE: better saveState Proof of concept, not realy sure it is atually 'better' Change-Id:

Change in vdsm[master]: WIP: DONTMERGE: do not leave leftovers if migrationCreate fails

gerrit-hooks has posted comments on this change. Change subject: WIP: DONTMERGE: do not leave leftovers if migrationCreate fails .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: vdsm: Remove unreachable code

Martin Betak has abandoned this change. Change subject: vdsm: Remove unreachable code .. Abandoned duplicate change -- To view, visit https://gerrit.ovirt.org/52997 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: build: enforce abs_import check

Dan Kenigsberg has uploaded a new change for review. Change subject: build: enforce abs_import check .. build: enforce abs_import check commit 2154bc8 defined a check for absolute imports in a limited whitelist, but failed to

Change in vdsm[master]: build: enforce abs_import check

gerrit-hooks has posted comments on this change. Change subject: build: enforce abs_import check .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: network: fix dhclient return code

gerrit-hooks has posted comments on this change. Change subject: network: fix dhclient return code .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: setupNetworks: moving nics between bonds

Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit

Change in vdsm[master]: vdsm: Remove unreachable code

Francesco Romani has posted comments on this change. Change subject: vdsm: Remove unreachable code .. Patch Set 2: Code-Review+1 this is mostly infra's territory, hence +1 and not +2 -- To view, visit

Change in vdsm[master]: createImageLinks: recreate if the link exists but it's broken

gerrit-hooks has posted comments on this change. Change subject: createImageLinks: recreate if the link exists but it's broken .. Patch Set 3: * #1300749::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: virt: recovery: use proper os.path functions

gerrit-hooks has posted comments on this change. Change subject: virt: recovery: use proper os.path functions .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: recovery: add constant for file extension

gerrit-hooks has posted comments on this change. Change subject: virt: recovery: add constant for file extension .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: recovery: add constant for file extension

Francesco Romani has uploaded a new change for review. Change subject: virt: recovery: add constant for file extension .. virt: recovery: add constant for file extension Consolidate the ".recovery" extension string on one

Change in vdsm[master]: virt: recovery: use proper os.path functions

Francesco Romani has uploaded a new change for review. Change subject: virt: recovery: use proper os.path functions .. virt: recovery: use proper os.path functions Use the facilities from os.path wherever we need them, instead

Change in vdsm[master]: setupNetworks: moving nics between bonds

Dan Kenigsberg has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit

Change in vdsm[master]: build: enforce abs_import check

Yaniv Bronhaim has posted comments on this change. Change subject: build: enforce abs_import check .. Patch Set 1: Code-Review+1 lib will be ready as well soon -- To view, visit https://gerrit.ovirt.org/53050 To unsubscribe,

Change in vdsm[master]: virt: add load() method to the recovery.File class

gerrit-hooks has posted comments on this change. Change subject: virt: add load() method to the recovery.File class .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: build: enforce abs_import check

Piotr Kliczewski has posted comments on this change. Change subject: build: enforce abs_import check .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53050 To unsubscribe, visit

Change in vdsm[master]: tests: start proper recovery.py tests

gerrit-hooks has posted comments on this change. Change subject: tests: start proper recovery.py tests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: build: enforce abs_import check

Dan Kenigsberg has posted comments on this change. Change subject: build: enforce abs_import check .. Patch Set 1: Verified+1 no functional change, passes unit tests. -- To view, visit https://gerrit.ovirt.org/53050 To

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

gerrit-hooks has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 6: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug *

Change in vdsm[master]: vmstats: remove useless short stacktrace

gerrit-hooks has posted comments on this change. Change subject: vmstats: remove useless short stacktrace .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED

Francesco Romani has uploaded a new change for review. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED libvirt sometimes raises it after migrations. Need to

Change in vdsm[master]: periodic: silence useless log

gerrit-hooks has posted comments on this change. Change subject: periodic: silence useless log .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED

gerrit-hooks has posted comments on this change. Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

Francesco Romani has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/52884/5/tests/periodicTests.py File

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

Milan Zamazal has uploaded a new change for review. Change subject: virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() .. virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() Change-Id:

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

gerrit-hooks has posted comments on this change. Change subject: virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug

Change in vdsm[master]: network: ovs configurator A

gerrit-hooks has posted comments on this change. Change subject: network: ovs configurator A .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: build: enforce abs_import check

gerrit-hooks has posted comments on this change. Change subject: build: enforce abs_import check .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: build: enforce abs_import check

Dan Kenigsberg has submitted this change and it was merged. Change subject: build: enforce abs_import check .. build: enforce abs_import check commit 2154bc8 defined a check for absolute imports in a limited whitelist, but

Change in vdsm[master]: net: Canonize dhcpv6 on API input

Dan Kenigsberg has posted comments on this change. Change subject: net: Canonize dhcpv6 on API input .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/52989 To unsubscribe, visit

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

Dan Kenigsberg has posted comments on this change. Change subject: net: Clean netinfo.__init__ and migrate to cache .. Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/53007 To unsubscribe, visit

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

Francesco Romani has posted comments on this change. Change subject: virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/53061/1/vdsm/virt/vm.py File

Change in vdsm[master]: vdsm: Remove unreachable code

gerrit-hooks has posted comments on this change. Change subject: vdsm: Remove unreachable code .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: vdsm: Remove unreachable code

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Remove unreachable code .. vdsm: Remove unreachable code Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593 Signed-off-by: Martin Betak

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

gerrit-hooks has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

Dan Kenigsberg has submitted this change and it was merged. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. v2v: support for importing Xen VMs via libvirt on RHEL hosts Adding support for import

Change in vdsm[master]: hostdev: fix detection for ppc64le

gerrit-hooks has posted comments on this change. Change subject: hostdev: fix detection for ppc64le .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: hostdev: fix detection for ppc64le

Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: fix detection for ppc64le .. hostdev: fix detection for ppc64le x86_64 detects the state of hostdev support by looking at 2 places: *

Change in vdsm[master]: hooks: ovs: enable auto-attach mapping

Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: enable auto-attach mapping .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/51859 To unsubscribe, visit

Change in vdsm[master]: net: IP DHCP detection

Edward Haas has uploaded a new change for review. Change subject: net: IP DHCP detection .. net: IP DHCP detection Improve and fix DHCP status detection. There have been several points covered in this patch: - dhcpv6 is now

Change in vdsm[master]: net: IP DHCP detection

gerrit-hooks has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: net: IP DHCP detection

Edward Haas has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/53076 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: vdsm: Remove unreachable code

Piotr Kliczewski has posted comments on this change. Change subject: vdsm: Remove unreachable code .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52980 To unsubscribe, visit

Change in vdsm[master]: network: ovs configurator A

gerrit-hooks has posted comments on this change. Change subject: network: ovs configurator A .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

Dan Kenigsberg has posted comments on this change. Change subject: net: Clean netinfo.__init__ and migrate to cache .. Patch Set 2: (2 comments) two nits https://gerrit.ovirt.org/#/c/53007/2/lib/vdsm/netinfo/__init__.py File

Change in vdsm[master]: net: Fixing old netinfo access

Dan Kenigsberg has posted comments on this change. Change subject: net: Fixing old netinfo access .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53011/1/vdsm/virt/vmdevices/graphics.py File

Change in vdsm[master]: virt: Fix of uninitialized variable access in Vm.setLinkAndN...

Milan Zamazal has posted comments on this change. Change subject: virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/53061/1/vdsm/virt/vm.py File