Change in vdsm[master]: net: IP DHCP detection

2016-02-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/53076/5/lib/vdsm/netinfo/dhcp.py File lib/vdsm/netinfo/dhcp.py: Line 73:

Change in vdsm[master]: net: IP DHCP detection

2016-02-05 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/53076 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: IP DHCP detection

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: net: IP DHCP detection

2016-02-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: IP DHCP detection .. net: IP DHCP detection Improve and fix DHCP status detection. There have been several points covered in this patch: -

Change in vdsm[master]: net: IP DHCP detection

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: register: Pull some vars into the class

2016-02-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: register: Pull some vars into the class .. Patch Set 3: Code-Review+1 Needs rebase -- To view, visit https://gerrit.ovirt.org/46977 To unsubscribe, visit

Change in vdsm[master]: storageServer: Normalize local path before escaping

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storageServer: Normalize local path before escaping .. Patch Set 2: * #1300749::Update tracker: OK * Set MODIFIED::bug 1300749#1300749IGNORE, not all

Change in vdsm[master]: storageServer: Normalize local path before escaping

2016-02-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: storageServer: Normalize local path before escaping .. storageServer: Normalize local path before escaping Hosted engine setup does not normalize

Change in vdsm[master]: storageServer: Normalize local path before escaping

2016-02-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: storageServer: Normalize local path before escaping .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52873 To unsubscribe, visit

Change in vdsm[master]: net: IP DHCP detection

2016-02-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 6: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/53076/6/lib/vdsm/netinfo/addresses.py File

Change in vdsm[master]: service: change vdsm KillMode to mixed

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 9: * #1189200::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1189200::OK, public bug * Check

Change in vdsm[master]: Require python-six >= 1.9.0

2016-02-05 Thread vfeenstr
Vinzenz Feenstra has uploaded a new change for review. Change subject: Require python-six >= 1.9.0 .. Require python-six >= 1.9.0 Change-Id: I329fd4fa0c49a7e0cf1c36543756f7e0b30b3ea4 Bug-Url: https://bugzilla.redhat.com/1300640

Change in vdsm[master]: Require python-six >= 1.9.0

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Require python-six >= 1.9.0 .. Patch Set 1: * #1300640::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1300640::OK, public bug * Check

Change in vdsm[master]: Require python-six >= 1.9.0

2016-02-05 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: Require python-six >= 1.9.0 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/53114 To unsubscribe, visit

Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

2016-02-05 Thread ciudavitacos
Javier Coscia has posted comments on this change. Change subject: Hook: ide2sata: To switch IDE disks to SATA .. Patch Set 7: (1 comment) Hey Dan, yes it was a copy+paste type, will get fixed in next patch

Change in vdsm[master]: net: IP DHCP detection

2016-02-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: IP DHCP detection .. Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/53076/5/lib/vdsm/netinfo/dhcp.py File lib/vdsm/netinfo/dhcp.py:

Change in vdsm[master]: Require python-six >= 1.9.0

2016-02-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Require python-six >= 1.9.0 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53114 To unsubscribe, visit

Change in vdsm[master]: Require python-six >= 1.9.0

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Require python-six >= 1.9.0 .. Patch Set 2: * #1300640::Update tracker: OK * Set MODIFIED::bug 1300640#1300640OK -- To view, visit

Change in vdsm[master]: Require python-six >= 1.9.0

2016-02-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Require python-six >= 1.9.0 .. Require python-six >= 1.9.0 Change-Id: I329fd4fa0c49a7e0cf1c36543756f7e0b30b3ea4 Bug-Url:

Change in vdsm[master]: net: Canonize dhcpv6 on API input

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Canonize dhcpv6 on API input .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: net: Canonize dhcpv6 on API input

2016-02-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Canonize dhcpv6 on API input .. net: Canonize dhcpv6 on API input IPv6 dhcp is enabled by default, therefore, if the key is missing from the

Change in vdsm[master]: net: Canonize dhcpv6 on API input

2016-02-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: Canonize dhcpv6 on API input .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52989 To unsubscribe, visit

Change in vdsm[master]: contrib: schema converter

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)

2016-02-05 Thread phoracek
Petr Horáček has abandoned this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Abandoned -- To view, visit https://gerrit.ovirt.org/52360 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: network: tests: fix funtional ovs tests with getProxy

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: tests: fix funtional ovs tests with getProxy .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: hooks: ovs: fix tests (waitForState and vdsProxy)

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix tests (waitForState and vdsProxy) .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/52360

Change in vdsm[master]: network: tests do not check OVS devices operstate

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: tests do not check OVS devices operstate .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: network: native Open vSwitch support

2016-02-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: native Open vSwitch support .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: contrib: schema converter

2016-02-05 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 2: Verified+1 Converter performs initial conversion from json to yaml formats. During development I noticed many

Change in vdsm[master]: storageServer: Normalize local path before escaping

2016-02-05 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: storageServer: Normalize local path before escaping .. Patch Set 1: 4 +1 and a +1 on both automated and manual testing, can we get this merged? -- To view,

Change in vdsm[master]: Require python-six >= 1.9.0

2016-02-05 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: Require python-six >= 1.9.0 .. Patch Set 1: Been hit with this issue as well on RHEL7 - Verified installation works fine now -- To view, visit