gerrit-hooks has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 3: Code-Review+2 Verified+1
Copying scores
--
To view, visit https://gerrit.ovirt.org/53701
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
net: api: destroyOnMasterRemoval has stable value
We don't have to check if 'remove' in attrs, it
gerrit-hooks has posted comments on this change.
Change subject: ipv6: ifcfg: explicitly disable dhcpv6
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/52759
To
Dan Kenigsberg has abandoned this change.
Change subject: ipv6: ifcfg: explicitly disable dhcpv6
..
Abandoned
The reason for getting an unsolicited address was probably autoconf router
advertisement
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: api: refactoring of _handleBondings
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/53695/10/lib/vdsm/network/api.py
File
Nir Soffer has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 14:
(5 comments)
https://gerrit.ovirt.org/#/c/52864/14/lib/api/Makefile.am
File lib/api/Makefile.am:
Line 31:
Dan Kenigsberg has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53942
gerrit-hooks has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 2:
* #1219363::Update tracker: OK
* Set MODIFIED::bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
net: use the correct dict with all the networks for disable_ipv6
Dan Kenigsberg has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53940
Nir Soffer has posted comments on this change.
Change subject: fileUtils: Add atomic_symlink utility
..
Patch Set 1:
ping
--
To view, visit https://gerrit.ovirt.org/53680
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: v2v: use new jobs infrastructure
..
Patch Set 3:
(2 comments)
Partial review
https://gerrit.ovirt.org/#/c/52858/3/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 80
Ondřej Svoboda has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 1: Verified+1
Tested on Fedora 22 on top of the backport of the
Ondřej Svoboda has posted comments on this change.
Change subject: net: also disable IPv6 on bridges not using it, after unified
restoration
..
Patch Set 1: Verified+1
Tested together with the fix which is required to
Ondřej Svoboda has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 1: Verified+1
Tested alone (as master already contains the original
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53714/2/tests/integration/jsonRpcTests.py
File
Nir Soffer has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 1: Code-Review+1
Waiting for another ack.
--
To view, visit https://gerrit.ovirt.org/53918
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: schema: inconsistency fixes
..
Patch Set 5: Code-Review+1
(1 comment)
Storage change looks ok, waiting from acks from other subsystem maintainers.
Nir Soffer has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 23:
(3 comments)
I have to invest more time in this, some comments for now.
Nir Soffer has posted comments on this change.
Change subject: move logUtils to lib
..
Patch Set 2: Code-Review+1
Looks fine, lets have another review.
--
To view, visit https://gerrit.ovirt.org/53889
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 1: Verified-1
* #1219363::Update tracker: OK
* Check Bug-Url::OK
*
Ondřej Svoboda has uploaded a new change for review.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
net: use the correct dict with all the networks for disable_ipv6 restoration
Adam Litke has posted comments on this change.
Change subject: repoplot: Distribute repoplot tool
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53941
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: repoplot: Allow using on headless server
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53939
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: move alignmentScan.py to lib
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/53758/5/lib/vdsm/alignmentScan.py
File lib/vdsm/alignmentScan.py:
Line 21:
Nir Soffer has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/49173/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 431
Nir Soffer has posted comments on this change.
Change subject: repoplot: Distribute repoplot tool
..
Patch Set 2: Verified+1
Passes make check && make rpm
--
To view, visit https://gerrit.ovirt.org/53941
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: repoplot: Allow using on headless server
..
Patch Set 2: Verified+1
Tested on rhel 7.2 headless hypervisor.
--
To view, visit https://gerrit.ovirt.org/53939
To
gerrit-hooks has posted comments on this change.
Change subject: repoplot: Distribute repoplot tool
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: repoplot: Allow using on headless server
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: repoplot: Distribute repoplot tool
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: repoplot: Distribute repoplot tool
..
repoplot: Distribute repoplot tool
For some reason we are distributing profile-stat and logdb, so now we
distribute also the
gerrit-hooks has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 1:
* #1219363::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Ondřej Svoboda has uploaded a new change for review.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
net: use the correct dict with all the networks for disable_ipv6 restoration
gerrit-hooks has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Move network tests to its own folder
..
tests: Move network tests to its own folder
Network tests (from tests/) have been moved to
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Move network tests to its own folder
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53704
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: repoplot: Visualize storage domain monitoring
..
repoplot: Visualize storage domain monitoring
Add repoplot command line tool for visualizing storage
gerrit-hooks has posted comments on this change.
Change subject: repoplot: Visualize storage domain monitoring
..
Patch Set 6:
* #1081962::Update tracker: OK
* Set MODIFIED::bug 1081962#1081962IGNORE, not oVirt
Nir Soffer has posted comments on this change.
Change subject: repoplot: Visualize storage domain monitoring
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/53861
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: repoplot: Allow using on headless server
..
repoplot: Allow using on headless server
matplotlib uses gtk by default, failing on a headless server. Now we use
the
gerrit-hooks has posted comments on this change.
Change subject: repoplot: Allow using on headless server
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: repoplot: Visualize storage domain monitoring
..
Patch Set 5: Code-Review+2
Please merge this! It's a great tool and will be very useful do developers and
users.
Francesco Romani has uploaded a new change for review.
Change subject: virt: clean and modernize the destroy() path
..
virt: clean and modernize the destroy() path
cleanup the destroy path with no changes in behaviour.
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
..
Patch Set 2:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: clean and modernize the destroy() path
..
Patch Set 1:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: virt: extract destroyVm helper
..
Patch Set 1:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
Francesco Romani has uploaded a new change for review.
Change subject: virt: extract destroyVm helper
..
virt: extract destroyVm helper
add utility method to encapsulate the retry logic,
previously found in destroyVmGraceful().
gerrit-hooks has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has restored this change.
Change subject: vm: do not call before_vm_start in dehibernation
..
Restored
let's try again
--
To view, visit https://gerrit.ovirt.org/45074
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has posted comments on this change.
Change subject: net: Fix dhcp reporting
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Edward Haas has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53701
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14:
no longer needed but still pretty nice piece of code I would say. Pity that
gerrit doesn't have *Archive* feature
Francesco Romani has abandoned this change.
Change subject: virt: add run_async helper
..
Abandoned
no longer needed
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/49570
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14: Code-Review-1
(3 comments)
mostly OK, but:
1. (MAJOR) we should review and test the saveState()
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: [wip] bridge: usage of yaml schema
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Edward Haas has posted comments on this change.
Change subject: net: api: refactoring of _handleBondings
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/53695/10/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
gerrit-hooks has posted comments on this change.
Change subject: adding network functional tests to check-merged job
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has posted comments on this change.
Change subject: net: Fix dhcp reporting
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] bridge: usage of yaml schema
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53919/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 62:
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: [wip] bridge: usage of yaml schema
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: schema: inconsistency fixes
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has uploaded a new change for review.
Change subject: [wip] bridge: usage of yaml schema
..
[wip] bridge: usage of yaml schema
Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Signed-off-by: pkliczewski
Piotr Kliczewski has uploaded a new change for review.
Change subject: bridge: remove dead code
..
bridge: remove dead code
Change-Id: I6e9a1a1289ffb89d3b39cd4b46ef72df0a615ff3
Signed-off-by: pkliczewski
Nir Soffer has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info`
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53785/4/vdsm/storage/storageServer.py
File
Petr Horáček has posted comments on this change.
Change subject: fix import error
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53901/2/init/wait_for_ipv4s
File init/wait_for_ipv4s:
Line 12:
Line 13: from
Petr Horáček has posted comments on this change.
Change subject: net: api: return networks to connectivity check from setup
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53757/2/lib/vdsm/network/api.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: api: destroyOnMasterRemoval has stable value
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: api: refactoring of _handleBondings
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has posted comments on this change.
Change subject: net: api: refactoring of _handleBondings
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/53695/10/lib/vdsm/network/api.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: Fix dhcp reporting
..
Patch Set 2: Verified-1
* #1310410::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1310410::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: netinfo: do not mistake a veth device for a VLAN in ifaceUsed
..
Patch Set 4:
* #1310410::Update tracker: OK
* Check Bug-Url::OK
* Check Public
gerrit-hooks has posted comments on this change.
Change subject: vmstats: from EAFP to LBYL
..
Patch Set 9:
* #1299480::Update tracker: OK
* Set MODIFIED::bug 1299480#1299480IGNORE, not all related patches are
closed,
Dan Kenigsberg has posted comments on this change.
Change subject: vmstats: from EAFP to LBYL
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53613
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmstats: from EAFP to LBYL
..
vmstats: from EAFP to LBYL
libvirt bulk stats' API allows to return partial result.
Hence, seems better to Look Before
Dan Kenigsberg has posted comments on this change.
Change subject: move logUtils to lib
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: repoplot: Visualize storage domain monitoring
..
Patch Set 5:
Here example outputs:
- https://bugzilla.redhat.com/attachment.cgi?id=1129733
-
gerrit-hooks has posted comments on this change.
Change subject: adding network functional tests to check-merged job
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: fix import error
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Yaniv Bronhaim has uploaded a new change for review.
Change subject: adding network functional tests to check-merged job
..
adding network functional tests to check-merged job
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: fix import error
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: vmstats: from EAFP to LBYL
..
Patch Set 8: Verified+1
changed only one comment, copied score.
--
To view, visit https://gerrit.ovirt.org/53613
To
gerrit-hooks has posted comments on this change.
Change subject: move hostdev to lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: move alignmentScan.py to lib
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: fix import error
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: move parted_utils to lib
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: move blkid to lib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: move logUtils to lib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
1 - 100 of 197 matches
Mail list logo
