Change in vdsm[master]: tests: Remove unused code

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Remove unused code .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: tests: Simplify DirectFile tests

2016-03-19 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Simplify DirectFile tests .. Patch Set 3: (6 comments) Very nice reduction and simplification! See comments about units and use of a constant.

Change in vdsm[master]: hostdev: expose hostdevReattach maintenance verb

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose hostdevReattach maintenance verb .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

2016-03-19 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class .. tests: ovs: mock setupNetworks in OVSNetworkTests class Until now we marked networks and bonds as OVS

Change in vdsm[master]: virt: common handling of exceptions

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 8: Looks nice, see comments. -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit

Change in vdsm[master]: dsaversion: Remove 3.4 support

2016-03-19 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: dsaversion: Remove 3.4 support .. dsaversion: Remove 3.4 support The current VDSM no longer supports 3.4 clusters (see, e.g., commit 1f21f1c). This patch

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread phoracek
Petr Horáček has abandoned this change. Change subject: net: native ovs [1] .. Abandoned -- To view, visit https://gerrit.ovirt.org/54820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon

Change in vdsm[master]: Vm: conf: proper locking in the creation path

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Vm: conf: proper locking in the creation path .. Patch Set 1: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug *

Change in vdsm[master]: spec: explicit virt-v2v requirement

2016-03-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: spec: explicit virt-v2v requirement .. Patch Set 4: Code-Review-1 (1 comment) Try to find out if the package could be added. That would make it available on

Change in vdsm[master]: migration: Add retry on full capacity

2016-03-19 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: migration: Add retry on full capacity .. Patch Set 20: I agree with mbetak. Plus this aligns with existing mechanism of queueing migrations by vdsm itself

Change in vdsm[master]: api: remove unused methods

2016-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 4: Code-Review+2 Too bad that the work of http://gerrit.ovirt.org/8182 is now dropped with no replacement on sight.

Change in vdsm[master]: tests: Simplify DirectFile tests

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Simplify DirectFile tests .. Patch Set 3: (6 comments) https://gerrit.ovirt.org/#/c/54678/3/tests/fileUtilTests.py File tests/fileUtilTests.py: Line 30:

Change in vdsm[master]: vm: conf: proper locking in onConnect()

2016-03-19 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: conf: proper locking in onConnect() .. vm: conf: proper locking in onConnect() Change-Id: I5f75630e204708bb4352f68240550b2b454806cc Bug-Url:

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: devices: drop support for ancient Engines

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: drop support for ancient Engines .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: events: introduction of schema

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: events: introduction of schema .. Patch Set 1: at first glance schema looks good. Will do proper review later. -- To view, visit

Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/53679 To

Change in vdsm[master]: hostdev: decode XML string when parsing devices

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: decode XML string when parsing devices .. Patch Set 1: Code-Review+1 seems OK, but not completely sure swallowing errors is a good idea. While I

Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm

2016-03-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm .. virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm This is just a simple move of

Change in vdsm[master]: tests: Remove unused code

2016-03-19 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Remove unused code .. tests: Remove unused code Remove class method from the DirectFile tests that nobody uses. Change-Id:

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev/sr-iov: don't reattach devices .. Patch Set 1: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/54937/1//COMMIT_MSG Commit

Change in vdsm[master]: vm: use the new response handling

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: use the new response handling .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: common handling of exceptions

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 6: Heh, I see you just did that :-) -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit

Change in vdsm[master]: hostdev: add support for hotplug

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: add support for hotplug .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: WIP: hook: add imagerepo feed containers

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: WIP: hook: add imagerepo feed containers .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54900 To unsubscribe, visit

Change in vdsm[master]: tests: let nose produce an xunit xml format.

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: let nose produce an xunit xml format. .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/45698 To

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Patch Set 6: * #1260428::Update tracker: OK -- To view, visit

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

2016-03-19 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: sp: allow executing upgradePool even if there is a pending update .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: Update v2v to use new jobs infrastructure

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Update v2v to use new jobs infrastructure .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/45382 To

Change in vdsm[master]: Update v2v to use new jobs infrastructure

2016-03-19 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: Update v2v to use new jobs infrastructure .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/45382

Change in vdsm[master]: tests: let nose produce an xunit xml format.

2016-03-19 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: tests: let nose produce an xunit xml format. .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit

Change in vdsm[master]: contrib: schema converter

2016-03-19 Thread alitke
Adam Litke has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 22: (2 comments) I think this is good enough to aid in our transition to yaml. Just a few comments/questions.

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

2016-03-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm .. Patch Set 12: Some test code added to better cover the moved code. -- To view, visit

Change in vdsm[master]: Vm: conf: proper locking in the creation path

2016-03-19 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: Vm: conf: proper locking in the creation path .. Vm: conf: proper locking in the creation path Change-Id: I9b754690a41cdc1e1303ddd4c792df5916570872 Bug-Url:

Change in vdsm[master]: spec: bump libguestfs-tools-c requirement

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: bump libguestfs-tools-c requirement .. Patch Set 3: * #1292096::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1292096::OK, public bug * Check

Change in vdsm[master]: virt: common handling of exceptions

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/54664/7/lib/vdsm/virt/api.py File lib/vdsm/virt/api.py: Line

Change in vdsm[master]: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm

2016-03-19 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm .. Patch Set 12: Verified+1 Verified by running a VM from Engine, migrating it to another host and

Change in vdsm[master]: vm: use the new response handling

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: use the new response handling .. Patch Set 1: The idea is that once the infrastructure (see patch 54664) is solid and in place, we could convert one

Change in vdsm[master]: api: Mandate force param in createVG

2016-03-19 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: api: Mandate force param in createVG .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54899 To unsubscribe, visit

Change in vdsm[master]: vm: conf: proper locking in onConnect()

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: conf: proper locking in onConnect() .. Patch Set 1: * #1318550::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1318550::OK, public bug * Check

Change in vdsm[ovirt-3.6]: guest-agent: Fix API version negotiation

2016-03-19 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: guest-agent: Fix API version negotiation .. Patch Set 1: Same as master -- To view, visit https://gerrit.ovirt.org/54896 To unsubscribe, visit

Change in vdsm[master]: virt: common handling of exceptions

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 6: Lets split this to infrastructure patch (with tests), and patch using this infrastructure, which probably

Change in vdsm[master]: HACK: hook: add imagerepo feed containers

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: HACK: hook: add imagerepo feed containers .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: storage: Remove legacy get[Iso|Floppy]List .. storage: Remove legacy get[Iso|Floppy]List The legacy getIsoList and getFloppyList verbs are only used in DCs of

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 20: Verified+1 v20 avoids to duplicate the define.py comments in exception.py Verified running

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net tests: IPv6 autoconf with RA server

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: IPv6 autoconf with RA server .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm

2016-03-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm .. virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm This is somewhat similar to

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm .. Patch Set 12: Code-Review+1 waiting for Martin's ACK. -- To view, visit

Change in vdsm[master]: net: abstact rollback handler as netswitch.RollbackManager

2016-03-19 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: abstact rollback handler as netswitch.RollbackManager .. net: abstact rollback handler as netswitch.RollbackManager In order to reuse current rollback

Change in vdsm[master]: directio: Port to Python 3

2016-03-19 Thread alitke
Adam Litke has posted comments on this change. Change subject: directio: Port to Python 3 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54699/2/tests/Makefile.am File tests/Makefile.am: Line 38:

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

2016-03-19 Thread aaviram
Amit Aviram has abandoned this change. Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully. .. Abandoned Common error catching is being implemented, see: https://gerrit.ovirt.org/#/c/54664/ -- To view,

Change in vdsm[master]: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm

2016-03-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm .. Patch Set 12: Code-Review+2 raising score after approval from network devs. -- To view,

Change in vdsm[master]: net: native ovs [3], ip handling

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [3], ip handling .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: bridge: data verification

2016-03-19 Thread alitke
Adam Litke has posted comments on this change. Change subject: bridge: data verification .. Patch Set 10: (6 comments) https://gerrit.ovirt.org/#/c/53919/10/lib/api/schemaapi.py File lib/api/schemaapi.py: Line 111:

Change in vdsm[master]: api: remove unused methods

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: remove unused methods .. Patch Set 5: Verified+1 Rebase only, no code changes. Verified by running local build. -- To view, visit

Change in vdsm[master]: tests: move sourcerouting_test to tests/net where it belongs

2016-03-19 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: tests: move sourcerouting_test to tests/net where it belongs .. tests: move sourcerouting_test to tests/net where it belongs Change-Id:

Change in vdsm[master]: net: native ovs [2], fake bridgeless

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [2], fake bridgeless .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm: Add create_volume job

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Add create_volume job .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/50221/12/vdsm/storage/sdm/api/base.py File vdsm/storage/sdm/api/base.py:

Change in vdsm[master]: storagetests: Add create_block_volume

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storagetests: Add create_block_volume .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54570 To unsubscribe, visit

Change in vdsm[master]: storagetests: Rename make_blocksd

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit

Change in vdsm[master]: storagetests: Create metadata storage area for block domains

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storagetests: Create metadata storage area for block domains .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54568 To unsubscribe, visit

Change in vdsm[master]: tests: refactor manifest_tests fake env setup

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: refactor manifest_tests fake env setup .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50273 To unsubscribe, visit

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: tests: Add test_overwrite_blocksize test

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test_overwrite_blocksize test .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54669 To unsubscribe, visit

Change in vdsm[master]: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm

2016-03-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm .. virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm This generally follows the Sound

Change in vdsm[master]: api: Mandate force param in createVG

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: api: Mandate force param in createVG .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: monitoring: Separate storage health monitoring

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitoring: Separate storage health monitoring .. Patch Set 10: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug *

Change in vdsm[master]: hostdev: don't implicitly reattach devices

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: don't implicitly reattach devices .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: monitoring: Separate storage health monitoring

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitoring: Separate storage health monitoring .. Patch Set 14: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug *

Change in vdsm[master]: monitoring: Introduce the eventloop module

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: monitoring: Introduce the eventloop module .. Patch Set 9: Verified+1 Verified using the tests and with the next patch running the demo checker process. -- To

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54900/2/lib/vdsm/storage/exception.py File

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: directio: Remove useless DirectFile.writelines()

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: directio: Remove useless DirectFile.writelines() .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54716 To unsubscribe, visit

Change in vdsm[master]: tests: Replace magic number with constant

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Replace magic number with constant .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54954 To unsubscribe, visit

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/54900/2/lib/vdsm/storage/exception.py File

Change in vdsm[master]: virt: set correct permissions for hwrng device

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: set correct permissions for hwrng device .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/54806/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1263:

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: supervdsm: move udev-related functions to udev.py .. Patch Set 6: Code-Review+1 Thanks Martin, look good, and your verification is fine. -- To view, visit

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

2016-03-19 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: supervdsm: move udev-related functions to udev.py .. supervdsm: move udev-related functions to udev.py Change-Id:

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: move udev-related functions to udev.py .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: contrib: schema converter

2016-03-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 22: (2 comments) https://gerrit.ovirt.org/#/c/52864/22/contrib/schema-converter File contrib/schema-converter: Line

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: native ovs [1] .. net: native ovs [1] Basic OVS implementation. Change-Id: I6d18b7d3e90902d29a2fdef246972a9fb1c705f1 Signed-off-by: Petr Horáček

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-03-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 1: Verified+1 Tested on Travis CI: https://travis-ci.org/EdDev/vdsm -- To view, visit

Change in vdsm[master]: osinfo: refactor package_versions function

2016-03-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: osinfo: refactor package_versions function .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/54546 To unsubscribe, visit

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit

Change in vdsm[master]: HACK: virt: override vm type from custom property

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: HACK: virt: override vm type from custom property .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: set correct permissions for hwrng device

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: set correct permissions for hwrng device .. Patch Set 3: * #1260686::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1260686::OK, public bug *

Change in vdsm[master]: api: Mandate force param in createVG

2016-03-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: api: Mandate force param in createVG .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54899/1//COMMIT_MSG Commit Message: Line 11: f4304e2). Line 12:

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

2016-03-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54856/1//COMMIT_MSG Commit Message: Line 6: Line

Change in vdsm[master]: osinfo: refactor package_versions function

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osinfo: refactor package_versions function .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: native ovs [1]

2016-03-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

  1   2   3   4   >