Nir Soffer has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 34: Verified+1
--
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: tests: Use VG tags to store fake block domain md
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Test storagetestlib FakeEnv functions
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix FakeLVM lv creation size
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Create fake block volume metadata
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: storagetestlib: Set fake block domain mountpoint
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Create block metadata file with correct size
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: tests: storagetestlib: Set fake block domain mountpoint
..
tests: storagetestlib: Set fake block domain mountpoint
BlockStorageDomainManifest depends on its
Adam Litke has uploaded a new change for review.
Change subject: tests: Test storagetestlib FakeEnv functions
..
tests: Test storagetestlib FakeEnv functions
The storagetestlib module provides functionality to create fake file
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add changeVGTags support
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Adam Litke has uploaded a new change for review.
Change subject: tests: Create block metadata file with correct size
..
tests: Create block metadata file with correct size
The function BlockStorageDomainManifest.metaSize
Adam Litke has uploaded a new change for review.
Change subject: tests: Fix FakeLVM lv creation size
..
tests: Fix FakeLVM lv creation size
This fixes two issues when creating fake LVs for testing. First, the
value of MB is
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize switch type from custom options
..
Patch Set 2: Verified+1
Passed network tests, new functions were tested manually.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: net: canonicalize switch type from custom options
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 34:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 17:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 5:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 4:
The code looks good, but I think we need to update the schema. Hopefuly we have
a proper way to mark
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/55872/1/lib/vdsm/protocoldetector.py
File
Petr Horáček has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 1: Verified+1
Passed network test.
--
To view, visit https://gerrit.ovirt.org/55860
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: move parse_bond_options to netinfo.bonding
..
Patch Set 1: Verified+1
Passed network test.
--
To view, visit https://gerrit.ovirt.org/55841
To
Petr Horáček has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 1:
Passed network and utils tests.
--
To view, visit https://gerrit.ovirt.org/55860
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: ceph: Require ceph-common when it is available
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/55872/1/lib/vdsm/protocoldetector.py
File
gerrit-hooks has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 7:
* #1320281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1320281::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: HA: Make getHostLeaseStatus API public
..
Patch Set 6: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/29157/6/client/vdsClient.py
File
Nir Soffer has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
This version disables the debuginfo package since we don't have any debug info
now.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
* #1320281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1320281::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 6:
* #1320281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1320281::OK, public bug
*
Allon Mureinik has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 4: Verified+1
Added TODO comment as per Nir's review
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Allon Mureinik has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55858/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Nir Soffer has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 4:
This version remove old package that sneaked in during the rebase.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 4:
* #1320281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1320281::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 5:
* #1320281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1320281::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 4:
This version remove the empty %files list.
--
To view, visit https://gerrit.ovirt.org/42491
To
gerrit-hooks has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 3:
* #1320281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1320281::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ceph: Do not require ceph-common on ppc64le
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 4:
* #1320281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1320281::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 2:
This version refine the commit message.
--
To view, visit https://gerrit.ovirt.org/55880
To
gerrit-hooks has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
..
Patch Set 1:
(7 comments)
Agreed. Changed it to always accept a list.
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 1: Code-Review-1
(6 comments)
https://gerrit.ovirt.org/#/c/55872/1/lib/vdsm/protocoldetector.py
Adam Litke has posted comments on this change.
Change subject: FakeLVM: Add changeVGTags support
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55703/2/tests/storagefakelib.py
File tests/storagefakelib.py:
Line
Francesco Romani has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55880
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49546/3/tests/storagefakelib.py
File tests/storagefakelib.py:
Line 156:
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: fill legacy display parameters
..
Patch Set 3:
* #1325361::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325361::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: automation: build and install vdsm only after spec or makefile
change
..
Patch Set 3: Code-Review+1
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: fill legacy display parameters
..
Patch Set 2:
* #1325361::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325361::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 1: Verified+1
Verified with the tests on python 2 and 3 with --enable-stress-tests.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: schedule: Port schedule module to Python 3
..
schedule: Port schedule module to Python 3
In Python 3, you cannot use push a tuple into a heap if one of the
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: fill legacy display parameters
..
Patch Set 1:
* #1325361::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325361::OK, public bug
*
Francesco Romani has uploaded a new change for review.
Change subject: vm: graphics: fill legacy display parameters
..
vm: graphics: fill legacy display parameters
To preserve backward compatibility with Engine 3.5,
Vdsm must
gerrit-hooks has posted comments on this change.
Change subject: virt: reformat code
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
Francesco Romani has uploaded a new change for review.
Change subject: virt: reformat code
..
virt: reformat code
Silly reformatting patch to make the code easier to change:
now updates to dicts() require minimal change (+1/-1
gerrit-hooks has posted comments on this change.
Change subject: automation: build and install vdsm only after spec or makefile
change
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Martin Sivák has posted comments on this change.
Change subject: Bump mom dependency to version 0.5.3
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55867
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove debian install files from vdsm
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55717
To unsubscribe, visit
Roman Mohr has posted comments on this change.
Change subject: Bump mom dependency to version 0.5.3
..
Patch Set 1: Verified+1
Installed from 3.6 snapshot repo and worked
--
To view, visit https://gerrit.ovirt.org/55867
To
Piotr Kliczewski has posted comments on this change.
Change subject: misc: Replace assert with AssertionError
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/34363
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55858/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Nir Soffer has posted comments on this change.
Change subject: sp.py: Assume a hostId when reconstructing master
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55857/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Nir Soffer has posted comments on this change.
Change subject: tests: Use integer division for array index in SchedulerTests
..
Patch Set 1: Verified+1
Tests pass now on Python 3.
Thanks!
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Use integer division for array index in SchedulerTests
..
tests: Use integer division for array index in SchedulerTests
In Python 3 the standard
gerrit-hooks has posted comments on this change.
Change subject: tests: Use integer division for array index in SchedulerTests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Nir Soffer has posted comments on this change.
Change subject: tests: Use integer division for array index in SchedulerTests
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55870
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 1: Verified+1
Verified on Michael's Burman env.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: fix integration tests
..
Patch Set 1: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/55871
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: tests: fix integration tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has uploaded a new change for review.
Change subject: jsonrpc: make sure not to block when processing i/o
..
jsonrpc: make sure not to block when processing i/o
Change-Id:
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: fix integration tests
..
tests: fix integration tests
Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd
Signed-off-by: pkliczewski
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: make sure not to block when processing i/o
..
Patch Set 1:
* #1321325::Update tracker: OK
* #1324155::Update tracker: OK
* #1323465::Update tracker: OK
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 3: Verified+1
Changed as per Nir's comments
--
To view, visit https://gerrit.ovirt.org/55859
To
Allon Mureinik has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 3: Verified+1
Removed pass from setStoragePoolDescription, as per Nir's comment.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55859/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Milan Zamazal has uploaded a new change for review.
Change subject: tests: Use integer division for array index in SchedulerTests
..
tests: Use integer division for array index in SchedulerTests
In Python 3 the standard
gerrit-hooks has posted comments on this change.
Change subject: tests: Use integer division for array index in SchedulerTests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55859/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Allon Mureinik has posted comments on this change.
Change subject: hsm.py: Deprecate setStoragePoolDescription
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55858/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Allon Mureinik has posted comments on this change.
Change subject: sp.py: Assume a hostId when reconstructing master
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55857/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:
gerrit-hooks has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Roman Mohr has uploaded a new change for review.
Change subject: Bump mom dependency to version 0.5.3
..
Bump mom dependency to version 0.5.3
Use mom version 0.5.3 which supports QoS changes on running VMs.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: Bump mom dependency to version 0.5.3
..
Patch Set 1: Verified-1
* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
*
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1:
it passes and the fail is not related. thanks
--
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: spbackends: simplify over-general evaluation
..
Patch Set 3:
Needs verify
--
To view, visit https://gerrit.ovirt.org/41253
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: misc: Replace assert with AssertionError
..
Patch Set 2: Verified+1
This version fix the typo in the commit message and add few trivial tests.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: misc: Replace assert with AssertionError
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
1 - 100 of 176 matches
Mail list logo