Yaniv Bronhaim has posted comments on this change.
Change subject: tests: fix integration tests
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55871/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
Yaniv Bronhaim has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 2:
although, it could be done directly in the initial check module introduction
patch
Yaniv Bronhaim has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 2: Code-Review-1
where is the remove part of the move?
--
To view, visit https://gerrit.ovirt.org/55860
To
Yaniv Bronhaim has posted comments on this change.
Change subject: schedule: Port schedule module to Python 3
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55880
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Make vdsm arch specific package
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42490/5/vdsm.spec.in
File vdsm.spec.in:
Line 45: %global
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Move vdsm package contents to vdsm-deamon
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/42491/7/vdsm.spec.in
File vdsm.spec.in:
Line 255:
Nir Soffer has restored this change.
Change subject: cache: Add caching decorator with invalidation
..
Restored
--
To view, visit https://gerrit.ovirt.org/34709
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: qemuimg: Memoize _supports_qcow2_compat
..
Restored
--
To view, visit https://gerrit.ovirt.org/34711
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Restored
--
To view, visit https://gerrit.ovirt.org/34710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: scsi: Scan only the required domain type
..
Restored
--
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has restored this change.
Change subject: sdc: Rename method to make it less confusing
..
Restored
--
To view, visit https://gerrit.ovirt.org/47916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Jenkins CI RO has abandoned this change.
Change subject: sysprep hook: unconfigure a vm clone
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit https://gerrit.ovirt.org/26886
To
Jenkins CI RO has abandoned this change.
Change subject: netinfo: simplify getNetworksAndVlansForIface
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
Jenkins CI RO has abandoned this change.
Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: netinfo: use a Link object in vlanSpeed
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/46770
To
Jenkins CI RO has abandoned this change.
Change subject: hsm: prepareForShutdown - operations order
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Memoize _supports_qcow2_compat
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/34711
To
gerrit-hooks has posted comments on this change.
Change subject: hsm: prepareForShutdown - operations order
..
Patch Set 5:
* #1161934::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/36162
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
Jenkins CI RO has abandoned this change.
Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
Jenkins CI RO has abandoned this change.
Change subject: sdc: Rename method to make it less confusing
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/34710
Jenkins CI RO has abandoned this change.
Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor
and product id
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To
Jenkins CI RO has abandoned this change.
Change subject: qemuimg: Memoize _supports_qcow2_compat
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit https://gerrit.ovirt.org/34711
gerrit-hooks has posted comments on this change.
Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor
and product id
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: netinfo: simplify getNetworksAndVlansForIface
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/46765
To
Jenkins CI RO has abandoned this change.
Change subject: netinfo: use a Link object in vlanSpeed
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit https://gerrit.ovirt.org/46770
Jenkins CI RO has abandoned this change.
Change subject: configfile: remove no longer used methods. vdsm is no
longer involved in libvirt log rotation since 33925 and we can remove
prefixLines and prependSection.
..
gerrit-hooks has posted comments on this change.
Change subject: sdc: Rename method to make it less confusing
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/47916
To
gerrit-hooks has posted comments on this change.
Change subject: sysprep hook: unconfigure a vm clone
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/26886
To
Jenkins CI RO has abandoned this change.
Change subject: scsi: Scan only the required domain type
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit https://gerrit.ovirt.org/45824
Jenkins CI RO has abandoned this change.
Change subject: cache: Add caching decorator with invalidation
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: scsi: Scan only the required domain type
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/45824
To
gerrit-hooks has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/34709
To
Jenkins CI RO has abandoned this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: configfile: remove no longer used methods. vdsm is no
longer involved in libvirt log rotation since 33925 and we can remove
prefixLines and prependSection.
Nir Soffer has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: test: Prettify netinfo_test mocks
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55900
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55898
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [1]: ovs switch skeleton
..
Patch Set 10:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 6:
* #1195208::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/55309
To
Petr Horáček has abandoned this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Abandoned
rget moved elsewhere, is_ovs_* is not needed with canonicalization
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [1]: ovs switch skeleton
..
Patch Set 9:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: test: Replacing MonkeyPatch with mock.patch example
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has uploaded a new change for review.
Change subject: test: Prettify netinfo_test mocks
..
test: Prettify netinfo_test mocks
Change-Id: I85b89eae71366f7cf3a331b54635483bb5cf9f51
Signed-off-by: Edward Haas
gerrit-hooks has posted comments on this change.
Change subject: test: Prettify netinfo_test mocks
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: port test models_test.py to python 3
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has posted comments on this change.
Change subject: hook: ovs: report network iface expeted by engine
..
Patch Set 1:
if you won't mind, i'd use your code with native, but now let's do it stupid
(and have less
gerrit-hooks has posted comments on this change.
Change subject: hook: ovs: report ip info on expected top device
..
Patch Set 3: Verified-1
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK,
gerrit-hooks has posted comments on this change.
Change subject: hook: ovs: report ip info on expected top device
..
Patch Set 3:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
Petr Horáček has posted comments on this change.
Change subject: hook: ovs: report ip info on expected top device
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/55893/2/vdsm_hooks/ovs/ovs_after_get_caps.py
File
Petr Horáček has posted comments on this change.
Change subject: net: find toplevel iterface name based on net attributes
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55323
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: find toplevel iterface name based on net attributes
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has uploaded a new change for review.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
net tests: Clean netinfo_test from uneeded mocks
Removing mockey patches that are no longer needed.
They
gerrit-hooks has posted comments on this change.
Change subject: net tests: Clean netinfo_test from uneeded mocks
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has posted comments on this change.
Change subject: net: persist bonding 'switch' parameter
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55825
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Fix FakeLVM lv creation size
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/55888/1/tests/storagetestlib.py
File
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: convert 'bridge' attr to boolean
..
Patch Set 2: Verified+1
Caps handling is working now.
--
To view, visit https://gerrit.ovirt.org/55890
To
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: convert 'bridge' attr to boolean
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55890/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: convert 'bridge' attr to boolean
..
Patch Set 2: Verified-1
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK,
Nir Soffer has posted comments on this change.
Change subject: tests: Create block metadata file with correct size
..
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/55887/1/tests/storagetestlib.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: Use VG tags to store fake block domain md
..
Patch Set 3: Code-Review-1
(1 comment)
Need to assert about the domain version.
Nir Soffer has posted comments on this change.
Change subject: tests: storagetestlib: Set fake block domain mountpoint
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55886
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Create fake block volume metadata
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55704
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Test storagetestlib FakeEnv functions
..
Patch Set 1: Code-Review-1
(9 comments)
Nice!
https://gerrit.ovirt.org/#/c/55889/1/tests/storagetestlibTests.py
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: disconnectStorageServer verb
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix a bad value in KSM test
..
Fix a bad value in KSM test
The merge across nodes allows only 0,1,2,3 values.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/55691
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Fix a bad value in KSM test
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55846
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 2:
I utterly forgot about this one!
--
To view, visit https://gerrit.ovirt.org/55897
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: FakeLVM: Add changeVGTags support
..
FakeLVM: Add changeVGTags support
changeVGTags support is needed to properly emulate tag-based block
storage domain
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add changeVGTags support
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 4: Verified+1
Tests pass
--
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: FakeLVM: Add changeLVTags
..
FakeLVM: Add changeLVTags
The BlockVolumeArtifacts code needs to use changeLVTags during volume
creation. Since we will want
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: Add changeVGTags support
..
Patch Set 3: Verified+1
Tests pass
--
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 4: Continuous-Integration+1
Jenkins build succeeded, but for some reason it did not marked this as verified.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: Add changeVGTags support
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: FakeLVM: Add changeLVTags
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55860/2/tests/utilsTests.py
File tests/utilsTests.py:
Line 341: def
Dan Kenigsberg has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/55860/2/tests/utilsTests.py
File tests/utilsTests.py:
Line 341: def
Dan Kenigsberg has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 2:
lib/vdsm/utils.py is - by definition - a function junkyard. I'd rather not add
more stuff onto it before
gerrit-hooks has posted comments on this change.
Change subject: utils: move rget to utils
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: canonicalize switch type from custom options
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: convert 'bridge' attr to boolean
..
Patch Set 1: Code-Review-1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: hook: ovs: report ip info on expected top device
..
Patch Set 2: Code-Review-1
(3 comments)
gerrit-hooks has posted comments on this change.
Change subject: net: move parse_bond_options to netinfo.bonding
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
*
Dan Kenigsberg has posted comments on this change.
Change subject: hook: ovs: report network iface expeted by engine
..
Patch Set 1: Code-Review+1
(1 comment)
your code seems right, but I'd like it even better if you adopt
Dan Kenigsberg has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55490
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: port test models_test.py to python 3
..
Patch Set 1:
Thanks. Would you please add it to the py3 list in tests/Makefile.am, so your
fixes are not broken
Jenkins CI has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 2: -Verified
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required
1 - 100 of 116 matches
Mail list logo
