Nir Soffer has posted comments on this change.
Change subject: require specific pep8 version
..
Patch Set 1: Code-Review-1
This is already solved in master, installing using pip.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 1: Code-Review+2
(1 comment)
Lets make sure this works both for images with links in
Adam Litke has uploaded a new change for review.
Change subject: storage: Do not reference image dir in backing volume path
..
storage: Do not reference image dir in backing volume path
Until now, the backing volume path (to be
gerrit-hooks has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 1:
* #1333627::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1333627::OK,
Nir Soffer has posted comments on this change.
Change subject: automation: Fix wiki url in README
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57240/1/automation/README
File automation/README:
Line 1: Take a look
gerrit-hooks has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 16:
* #1305529::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305529::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: volume: Add volumePath setter to manifest.
..
Patch Set 3:
Adam, does this affect 3.6?
--
To view, visit https://gerrit.ovirt.org/57194
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: volume: Add volumePath setter to manifest.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: volume: Add volumePath setter to manifest.
..
volume: Add volumePath setter to manifest.
Fix broken merge volume flow which was introduced at
commit
gerrit-hooks has posted comments on this change.
Change subject: storage: organize imports in iscsi.py
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: move iscsi.py to vdsm storage lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: organize imports in iscsiadm.py
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: move iscsiadm.py to vdsm storage lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: move imagetickets.py to vdsm storage lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: organize imports in imageSharing.py
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: move curlImgWrap.py to vdsm storage lib
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: organize imports in devicemapper.py
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: storage: move clusterlock.py to vdsm storage lib
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: move devicemapper.py to vdsm storage lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: move imageSharing.py to vdsm storage lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: move fuser module to vdsm storage lib
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: volume: Add volumePath setter to manifest.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57194
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56912/8/lib/vdsm/v2v.py
File
Adam Litke has posted comments on this change.
Change subject: block: simplify zeroImgVolumes using threads
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/35630/3/vdsm/storage/blockSD.py
File
Nir Soffer has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56912
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: support new dd output
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: support new dd output
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: readspeed: drop useless return value
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/56160
To
Francesco Romani has posted comments on this change.
Change subject: tests: improve miscTests::ReadSpeed
..
Patch Set 1:
Comments addressed in 56091, we don't need this patch anymore.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: improve miscTests::ReadSpeed
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/56159
To unsubscribe,
Francesco Romani has abandoned this change.
Change subject: storage: readspeed: drop useless return value
..
Abandoned
Comments addressed in 56091, we don't need this patch anymore.
--
To view, visit
Francesco Romani has abandoned this change.
Change subject: tests: improve miscTests::ReadSpeed
..
Abandoned
Comments addressed in 56091, we don't need this patch anymore.
--
To view, visit https://gerrit.ovirt.org/56159
To
gerrit-hooks has posted comments on this change.
Change subject: storage: readspeed: drop useless return value
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: support new dd output
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Move hoststats code to host package
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Introduce HostApi class to keep only instance
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: Introduce HostApi class to keep only instance
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57182/1/lib/vdsm/common/host/api.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Introduce vdsm.common.host package for all host related code
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/57172
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 25:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK,
gerrit-hooks has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 27:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add vdsClient hotunplug command
..
Patch Set 25:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: Introduce vdsm.common.host package for all host related code
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: m2c: use custom certificate validation function
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/53398
To
Piotr Kliczewski has abandoned this change.
Change subject: m2c: use custom certificate validation function
..
Abandoned
We do not need this patch anymore.
--
To view, visit https://gerrit.ovirt.org/53398
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 4: Verified+1
Simone can you please verify?
--
To view, visit https://gerrit.ovirt.org/56288
To
gerrit-hooks has posted comments on this change.
Change subject: client: do not protect requests on client side
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: Fix wiki url in README
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57240
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: fixes for pep8 1.6.x
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56084/3/vdsm/virt/vmdevices/storage.py
File
Francesco Romani has abandoned this change.
Change subject: configure: add support for nosetests/python 3.5
..
Abandoned
https://gerrit.ovirt.org/#/c/56533 does a better job.
--
To view, visit https://gerrit.ovirt.org/56083
gerrit-hooks has posted comments on this change.
Change subject: configure: add support for nosetests/python 3.5
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/56083
To
gerrit-hooks has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ramesh N has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/56738/5/client/vdsClientGluster.py
File client/vdsClientGluster.py:
Edward Haas has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 25: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Yaniv Bronhaim has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/56874/9/lib/vdsm/host.py
Piotr Kliczewski has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/56874/9/lib/vdsm/host.py
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: get_external_vms returns additional video info for kvm
images
..
Patch Set 3: Code-Review-1
(1 comment)
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 22: Verified+1
Rebase only, no code changes. Verified by updating vdsm and seeing that there
are no
Piotr Kliczewski has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 12: Verified+1
Rebase only, no code changes. Verified by updating vdsm and seeing that there
are no
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 25: Verified+1
Rebase only, no code changes. Verified by updating vdsm and seeing that there
are no communication
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 29: Verified+1
Code changes as Dan requested. Verified by updating vdsm and seeing that there
are no communication
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 24: Verified+1
Code changes as Dan requested. Verified by updating vdsm and seeing that there
are no communication
gerrit-hooks has posted comments on this change.
Change subject: events: verify data before sending
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: schema: externalize api_strict_mode
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: v2v: add support for importing kvm based vms from libvirt
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
gerrit-hooks has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: add support for importing kvm based vms from libvirt
..
v2v: add support for importing kvm based vms from libvirt
Change-Id:
Petr Horáček has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 25: Verified+1
(1 comment)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/56901/24/tests/network/ovs_info_test.py
File
Petr Horáček has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 27: Verified+1
(7 comments)
Passed ovs_info_test.py
https://gerrit.ovirt.org/#/c/56972/26/lib/vdsm/network/ovs/info.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: OVS netinfo
..
Patch Set 27:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 25:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK,
Irit Goihman has posted comments on this change.
Change subject: Introduce vdsm.common.host package for all host related code
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57172
To unsubscribe,
Shahar Havivi has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/56912
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no
Yaniv Bronhaim has posted comments on this change.
Change subject: Move code of the host stats dict creation from API.py to
host.api module
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/56874/9/lib/vdsm/host.py
gerrit-hooks has posted comments on this change.
Change subject: Introduce vdsm.common.host package for all host related code
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Edward Haas has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/56901/24/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:
Line 65:
Shahar Havivi has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 7: Verified-1
--
To view, visit https://gerrit.ovirt.org/56912
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: v2v: get_external_vms returns additional video info for kvm
images
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/57247
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: v2v: get_external_vms returns additional video info for kvm
images
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Pavel Zhukov has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 20: Verified-1
(1 comment)
https://gerrit.ovirt.org/#/c/55029/20/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File
Francesco Romani has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 6:
(1 comment)
looks like we can't have this the clean way :(
Edward Haas has posted comments on this change.
Change subject: net: fake OVS networks as bridgeless
..
Patch Set 5: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/57068/5/lib/vdsm/network/ovs/info.py
File
1 - 100 of 216 matches
Mail list logo