Change in vdsm[master]: bridgeTests:Remove extra param to migrationCreate

Nir Soffer has posted comments on this change. Change subject: bridgeTests:Remove extra param to migrationCreate .. Patch Set 2: This test is marked as broken in master, so this is not needed. The test will be correct when

Change in vdsm[master]: tests: Mark new bridge test as broken

Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Mark new bridge test as broken .. tests: Mark new bridge test as broken In commit acc19386f66d (rpc: Add test for 'int' parameters in Bridge)

Change in vdsm[master]: tests: Mark new bridge test as broken

Dan Kenigsberg has posted comments on this change. Change subject: tests: Mark new bridge test as broken .. Patch Set 1: Code-Review+2 We cannot keep master broken -- To view, visit https://gerrit.ovirt.org/57364 To

Change in vdsm[master]: virt: Temporary fix resolving race condition when adding ext...

Marcin Mirecki has uploaded a new change for review. Change subject: virt: Temporary fix resolving race condition when adding external network to vm .. virt: Temporary fix resolving race condition when adding external network

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

Irit Goihman has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 14: > with this patch, we require el7 developers and builders to install > tox by pip. > > Can

Change in vdsm[master]: v2v: Detect VM with snapshots

Dan Kenigsberg has submitted this change and it was merged. Change subject: v2v: Detect VM with snapshots .. v2v: Detect VM with snapshots virt-v2v cannot properly handle conversion of VMware machine with snapshots. Engine

Change in vdsm[master]: VM.migrationCreate: Add incomingLimit param

David Caro has abandoned this change. Change subject: VM.migrationCreate: Add incomingLimit param .. Abandoned It's more complicated than expected... dropping -- To view, visit https://gerrit.ovirt.org/57391 To unsubscribe,

Change in vdsm[master]: VM.migrationCreate: Add incomingLimit param

David Caro has uploaded a new change for review. Change subject: VM.migrationCreate: Add incomingLimit param .. VM.migrationCreate: Add incomingLimit param Change-Id: I0b0e119cbf25f8d9efaf44adbfea62c67ca493c4 Signed-off-by:

Change in vdsm[master]: bridgeTests:Remove extra param to migrationCreate

David Caro has posted comments on this change. Change subject: bridgeTests:Remove extra param to migrationCreate .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/57388 To unsubscribe, visit

Change in vdsm[master]: bridgeTests:Remove extra param to migrationCreate

David Caro has posted comments on this change. Change subject: bridgeTests:Remove extra param to migrationCreate .. Patch Set 1: This should solve the current issues with the vdsm tests, @mbetak can you ensure it's not

Change in vdsm[master]: bridgeTests:Remove extra param to migrationCreate

David Caro has uploaded a new change for review. Change subject: bridgeTests:Remove extra param to migrationCreate .. bridgeTests:Remove extra param to migrationCreate Change-Id: Ifa02aba240760f1b69aa34b3cba5a1fb2c4120ad

Change in vdsm[master]: hostdev: fix scsi udev rule target

Nir Soffer has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py File vdsm/supervdsm_api/udev.py:

Change in vdsm[master]: DONTMERGE:Using unstable lago

David Caro has abandoned this change. Change subject: DONTMERGE:Using unstable lago .. Abandoned not needed anymore -- To view, visit https://gerrit.ovirt.org/57378 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hostdev: teardown non-scsi devices

Francesco Romani has posted comments on this change. Change subject: hostdev: teardown non-scsi devices .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/57375/4/vdsm/virt/vmdevices/hostdevice.py File

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

Francesco Romani has posted comments on this change. Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57374 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix scsi udev rule target

Francesco Romani has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 4: Code-Review+1 wrong button! -- To view, visit https://gerrit.ovirt.org/57373 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix scsi udev rule target

Francesco Romani has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57373 To unsubscribe, visit

Change in vdsm[master]: storage: add LegacyCdromPath as DriveSpec

Nir Soffer has posted comments on this change. Change subject: storage: add LegacyCdromPath as DriveSpec .. Patch Set 3: Code-Review+1 (1 comment) Nice, thanks!

Change in vdsm[master]: vmdevices: make disk's makeName public

Martin Polednik has posted comments on this change. Change subject: vmdevices: make disk's makeName public .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/56804 To unsubscribe, visit

Change in vdsm[master]: cdrom: API change: require interface & index

Martin Polednik has posted comments on this change. Change subject: cdrom: API change: require interface & index .. Patch Set 5: Verified+1 Verified by (ab)using virt functional tests with new api. -- To view, visit

Change in vdsm[master]: vmxml: move metadata handling into helpers

Francesco Romani has uploaded a new change for review. Change subject: vmxml: move metadata handling into helpers .. vmxml: move metadata handling into helpers to make room for future users of the `metadata' section, we split

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

Martin Polednik has posted comments on this change. Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/57374/4/lib/vdsm/hostdev.py File

Change in vdsm[master]: hostdev: teardown non-scsi devices

Martin Polednik has posted comments on this change. Change subject: hostdev: teardown non-scsi devices .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/57375/4//COMMIT_MSG Commit Message: PS4, Line 11: having wrong

Change in vdsm[master]: hook: add imagerepo feed containers

Francesco Romani has abandoned this change. Change subject: hook: add imagerepo feed containers .. Abandoned could work, but better to have something clearer -- To view, visit https://gerrit.ovirt.org/54873 To unsubscribe,

Change in vdsm[master]: virt: utils: is_kvm from custom containerType

Francesco Romani has abandoned this change. Change subject: virt: utils: is_kvm from custom containerType .. Abandoned better to just use the metadata section. -- To view, visit https://gerrit.ovirt.org/54872 To unsubscribe,

Change in vdsm[master]: containers: always add emulator to XML

Francesco Romani has abandoned this change. Change subject: containers: always add emulator to XML .. Abandoned bad idea: let's use the metadata section, and not abuse vmType. -- To view, visit https://gerrit.ovirt.org/54176

Change in vdsm[master]: vmxml: move namespace declaration

Francesco Romani has uploaded a new change for review. Change subject: vmxml: move namespace declaration .. vmxml: move namespace declaration to make room for future users of the libvirt domain `metadata' section, we move the

Change in vdsm[master]: vmxml: export drive/volume mapping

Francesco Romani has uploaded a new change for review. Change subject: vmxml: export drive/volume mapping .. vmxml: export drive/volume mapping add metadata section about mapping between VM drives and container volumes, which

Change in vdsm[master]: vmxml: metadata could be local variable

Francesco Romani has uploaded a new change for review. Change subject: vmxml: metadata could be local variable .. vmxml: metadata could be local variable There is no need for `metadata' to be an instance variable, so this patch

Change in vdsm[master]: vmxml: move containerType in the metadata section

Francesco Romani has uploaded a new change for review. Change subject: vmxml: move containerType in the metadata section .. vmxml: move containerType in the metadata section TODO Change-Id:

Change in vdsm[master]: Adapting to latest lago 0.17

David Caro has posted comments on this change. Change subject: Adapting to latest lago 0.17 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/57376 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: hostdev: fix scsi udev rule target

Martin Polednik has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57373 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix scsi udev rule target

Francesco Romani has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 4: (1 comment) same question as PS3 https://gerrit.ovirt.org/#/c/57373/4/vdsm/supervdsm_api/udev.py File

Change in vdsm[master]: storage: extend drives name to allow sata interface

Martin Polednik has posted comments on this change. Change subject: storage: extend drives name to allow sata interface .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/56803 To unsubscribe, visit

Change in vdsm[master]: storage: add block device naming tests

Martin Polednik has posted comments on this change. Change subject: storage: add block device naming tests .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/56802 To unsubscribe, visit

Change in vdsm[master]: storage: add LegacyCdromPath as DriveSpec

Martin Polednik has posted comments on this change. Change subject: storage: add LegacyCdromPath as DriveSpec .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/57339 To unsubscribe, visit

Change in vdsm[master]: virt: add kernel cmdline reporting

Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit

Change in vdsm[master]: virt: set correct permissions for hwrng device

Martin Polednik has posted comments on this change. Change subject: virt: set correct permissions for hwrng device .. Patch Set 12: Verified+1 -- To view, visit https://gerrit.ovirt.org/54806 To unsubscribe, visit

Change in vdsm[master]: virt: add kernel cmdline reporting

Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/57084/7/vdsm/caps.py File vdsm/caps.py: Line 175: Line 176:

Change in vdsm[master]: virt: add kernel cmdline reporting

Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit

Change in vdsm[master]: hostdev: teardown non-scsi devices

Francesco Romani has posted comments on this change. Change subject: hostdev: teardown non-scsi devices .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/57375/4//COMMIT_MSG Commit Message: PS4, Line 11: having wrong

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

Francesco Romani has posted comments on this change. Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/57374/4/lib/vdsm/hostdev.py File

Change in vdsm[master]: hostdev: teardown non-scsi devices

Martin Polednik has posted comments on this change. Change subject: hostdev: teardown non-scsi devices .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/57375 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix scsi udev rule target

Martin Polednik has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 4: -Code-Review Verified+1 -- To view, visit https://gerrit.ovirt.org/57373 To unsubscribe, visit

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: To clarify: We must be careful about balloon devices because if libvirt doesn't find one in

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

Martin Polednik has posted comments on this change. Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/57374 To unsubscribe, visit

Change in vdsm[master]: hostdev: fix scsi udev rule target

Martin Polednik has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/57373/3/vdsm/supervdsm_api/udev.py File

Change in vdsm[master]: hostdev: fix scsi udev rule target

Francesco Romani has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 3: Code-Review+1 (1 comment) looks OK, few questions inside

Change in vdsm[master]: hostdev: fix scsi udev rule target

Francesco Romani has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 3: -Code-Review ...and I didn't notice the typo! -- To view, visit https://gerrit.ovirt.org/57373 To

Change in vdsm[master]: hostdev: fix scsi udev rule target

Martin Polednik has posted comments on this change. Change subject: hostdev: fix scsi udev rule target .. Patch Set 3: Code-Review-1 Verified-1 (1 comment) typo snuck in that broke everything, resubmitting asap

Change in vdsm[master]: virt: add kernel cmdline reporting

Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 7: Code-Review+2 (1 comment) looks ok, tested and very low risk. Silly comment inside. Taking ownership (+2

Change in vdsm[master]: Adapting to latest lago 0.17

David Caro has uploaded a new change for review. Change subject: Adapting to latest lago 0.17 .. Adapting to latest lago 0.17 Change-Id: I78360edc6ab2fd0c3faea8f308609b23f711ad0b Signed-off-by: David Caro

Change in vdsm[master]: check-merged:Using yaml for the lago initfile

David Caro has uploaded a new change for review. Change subject: check-merged:Using yaml for the lago initfile .. check-merged:Using yaml for the lago initfile Change-Id: I32af33e5cabda00e2e43e6512079c3b93fa59e9f Signed-off-by:

Change in vdsm[master]: DONTMERGE:Using unstable lago

David Caro has uploaded a new change for review. Change subject: DONTMERGE:Using unstable lago .. DONTMERGE:Using unstable lago Change-Id: Ic5bb2e4bcc4bcaa041c31c7f11a900b0fcf610e2 Signed-off-by: David Caro

Change in vdsm[master]: hostdev: fix rmAppropriateSCSIDevice in reattach

Martin Polednik has uploaded a new change for review. Change subject: hostdev: fix rmAppropriateSCSIDevice in reattach .. hostdev: fix rmAppropriateSCSIDevice in reattach rmAppropriateSCSIDevice also requires name argument.

Change in vdsm[master]: hostdev: teardown non-scsi devices

Martin Polednik has uploaded a new change for review. Change subject: hostdev: teardown non-scsi devices .. hostdev: teardown non-scsi devices We have previously removed tearing down host devices due to issues with some PCI

Change in vdsm[master]: hostdev: fix udev rule target

Martin Polednik has uploaded a new change for review. Change subject: hostdev: fix udev rule target .. hostdev: fix udev rule target Previously, the rule worked as expected but did not properly signal ownership of the device.

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

Francesco Romani has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: I'm not completely sure what's going on here (disclaimer: I haven't spent much time

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: Couldn't we simply ignore balloon devices with model='none'? -- To view, visit

Change in vdsm[master]: monitor: Separate setup from monitor loop

Nir Soffer has uploaded a new change for review. Change subject: monitor: Separate setup from monitor loop .. monitor: Separate setup from monitor loop We have two implicit states in the monitor: - setup produce the

Change in vdsm[master]: migration: log the convergence schedule only if provided

Milan Zamazal has posted comments on this change. Change subject: migration: log the convergence schedule only if provided .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57370 To unsubscribe, visit

Change in vdsm[master]: migrations: enhance legacy downtime alg

Milan Zamazal has posted comments on this change. Change subject: migrations: enhance legacy downtime alg .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56561 To unsubscribe, visit

Change in vdsm[master]: cdrom: API change: require interface & index

Martin Polednik has posted comments on this change. Change subject: cdrom: API change: require interface & index .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/56805/3/lib/api/vdsm-api.yml File

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: For me, the balloon alias gets lost after libvirtd restart. Just restarting Vdsm doesn't

Change in vdsm[master]: migration: log the convergence schedule only if provided

Francesco Romani has posted comments on this change. Change subject: migration: log the convergence schedule only if provided .. Patch Set 1: Code-Review+2 I was also thinking about something like this :) Thanks -- To view,

Change in vdsm[master]: migration: log the convergence schedule only if provided

Tomas Jelinek has uploaded a new change for review. Change subject: migration: log the convergence schedule only if provided .. migration: log the convergence schedule only if provided No need to flood the logs with logs which

Change in vdsm[master]: virt: set correct permissions for hwrng device

Martin Polednik has posted comments on this change. Change subject: virt: set correct permissions for hwrng device .. Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/54806/11/vdsm/supervdsm_api/udev.py File

Change in vdsm[master]: gluster: add gluster heal info verb

Ramesh N has posted comments on this change. Change subject: gluster: add gluster heal info verb .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/56738/9/tests/glusterVolumeHealInfo.xml File

Change in vdsm[master]: gluster: add gluster heal info verb

Sahina Bose has posted comments on this change. Change subject: gluster: add gluster heal info verb .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/56738/9/tests/glusterVolumeHealInfo.xml File

Change in vdsm[master]: gluster: add gluster heal info verb

Ramesh N has posted comments on this change. Change subject: gluster: add gluster heal info verb .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/56738 To unsubscribe, visit

Change in vdsm[master]: migrations: enhance legacy downtime alg

Milan Zamazal has posted comments on this change. Change subject: migrations: enhance legacy downtime alg .. Patch Set 5: (2 comments) Thanks for clarifications. I'm still confused about migration_downtime_delay description,

Change in vdsm[master]: dhclient: consider NetworkManager lease files for DUID too

Ondřej Svoboda has posted comments on this change. Change subject: dhclient: consider NetworkManager lease files for DUID too .. Patch Set 1: May 12 11:25:28 f23-host kernel: bond11: the permanent HWaddr of veth_T7jrD4ZBWw -

Change in vdsm[master]: storage: support new dd output

Nir Soffer has posted comments on this change. Change subject: storage: support new dd output .. Patch Set 5: Looks nice, but I plan to merge first https://gerrit.ovirt.org/54757 and the the monitoring-pre, so this will have

Change in vdsm[master]: migrations: enhance legacy downtime alg

Tomas Jelinek has posted comments on this change. Change subject: migrations: enhance legacy downtime alg .. Patch Set 5: (6 comments) https://gerrit.ovirt.org/#/c/56561/3//COMMIT_MSG Commit Message: PS3, Line 12: during the

Change in vdsm[master]: tests: Mark new bridge test as broken

Francesco Romani has posted comments on this change. Change subject: tests: Mark new bridge test as broken .. Patch Set 1: Code-Review+1 A patch current under review will unbreak this, meanwhile I'm ok with this, we need

Change in vdsm[master]: v2v: Detect VM with snapshots

Francesco Romani has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 899: Line 900:

Change in vdsm[master]: v2v: Detect VM with snapshots

Francesco Romani has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/56574/10/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 899: Line 900: