Freddy Rolland has posted comments on this change.
Change subject: tests: Fix FakeDomainManifest implementation
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57686
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: Move Volume MD fields to storage constants
..
Patch Set 3: Code-Review-1
(1 comment)
Need to fix import in previous patch, needed here
Freddy Rolland has posted comments on this change.
Change subject: Move volume type constants to constants module
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/57581/3/vdsm/storage/volume.py
File
Freddy Rolland has posted comments on this change.
Change subject: Move volume type constants to constants module
..
Patch Set 3: Code-Review-1
(1 comment)
For visibility.
See if my comment is correct.
Freddy Rolland has posted comments on this change.
Change subject: Move VolumeMetadata to vsdm.storage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57685
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: Move gluster package to vdsm.gluster
..
Patch Set 2:
(1 comment)
Overall changes looks to correct. Let me verify once.
Edward Haas has posted comments on this change.
Change subject: virt: Collect vm start flags from device hooks when running vm
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/57538/6//COMMIT_MSG
Commit Message:
PS6,
Edward Haas has posted comments on this change.
Change subject: net: Ignore noqueue queuing discipline
..
Patch Set 1:
We used centos-ovirt40-candidate in master, but I think for 3.6 we should use
something else.
Looks like
gerrit-hooks has posted comments on this change.
Change subject: tests: Simplify DirectFile tests
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Simplify DirectFile tests
..
tests: Simplify DirectFile tests
For diretio we support only full blocks, so using generated data aligned
to block
gerrit-hooks has posted comments on this change.
Change subject: storageServer: Remove dead code
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Simplify DirectFile tests
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Modernize test names
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: Replace magic number with constant
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: directio: Remove useless DirectFile.writelines()
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: directio: Add test for reading entire file
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: directio: Keep line terminators in readlines()
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: Remove the redundant "d" mode
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: Remove open_ex
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: directio: Introduce vdsm.storage.directio module
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: directio: Add failing test for DirectFile.readlines()
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: directio: Port to Python 3
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: directio: Require full blocks
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: infra tests: moved infra tests to tests directory
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/57562/3/tests/filecontrol_test.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/57585
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57710
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: Move blockVolume constants to storage constants
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57583
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: tests: Fix FakeDomainManifest implementation
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57686
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: Move VolumeMetadata to vsdm.storage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57685
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: Move volume type constants to constants module
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57581
To unsubscribe, visit
Pavel Zhukov has posted comments on this change.
Change subject: net: Ignore noqueue queuing discipline
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57557
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: Move Volume MD fields to storage constants
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57582
To unsubscribe, visit
Hello Piotr Kliczewski, Adam Litke,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/57710
to review the following change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 1:
* #1337314::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1337314::OK, public bug
Nir Soffer has posted comments on this change.
Change subject: Move blockVolume constants to storage constants
..
Patch Set 3:
Waiting for another review and ci.
--
To view, visit https://gerrit.ovirt.org/57583
To
Nir Soffer has posted comments on this change.
Change subject: Move volume type constants to constants module
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57581
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Collect vm start flags from device hooks when running vm
..
Patch Set 6:
* #1314371::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: Move Volume MD fields to storage constants
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57582
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Move VolumeMetadata to vsdm.storage
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57685
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: Import storage constants as sc
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57580
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Temporary hack around circular import
..
Patch Set 1: Code-Review-1
Will be deleted soon, if you use this, please rebase on
gerrit-hooks has posted comments on this change.
Change subject: Move VolumeMetadata to vsdm.storage
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has submitted this change and it was merged.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
blockSD: Fix busy loop when zeroing image volumes
We used to wait on the wrong file descriptor
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 6:
* #1337314::Update tracker: OK
* Set MODIFIED::bug 1337314#1337314OK
--
To view,
Adam Litke has posted comments on this change.
Change subject: Move VolumeMetadata to vsdm.storage
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/57685
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Move blockVolume constants to storage constants
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/57583
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: tests: Fix FakeDomainManifest implementation
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/57686
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Move volume type constants to constants module
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/57581
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Move Volume MD fields to storage constants
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/57582
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Import storage constants as sc
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/57580
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix FakeDomainManifest implementation
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Move Volume MD fields to storage constants
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: Move blockVolume constants to storage constants
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Move volume type constants to constants module
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 49:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 11:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitor: Simplify Status class
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 13:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 15:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 19:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 19:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 31:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 5:
* #1337314::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1337314::OK, public bug
Piotr Kliczewski has posted comments on this change.
Change subject: yml: return type fixes for Host.getCapabilities
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/57623/3/lib/api/vdsm-api.yml
File
Nir Soffer has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/57432
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 30: Verified+1
--
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/56886
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/56826
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Pass change event to monitor threads
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: monitor: Pass change event to monitor threads
..
monitor: Pass change event to monitor threads
We used to pass the DomainMonitor object to MonitorThread,
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 14:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 10:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 12:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 48:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitor: Simplify Status class
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 18:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 18:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 30:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57541
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57585
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: monitor: Pass change event to monitor threads
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57706
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: monitor: Pass change event to monitor threads
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: monitor: Pass change event to monitor threads
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57706
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/57585
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: monitor: Pass change event to monitor threads
..
Patch Set 1: Code-Review+1
Gets rid of that nasty weakref too!
--
To view, visit https://gerrit.ovirt.org/57706
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: monitor: Pass change event to monitor threads
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: monitor: Pass change event to monitor threads
..
monitor: Pass change event to monitor threads
We used to pass the DomainMonitor object to MonitorThread, so the
Nir Soffer has posted comments on this change.
Change subject: tests: Fix FakeDomainManifest implementation
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57686
To unsubscribe, visit
1 - 100 of 325 matches
Mail list logo