Nir Soffer has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 2:
ping
--
To view, visit https://gerrit.ovirt.org/57419
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sp: _upgradePoolDomain - improved logging
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/57551/3/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 153
Nir Soffer has posted comments on this change.
Change subject: sp: _upgradePool - log before starting domain upgrade thread
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57550
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitor: Simplify Status class
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 12:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 14:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 50:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 32:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 20:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 16:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 20:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
Nir Soffer has abandoned this change.
Change subject: storage: Temporary hack around circular import
..
Abandoned
Not needed now
--
To view, visit https://gerrit.ovirt.org/57480
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Temporary hack around circular import
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/57480
To
Francesco Romani has posted comments on this change.
Change subject: migration: use composition in DowntimeThread
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56687/4//COMMIT_MSG
Commit Message:
PS4, Line 9: It
Francesco Romani has posted comments on this change.
Change subject: migration: wait for monitor thread before to exit
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57753/1/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: migration: move helper into Progress class
..
Patch Set 12: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/56313/12/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Code-Review+1
adding exception (removed gerrit-hooks score) because this change has
Petr Horáček has posted comments on this change.
Change subject: ppc64hwinfo: add tests for _getFromDeviceTree
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/57746/1/tests/hwinfo_test.py
File
Petr Balogh has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Verified+1
Verified same as in the case of the patch which I cherry-picked from.
--
To view,
Edward Haas has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57444
To unsubscribe, visit
Tomas Golembiovsky has posted comments on this change.
Change subject: schema: Marked optional fields in ExternalVmInfo.
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/57417/1//COMMIT_MSG
Commit Message:
PS1, Line
Martin Polednik has posted comments on this change.
Change subject: migration: early exit when stopped
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57658
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: migration: MonitorThread.progress could be None
..
migration: MonitorThread.progress could be None
A future patch wants to provide richer progress
Martin Polednik has posted comments on this change.
Change subject: migration: move helper into Progress class
..
Patch Set 12: Code-Review+1
way nicer imo!
--
To view, visit https://gerrit.ovirt.org/56313
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: ppc64hwinfo: make _getFromDeviceTree testable
..
Patch Set 1: Code-Review+1
(1 comment)
seems harmless enough to have tests in the followup patch
Petr Horáček has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 5: Verified+1
Passed unit network tests.
--
To view, visit https://gerrit.ovirt.org/57444
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: Block stuck VMs in executor
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has posted comments on this change.
Change subject: migration: use composition in DowntimeThread
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56687/4//COMMIT_MSG
Commit Message:
PS4, Line 9: It is
Martin Polednik has posted comments on this change.
Change subject: migration: unify again performing modes
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56686
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: ppc64hwinfo: make _getFromDeviceTree testable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57745/1/lib/vdsm/ppc64HardwareInfo.py
File
Martin Polednik has posted comments on this change.
Change subject: migration: make MonitorThread own DowntimeThread
..
Patch Set 5: Code-Review+1
Fine by me, the name makes it much better for someone not involved in the code.
Martin Polednik has posted comments on this change.
Change subject: migration: wait for monitor thread before to exit
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57753/1/vdsm/virt/migration.py
File
Martin Polednik has posted comments on this change.
Change subject: migration: add 'ongoing' property to Progress
..
Patch Set 12: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56314
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: migration: MonitorThread.progress could be None
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57752
To unsubscribe, visit
Martin Polednik has uploaded a new change for review.
Change subject: ppc64hwinfo: refactor _getFromDeviceTree
..
ppc64hwinfo: refactor _getFromDeviceTree
The function was not pep8 compliant and not really nice either. We
Francesco Romani has uploaded a new change for review.
Change subject: migration: wait for monitor thread before to exit
..
migration: wait for monitor thread before to exit
We want to make sure to not leave the monitor thread
gerrit-hooks has posted comments on this change.
Change subject: migration: make MonitorThread own DowntimeThread
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has uploaded a new change for review.
Change subject: ppc64hwinfo: refactor getHardwareInfoStructure
..
ppc64hwinfo: refactor getHardwareInfoStructure
Since all information we need are now available via
gerrit-hooks has posted comments on this change.
Change subject: migration: add 'ongoing' property to Progress
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: migration: early exit when stopped
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: migration: unify again performing modes
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has uploaded a new change for review.
Change subject: ppc64hwinfo: extend cpuinfo to platform and machine
..
ppc64hwinfo: extend cpuinfo to platform and machine
Platform and machine keys in cpuinfo are ppc64 and
gerrit-hooks has posted comments on this change.
Change subject: migration: decorate with utils.traceback()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: use composition in DowntimeThread
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: ppc64hwinfo: make _getFromDeviceTree testable
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: migration: move helper into Progress class
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: MonitorThread.progress could be None
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ppc64hwinfo: extend cpuinfo to platform and machine
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ppc64hwinfo: make getHardwareInfoStructure testable
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: migration: wait for monitor thread before to exit
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ppc64hwinfo: add tests for _getFromDeviceTree
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ppc64hwinfo: refactor _getFromDeviceTree
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has uploaded a new change for review.
Change subject: ppc64hwinfo: make _getFromDeviceTree testable
..
ppc64hwinfo: make _getFromDeviceTree testable
We make the code testable by factoring device tree path to the
gerrit-hooks has posted comments on this change.
Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has uploaded a new change for review.
Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure
..
ppc64hwinfo: add tests for getHardwareInfoStructure
Change-Id:
Martin Polednik has uploaded a new change for review.
Change subject: ppc64hwinfo: make getHardwareInfoStructure testable
..
ppc64hwinfo: make getHardwareInfoStructure testable
Make the code testable by moving cpuinfo path to
gerrit-hooks has posted comments on this change.
Change subject: ppc64hwinfo: refactor getHardwareInfoStructure
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Martin Polednik has uploaded a new change for review.
Change subject: ppc64hwinfo: add tests for _getFromDeviceTree
..
ppc64hwinfo: add tests for _getFromDeviceTree
Change-Id: Id589267feafafd14846c1d38a850e0a79ae8e0d2
Francesco Romani has posted comments on this change.
Change subject: migration: use composition in DowntimeThread
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56687/4//COMMIT_MSG
Commit Message:
PS4, Line 9: It
gerrit-hooks has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57547
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: code coverage: add coverage for supervdsmServer
..
code coverage: add coverage for supervdsmServer
In our QE jobs we would like to see also coverage
Martin Polednik has posted comments on this change.
Change subject: migration: make MonitorThread own DowntimeThread
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56685/4/vdsm/virt/migration.py
File
Petr Horáček has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 4: Verified+1
(1 comment)
Passed network unit tests.
Piotr Kliczewski has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57735
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: make MonitorThread own DowntimeThread
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/56685/4/vdsm/virt/migration.py
File
Martin Peřina has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57620
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/57620
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: migration: move helper into Progress class
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/56313/11/vdsm/virt/migration.py
File
gerrit-hooks has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Eli Mesika has posted comments on this change.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/57620/7/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line
Edward Haas has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/57444/4/lib/vdsm/network/ovs/switch.py
File
Petr Balogh has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1:
OK, thank you. it's cherry-picked here: https://gerrit.ovirt.org/#/c/57735
--
To view, visit
Petr Balogh has uploaded a new change for review.
Change subject: code coverage: add coverage for supervdsmServer
..
code coverage: add coverage for supervdsmServer
In our QE jobs we would like to see also coverage report for
gerrit-hooks has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
gerrit-hooks has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: code coverage: add coverage for supervdsmServer
..
Patch Set 1: Code-Review+1
the ovirt-3.6.3 branch is no longer used.
backporting to 3.6.z is feasible:
Francesco Romani has posted comments on this change.
Change subject: vdsm: return error when status cmd fail
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57641
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: vdsm: return error when status cmd fail
..
vdsm: return error when status cmd fail
This patch fixes an issue in the case that status command fails.
gerrit-hooks has posted comments on this change.
Change subject: vdsm: return error when status cmd fail
..
Patch Set 2:
* #1325664::Update tracker: OK
* Set MODIFIED::bug 1325664#1325664OK
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 3: Verified+1
(4 comments)
Passed network unit tests.
Martin Polednik has posted comments on this change.
Change subject: tests: Prevent multiple invocations of makecerts.sh
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57344
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/57444/3/lib/vdsm/network/ovs/validator.py
File
Edward Haas has posted comments on this change.
Change subject: net: ovs validator should accept multiple untagged nets
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57443
To unsubscribe, visit
Martin Peřina has posted comments on this change.
Change subject: vdsm: return error when status cmd fail
..
Patch Set 1:
Can we merge it?
--
To view, visit https://gerrit.ovirt.org/57641
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: use netinfo for OVS validation
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Martin Polednik has posted comments on this change.
Change subject: migration: move helper into Progress class
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/56313/11/vdsm/virt/migration.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Prevent multiple invocations of makecerts.sh
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57344
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: draft: Adding report_stats to host.api, virt.stats and health
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Francesco Romani has posted comments on this change.
Change subject: migration: move helper into Progress class
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/56313/11/vdsm/virt/migration.py
File
Petr Horáček has posted comments on this change.
Change subject: net: ovs validator should accept multiple untagged nets
..
Patch Set 3: Verified+1
(1 comment)
Passed network unit tests.
gerrit-hooks has posted comments on this change.
Change subject: net: ovs validator should accept multiple untagged nets
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK,
Nir Soffer has posted comments on this change.
Change subject: draft: Adding report_stats to host.api and to virt.stats
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/56880/17/lib/vdsm/reports.py
File
1 - 100 of 182 matches
Mail list logo