Change in vdsm[ovirt-3.6]: storage: Do not reference image dir in backing volume path

2016-05-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Do not reference image dir in backing volume path .. Patch Set 2: ping -- To view, visit https://gerrit.ovirt.org/57419 To unsubscribe, visit

Change in vdsm[master]: sp: _upgradePoolDomain - improved logging

2016-05-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: _upgradePoolDomain - improved logging .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/57551/3/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 153

Change in vdsm[master]: sp: _upgradePool - log before starting domain upgrade thread

2016-05-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: _upgradePool - log before starting domain upgrade thread .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57550 To unsubscribe, visit

Change in vdsm[master]: monitor: Separate path status and domain status

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitor: Separate path status and domain status .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: monitor: Simplify Status class

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitor: Simplify Status class .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: lvm: Simplify locking, increasing concurrency

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: lvm: Simplify locking, increasing concurrency .. Patch Set 12: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug *

Change in vdsm[master]: misc: Remove unused readspeed function

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: misc: Remove unused readspeed function .. Patch Set 14: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check

Change in vdsm[master]: tests: Add monitor thread tests

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add monitor thread tests .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: monitoring: Introduce the check module

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the check module .. Patch Set 50: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check

Change in vdsm[master]: monitor: Detach read delay from storage domain

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitor: Detach read delay from storage domain .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: monitoring: Introduce the asyncevent module

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the asyncevent module .. Patch Set 32: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug *

Change in vdsm[master]: monitoring: Add process helpers

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitoring: Add process helpers .. Patch Set 20: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check

Change in vdsm[master]: monitor: Eliminate nextStatus instance variable

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitor: Eliminate nextStatus instance variable .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: monitor: Separate setup from monitor loop

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitor: Separate setup from monitor loop .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: monitoring: Use new monitoring infrastructure

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitoring: Use new monitoring infrastructure .. Patch Set 16: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug *

Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: monitoring: Port vdsm.storage.check to python 3 .. Patch Set 20: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug

Change in vdsm[master]: storage: Temporary hack around circular import

2016-05-19 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: storage: Temporary hack around circular import .. Abandoned Not needed now -- To view, visit https://gerrit.ovirt.org/57480 To unsubscribe, visit

Change in vdsm[master]: storage: Temporary hack around circular import

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Temporary hack around circular import .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/57480 To

Change in vdsm[master]: migration: use composition in DowntimeThread

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: use composition in DowntimeThread .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56687/4//COMMIT_MSG Commit Message: PS4, Line 9: It

Change in vdsm[master]: migration: wait for monitor thread before to exit

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/57753/1/vdsm/virt/migration.py File

Change in vdsm[master]: migration: move helper into Progress class

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 12: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56313/12/vdsm/virt/migration.py File

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Code-Review+1 adding exception (removed gerrit-hooks score) because this change has

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

2016-05-19 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/57746/1/tests/hwinfo_test.py File

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread pbalogh
Petr Balogh has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Verified+1 Verified same as in the case of the patch which I cherry-picked from. -- To view,

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57444 To unsubscribe, visit

Change in vdsm[master]: schema: Marked optional fields in ExternalVmInfo.

2016-05-19 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: schema: Marked optional fields in ExternalVmInfo. .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/57417/1//COMMIT_MSG Commit Message: PS1, Line

Change in vdsm[master]: migration: early exit when stopped

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: early exit when stopped .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57658 To unsubscribe, visit

Change in vdsm[master]: migration: MonitorThread.progress could be None

2016-05-19 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: migration: MonitorThread.progress could be None .. migration: MonitorThread.progress could be None A future patch wants to provide richer progress

Change in vdsm[master]: migration: move helper into Progress class

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 12: Code-Review+1 way nicer imo! -- To view, visit https://gerrit.ovirt.org/56313 To unsubscribe,

Change in vdsm[master]: ppc64hwinfo: make _getFromDeviceTree testable

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: ppc64hwinfo: make _getFromDeviceTree testable .. Patch Set 1: Code-Review+1 (1 comment) seems harmless enough to have tests in the followup patch

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 5: Verified+1 Passed unit network tests. -- To view, visit https://gerrit.ovirt.org/57444 To unsubscribe,

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: virt: Block stuck VMs in executor

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Block stuck VMs in executor .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: Limit the number of workers in executor

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: use composition in DowntimeThread

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: use composition in DowntimeThread .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56687/4//COMMIT_MSG Commit Message: PS4, Line 9: It is

Change in vdsm[master]: migration: unify again performing modes

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: unify again performing modes .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56686 To unsubscribe, visit

Change in vdsm[master]: ppc64hwinfo: make _getFromDeviceTree testable

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: ppc64hwinfo: make _getFromDeviceTree testable .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/57745/1/lib/vdsm/ppc64HardwareInfo.py File

Change in vdsm[master]: migration: make MonitorThread own DowntimeThread

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 5: Code-Review+1 Fine by me, the name makes it much better for someone not involved in the code.

Change in vdsm[master]: migration: wait for monitor thread before to exit

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/57753/1/vdsm/virt/migration.py File

Change in vdsm[master]: migration: add 'ongoing' property to Progress

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56314 To unsubscribe, visit

Change in vdsm[master]: migration: MonitorThread.progress could be None

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: MonitorThread.progress could be None .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57752 To unsubscribe, visit

Change in vdsm[master]: ppc64hwinfo: refactor _getFromDeviceTree

2016-05-19 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: ppc64hwinfo: refactor _getFromDeviceTree .. ppc64hwinfo: refactor _getFromDeviceTree The function was not pep8 compliant and not really nice either. We

Change in vdsm[master]: migration: wait for monitor thread before to exit

2016-05-19 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: migration: wait for monitor thread before to exit .. migration: wait for monitor thread before to exit We want to make sure to not leave the monitor thread

Change in vdsm[master]: migration: make MonitorThread own DowntimeThread

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: refactor getHardwareInfoStructure

2016-05-19 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: ppc64hwinfo: refactor getHardwareInfoStructure .. ppc64hwinfo: refactor getHardwareInfoStructure Since all information we need are now available via

Change in vdsm[master]: migration: add 'ongoing' property to Progress

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: add 'ongoing' property to Progress .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: early exit when stopped

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: early exit when stopped .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: migration: unify again performing modes

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: unify again performing modes .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: ppc64hwinfo: extend cpuinfo to platform and machine

2016-05-19 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: ppc64hwinfo: extend cpuinfo to platform and machine .. ppc64hwinfo: extend cpuinfo to platform and machine Platform and machine keys in cpuinfo are ppc64 and

Change in vdsm[master]: migration: decorate with utils.traceback()

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: decorate with utils.traceback() .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: use composition in DowntimeThread

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: use composition in DowntimeThread .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: ppc64hwinfo: make _getFromDeviceTree testable

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: make _getFromDeviceTree testable .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: move helper into Progress class

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: MonitorThread.progress could be None

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: MonitorThread.progress could be None .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: extend cpuinfo to platform and machine

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: extend cpuinfo to platform and machine .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: make getHardwareInfoStructure testable

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: make getHardwareInfoStructure testable .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: wait for monitor thread before to exit

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: wait for monitor thread before to exit .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: refactor _getFromDeviceTree

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: refactor _getFromDeviceTree .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: ppc64hwinfo: make _getFromDeviceTree testable

2016-05-19 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: ppc64hwinfo: make _getFromDeviceTree testable .. ppc64hwinfo: make _getFromDeviceTree testable We make the code testable by factoring device tree path to the

Change in vdsm[master]: ppc64hwinfo: add tests for getHardwareInfoStructure

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: add tests for getHardwareInfoStructure

2016-05-19 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure .. ppc64hwinfo: add tests for getHardwareInfoStructure Change-Id:

Change in vdsm[master]: ppc64hwinfo: make getHardwareInfoStructure testable

2016-05-19 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: ppc64hwinfo: make getHardwareInfoStructure testable .. ppc64hwinfo: make getHardwareInfoStructure testable Make the code testable by moving cpuinfo path to

Change in vdsm[master]: ppc64hwinfo: refactor getHardwareInfoStructure

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: refactor getHardwareInfoStructure .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: ppc64hwinfo: add tests for _getFromDeviceTree

2016-05-19 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: ppc64hwinfo: add tests for _getFromDeviceTree .. ppc64hwinfo: add tests for _getFromDeviceTree Change-Id: Id589267feafafd14846c1d38a850e0a79ae8e0d2

Change in vdsm[master]: migration: use composition in DowntimeThread

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: use composition in DowntimeThread .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56687/4//COMMIT_MSG Commit Message: PS4, Line 9: It

Change in vdsm[master]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57547 To unsubscribe, visit

Change in vdsm[master]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: code coverage: add coverage for supervdsmServer .. code coverage: add coverage for supervdsmServer In our QE jobs we would like to see also coverage

Change in vdsm[master]: migration: make MonitorThread own DowntimeThread

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56685/4/vdsm/virt/migration.py File

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 4: Verified+1 (1 comment) Passed network unit tests.

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57735 To unsubscribe, visit

Change in vdsm[master]: migration: make MonitorThread own DowntimeThread

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: make MonitorThread own DowntimeThread .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/56685/4/vdsm/virt/migration.py File

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread mperina
Martin Peřina has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit

Change in vdsm[master]: migration: move helper into Progress class

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/56313/11/vdsm/virt/migration.py File

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py

2016-05-19 Thread emesika
Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/57620/7/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/57444/4/lib/vdsm/network/ovs/switch.py File

Change in vdsm[master]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread pbalogh
Petr Balogh has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: OK, thank you. it's cherry-picked here: https://gerrit.ovirt.org/#/c/57735 -- To view, visit

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread pbalogh
Petr Balogh has uploaded a new change for review. Change subject: code coverage: add coverage for supervdsmServer .. code coverage: add coverage for supervdsmServer In our QE jobs we would like to see also coverage report for

Change in vdsm[ovirt-3.6]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: code coverage: add coverage for supervdsmServer

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: code coverage: add coverage for supervdsmServer .. Patch Set 1: Code-Review+1 the ovirt-3.6.3 branch is no longer used. backporting to 3.6.z is feasible:

Change in vdsm[ovirt-3.6]: vdsm: return error when status cmd fail

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vdsm: return error when status cmd fail .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57641 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: vdsm: return error when status cmd fail

2016-05-19 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: vdsm: return error when status cmd fail .. vdsm: return error when status cmd fail This patch fixes an issue in the case that status command fails.

Change in vdsm[ovirt-3.6]: vdsm: return error when status cmd fail

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: return error when status cmd fail .. Patch Set 2: * #1325664::Update tracker: OK * Set MODIFIED::bug 1325664#1325664OK -- To view, visit

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 3: Verified+1 (4 comments) Passed network unit tests.

Change in vdsm[master]: tests: Prevent multiple invocations of makecerts.sh

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: tests: Prevent multiple invocations of makecerts.sh .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57344 To unsubscribe, visit

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/57444/3/lib/vdsm/network/ovs/validator.py File

Change in vdsm[master]: net: ovs validator should accept multiple untagged nets

2016-05-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: ovs validator should accept multiple untagged nets .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57443 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: vdsm: return error when status cmd fail

2016-05-19 Thread mperina
Martin Peřina has posted comments on this change. Change subject: vdsm: return error when status cmd fail .. Patch Set 1: Can we merge it? -- To view, visit https://gerrit.ovirt.org/57641 To unsubscribe, visit

Change in vdsm[master]: net: use netinfo for OVS validation

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: migration: move helper into Progress class

2016-05-19 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/56313/11/vdsm/virt/migration.py File

Change in vdsm[master]: tests: Prevent multiple invocations of makecerts.sh

2016-05-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Prevent multiple invocations of makecerts.sh .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57344 To unsubscribe, visit

Change in vdsm[master]: draft: Adding report_stats to host.api, virt.stats and health

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: draft: Adding report_stats to host.api, virt.stats and health .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: migration: move helper into Progress class

2016-05-19 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: move helper into Progress class .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/56313/11/vdsm/virt/migration.py File

Change in vdsm[master]: net: ovs validator should accept multiple untagged nets

2016-05-19 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: ovs validator should accept multiple untagged nets .. Patch Set 3: Verified+1 (1 comment) Passed network unit tests.

Change in vdsm[master]: net: ovs validator should accept multiple untagged nets

2016-05-19 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: ovs validator should accept multiple untagged nets .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK,

Change in vdsm[master]: draft: Adding report_stats to host.api and to virt.stats

2016-05-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: draft: Adding report_stats to host.api and to virt.stats .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/56880/17/lib/vdsm/reports.py File

  1   2   >