Change in vdsm[master]: sdc: Safer way to access storage domain manifest

Adam Litke has posted comments on this change. Change subject: sdc: Safer way to access storage domain manifest .. Patch Set 4: Ping. This is needed for SDM.copy_data -- To view, visit https://gerrit.ovirt.org/58879 To

Change in vdsm[master]: rename execCmd and startCmd to run_cmd and start_cmd

Nir Soffer has posted comments on this change. Change subject: rename execCmd and startCmd to run_cmd and start_cmd .. Patch Set 1: Please do this change before creating startCmd. -- To view, visit

Change in vdsm[master]: rename execCmd and startCmd to run_cmd and start_cmd

Nir Soffer has posted comments on this change. Change subject: rename execCmd and startCmd to run_cmd and start_cmd .. Patch Set 1: Looks nice, will review later. -- To view, visit https://gerrit.ovirt.org/60280 To

Change in vdsm[master]: sd: Unify getVolumeLease signature

Adam Litke has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60281 To unsubscribe, visit

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

Adam Litke has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60282 To unsubscribe, visit

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

gerrit-hooks has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config .. Patch Set 5: * #1344289::Update tracker: OK * Set MODIFIED::bug 1344289#1344289OK --

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

Nir Soffer has submitted this change and it was merged. Change subject: verify_untrusted_volume: Only allow compat designated by config .. verify_untrusted_volume: Only allow compat designated by config Currently each host

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

gerrit-hooks has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

Nir Soffer has uploaded a new change for review. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. sd: Move getVolumeLease to StorageDomainManifest We need to acquire volume leases from any host during data

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

Adam Litke has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config .. Patch Set 4: Verified+1 (1 comment) Verified with unit tests.

Change in vdsm[master]: sd: Unify getVolumeLease signature

gerrit-hooks has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

gerrit-hooks has posted comments on this change. Change subject: Remove deathSignal usages in sync execCmd calls .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: Add docstrings about Executor parameters and behavior

Francesco Romani has posted comments on this change. Change subject: virt: Add docstrings about Executor parameters and behavior .. Patch Set 14: Verified+1 this change only touches docstrings. If jenkins is happy, so we are.

Change in vdsm[master]: rename execCmd and startCmd to run_cmd and start_cmd

Yaniv Bronhaim has uploaded a new change for review. Change subject: rename execCmd and startCmd to run_cmd and start_cmd .. rename execCmd and startCmd to run_cmd and start_cmd Change-Id:

Change in vdsm[master]: Using startCmd func for running async execution

Yaniv Bronhaim has posted comments on this change. Change subject: Using startCmd func for running async execution .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py File

Change in vdsm[master]: Using startCmd func for running async execution

Nir Soffer has posted comments on this change. Change subject: Using startCmd func for running async execution .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py File lib/vdsm/commands.py:

Change in vdsm[master]: Using startCmd func for running async execution

Yaniv Bronhaim has posted comments on this change. Change subject: Using startCmd func for running async execution .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py File

Change in vdsm[master]: schema: fix VM.create return value

Francesco Romani has posted comments on this change. Change subject: schema: fix VM.create return value .. Patch Set 1: Code-Review-1 still broken. -- To view, visit https://gerrit.ovirt.org/60279 To unsubscribe, visit

Change in vdsm[master]: schema: fix VM.create parameters

gerrit-hooks has posted comments on this change. Change subject: schema: fix VM.create parameters .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: schema: fix VM.create return value

Francesco Romani has uploaded a new change for review. Change subject: schema: fix VM.create return value .. schema: fix VM.create return value Fix the return value of this verb to match what Engine 4.0.0 actually expects

Change in vdsm[master]: Using startCmd func for running async execution

Yaniv Bronhaim has posted comments on this change. Change subject: Using startCmd func for running async execution .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py File

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

Nir Soffer has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config .. Patch Set 4: Code-Review+2 I talk with Adam and we agreed that this is good enough for 4.0,

Change in vdsm[master]: contrib: add simple tool to prettify python dumps

Nir Soffer has posted comments on this change. Change subject: contrib: add simple tool to prettify python dumps .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60272/1//COMMIT_MSG Commit Message: Line 10: API logs.

Change in vdsm[master]: tests: add helper to read test data

Nir Soffer has posted comments on this change. Change subject: tests: add helper to read test data .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py File tests/testlib.py: Line 567: return

Change in vdsm[master]: schema: fix VM.create

Francesco Romani has posted comments on this change. Change subject: schema: fix VM.create .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/59258/4/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 6487 Line 6488

Change in vdsm[master]: tests: add helper to read test data

gerrit-hooks has posted comments on this change. Change subject: tests: add helper to read test data .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: add helper to read test data

Francesco Romani has posted comments on this change. Change subject: tests: add helper to read test data .. Patch Set 1: Verified+1 verified while working on 59258 -- To view, visit https://gerrit.ovirt.org/60271 To

Change in vdsm[master]: contrib: add simple tool to prettify python dumps

Francesco Romani has uploaded a new change for review. Change subject: contrib: add simple tool to prettify python dumps .. contrib: add simple tool to prettify python dumps We often need to feed log dumps into tests, like API

Change in vdsm[master]: schema: use datatype to silence inconsistencies

Francesco Romani has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt File contrib/refmt: Line 1:

Change in vdsm[master]: schema: use datatype to silence inconsistencies

Francesco Romani has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59258/3/tests/testlib.py File tests/testlib.py:

Change in vdsm[master]: schema: use datatype to silence inconsistencies

Piotr Kliczewski has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt File contrib/refmt: Line 1:

Change in vdsm[master]: schema: use datatype to silence inconsistencies

Francesco Romani has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 3: (2 comments) need to split the changes to the schema in a series. This patch will fix

Change in vdsm[master]: schema: use datatype to silence inconsistencies

Francesco Romani has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 3: Data always comes from oVirt Engine Version: 4.0.0.4-1.el7.centos -- To view, visit

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG Commit Message: Line 13: It would be

Change in vdsm[master]: schema: use datatype to silence inconsistencies

Francesco Romani has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 3: Code-Review-1 still broken, as per previous patchset -- To view, visit

Change in vdsm[master]: schema: use datatype to silence inconsistencies

gerrit-hooks has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: schema: use datatype to silence inconsistencies

Francesco Romani has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies .. Patch Set 2: Code-Review-1 WIP, still broken. Data comes from oVirt Engine Version: 4.0.0.4-1.el7.centos

Change in vdsm[master]: supervdsm: expose systemd utilities

gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vmxml: add image in metadata container

gerrit-hooks has posted comments on this change. Change subject: vmxml: add image in metadata container .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Enable tests watcher only if TIMEOUT set

Francesco Romani has posted comments on this change. Change subject: tests: Enable tests watcher only if TIMEOUT set .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60240 To unsubscribe, visit

Change in vdsm[master]: tests: Add test for testing the timeout mechanism

Francesco Romani has posted comments on this change. Change subject: tests: Add test for testing the timeout mechanism .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/58423 To unsubscribe, visit

Change in vdsm[master]: tests: Terminate watcher when tests fail

Francesco Romani has posted comments on this change. Change subject: tests: Terminate watcher when tests fail .. Patch Set 1: Code-Review+1 seen this on my box, nice fix -- To view, visit https://gerrit.ovirt.org/60239 To

Change in vdsm[master]: utils: build cert paths in single place

Francesco Romani has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 11: Code-Review+1 nice improvement. -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe,

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

gerrit-hooks has posted comments on this change. Change subject: Revert "spbackends: Remove StoragePoolDiskBackend" .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

Nir Soffer has submitted this change and it was merged. Change subject: Revert "spbackends: Remove StoragePoolDiskBackend" .. Revert "spbackends: Remove StoragePoolDiskBackend" This reverts commit

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

Nir Soffer has posted comments on this change. Change subject: Revert "spbackends: Remove StoragePoolDiskBackend" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60256 To unsubscribe, visit

Change in vdsm[master]: contrib: Simple jsonrpc client

Jenkins CI has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 16: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 15 -- To view,

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

Allon Mureinik has posted comments on this change. Change subject: Revert "spbackends: Remove StoragePoolDiskBackend" .. Patch Set 1: Verified+1 trivial git revert -- To view, visit https://gerrit.ovirt.org/60256 To

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

gerrit-hooks has posted comments on this change. Change subject: Revert "spbackends: Remove StoragePoolDiskBackend" .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

Allon Mureinik has uploaded a new change for review. Change subject: Revert "spbackends: Remove StoragePoolDiskBackend" .. Revert "spbackends: Remove StoragePoolDiskBackend" This reverts commit

Change in vdsm[master]: contrib: Simple jsonrpc client

gerrit-hooks has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: utils: build cert paths in single place

Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 11: Verified+1 Verified by updating vdsm and checking that communication works. One vm was started to

Change in vdsm[master]: utils: build cert paths in single place

gerrit-hooks has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: stomp: simplified client

gerrit-hooks has posted comments on this change. Change subject: stomp: simplified client .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: contrib: Simple jsonrpc client

gerrit-hooks has posted comments on this change. Change subject: contrib: Simple jsonrpc client .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vmxml: move metadata handling into helpers

Dan Kenigsberg has posted comments on this change. Change subject: vmxml: move metadata handling into helpers .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57380 To unsubscribe, visit

Change in vdsm[master]: doc: add basic quickstart for containers

gerrit-hooks has posted comments on this change. Change subject: doc: add basic quickstart for containers .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: reorder sampling initialization

gerrit-hooks has posted comments on this change. Change subject: vm: reorder sampling initialization .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vmxml: add image in metadata container

gerrit-hooks has posted comments on this change. Change subject: vmxml: add image in metadata container .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: kill _stubDependentInit()

Francesco Romani has abandoned this change. Change subject: vm: kill _stubDependentInit() .. Abandoned squashed in 53820 -- To view, visit https://gerrit.ovirt.org/59818 To unsubscribe, visit

Change in vdsm[master]: utils: build cert paths in single place

Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/52354/10/build-aux/Makefile.subs File

Change in vdsm[master]: vmxml: metadata could be local variable

gerrit-hooks has posted comments on this change. Change subject: vmxml: metadata could be local variable .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: split out SLA settings from domDependentInit

gerrit-hooks has posted comments on this change. Change subject: vm: split out SLA settings from domDependentInit .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vm: reorder sampling initialization

gerrit-hooks has posted comments on this change. Change subject: vm: reorder sampling initialization .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: split device init from domDependentInit

gerrit-hooks has posted comments on this change. Change subject: vm: split device init from domDependentInit .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

Piotr Kliczewski has posted comments on this change. Change subject: jsonrpcvdscli: add additional verbs .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60248 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

Jenkins CI has posted comments on this change. Change subject: jsonrpcvdscli: add additional verbs .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: add additional verbs .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

Simone Tiraboschi has uploaded a new change for review. Change subject: jsonrpcvdscli: add additional verbs .. jsonrpcvdscli: add additional verbs Add additional verbs required by the hosted-engine upgrade flow. Change-Id:

Change in vdsm[master]: wip: tests: change testing framework to pytest

gerrit-hooks has posted comments on this change. Change subject: wip: tests: change testing framework to pytest .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: utils: build cert paths in single place

Piotr Kliczewski has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/52354/10//COMMIT_MSG Commit Message: Line 4: Commit: