Sahina Bose has posted comments on this change.
Change subject: api: fixing default value for GlusterHost.createBrick
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60379
To unsubscribe, visit
Ramesh N has posted comments on this change.
Change subject: api: fixing default value for GlusterHost.createBrick
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60379
To unsubscribe, visit
Ramesh N has uploaded a new change for review.
Change subject: api: fixing default value for GlusterHost.createBrick
..
api: fixing default value for GlusterHost.createBrick
Change default value for raidParamas to an empty dict
Yaniv Bronhaim has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/60318/4/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line
Nir Soffer has posted comments on this change.
Change subject: schema: fix VM.create parameters
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59258/7/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:
Line 446:
gerrit-hooks has posted comments on this change.
Change subject: ovs: set mtu
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK,
gerrit-hooks has posted comments on this change.
Change subject: ovs: early IP+link setup
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: schema: fix VM.create parameters
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59258/7/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Terminate watcher when tests fail
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60239
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add test for testing the timeout mechanism
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/58423
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60271/2/tests/testlib.py
File tests/testlib.py:
Line 24: import
gerrit-hooks has posted comments on this change.
Change subject: tests: Move fake_mounts to storagefakelib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sdc: Safer way to access storage domain manifest
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: volume: Use StorageDomainManitest when possible
..
volume: Use StorageDomainManitest when possible
New code should use the StorageDomainManifest classes instead
gerrit-hooks has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60271/2/tests/testlib.py
File tests/testlib.py:
Line 24:
Nir Soffer has posted comments on this change.
Change subject: contrib: add simple tool to prettify python dumps
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/60272/3/contrib/refmt
File contrib/refmt:
Line 37: #
Francesco Romani has posted comments on this change.
Change subject: contrib: add simple tool to prettify python dumps
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/60272/2/contrib/refmt
File contrib/refmt:
Line
Francesco Romani has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py
File tests/testlib.py:
Line 567:
Petr Horáček has posted comments on this change.
Change subject: qos: fix invalid dictionary iteration
..
Patch Set 1: Verified+1
Fails on master with 'too many values to unpack', it is OK with this patch:
NETSETUP = {
gerrit-hooks has posted comments on this change.
Change subject: qos: fix invalid dictionary iteration
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has uploaded a new change for review.
Change subject: qos: fix invalid dictionary iteration
..
qos: fix invalid dictionary iteration
`for x, y in dictionary` is not valid dictionary iteration. This bug
was here for
Petr Horáček has posted comments on this change.
Change subject: net: call address.flush explicitly after dhclient.kill
..
Patch Set 2: Verified+1
Passed functional/networkTests.py
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 5:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: call address.flush explicitly after dhclient.kill
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK,
gerrit-hooks has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 2:
* #1225728::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1225728::OK, public bug
* Check
Sahina Bose has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/60329
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 1:
* #1225728::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1225728::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 9:
* #1225728::Update tracker: OK
* Set MODIFIED::bug 1225728#1225728IGNORE, not oVirt classification but
Dan Kenigsberg has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/58605
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: image: Add timing for copy volume operations
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: Using startCmd func for running async execution
..
Patch Set 3: Code-Review-1
Please address the comments, and split this to:
- new start_cmd function
- use new
Nir Soffer has posted comments on this change.
Change subject: Using startCmd func for running async execution
..
Patch Set 2:
(6 comments)
https://gerrit.ovirt.org/#/c/60237/2/lib/vdsm/commands.py
File lib/vdsm/commands.py:
Nir Soffer has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py
File tests/testlib.py:
Line 567: return
Francesco Romani has posted comments on this change.
Change subject: vm: devices: drop support for ancient Engines
..
Patch Set 9: Code-Review-2
please let's continue here:
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has uploaded a new change for review.
Change subject: vm: storage: drop legacy drive config support
..
vm: storage: drop legacy drive config support
Drop the legacy Vm methods to rebuild specific drive
Sahina Bose has posted comments on this change.
Change subject: build: enable vdsm-gluster build
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/58605
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Irit Goihman has uploaded a new change for review.
Change subject: vdscli: added DeprecationWarning to module
..
vdscli: added DeprecationWarning to module
vdscli is deprecated and will be replaced soon by jsonrpccli.
since we
gerrit-hooks has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Petr Horáček has posted comments on this change.
Change subject: ovs hook: fix dhclient imports
..
Patch Set 2: Verified+1
OVS hook stopped NIC's dhclient and started a new one on OVS bridge.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: ovs hook: fix dhclient imports
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: contrib: add simple tool to prettify python dumps
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: schema: fix VM.create return value
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: net: add address.flush family argument
..
Patch Set 2: Verified+1
iproute configurator was able to flush IP from used NIC.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: wait properly for migration to begin
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/59151/8/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
gerrit-hooks has posted comments on this change.
Change subject: Using startCmd func for running async execution
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: add address.flush family argument
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Yaniv Bronhaim has posted comments on this change.
Change subject: Using startCmd func for running async execution
..
Patch Set 2:
(6 comments)
https://gerrit.ovirt.org/#/c/60237/2/lib/vdsm/commands.py
File
gerrit-hooks has posted comments on this change.
Change subject: Rename execCmd and startCmd to run_cmd and start_cmd
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/59151/8/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
gerrit-hooks has posted comments on this change.
Change subject: fcoe hook: enable service
..
Patch Set 1:
* #1353456::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1353456::OK, public bug
* Check
Dan Kenigsberg has uploaded a new change for review.
Change subject: fcoe hook: enable service
..
fcoe hook: enable service
When fcoe is requested, we should start fcoe and lldpad immediately, but
also after next boot.
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 18: Code-Review+1
(1 comment)
one minor comment in the tests, overall looks good to me.
Francesco Romani has posted comments on this change.
Change subject: tests: add helper to read test data
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py
File tests/testlib.py:
Line 567:
gerrit-hooks has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: add simple tool to prettify python dumps
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: schema: fix VM.create return value
..
Patch Set 1: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/60279/1/lib/api/vdsm-api.yml
File
Piotr Kliczewski has posted comments on this change.
Change subject: schema: fix VM.create parameters
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit
65 matches
Mail list logo
