gerrit-hooks has posted comments on this change.
Change subject: net: lookup dhclient file
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has uploaded a new change for review.
Change subject: net: lookup dhclient file
..
net: lookup dhclient file
Change-Id: I94d2c35bfa8acfc808d3852d41b45b7df38c2c41
Bug-Url: https://bugzilla.redhat.com/1195208
Yaniv Bronhaim has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61384
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: lvm: Do not rely on return code when handling extendLV errors
..
Patch Set 1:
* #1363734::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Adam Litke has uploaded a new change for review.
Change subject: lvm: Do not rely on return code when handling extendLV errors
..
lvm: Do not rely on return code when handling extendLV errors
LVM has changed the return code
gerrit-hooks has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 9:
* #1351095::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1351095::OK, public bug
*
Yaniv Bronhaim has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 14: Verified+1
--
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61869
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61617
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61616
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility only
Francesco Romani has posted comments on this change.
Change subject: confis: move modprobe files loading to static
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61762/3//COMMIT_MSG
Commit Message:
PS3, Line 7:
Francesco Romani has posted comments on this change.
Change subject: confis: move modprobe files loading to static
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61762
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61619
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61605
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 7: Code-Review-1
(1 comment)
-1 for visibility
bad rebase?
https://gerrit.ovirt.org/#/c/61603/7/.gitignore
Francesco Romani has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 7: Code-Review-1
(1 comment)
-1 for visibility, I like this patch (series) very much
Francesco Romani has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit
Petr Horáček has uploaded a new change for review.
Change subject: ovs: use vdsmbr_test name for test bridges
..
ovs: use vdsmbr_test name for test bridges
We should use the same prefix as for 'real' OVS bridge, so we are
able
gerrit-hooks has posted comments on this change.
Change subject: ovs: early IP+link setup
..
Patch Set 7:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: add OVS bridges cleanup to shell_helper
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: ovs: use vdsmbr_test name for test bridges
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: ovs: early IP+link setup
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Irit Goihman has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 3: Verified+1
check-merged run:
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
Irit Goihman has posted comments on this change.
Change subject: supervdsmServer: using moduleloader for dynamic imports
..
Patch Set 1:
check-merged run:
nose.config: INFO: Ignoring files matching ['^\\.', '^_',
Irit Goihman has posted comments on this change.
Change subject: supervdsmServer: using moduleloader for dynamic imports
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61313
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test
..
Patch Set 3:
(1 comment)
partial review
Douglas Schilling Landgraf has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 2: Code-Review+1
indeed, needed
--
To view, visit https://gerrit.ovirt.org/61384
To
gerrit-hooks has posted comments on this change.
Change subject: ovs: early IP+link setup
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Jenkins CI has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 3:
Propagate review hook: Continuous Integration value inherited from patch 2
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 46:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Jenkins CI has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 3: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 39:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Irit Goihman has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/61415
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: packaging: spec: update Url field
..
packaging: spec: update Url field
Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Signed-off-by: Sandro
gerrit-hooks has posted comments on this change.
Change subject: packaging: spec: update Url field
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: packaging: spec: update Url field
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61883
To unsubscribe, visit
Irit Goihman has uploaded a new change for review.
Change subject: functional tests: fix supervdsmServer test
..
functional tests: fix supervdsmServer test
supervdsmServer dropPrivileges function is switching root user to
a non
Edward Haas has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 36: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Edward Haas has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: configs: introduce static dir
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: autoconf: properly sort makefiles
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: confis: move modprobe files loading to static
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: makefile: remove unused all-local section
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 36: Verified+1
(2 comments)
Passed network/*_test.py OK.
https://gerrit.ovirt.org/#/c/60404/34/lib/vdsm/network/ovs/switch.py
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 16: Verified+1
Passed utilsTests.py
--
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 16:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 16:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 25:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 36:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 35:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 24:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 38:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: **WIP** tool: reconfigure containers networks
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 45:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6: Code-Review+1
the virt part looks ok
--
To view, visit https://gerrit.ovirt.org/59544
To
Edward Haas has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 34: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/60404/34/lib/vdsm/network/ovs/switch.py
File
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 15:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 15: Verified+1
Passed utilsTests.py
--
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 34: Verified+1
(4 comments)
Passed network/*_test.py OK
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 34:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 33:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 14: -Verified
--
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 32:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: [wip] infra tests: added functional test for upgrading vdsm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 23:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 14: Verified+1
(1 comment)
Passed utilsTests.py
https://gerrit.ovirt.org/#/c/61482/13/tests/utilsTests.py
File
gerrit-hooks has posted comments on this change.
Change subject: utils: atomic file write
..
Patch Set 14:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 1:
* #1361028::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1361028::OK, public bug
* Check
Hello Dan Kenigsberg, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61889
to review the following change.
Change subject: periodic: always re-schedule operations
..
periodic:
1 - 100 of 123 matches
Mail list logo