Ondřej Svoboda has posted comments on this change.
Change subject: net: don't accept a network with nameservers but default route
unset
..
Patch Set 1:
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: net: don't accept a network with nameservers but default route
unset
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
gerrit-hooks has posted comments on this change.
Change subject: tests: add assertRaisesSetupNetworksError to netfunctestlib
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ondřej Svoboda has uploaded a new change for review.
Change subject: net: don't accept a network with nameservers but default route
unset
..
net: don't accept a network with nameservers but default route unset
Change-Id:
Ondřej Svoboda has uploaded a new change for review.
Change subject: tests: add assertRaisesSetupNetworksError to netfunctestlib
..
tests: add assertRaisesSetupNetworksError to netfunctestlib
Change-Id:
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Removing deprecated lines from spec
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62159
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: remove deprecated BuildRoot macro
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: spec: remove deprecated BuildRoot macro
..
spec: remove deprecated BuildRoot macro
Change-Id: I3cb8398b42071f1fc2432f3bc0e754a27b0474b6
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix configfile for py3 to use unicode
..
Patch Set 16: Verified+1
--
To view, visit https://gerrit.ovirt.org/48052
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: write out nameservers to ifcfg files
..
Patch Set 16:
* #1351095::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1351095::OK, public bug
*
Edward Haas has posted comments on this change.
Change subject: net: write out nameservers to ifcfg files
..
Patch Set 15: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/61184/14/tests/network/func_dns_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: write out nameservers to ifcfg files
..
Patch Set 15:
* #1351095::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1351095::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: add a 'nameservers' property to NetInfo
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: netinfo: add a 'nameservers' property to NetInfo
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Jenkins CI has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value
Jenkins CI has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: Collect ksm values only if exist
..
Patch Set 2: -Verified
* #1350350::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350350::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At
gerrit-hooks has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Rename reports to metrics
..
Rename reports to metrics
Leftovers from using reports instead of metrics (following
https://gerrit.ovirt.org/#/c/60846/)
Edward Haas has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 16: Verified+1
Tested on a setup with Engine and two Hosts.
Migration performed from OVS to
Edward Haas has posted comments on this change.
Change subject: revert net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62121
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 13:
(3 comments)
https://gerrit.ovirt.org/#/c/61184/13/lib/vdsm/network/netinfo/cache.py
File
Shahar Havivi has posted comments on this change.
Change subject: v2v: Add execCmd() that accepts stdin/out/err
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62092
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 14: Code-Review+1
(1 comment)
initial, partial review.
Dan Kenigsberg has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/61184/13/tests/network/netfunctestlib.py
File
Francesco Romani has posted comments on this change.
Change subject: v2v: Add execCmd() that accepts stdin/out/err
..
Patch Set 1: Code-Review+2
ok, good enough for me
--
To view, visit https://gerrit.ovirt.org/62092
To
Francesco Romani has posted comments on this change.
Change subject: v2v: Bump version requirement on python-cpopen.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62093/1/tests/v2vTests.py
File tests/v2vTests.py:
Sandro Bonazzola has posted comments on this change.
Change subject: changing repos to be multi arch and support ppc64le
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62123
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 2: Code-Review+1
(but I'm waiting for Polednik to drop his -1 or explain it better)
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 2: Code-Review+2
I think that the build script works fine on ppc as well (albeit creating a hook
that we
Dan Kenigsberg has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: use 3.6 repos
..
automation: use 3.6 repos
Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Signed-off-by: Sandro Bonazzola
Eyal Edri has posted comments on this change.
Change subject: changing repos to be multi arch and support ppc64le
..
Patch Set 1: Verified-1
some repos are still missing ppc64le
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: changing repos to be multi arch and support ppc64le
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Eyal Edri has uploaded a new change for review.
Change subject: changing repos to be multi arch and support ppc64le
..
changing repos to be multi arch and support ppc64le
Change-Id: I7edd684cf40f2122c4a3afe0091ac2eace1129ef
Dan Kenigsberg has posted comments on this change.
Change subject: Change Source0 after uploading latest tar
..
Patch Set 2:
it sounds very odd to link to a private page on fedorahosted, which can
disappear tomorrow, and
Sahina Bose has posted comments on this change.
Change subject: virt: enable glusterfs access through libgfapi interface
..
Patch Set 8:
ping - reviews please?
--
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Sandro Bonazzola has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61984/1//COMMIT_MSG
Commit Message:
Line 4: Commit: Sandro
Martin Polednik has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1: Code-Review-1
Agree with Piotr, why is this needed? (I have a feeling that vhostmd is
required on ppc?)
Edward Haas has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/60821/12/lib/vdsm/network/netinfo/qos.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61984/1//COMMIT_MSG
Commit Message:
Line 4: Commit: Sandro
Piotr Kliczewski has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit
Edward Haas has uploaded a new change for review.
Change subject: revert net: Libvirt hook that enables ovs-legacy migration
..
revert net: Libvirt hook that enables ovs-legacy migration
Both the integrated and older OVS hook
gerrit-hooks has posted comments on this change.
Change subject: revert net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Yaniv Bronhaim has posted comments on this change.
Change subject: Change Source0 after uploading latest tar
..
Patch Set 2:
because fedora-review wants working path to download the tar file
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: configs: move modprobe files loading to static
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/59645/15/vdsm/virt/libvirt-hook.sh
File
gerrit-hooks has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: configs: move rwtab to static
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: automation: use 4.0 repos
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move rwtab to static
..
configs: move rwtab to static
Part of the move of static files to new directory. The files are moved
to
Francesco Romani has submitted this change and it was merged.
Change subject: automation: use 4.0 repos
..
automation: use 4.0 repos
Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Signed-off-by: Sandro Bonazzola
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move sudoers to static
..
configs: move sudoers to static
Part of the move of static files to new directory. The files are moved
to
gerrit-hooks has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move logger to static
..
configs: move logger to static
Part of the move of static files to new directory. The files are moved
to
gerrit-hooks has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move mom to static
..
configs: move mom to static
Part of the move of static files to new directory. The files are moved
to corresponding
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 15: Code-Review-1
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: Update spec change-log after re-review
..
Patch Set 5:
* #1361659::Update tracker: OK
* Set MODIFIED::bug 1361659#1361659FAILED, illegal change from
gerrit-hooks has posted comments on this change.
Change subject: Removed %config(noreplace) from
%{_tmpfilesdir}/%{vdsm_name}.conf
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removed %config(noreplace) from
%{_tmpfilesdir}/%{vdsm_name}.conf
..
Removed %config(noreplace) from %{_tmpfilesdir}/%{vdsm_name}.conf
gerrit-hooks has posted comments on this change.
Change subject: Specifies vdsm-infra version to obsoletes
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Update spec change-log after re-review
..
Update spec change-log after re-review
See topic: https://gerrit.ovirt.org/#/q/topic:spec-review
Bug-Url:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Specifies vdsm-infra version to obsoletes
..
Specifies vdsm-infra version to obsoletes
Change-Id: Ifde739ee3520105d738ad217179da563ce10ddf5
Dan Kenigsberg has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/60821/12/lib/vdsm/network/netinfo/qos.py
File
Edward Haas has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 15: -Verified
--
To view, visit https://gerrit.ovirt.org/59645
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 15: Verified+1
(2 comments)
https://gerrit.ovirt.org/#/c/59645/14/vdsm/virt/vm_migrate_hook.py
gerrit-hooks has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: network: filter out 'veth' devices
..
Patch Set 12: Code-Review-1
there are legitimate use cases for Vdsm to use veth (e.g. openvswitch). Check
again more
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61619
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61616
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61617
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move sudoers to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61603
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move limits to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61605
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move rwtab to static
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61604
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 14: Code-Review-1
(1 comment)
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move mom to static
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61602
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: configs: move logger to static
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Require python2-devel specifically to avoid python3 pkg
..
Require python2-devel specifically to avoid python3 pkg
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: Require python2-devel specifically to avoid python3 pkg
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has posted comments on this change.
Change subject: Change Source0 after uploading latest tar
..
Patch Set 2: Code-Review-1
I don't understand why this is good/needed.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: packaging: spec: drop default defattr
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: Using %{_libdir} macro instead of /usr/lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Using %{_libdir} macro instead of /usr/lib
..
Using %{_libdir} macro instead of /usr/lib
Change-Id: I8c70582236868a0d9d9f37bb3f1fd7527138404f
Dan Kenigsberg has submitted this change and it was merged.
Change subject: packaging: spec: drop default defattr
..
packaging: spec: drop default defattr
Dropping default defattr, not needed since EPEL 6.
Part of Fedora 24
gerrit-hooks has posted comments on this change.
Change subject: virt net: Support VM migration on OVS based networks
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Edward Haas has posted comments on this change.
Change subject: network: write out nameservers to ifcfg files
..
Patch Set 13: Code-Review-1
(8 comments)
https://gerrit.ovirt.org/#/c/61184/13/lib/vdsm/network/netinfo/cache.py
Francesco Romani has posted comments on this change.
Change subject: v2v: Bump version requirement on python-cpopen.
..
Patch Set 1:
(1 comment)
-1 for visibility
https://gerrit.ovirt.org/#/c/62093/1/tests/v2vTests.py
File
Francesco Romani has posted comments on this change.
Change subject: v2v: Bump version requirement on python-cpopen.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62093/1/vdsm.spec.in
File vdsm.spec.in:
Line 81:
Francesco Romani has posted comments on this change.
Change subject: v2v: Bump version requirement on python-cpopen.
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/62093
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: v2v: Bump version requirement on python-cpopen.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62093
To unsubscribe, visit
1 - 100 of 126 matches
Mail list logo