gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/64377/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2698:
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/64377/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2698:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Simplify and complete map tests
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Simplify and complete map tests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Simplify and complete map tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: qemuimg: Simplify and complete map tests
..
qemuimg: Simplify and complete map tests
Trying to understand map output:
- Use pprint to prety print the map
-
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65108
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: core: Expose API for qemuimg commit
..
core: Expose API for qemuimg commit
Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Signed-off-by: Ala Hino
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Require explicit start of QemuImgOperation
..
Patch Set 2: Code-Review-1
(3 comments)
I like this direction, but we can do this with minimal changes.
Nir Soffer has posted comments on this change.
Change subject: storage: Fix abort race in SDM.copy_data
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/65150/2/vdsm/storage/sdm/api/copy_data.py
File
Nir Soffer has posted comments on this change.
Change subject: fix abort to raise
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/65147/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 186
Line 187
Line 188
Line 189
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Fix test to not wait forever on failure
..
tests: Fix test to not wait forever on failure
Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
Nir Soffer has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/65102/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 129:
Line
Adam Litke has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Code-Review+2
(2 comments)
https://gerrit.ovirt.org/#/c/64222/12/lib/vdsm/qemuimg.py
File
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/64222
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 12: Code-Review+1 Continuous-Integration+1
Thanks Ala, excellent work!
Network tests failing again.
Waiting for
Adam Litke has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/65149
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix abort race in SDM.copy_data
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Require explicit start of QemuImgOperation
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix abort race in SDM.copy_data
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Require explicit start of QemuImgOperation
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Fix test to not wait forever on failure
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: fix abort to raise
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
Adam Litke has uploaded a new change for review.
Change subject: storage: Fix abort race in SDM.copy_data
..
storage: Fix abort race in SDM.copy_data
The copy_data job supports aborting the qemuimg process. If such a
process
Adam Litke has uploaded a new change for review.
Change subject: qemuimg: Require explicit start of QemuImgOperation
..
qemuimg: Require explicit start of QemuImgOperation
Currently the underlying qemuimg command is started by
Adam Litke has uploaded a new change for review.
Change subject: fix abort to raise
..
fix abort to raise
Change-Id: I5efe2319d023bd813777c76a0bbaa0b9576281f6
Signed-off-by: Adam Litke
---
M lib/vdsm/jobs.py
Adam Litke has uploaded a new change for review.
Change subject: tests: Fix test to not wait forever on failure
..
tests: Fix test to not wait forever on failure
Change-Id: I57d49895ff0c222b5cdda537e722248d1f2681b7
gerrit-hooks has posted comments on this change.
Change subject: travis: Run docker with --privileged
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: travis: Run docker with --privileged
..
travis: Run docker with --privileged
Running docker with --privileged allow creation of loop devices inside
the container
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install development tools using pip
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: travis: Fix build using new docker image
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Use one package per line
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: schema: fixing type of default values
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65113/1//COMMIT_MSG
Commit Message:
Line 4: Commit: Piotr
Nir Soffer has posted comments on this change.
Change subject: schema: fixing type of default values
..
Patch Set 1: Code-Review+1
Looks good, but we need ack from the SLA team.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add missing packages
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Use one package per line
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: travis: Fix build using new docker image
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install development tools using pip
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Add missing packages
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: travis: Fix build using new docker image
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Use one package per line
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: dockerfile: Install development tools using pip
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21: Code-Review+1
Waiting for Francesco ack.
--
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64377/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2707
Nir Soffer has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: travis: Fix build using new docker image
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65070/1/.travis.yml
File .travis.yml:
Line 8: depth: 999
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/64377
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Verified+1
Verified that migrations still work and that when Engine asks to migrate
Nir Soffer has posted comments on this change.
Change subject: dockerfile: Install developer tools using pip
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65069/1/contrib/Dockerfile
File contrib/Dockerfile:
Line
Francesco Romani has posted comments on this change.
Change subject: virt: Try to detect non guest iniated shutdowns
..
Patch Set 6: Code-Review-1
(2 comments)
I'm fine with the concept, Vinzenz explained the logic and the
Nir Soffer has posted comments on this change.
Change subject: dockerfile: Add missing packages
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65067/1/contrib/Dockerfile
File contrib/Dockerfile:
Line 1: FROM
gerrit-hooks has posted comments on this change.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vm: a Down domain is not ready for commands
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has uploaded a new change for review.
Change subject: vm: a Down domain is not ready for commands
..
vm: a Down domain is not ready for commands
isDomainReadyForCommands() sometimes print scary stacktraces
in
Francesco Romani has uploaded a new change for review.
Change subject: vm: ignore more errors in isDomainReadyForCommands
..
vm: ignore more errors in isDomainReadyForCommands
Due to race on domain shutdown, and after migration
Martin Polednik has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2: Verified+1
Tested on standard & RT kernel -- reports correct build time for both.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Maor Lipchuk has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/64377/20/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2698:
gerrit-hooks has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg map
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/65112/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 213:
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg map
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/65112/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 213:
Francesco Romani has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65108
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 19:
* update_tracker: OK
* Set MODIFIED::bug 1356161#1356161::IGNORE, skipping for branch
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
hostdev: prefer numa nodes close to device MMIO
Therefore reducing the NUMA distance if VM's memory
Piotr Kliczewski has posted comments on this change.
Change subject: schema: fixing type of default values
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65113
To unsubscribe, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: fixing type of default values
..
schema: fixing type of default values
Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294
Signed-off-by: Piotr
gerrit-hooks has posted comments on this change.
Change subject: schema: fixing type of default values
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: drop dead constant
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: drop dead constant
..
Patch Set 1: Verified+1
builds and runs
--
To view, visit https://gerrit.ovirt.org/65097
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: drop dead constant
..
drop dead constant
It has not been used in code since commit 87f0129.
Change-Id: I1c3651d296ee757752bee659fa08835bd385e91a
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 18:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
gerrit-hooks has posted comments on this change.
Change subject: devices: add is_hostdevice attribute
..
Patch Set 10:
* #62063::Update tracker: OK
* #1356161::Update tracker: OK
* Set MODIFIED::bug
gerrit-hooks has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 10:
* #62064::Update tracker: OK
* #1356161::Update tracker: OK
* Set MODIFIED::bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: properly set is_hostdevice
..
hostdev: properly set is_hostdevice
Since we added is_hostdevice attribute to all devices, and the
attribute
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..
vmxml: move condition from appendNumaTune to buildDomainXML
Having the condition that
gerrit-hooks has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 16:
* #60637::Update tracker: OK
* #1356161::Update tracker: OK
* Set MODIFIED::bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: expose numa_node in host device
..
hostdev: expose numa_node in host device
Change-Id: I4584b99dfbff8b2e61f4f73ad58e3b67bf0c55ce
Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 16:
* update_tracker: OK
* Set MODIFIED::bug 1356161#1356161IGNORE, not all related patches are
Dan Kenigsberg has submitted this change and it was merged.
Change subject: devices: add is_hostdevice attribute
..
devices: add is_hostdevice attribute
is_hostdevice attribute is currently used to determine whether given
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: report device MMIO numa node
..
hostdev: report device MMIO numa node
MMIO, or memory mapped IO, is a method of performing device IO via
gerrit-hooks has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg map
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: core: Introduce new Volume.reduceSize verb
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: core: Introduce new Volume.getWatermarks verb
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ala Hino has uploaded a new change for review.
Change subject: [WIP] core: Expose API for qemuimg map
..
[WIP] core: Expose API for qemuimg map
Change-Id: I54d6c936239d3dcc7a3d236dbaab0a93501ada8c
Signed-off-by: Ala Hino
Nir Soffer has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/65039/1/vdsm/storage/image.py
File vdsm/storage/image.py:
gerrit-hooks has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1:
* #1380822::Update tracker: OK
* #65007::Update tracker: OK
* Check Bug-Url::OK
* Check
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65108
to review the following change.
Change subject: virt: Make boolean values from boolean migration options
..
gerrit-hooks has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 3:
* #1380822::Update tracker: OK
* #65007::Update tracker: OK
* Set MODIFIED::bug
Nir Soffer has submitted this change and it was merged.
Change subject: virt: Make boolean values from boolean migration options
..
virt: Make boolean values from boolean migration options
`compressed' and `autoConverge'
Francesco Romani has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: travis: Fix build using new docker image
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65070/1/.travis.yml
File .travis.yml:
PS1, Line 12:
1 - 100 of 104 matches
Mail list logo