Change in vdsm[master]: properties: Make password test data more clear

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Make password test data more clear .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: properties: Python 3 compliant base64 usage

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Python 3 compliant base64 usage .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: properties: Python 3 compliant base64 usage

2016-10-07 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: properties: Python 3 compliant base64 usage .. properties: Python 3 compliant base64 usage base64.b64encode and base64.b64decode receive and return byte

Change in vdsm[master]: properties: Python 3 compatible string type check

2016-10-07 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: properties: Python 3 compatible string type check .. properties: Python 3 compatible string type check basestring is removed in py3; now using

Change in vdsm[master]: properties: Python 3 compatible string type check

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Python 3 compatible string type check .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To

Change in vdsm[master]: properties: Use python 3 compatible metaclass

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Use python 3 compatible metaclass .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: properties: Use python 3 compatible metaclass

2016-10-07 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: properties: Use python 3 compatible metaclass .. properties: Use python 3 compatible metaclass Setting metaclass differs in py2/3; now using six's

Change in vdsm[master]: properties: Make passowrd test data more clear

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Make passowrd test data more clear .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65258 To unsubscribe, visit

Change in vdsm[master]: properties: Make passowrd test data more clear

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Make passowrd test data more clear .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: properties: Make passowrd test data more clear

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: properties: Make passowrd test data more clear .. properties: Make passowrd test data more clear The old test used the value b"12345678", which may confuse the

Change in vdsm[master]: properties: py3: properties.py and properties_test.py compli...

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: py3: properties.py and properties_test.py compliance .. Patch Set 3: Your new patches replace this patch, you can abandon it now. -- To view, visit

Change in vdsm[master]: properties: Enable tests on python 3

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Enable tests on python 3 .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65257 To unsubscribe, visit

Change in vdsm[master]: properties: Python 3 compatible string type check

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Python 3 compatible string type check .. Patch Set 3: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/63709 To

Change in vdsm[master]: properties: Use python 3 compatible metaclass

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Use python 3 compatible metaclass .. Patch Set 4: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/63710 To unsubscribe,

Change in vdsm[master]: properties: Python 3 compliant base64 usage

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Python 3 compliant base64 usage .. Patch Set 2: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/63714 To unsubscribe,

Change in vdsm[master]: properties: Enable tests on python 3

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Enable tests on python 3 .. Patch Set 1: This complete Leon patches. -- To view, visit https://gerrit.ovirt.org/65257 To unsubscribe, visit

Change in vdsm[master]: properties: Enable tests on python 3

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Enable tests on python 3 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: properties: Enable tests on python 3

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: properties: Enable tests on python 3 .. properties: Enable tests on python 3 Change-Id: I7f8f9f218a1bec57d9158a01a1a024adaa5e27b1 Signed-off-by: Nir Soffer

Change in vdsm[master]: properties: Python 3 compliant base64 usage

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Python 3 compliant base64 usage .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/63714 To unsubscribe, visit

Change in vdsm[master]: properties: Python 3 compliant base64 usage

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Python 3 compliant base64 usage .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: properties: Python 3 compatible string type check

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Python 3 compatible string type check .. Patch Set 3: Code-Review+2 Rebased on previous properties python 3 patch, it is easier to review and test

Change in vdsm[master]: properties: Python 3 compatible string type check

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Python 3 compatible string type check .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: properties: Use python 3 compatible metaclass

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Use python 3 compatible metaclass .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: properties: Use python 3 compatible metaclass

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: properties: Use python 3 compatible metaclass .. Patch Set 3: Code-Review+2 Removed extra line at the end of the file and, move six import to 3rd party import

Change in vdsm[master]: properties: Use python 3 compatible metaclass

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: properties: Use python 3 compatible metaclass .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65231 To unsubscribe,

Change in vdsm[master]: image: Calculate qcow volume size on import.

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: image: Calculate qcow volume size on import. .. Patch Set 2: Missing changes: - Update lib/vdsm/storage/Makefile.am - vdsm.spec.in -- To view, visit

Change in vdsm[master]: clientIF: Fix reactor life cycle

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 7: Waiting for Adam review. -- To view, visit https://gerrit.ovirt.org/65178 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 6: Waiting for Adam review. -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 6: Code-Review+1 Waiting for Adam review. -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe,

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-07 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-07 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65178 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/65179/5/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 223:

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 5: Code-Review+1 (2 comments) Looks good, just minor indentation issue.

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 2: * #1208141::Update tracker: OK * #1381899::Update tracker: OK * #65230::Update tracker: OK * Set MODIFIED::bug

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: api: Speed up schema loading .. api: Speed up schema loading Use yaml.CLoader for 13x speedup in vdsm schema loading. Here is a comparison with other

Change in vdsm[master]: image: Calculate qcow volume size on import.

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: image: Calculate qcow volume size on import. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65039/2/vdsm/storage/image.py File vdsm/storage/image.py:

Change in vdsm[master]: image: Calculate qcow volume size on import.

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: image: Calculate qcow volume size on import. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65039/2/vdsm/storage/qcow2.py File vdsm/storage/qcow2.py:

Change in vdsm[master]: image: Calculate qcow volume size on import.

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: image: Calculate qcow volume size on import. .. Patch Set 2: (14 comments) https://gerrit.ovirt.org/#/c/65039/2/vdsm/storage/image.py File vdsm/storage/image.py:

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 4: Continuous-Integration+1 Please fix pep8 errors in this topic. -- To view, visit

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 5: Code-Review+1 Please fix pep8 errors in this topic. -- To view, visit https://gerrit.ovirt.org/65178 To

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 4: Please make pep8 tool happy: 23:29:30 ./lib/vdsm/qemuimg.py:100:80: E501 line too long (81 > 79 characters)

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit

Change in vdsm[master]: profiling: Add env context manager

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: profiling: Add env context manager .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: profiling: Decouple cpu profiling from vdsm config

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: profiling: Decouple cpu profiling from vdsm config .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: profiling: Add generic Profiler class

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: profiling: Add generic Profiler class .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: profiling: Add devel:cpu_profile_filename option

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: profiling: Add devel:cpu_profile_filename option .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: profiling: Rename cpuProfileTests.py

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: profiling: Rename cpuProfileTests.py .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: profiling: Decouple cpu profiling from vdsm config

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: profiling: Decouple cpu profiling from vdsm config .. profiling: Decouple cpu profiling from vdsm config Previously we accessed vdsm configuration to set module

Change in vdsm[master]: profiling: Add env context manager

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: profiling: Add env context manager .. profiling: Add env context manager Instead of having multiple @MonkeyPatch() lines for each test, use a context manager that

Change in vdsm[master]: profiling: Add devel:cpu_profile_filename option

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: profiling: Add devel:cpu_profile_filename option .. profiling: Add devel:cpu_profile_filename option This is mainly for simplifying the tests. Now we can control

Change in vdsm[master]: profiling: Add generic Profiler class

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: profiling: Add generic Profiler class .. profiling: Add generic Profiler class Current profiling solution is usable only by vdsm, writing the profile to

Change in vdsm[master]: profiling: Rename cpuProfileTests.py

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: profiling: Rename cpuProfileTests.py .. profiling: Rename cpuProfileTests.py Use new naming convention for tests modules: cpu_profile_test.py Change-Id:

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Verified+1 Verified with ovirt-hosted-engine-ha and ovirt-hosted-engine-setup -- To view, visit

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit https://gerrit.ovirt.org/65230 To unsubscribe, visit

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65230 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: Verified-1 * #1381880::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[ovirt-3.6]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: edit nic detached from bridge but still attached to a vlan .. net: edit nic detached from bridge but still attached to a vlan Change-Id:

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: Verified-1 * #1372798::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65230 To unsubscribe, visit

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: * #1208141::Update tracker: OK * #1381899::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1381899::OK,

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: edit nic detached from bridge but still attached to a vlan .. net: edit nic detached from bridge but still attached to a vlan Change-Id:

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: * #1372798::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: net: edit nic detached from bridge but still attached to a vlan .. net: edit nic detached from bridge but still attached to a vlan Change-Id:

Change in vdsm[master]: api: Speed up schema loading

2016-10-07 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: api: Speed up schema loading .. api: Speed up schema loading Use yaml.CLoader for 13x speedup in vdsm schema loading. Here is a comparison with other formats: $

Change in vdsm[master]: osinfo: properly parse kernel compile time

2016-10-07 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: osinfo: properly parse kernel compile time .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line

Change in vdsm[ovirt-3.6]: net: edit bond detached from bridge but still attached to a ...

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 3: * #63723::Update tracker: OK * #1381880::Update tracker: OK * Check Bug-Url::OK

Change in vdsm[ovirt-3.6]: net: edit bond detached from bridge but still attached to a ...

2016-10-07 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 2: Verified+1 Passed functional/networkTests.py and manual testing (add untagged

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net libvirt: make network/libvirt.py suitable for OVS

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net libvirt: make network/libvirt.py suitable for OVS .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net tests: minor libvirt_tests style refactoring

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: minor libvirt_tests style refactoring .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[ovirt-3.6]: net: edit bond detached from bridge but still attached to a ...

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 2: * #1372798::Update tracker: OK * #63723::Update tracker: OK * Check Bug-Url::OK

Change in vdsm[ovirt-3.6]: net: edit bond detached from bridge but still attached to a ...

2016-10-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 1: * #1372798::Update tracker: OK * #63723::Update tracker: OK * Check Bug-Url::OK

Change in vdsm[ovirt-3.6]: net: edit bond detached from bridge but still attached to a ...

2016-10-07 Thread phoracek
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65219 to review the following change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. net:

Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance

2016-10-07 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: [WIP] use libvirt domain xml prepared in advance .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py File

Change in vdsm[master]: schema: Change description of io tune parameters.

2016-10-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: schema: Change description of io tune parameters. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65164 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit

Change in vdsm[master]: clientIF: Fix reactor life cycle

2016-10-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File

Change in vdsm[master]: tests: Create all instance variables in setUp

2016-10-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: tests: Create all instance variables in setUp .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65101 To unsubscribe, visit

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File