gerrit-hooks has posted comments on this change.
Change subject: properties: Make password test data more clear
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: properties: Python 3 compliant base64 usage
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: properties: Python 3 compliant base64 usage
..
properties: Python 3 compliant base64 usage
base64.b64encode and base64.b64decode receive and return byte
Nir Soffer has submitted this change and it was merged.
Change subject: properties: Python 3 compatible string type check
..
properties: Python 3 compatible string type check
basestring is removed in py3; now using
gerrit-hooks has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has submitted this change and it was merged.
Change subject: properties: Use python 3 compatible metaclass
..
properties: Use python 3 compatible metaclass
Setting metaclass differs in py2/3; now using six's
Nir Soffer has posted comments on this change.
Change subject: properties: Make passowrd test data more clear
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65258
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: properties: Make passowrd test data more clear
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: properties: Make passowrd test data more clear
..
properties: Make passowrd test data more clear
The old test used the value b"12345678", which may confuse the
Nir Soffer has posted comments on this change.
Change subject: properties: py3: properties.py and properties_test.py compliance
..
Patch Set 3:
Your new patches replace this patch, you can abandon it now.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: properties: Enable tests on python 3
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65257
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
..
Patch Set 3: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/63709
To
Nir Soffer has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
..
Patch Set 4: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/63710
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compliant base64 usage
..
Patch Set 2: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/63714
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: properties: Enable tests on python 3
..
Patch Set 1:
This complete Leon patches.
--
To view, visit https://gerrit.ovirt.org/65257
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: properties: Enable tests on python 3
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: properties: Enable tests on python 3
..
properties: Enable tests on python 3
Change-Id: I7f8f9f218a1bec57d9158a01a1a024adaa5e27b1
Signed-off-by: Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compliant base64 usage
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63714
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: properties: Python 3 compliant base64 usage
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
..
Patch Set 3: Code-Review+2
Rebased on previous properties python 3 patch, it is easier to review and test
gerrit-hooks has posted comments on this change.
Change subject: properties: Python 3 compatible string type check
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
..
Patch Set 3: Code-Review+2
Removed extra line at the end of the file and, move six import to 3rd party
import
gerrit-hooks has posted comments on this change.
Change subject: properties: Use python 3 compatible metaclass
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65231
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 2:
Missing changes:
- Update lib/vdsm/storage/Makefile.am
- vdsm.spec.in
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: clientIF: Fix reactor life cycle
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py
File
Nir Soffer has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 7:
Waiting for Adam review.
--
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 6:
Waiting for Adam review.
--
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6: Code-Review+1
Waiting for Adam review.
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe,
Ala Hino has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/65178
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/5/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 223:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 5: Code-Review+1
(2 comments)
Looks good, just minor indentation issue.
gerrit-hooks has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 2:
* #1208141::Update tracker: OK
* #1381899::Update tracker: OK
* #65230::Update tracker: OK
* Set MODIFIED::bug
Dan Kenigsberg has submitted this change and it was merged.
Change subject: api: Speed up schema loading
..
api: Speed up schema loading
Use yaml.CLoader for 13x speedup in vdsm schema loading.
Here is a comparison with other
Nir Soffer has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65039/2/vdsm/storage/image.py
File vdsm/storage/image.py:
Nir Soffer has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65039/2/vdsm/storage/qcow2.py
File vdsm/storage/qcow2.py:
Nir Soffer has posted comments on this change.
Change subject: image: Calculate qcow volume size on import.
..
Patch Set 2:
(14 comments)
https://gerrit.ovirt.org/#/c/65039/2/vdsm/storage/image.py
File vdsm/storage/image.py:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 4: Continuous-Integration+1
Please fix pep8 errors in this topic.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 5: Code-Review+1
Please fix pep8 errors in this topic.
--
To view, visit https://gerrit.ovirt.org/65178
To
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 4:
Please make pep8 tool happy:
23:29:30 ./lib/vdsm/qemuimg.py:100:80: E501 line too long (81 > 79 characters)
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: profiling: Add env context manager
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: profiling: Decouple cpu profiling from vdsm config
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: profiling: Add generic Profiler class
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: profiling: Add devel:cpu_profile_filename option
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: profiling: Rename cpuProfileTests.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: profiling: Decouple cpu profiling from vdsm config
..
profiling: Decouple cpu profiling from vdsm config
Previously we accessed vdsm configuration to set module
Nir Soffer has uploaded a new change for review.
Change subject: profiling: Add env context manager
..
profiling: Add env context manager
Instead of having multiple @MonkeyPatch() lines for each test, use a
context manager that
Nir Soffer has uploaded a new change for review.
Change subject: profiling: Add devel:cpu_profile_filename option
..
profiling: Add devel:cpu_profile_filename option
This is mainly for simplifying the tests. Now we can control
Nir Soffer has uploaded a new change for review.
Change subject: profiling: Add generic Profiler class
..
profiling: Add generic Profiler class
Current profiling solution is usable only by vdsm, writing the profile
to
Nir Soffer has uploaded a new change for review.
Change subject: profiling: Rename cpuProfileTests.py
..
profiling: Rename cpuProfileTests.py
Use new naming convention for tests modules: cpu_profile_test.py
Change-Id:
Simone Tiraboschi has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Verified+1
Verified with ovirt-hosted-engine-ha and ovirt-hosted-engine-setup
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Verified+1
Verified by the tests.
--
To view, visit https://gerrit.ovirt.org/65230
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65230
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: Verified-1
* #1381880::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Petr Horáček has uploaded a new change for review.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: Verified-1
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Simone Tiraboschi has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65230
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1:
* #1208141::Update tracker: OK
* #1381899::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1381899::OK,
Petr Horáček has uploaded a new change for review.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1:
* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Petr Horáček has uploaded a new change for review.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
net: edit nic detached from bridge but still attached to a vlan
Change-Id:
Nir Soffer has uploaded a new change for review.
Change subject: api: Speed up schema loading
..
api: Speed up schema loading
Use yaml.CLoader for 13x speedup in vdsm schema loading.
Here is a comparison with other formats:
$
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: properly parse kernel compile time
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 3:
* #63723::Update tracker: OK
* #1381880::Update tracker: OK
* Check Bug-Url::OK
Petr Horáček has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 2: Verified+1
Passed functional/networkTests.py and manual testing (add untagged
gerrit-hooks has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net libvirt: make network/libvirt.py suitable for OVS
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 2:
* #1372798::Update tracker: OK
* #63723::Update tracker: OK
* Check Bug-Url::OK
gerrit-hooks has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 1:
* #1372798::Update tracker: OK
* #63723::Update tracker: OK
* Check Bug-Url::OK
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65219
to review the following change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
net:
Michal Skrivanek has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65182/2/vdsm/virt/vmxml.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: schema: Change description of io tune parameters.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65164
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: clientIF: Fix reactor life cycle
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: tests: Create all instance variables in setUp
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65101
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File
90 matches
Mail list logo